Page MenuHomePhabricator
Feed All Stories

Mar 13 2019

epriestley added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

Have you possibly changed mailers from "SES" to "SES via SMTP" or something like that? The logic here is basically:

Mar 13 2019, 4:36 PM · Mail
brhodes created T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.
Mar 13 2019, 4:19 PM · Mail
epriestley added a comment to D20283: When performing complex edits, pause sub-editors before they publish to propagate "Must Encrypt" and other state.

This also probably fixes a couple of minor bugs. For example, I suspect this is currently a bug, although I haven't verified it:

Mar 13 2019, 4:14 PM
epriestley added a comment to D20283: When performing complex edits, pause sub-editors before they publish to propagate "Must Encrypt" and other state.

Herald rules may "Require Secure Mail", but we won't know that at the time we're building mail about the indirect change to "Y". This is a problem in practice.

Mar 13 2019, 4:11 PM
epriestley requested review of D20283: When performing complex edits, pause sub-editors before they publish to propagate "Must Encrypt" and other state.
Mar 13 2019, 4:09 PM
brhodes abandoned D19079: Cut the middle, not bottom, of a big traceback.
Mar 13 2019, 4:07 PM
20after4 awarded T10578: Provide 'Sort by Points' option in workboards a Love token.
Mar 13 2019, 4:05 PM · Workboards (v3), Feature Request
20after4 awarded T10333: Add groups to workboard columns a Love token.
Mar 13 2019, 4:05 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a comment to T7216: Make it easier to update the ApplicationSearch saved query used by a dashboard panel.

See also https://phabricator.wikimedia.org/T113556 downstream.

Mar 13 2019, 11:54 AM · Dashboards
epriestley renamed T7216: Make it easier to update the ApplicationSearch saved query used by a dashboard panel from Make it easier to update an ApplicationSearch saved query to Make it easier to update the ApplicationSearch saved query used by a dashboard panel.
Mar 13 2019, 11:51 AM · Dashboards
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 13 2019, 11:19 AM · Plans
epriestley added a comment to T5422: Does Phabricator integrate with JIRA?.

See PHI1125. Recent versions of JIRA (JIRA 8?) still work with approximately the same instructions, but you have to fill out a modal dialog with about 7 required fields first, and none of the fields have real values. That is, the configuration instructions for recent JIRA are:

Mar 13 2019, 11:16 AM · Guides, Doorkeeper
epriestley closed T10333: Add groups to workboard columns, a subtask of T8135: drag & drop on a workboard sorted by priority behavior is surprising, as Resolved.
Mar 13 2019, 11:12 AM · Restricted Project, Workboards (v3), Restricted Project
epriestley closed T10333: Add groups to workboard columns as Resolved.

I'm going to consider this resolved at this point. The one thing I haven't built is the "task/point count" from the mocks (on the right-hand side of the header, counting points in each group), but I think this is probably only of much use under "Group by Owner", and maybe not even then. I'm open to building this in a future iteration and it's not likely to be very much work, I'd just like to see feedback that we're generally headed in the right direction first and that the element would have real-world use cases.

Mar 13 2019, 11:11 AM · Restricted Project, Restricted Project, Workboards (v3)
arielyang added a comment to D20110: Remove the highly suspect "Import from LDAP" workflow.

Very very disappointed. "Import from LDAP" worked very well and we use that almost every week for importing newly added employees. Though it's ok that employees register themself, but it changed our existing workflow in our company.

Mar 13 2019, 12:41 AM

Mar 12 2019

epriestley committed rPa6e17fb702d1: Improve workboard "Owner" grouping, add "Author" grouping and "Title" sort (authored by epriestley).
Improve workboard "Owner" grouping, add "Author" grouping and "Title" sort
Mar 12 2019, 9:30 PM
epriestley updated the summary of D20282: Allow "Move Tasks to Column..." to prompt for MFA.
Mar 12 2019, 9:30 PM
epriestley closed D20278: Improve workboard "Owner" grouping, add "Author" grouping and "Title" sort.
Mar 12 2019, 9:30 PM
amckinley accepted D20278: Improve workboard "Owner" grouping, add "Author" grouping and "Title" sort.
Mar 12 2019, 9:29 PM
epriestley requested review of D20282: Allow "Move Tasks to Column..." to prompt for MFA.
Mar 12 2019, 9:21 PM
epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: D20282: Allow "Move Tasks to Column..." to prompt for MFA.
Mar 12 2019, 9:20 PM · Workboards (v3), Plans, Projects
epriestley committed rP8d7449287509: Make workboard sort-order inversions more clear by using "-1 * ..." instead of… (authored by epriestley).
Make workboard sort-order inversions more clear by using "-1 * ..." instead of…
Mar 12 2019, 9:06 PM
epriestley closed D20281: Make workboard sort-order inversions more clear by using "-1 * ..." instead of "(int)-(int)".
Mar 12 2019, 9:06 PM
jdforrester awarded rP03b7aca019d1: Implement "Sort by Points" on workboards a Party Time token.
Mar 12 2019, 8:57 PM
epriestley committed rPa400d82932a6: Add "Group by Status" to Workboards (authored by epriestley).
Add "Group by Status" to Workboards
Mar 12 2019, 8:56 PM
epriestley closed D20277: Add "Group by Status" to Workboards.
Mar 12 2019, 8:56 PM
epriestley committed rP03b7aca019d1: Implement "Sort by Points" on workboards (authored by epriestley).
Implement "Sort by Points" on workboards
Mar 12 2019, 8:54 PM
epriestley closed T10578: Provide 'Sort by Points' option in workboards as Resolved by committing rP03b7aca019d1: Implement "Sort by Points" on workboards.
Mar 12 2019, 8:54 PM · Workboards (v3), Feature Request
epriestley closed D20276: Implement "Sort by Points" on workboards.
Mar 12 2019, 8:54 PM
amckinley accepted D20277: Add "Group by Status" to Workboards.
Mar 12 2019, 8:49 PM
epriestley updated the diff for D20276: Implement "Sort by Points" on workboards.
  • Use "fa-map-pin", which I guess is sort of a pun about "points" on a map?
Mar 12 2019, 8:49 PM
epriestley committed rPc020f027bbe6: Add an "Sort by Creation Date" filter to workboards and modularize remaining… (authored by epriestley).
Add an "Sort by Creation Date" filter to workboards and modularize remaining…
Mar 12 2019, 8:47 PM
epriestley closed D20275: Add an "Sort by Creation Date" filter to workboards and modularize remaining order behaviors.
Mar 12 2019, 8:47 PM
epriestley committed rP804be81f5dbb: Provide better UI feedback about cards that can't be dragged or edited (authored by epriestley).
Provide better UI feedback about cards that can't be dragged or edited
Mar 12 2019, 8:44 PM
epriestley closed T10722: Communicate drag policies clearly in the workboard/list UIs as Resolved by committing rP804be81f5dbb: Provide better UI feedback about cards that can't be dragged or edited.
Mar 12 2019, 8:43 PM · Workboards (v3), Bug Report
epriestley closed D20274: Provide better UI feedback about cards that can't be dragged or edited.
Mar 12 2019, 8:43 PM
epriestley committed rP74de153e59be: Allow MFA task edits to go through on workboards (authored by epriestley).
Allow MFA task edits to go through on workboards
Mar 12 2019, 8:42 PM
epriestley closed D20273: Allow MFA task edits to go through on workboards.
Mar 12 2019, 8:42 PM
epriestley committed rP1bdf446a8026: Improve rendering of empty workboard columns in header views (authored by epriestley).
Improve rendering of empty workboard columns in header views
Mar 12 2019, 8:40 PM
epriestley closed D20272: Improve rendering of empty workboard columns in header views.
Mar 12 2019, 8:40 PM
epriestley added a comment to D20276: Implement "Sort by Points" on workboards.

This is still a little more sensical than changing the date created though, isn't it?

Mar 12 2019, 8:39 PM
amckinley accepted D20276: Implement "Sort by Points" on workboards.
Mar 12 2019, 8:33 PM
amckinley added a comment to D20276: Implement "Sort by Points" on workboards.

This is a static sorting (like "By Date Created") where you can't change point values by dragging.

Mar 12 2019, 8:32 PM
epriestley committed rP21dd79b35af2: When creating or editing a card on a sorted/grouped workboard, adjust headers… (authored by epriestley).
When creating or editing a card on a sorted/grouped workboard, adjust headers…
Mar 12 2019, 8:28 PM
epriestley closed D20271: When creating or editing a card on a sorted/grouped workboard, adjust headers appropriately.
Mar 12 2019, 8:28 PM
epriestley committed rP2fdab434faf3: Implement "Group by Owner" on Workboards (authored by epriestley).
Implement "Group by Owner" on Workboards
Mar 12 2019, 8:26 PM
epriestley closed D20270: Implement "Group by Owner" on Workboards.
Mar 12 2019, 8:26 PM
epriestley updated the diff for D20270: Implement "Group by Owner" on Workboards.
  • Typo correction.
Mar 12 2019, 8:16 PM
amckinley accepted D20275: Add an "Sort by Creation Date" filter to workboards and modularize remaining order behaviors.
Mar 12 2019, 8:13 PM
amckinley accepted D20281: Make workboard sort-order inversions more clear by using "-1 * ..." instead of "(int)-(int)".
Mar 12 2019, 8:10 PM
epriestley requested review of D20281: Make workboard sort-order inversions more clear by using "-1 * ..." instead of "(int)-(int)".
Mar 12 2019, 8:09 PM
epriestley added inline comments to D20274: Provide better UI feedback about cards that can't be dragged or edited.
Mar 12 2019, 8:08 PM
epriestley committed rP9a8019d4a98b: Modularize workboard column orders (authored by epriestley).
Modularize workboard column orders
Mar 12 2019, 8:08 PM
epriestley closed D20269: Modularize workboard column orders.
Mar 12 2019, 8:07 PM
amckinley accepted D20274: Provide better UI feedback about cards that can't be dragged or edited.
Mar 12 2019, 8:07 PM
amckinley accepted D20273: Allow MFA task edits to go through on workboards.
Mar 12 2019, 8:05 PM
amckinley accepted D20272: Improve rendering of empty workboard columns in header views.
Mar 12 2019, 8:03 PM
epriestley added inline comments to D20271: When creating or editing a card on a sorted/grouped workboard, adjust headers appropriately.
Mar 12 2019, 8:03 PM
amckinley accepted D20271: When creating or editing a card on a sorted/grouped workboard, adjust headers appropriately.
Mar 12 2019, 8:02 PM
epriestley committed rP7d849afd16c5: Add a "WorkboardCardTemplate" class to make workboard client code easier to… (authored by epriestley).
Add a "WorkboardCardTemplate" class to make workboard client code easier to…
Mar 12 2019, 8:02 PM
epriestley closed D20267: Add a "WorkboardCardTemplate" class to make workboard client code easier to reason about.
Mar 12 2019, 8:02 PM
epriestley added inline comments to D20267: Add a "WorkboardCardTemplate" class to make workboard client code easier to reason about.
Mar 12 2019, 8:01 PM
epriestley committed rP4bad6bc42af9: Remove all readers/writers for task "subpriority" (authored by epriestley).
Remove all readers/writers for task "subpriority"
Mar 12 2019, 7:57 PM
epriestley closed D20266: Remove all readers/writers for task "subpriority".
Mar 12 2019, 7:57 PM
epriestley added inline comments to D20269: Modularize workboard column orders.
Mar 12 2019, 7:55 PM
amckinley accepted D20270: Implement "Group by Owner" on Workboards.
Mar 12 2019, 7:53 PM
epriestley committed rP46ed8d4a5ea7: On Workboards, sort groups by "natural order", not subpriority (authored by epriestley).
On Workboards, sort groups by "natural order", not subpriority
Mar 12 2019, 7:48 PM
epriestley closed D20265: On Workboards, sort groups by "natural order", not subpriority.
Mar 12 2019, 7:48 PM
epriestley committed rP00543f0620d1: Remove the ability to drag tasks up and down on (non-Workboard) priority list… (authored by epriestley).
Remove the ability to drag tasks up and down on (non-Workboard) priority list…
Mar 12 2019, 7:47 PM
epriestley closed D20263: Remove the ability to drag tasks up and down on (non-Workboard) priority list views.
Mar 12 2019, 7:47 PM
amckinley accepted D20269: Modularize workboard column orders.
Mar 12 2019, 7:47 PM
epriestley committed rPHU34b68955748b: Add "assert_same_keys()" to "libphutil/" (authored by epriestley).
Add "assert_same_keys()" to "libphutil/"
Mar 12 2019, 7:42 PM
epriestley closed D20268: Add "assert_same_keys()" to "libphutil/".
Mar 12 2019, 7:42 PM
epriestley committed rP7574be5372fe: Remove opacity effects for left-side / right-side diff text selection (authored by epriestley).
Remove opacity effects for left-side / right-side diff text selection
Mar 12 2019, 7:40 PM
epriestley closed D20264: Remove opacity effects for left-side / right-side diff text selection.
Mar 12 2019, 7:40 PM
amckinley accepted D20268: Add "assert_same_keys()" to "libphutil/".
Mar 12 2019, 7:21 PM
amckinley accepted D20267: Add a "WorkboardCardTemplate" class to make workboard client code easier to reason about.
Mar 12 2019, 7:05 PM
epriestley committed rP46ab71f834dc: Fix "abou" typo of "about" in SearchEngine API methods (authored by epriestley).
Fix "abou" typo of "about" in SearchEngine API methods
Mar 12 2019, 7:02 PM
epriestley closed D20280: Fix "abou" typo of "about" in SearchEngine API methods.
Mar 12 2019, 7:02 PM
amckinley updated the summary of D20267: Add a "WorkboardCardTemplate" class to make workboard client code easier to reason about.
Mar 12 2019, 6:58 PM
amckinley accepted D20280: Fix "abou" typo of "about" in SearchEngine API methods.
Mar 12 2019, 6:55 PM
epriestley added a comment to D20266: Remove all readers/writers for task "subpriority".

Oh, I didn't submit this comment:

Mar 12 2019, 6:55 PM
epriestley requested review of D20280: Fix "abou" typo of "about" in SearchEngine API methods.
Mar 12 2019, 6:54 PM
amckinley accepted D20266: Remove all readers/writers for task "subpriority".
Mar 12 2019, 6:54 PM
amckinley accepted D20265: On Workboards, sort groups by "natural order", not subpriority.
Mar 12 2019, 6:48 PM
amckinley accepted D20264: Remove opacity effects for left-side / right-side diff text selection.

I think I lean toward "yeah, let's get rid of this" after sleeping on it.

Mar 12 2019, 6:38 PM
amckinley accepted D20263: Remove the ability to drag tasks up and down on (non-Workboard) priority list views.
Mar 12 2019, 6:37 PM
epriestley requested review of D20279: Provide basic scaffolding for workboard column triggers.
Mar 12 2019, 6:16 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20279: Provide basic scaffolding for workboard column triggers.
Mar 12 2019, 6:15 PM · Workboards (v3), Restricted Project
mbinder awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Party Time token.
Mar 12 2019, 5:35 PM · Workboards (v3), Restricted Project
epriestley triaged T13264: Maybe stack multiple breadcrumb sequences? as Wishlist priority.
Mar 12 2019, 4:57 PM · Design
epriestley added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

Currently, you can put a task in a column in these ways:

Mar 12 2019, 1:37 PM · Workboards (v3), Restricted Project
epriestley added a member for Community: mves.
Mar 12 2019, 12:44 PM
epriestley closed T10944: Subproject is not archived when parent project gets archived as Wontfix.

Currently, expected behavior.

Mar 12 2019, 3:20 AM · Projects, Bug Report
epriestley closed T11974: Projects should allow setting of any icon as Resolved.

More or less resolved previously in D14918.

Mar 12 2019, 3:17 AM · Projects
epriestley closed T11974: Projects should allow setting of any icon, a subtask of T11971: Build an Icon Typeahead, as Resolved.
Mar 12 2019, 3:17 AM · PHUI
epriestley closed T10611: No option to specify a Space when editing a Project's visibility policy as Resolved.

D19549 added Spaces support to projects.

Mar 12 2019, 3:16 AM · Projects, Restricted Project, Feature Request, Spaces
epriestley requested review of D20278: Improve workboard "Owner" grouping, add "Author" grouping and "Title" sort.
Mar 12 2019, 3:15 AM
epriestley closed T10266: Firefox body scroll fails when dragging tasks as Wontfix.

Mooted by D20263, which removes the rarely-used drag functionality from global lists.

Mar 12 2019, 3:14 AM · Firefox, Projects
epriestley added a revision to T10333: Add groups to workboard columns: D20278: Improve workboard "Owner" grouping, add "Author" grouping and "Title" sort.
Mar 12 2019, 3:13 AM · Restricted Project, Restricted Project, Workboards (v3)