I'm going to look at improving the push logs a bit to show which rule blocked a push to address the actual use case in PHI765, which makes this more of a distance nice-to-have.

T1022 is possibly somewhat-vaguely-adjacent on symlink stuff.

@jcox do you know how to reproduce arc diff dying when you try to create certain types of diffs that move or remove symlinks? I think that's adjacent, if not identical to what's being talked about here.

I think the following change to src/applications/herald/controller/HeraldRuleController.php line 672 (as of 185c28f307e4) should provide an immediate improvement to at least indicate that they are different rules:

As a special case of this, if you commit an empty a.py file, then add content to it and also add a new empty b.py file in a commit on top of it, the new empty b.py will be detected as a copy of a.py based on the previous (empty) content of the file. I think Git is being pretty reasonable/consistent here, but this is potentially also expectation-defying:

Trying to reproduce this locally just hits the ft_doc.epochModified issue. I'm not immediately sure why the behavior differs between my local install and secure, but that issue probably needs to be fixed first.

Actually, I'm not entirely right in merging that task -- T13163 isn't quite the same as the other two issues here. I think they're similar, but the query text is relevant in the case of T13163. Notably:

You could use a Script and Regex Linter with config like this:

Is there any solutions for arclint & scss or is this still a valid issue?

ugh, zucchini

Thanks!

I really haven't looked into the backwards compatibility issue as we're already test-driving on PHP 7.3 preview, so I can't help you out there. Your suggestion to detect the PHP version and offer this solution only for versions of PHP 7 and higher seems like the most obvious approach.

I didn't even suggest dropping support, I'm merely listing the options to allow both versions to work.
We use a manually patched version of arcanist because it suits our company's use case, but it wouldn't be suitable for a merge in Phabricator's codebase in this state.

@mydeveloperday Thanks! That'll work

@dwilches I needed the same ,just wrote up my solution here

Tough decision to make. Given the fact that most PHP projects are abandoning PHP 5 support is great, but with forcing users to upgrade is not always a good thing, as I'm not sure how this would impact the corporate/enterprise customers.

@DragonBe Backwards compatibility is broken by this fix. I'm not sure what the phabricator policy is regarding this, but I see two options:

• Creating another test engine (one for PHPUnit <= 5 and one for PHPUnit > 5)
• Parsing output differently depending on the PHPUnit version and reuse the old code where needed. This would require a little work to do things properly I guess.

In T8510#200946, @aklapper wrote:

In https://phabricator.wikimedia.org/T76732#2803813 ksmith brings up that "In the search bar in the toolbar at the top of the screen, searching for "Maps" brings up Maps as the third option. Searching for "Discovery" brings up Discovery as the second option."

@epriestley any updates on this, or should I land it before this week's release cut as-is?

Can't wait for "connect 2" to come out on playstation six.

Is there a workaround for including a newline in a table's cells? I've tried with both pipe and HTML syntax, and with %%%, triple back-tick and <br> with no success.

• Trivial update mostly for demonstrating API calls.

PHI781 asks for [ ] Show on commit message template. for "Maniphest Tasks:".

I think the label Maniphest Tasks is no longer rendered, because the tasks are being parsed from the message body ("fixes Txxx").

In D18181#240863, @epriestley wrote:

(Does this survive a cert file with no terminal newline?)

Ah, fair enough :) Thanks for clarifying. I'll drop this revision, then.

(Does this survive a cert file with no terminal newline?)

See https://secure.phabricator.com/book/phabricator/article/tone/

I'm also wondering about this. I've moved the fields around in that config setting, but I can't get Maniphest Tasks: to appear in the template when running arc diff. Is this still the place to make the change or has it moved since you comment?

Ping on this?