Choosing "Abandon Revision" because "Abandon Revision, Set it on Fire, and Pretend it Never Existed" isn't an option. I'll get a diff ready that adds that as an option.

Oh god. I step away for 5 minutes and I'm now on the phacility hit-list.

haha I had a feeling this probably fell into the category of things that are in the process of being done a better/holistic way

Use <= rather than <

@epriestley do these changes look alright? I pulled most of PhabricatorWorkerArchiveTaskQuery up into the abstract PhabricatorWorkerTaskQuery and then added PhabricatorWorkerActiveTaskQuery. That made it more straightforward to just AND all the constraints together.

Backed PhabricatorWorkerActiveTasks with an actual query object and refactored to share
some logic between Active and Archived tasks. Also removed some overeager indentations.

Confirmed this on my local. It seems to be due to D16851, specifically this line: https://secure.phabricator.com/source/phabricator/browse/master/src/applications/diffusion/application/PhabricatorDiffusionApplication.php$104.

Pretty sure this works as intended

{auto-playing-audio WilhelmScream.mp3}

Yes I did have the persistent chat pane open. Also can't seem to repro without it.

The other errors that appear in DarkConsole:

Hmmm I'm not seeing those lines in that file anywhere. On the current head of master, I'm pretty sure the viewer is always set to PhabricatorUser::getOmnipotentUser() in TransactionPublishWorker. Although maybe that isn't making it all the way to the policy aware query in every case.

@jessjohnson I still haven't had a chance to dig further into this, but I'll report back when I do (or if you figure anything out, please let me know). I don't think killing off the tasks permanently is really an option since this seems to happen for specific degenerate instances of otherwise-needed tasks. Perhaps not allowing these tasks to retry would be an okay bandaid, but I'd still like to figure out the underlying problem if we can.

Nope we don't have that integrated in yet (just missed our last cutoff). Once we get that pulled in I'll confirm it clears up the issue.

Evan, do you think there is a route forward with this that would be feasible for me to implement upstream?

Ah yeah it could be related to that (policy errors/unit test failures), although I wouldn't really describe this as "extremely rare" (except of course when I'm trying to make it happen). Some stats from grepping through logs: since last week it looks like this error has happened 73k times involving 193 distinct diffs. It's like the daemons are laughing at my inability to repro it.

Just spent a bit of time trying to repro this in a script but could not. The diffs always load successfully from the script. I even tried waiting until right after one of the errors popped up in the logs and then queried for that diff via the script right away.

Gonna go ahead and say no one should be automatically subscribed to tokens

Fixed issues brought up in CR

removed another vestige of application names

DELETE MOARRR CODE

Make getRedirectURI always have a domain

s/phurl/Phurl/

Added short URL to results

Added ability to search by URL name substring

Clean up regex

Updated based on CR comments

Added parameters for width, height, alt, layout, and href

As far as dealing with URLs where the protocol isn't specified I see a few possible approaches:

Use null rather than empty string.

more succinct alias checking for src key

All of the following syntaxes work now:

Now using the imageproxy endpoint.

Deal with null file and bypass policies for external files

Updated based on CR comments

Tidied up code a bit based on code review