Haha!
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 11 2014
Jun 11 2014
Jun 10 2014
Jun 10 2014
Jun 9 2014
Jun 9 2014
Are there any outstanding issues here that I need to fix before it can land?
talshiri retitled D9442: Allow specifying runtime configuration with --set-config key=value from to Allow specifying runtime configuration with --set-config key=value.
Jun 7 2014
Jun 7 2014
Jun 6 2014
Jun 6 2014
- don't assume there's an email body
- inline patch no longer destroys whitespaces
talshiri retitled D9405: made email commands extraction a bit more lax from to made email commands extraction a bit more lax.
Jun 5 2014
Jun 5 2014
- if repo name doesn't exist, use the basename of the source path
- changed "--range" to "--head"
talshiri retitled D9383: return remote for getSourceControlPath from to return remote for getSourceControlPath.
talshiri retitled D9382: Only canonize paths if both sourceControlPath field is present and we're in SVN. from to Only canonize paths if both sourceControlPath field is present and we're in SVN..
Jun 4 2014
Jun 4 2014
Colorize actions according to their getColor(). Better emails!
talshiri retitled D9379: Changed behavior of "code block" button to use triple tick syntax ("```") instead of whitespacing. from to Changed behavior of "code block" button to use triple tick syntax ("```") instead of whitespacing..
perserve newlines when generating html
Also interested in this. It could maaaybe reduce reliance on email </wishful thinking>
Jun 3 2014
Jun 3 2014
Fixed diff being reversed :P
minor oops
Moved things to getMailSubjectPrefix, which is slightly more useful and doesn't add an extra variable.
Don't modify Topic
Don't die if no repo/branch are defined
talshiri updated the task description for T5244: Allow email subjects and bodies to be more customizable.
talshiri updated the task description for T5244: Allow email subjects and bodies to be more customizable.
talshiri updated the task description for T5244: Allow email subjects and bodies to be more customizable.
talshiri edited this Maniphest Task.
May 31 2014
May 31 2014
talshiri retitled D9342: Make Differential email subject more configurable. from to Make Differential email subject more configurable..
May 21 2014
May 21 2014
applied change requests
May 20 2014
May 20 2014
talshiri retitled D9223: Added placeholder support to custom text fields from to Added placeholder support to custom text fields.
May 16 2014
May 16 2014
talshiri added a comment to D9150: can now tell phabricator you trust an auth provider's emails (useful for Google OAuth), which will mark emails as "verified" and will skip email verification..
Thanks Evan!
talshiri updated the diff for D9150: can now tell phabricator you trust an auth provider's emails (useful for Google OAuth), which will mark emails as "verified" and will skip email verification..
added shouldAllowEmailTrustConfiguration()
talshiri updated the diff for D9150: can now tell phabricator you trust an auth provider's emails (useful for Google OAuth), which will mark emails as "verified" and will skip email verification..
incorporated review comments
talshiri retitled D9150: can now tell phabricator you trust an auth provider's emails (useful for Google OAuth), which will mark emails as "verified" and will skip email verification. from to can now tell phabricator you trust an auth provider's emails (useful for Google OAuth), which will mark emails as "verified" and will skip email verification..
new diff incoming
talshiri abandoned D9144: Allow auth adapters to signal that the email address they're returning is trusted, so the email verification step can be skipped.
Not needed anymore (config stuff live in the phabricator repo)
May 15 2014
May 15 2014
talshiri retitled D9146: skip email verification when dealing with trusted auth providers from to skip email verification when dealing with trusted auth providers.
talshiri added a comment to D9144: Allow auth adapters to signal that the email address they're returning is trusted, so the email verification step can be skipped.
Are emails coming from Google ever not trusted?
If I make it configurable, would it be ok to make it the default on Google?
talshiri retitled D9144: Allow auth adapters to signal that the email address they're returning is trusted, so the email verification step can be skipped from to Allow auth adapters to signal that the email address they're returning is trusted, so the email verification step can be skipped.
Feb 21 2014
Feb 21 2014
That would close CRs that haven't been pushed, though.
What about having it check with diffusion first? If it's there, close. Otherwise it will get closed normally when diffusion sees it.
The issue here is that some users want to push directly to master, and have the code reviewed post-push (so there's no arc land).
(wait = don't do anything on push, and as soon as it's accepted it queries diffusion for the commit to see if it's there)
Ha! That is awesome.
How does autoclose work in those cases? Does it wait for it to be accepted before switching it over to closed?
Hey Evan!
Some updates on this (we've already discusses some of these, but I'm just summarizing them here for reference sake):
Jan 26 2014
Jan 26 2014
Awesome!
Jan 24 2014
Jan 24 2014
How would it work with T4344, though? Also query with a project id?
Jan 21 2014
Jan 21 2014
btw, we should probably add this to the "Configuring Inbound Email" article
Jan 17 2014
Jan 17 2014
talshiri edited this Maniphest Task.
Jan 15 2014
Jan 15 2014
haha. ok.