If something goes wrong with this, the patch which fixes the problem can now change the indexer version and then all mis-indexed documents can be reindexed with:
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Feb 17 2021
Feb 17 2021
epriestley added a comment to T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes.
epriestley committed rP6703fec3e27d: When documents are indexed, record the indexer version (versus the object… (authored by epriestley).
When documents are indexed, record the indexer version (versus the object…
epriestley committed rP4f647fb6be2b: When updating a Ferret search index document, reuse existing rows where possible (authored by epriestley).
When updating a Ferret search index document, reuse existing rows where possible
epriestley updated the diff for D21560: When documents are indexed, record the indexer version (versus the object version) and index epoch.
- Correct "bin/index" -> "bin/search index".
epriestley updated the diff for D21560: When documents are indexed, record the indexer version (versus the object version) and index epoch.
- Fix typos and bugs, test more "--type" flag values.
Feb 16 2021
Feb 16 2021
epriestley added a comment to T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes.
The existing SearchIndexVersion table (which stores document versions) may reasonably be able to store index versions too. This limits the need to apply changes to fdocument.
epriestley added a comment to T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes.
This has stalled for a while because it's moderately expensive to recover from if the updated index logic has a bug: rebuilding all document indexes is expensive, and it's difficult to identify the set of documents that need to be reindexed if a bug is present.
epriestley updated the diff for D21495: When updating a Ferret search index document, reuse existing rows where possible.
- Fix recently added lint warning about catching "Exception" without "Throwable".
epriestley closed T13607: Provide additional query constraints in "harbormaster.target.search" as Resolved.
Yep, that's more constraints.
epriestley committed rP5d6dddc5eb61: Add more constraints to "harbormaster.target.search" (authored by epriestley).
Add more constraints to "harbormaster.target.search"
epriestley triaged T13607: Provide additional query constraints in "harbormaster.target.search" as Normal priority.
epriestley updated the task description for T1022: arc patch fails to properly apply a patch which changes a symlink to a real file.
Feb 15 2021
Feb 15 2021
epriestley triaged T13606: In Diffusion UI, satisfy "Refs" query from the database, not the API as Normal priority.
See PHI1997, which discusses things from the perspective of reporting coverage from a build system.
Add a PHID to Changesets
epriestley committed rP9feb7343e662: Provide a "differential.changeset.search" Conduit API method (authored by epriestley).
Provide a "differential.changeset.search" Conduit API method
epriestley requested review of D21558: Provide a "differential.changeset.search" Conduit API method.
epriestley triaged T13605: Implement a "differential.changeset.search" API method as Normal priority.
In 2014, Phacility was still largely pre-revenue and the business model wasn't entirely clear, and there was value in testing support for payment processing by handling small, low-stakes charges. Phacility now has revenue and more clarity around the business model (and the payment processing code is more mature and proven), and accepting donations (even with the disclaimer that Phacility is an "evil, for-profit corporation") no longer feels appropriate.
Feb 13 2021
Feb 13 2021
epriestley committed rP42c26821ef92: When a revision has only human reviewers but none can view it, show a warning… (authored by epriestley).
When a revision has only human reviewers but none can view it, show a warning…
epriestley committed rP90903282c706: Render user hovercards with context information about their ability to see the… (authored by epriestley).
Render user hovercards with context information about their ability to see the…
epriestley committed rPa4cb2bb77247: When a subscriber can't see an object, clearly show that they're missing the… (authored by epriestley).
When a subscriber can't see an object, clearly show that they're missing the…
epriestley committed rP2f33dedc8b62: When a reviewer can't see a revision, show it clearly in the reviewer list (authored by epriestley).
When a reviewer can't see a revision, show it clearly in the reviewer list
epriestley committed rP2aac3156f791: Restructure Hovercards to support more context information (authored by epriestley).
Restructure Hovercards to support more context information
epriestley committed rPf0dc06529033: Lift bulk tests for "many users against one object" capabilities into… (authored by epriestley).
Lift bulk tests for "many users against one object" capabilities into…
epriestley committed rP58bbd6ee8838: Propagate the "ContextObject" to Remarkup rendering in timelines (authored by epriestley).
Propagate the "ContextObject" to Remarkup rendering in timelines
(stable) Promote 2021 Week 7
(stable) Promote 2021 Week 7
Feb 12 2021
Feb 12 2021
Feb 10 2021
Feb 10 2021
Update golint install instructions
Feb 8 2021
Feb 8 2021
I also don't see any way to really make useful assertions about this parameter statically.
epriestley committed rP3e38579feea3: Update install and upgrade documentation for libphutil (authored by epriestley).
Update install and upgrade documentation for libphutil
epriestley committed rARC239ad5c55d8d: In "array_mergev()", guarantee the "call_user_func_array()" parameter list is a… (authored by epriestley).
In "array_mergev()", guarantee the "call_user_func_array()" parameter list is a…
PHP8 supports named arguments. At a minimum, the builtin function call_user_func_array() has changed behavior. This script:
epriestley committed rP67cf80b377bd: Test if "get_magic_quotes_gpc()" exists before calling it (authored by epriestley).
Test if "get_magic_quotes_gpc()" exists before calling it
Feb 7 2021
Feb 7 2021
(stable) Promote 2021 Week 6
(stable) Promote 2021 Week 6
Feb 5 2021
Feb 5 2021
epriestley added a comment to T12771: Users can mistakenly create revisions with no repository through confusion or misconfiguration.
See also PHI1987 for another case of this.
epriestley requested review of D21548: Propagate the "ContextObject" to Remarkup rendering in timelines.
epriestley added a comment to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers.
- When rendering a "no view permission" hovercard, it would be nice to annotate it with an explicit "The user can't see this object" piece of context information.
epriestley added a comment to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers.
- Context objects don't make it into timeline rendering engines.
- Context objects don't make it into comment previews.
Feb 4 2021
Feb 4 2021
epriestley triaged T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers as Normal priority.
epriestley closed T13600: Improve workflow for host-to-host Phacility cluster repository migrations of observed repositories as Resolved.
This more-or-less worked as desired. Some minor issues:
epriestley committed rPf63680db381a: (stable) Add an "--ignore-locality" flag to "bin/repository pull" (authored by epriestley).
(stable) Add an "--ignore-locality" flag to "bin/repository pull"
epriestley committed rP00cf93548b70: Add an "--ignore-locality" flag to "bin/repository pull" (authored by epriestley).
Add an "--ignore-locality" flag to "bin/repository pull"