- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Sep 17 2020
Sep 17 2020
epriestley committed rARC563dc2a993ec: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions (authored by epriestley).
In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions
epriestley triaged T13582: Exception handling in ConduitFuture for raw HTTP exceptions lacks tailoring as Low priority.
epriestley committed rARC8e5e49984d50: Fix a slow memory leak in long-lived FutureIterator objects, as used by… (authored by epriestley).
Fix a slow memory leak in long-lived FutureIterator objects, as used by…
epriestley added a comment to T13572: Daemon overseers may have a slow memory leak, possibly in FuturePool.
This synthetic script demonstrates the conceptual problem with FutureIterator:
epriestley committed rPa754c694deab: Add missing indexes to DrydockRepositoryOperation (authored by epriestley).
Add missing indexes to DrydockRepositoryOperation
Sep 16 2020
Sep 16 2020
epriestley closed T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash as Resolved.
epriestley committed rP969587f7b0c3: Log unexpected exceptions raised by Conduit calls (authored by epriestley).
Log unexpected exceptions raised by Conduit calls
epriestley committed rP2a83df578604: Fix an issue where a GROUP BY was missing when a query matched a revision using… (authored by epriestley).
Fix an issue where a GROUP BY was missing when a query matched a revision using…
epriestley committed rP737e7c85412c: When an in-process worker subtask fails permanently, don't fatal the whole… (authored by epriestley).
When an in-process worker subtask fails permanently, don't fatal the whole…
epriestley committed rPa39c59044235: Move task and revision closure to the "publishing" step of the commit import… (authored by epriestley).
Move task and revision closure to the "publishing" step of the commit import…
epriestley committed rP93ef902ffa3c: Fix a view fatal in CommitGraphView when commits are undiscovered (authored by epriestley).
Fix a view fatal in CommitGraphView when commits are undiscovered
epriestley committed rP6f78e2a91c88: When a commit is marked "closeable", clear the "published" flag (authored by epriestley).
When a commit is marked "closeable", clear the "published" flag
epriestley committed rPcebde34425c2: Make "CommitData" wrap and persist a "CommitRef" record (authored by epriestley).
Make "CommitData" wrap and persist a "CommitRef" record
epriestley committed rPe454c3dafe99: Wrap all direct access to author/committer properties on "CommitData" (authored by epriestley).
Wrap all direct access to author/committer properties on "CommitData"
epriestley committed rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits" (authored by epriestley).
Turn "bypassCache" into a no-op in "diffusion.querycommits"
epriestley committed rP3a80efa440f0: Build "DiffusionCommitRef" objects from "internal.commit.search", not… (authored by epriestley).
Build "DiffusionCommitRef" objects from "internal.commit.search", not…
epriestley committed rPa745055813e4: Lift Diffusion Conduit call proxying to the root level of Conduit (authored by epriestley).
Lift Diffusion Conduit call proxying to the root level of Conduit
epriestley committed rPf6238f9d9bd3: Remove "bin/repository lookup-users" workflow (authored by epriestley).
Remove "bin/repository lookup-users" workflow
epriestley committed rPa9506097ea04: Add "internal.commit.search" to replace the cache bypass mode of "diffusion. (authored by epriestley).
Add "internal.commit.search" to replace the cache bypass mode of "diffusion.
Delete some commit dead parsing code
epriestley committed rARCde209ec06488: When raising a Conduit client exception, show the called method in the error… (authored by epriestley).
When raising a Conduit client exception, show the called method in the error…
epriestley triaged T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash as Normal priority.
Sep 15 2020
Sep 15 2020
epriestley committed rP3dfa89dd5d27: Update SES API to use AWSv4 signatures (authored by epriestley).
Update SES API to use AWSv4 signatures
epriestley added a comment to T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly.
I've marked D21461 as resolving this, since the new errors surface the particulars:
Sep 8 2020
Sep 8 2020
epriestley requested review of D21460: When a commit is marked "closeable", clear the "published" flag.
epriestley requested review of D21458: Fix a view fatal in CommitGraphView when commits are undiscovered.
epriestley triaged T13580: Make "fully imported" a separate commit bit or standalone flag, not a complex bitmask operation as Wishlist priority.
epriestley closed T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path as Resolved.
- D21457 fixes approximately 20 additional errors identified by the linter in phabricator/.
epriestley committed rARC73847a4b194b: Fix a false negative in lint for "xsprintf()"-family functions (authored by epriestley).
Fix a false negative in lint for "xsprintf()"-family functions
epriestley committed rARC7112ee3d5960: Fix additional "xsprintf()"-family static parameter errors (authored by epriestley).
Fix additional "xsprintf()"-family static parameter errors
epriestley committed rARC83e63aeb078b: Allow AAST to extract string literal values from HEREDOCs (authored by epriestley).
Allow AAST to extract string literal values from HEREDOCs
epriestley committed rARC1c327208d7ba: Fix a missing "pht()" parameter in HTTPSFuture (authored by epriestley).
Fix a missing "pht()" parameter in HTTPSFuture
epriestley committed rP6e1b5da1121c: Fix additional "xprintf()"-class static parameter lint errors (authored by epriestley).
Fix additional "xprintf()"-class static parameter lint errors
epriestley requested review of D21457: Fix additional "xprintf()"-class static parameter lint errors.
Sep 5 2020
Sep 5 2020
epriestley added a comment to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.
- D21454 fixes the specific issue in HTTPSFuture.
epriestley added a comment to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.
Check if arc lint catches this.
epriestley requested review of D21453: Fix a false negative in lint for "xsprintf()"-family functions.
Sep 4 2020
Sep 4 2020
epriestley committed rP5fff4ed8dbb7: (stable) Remove obsolete write to "pid" property in "annihilateProcessGroup()"… (authored by epriestley).
(stable) Remove obsolete write to "pid" property in "annihilateProcessGroup()"…
epriestley committed rP69662a11d73d: (stable) When printing timestamps on paper: use an absolute, context-free date… (authored by epriestley).
(stable) When printing timestamps on paper: use an absolute, context-free date…
epriestley committed rP7daaaa8463e2: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon… (authored by epriestley).
Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon…