Page MenuHomePhabricator
Feed Advanced Search

Feb 13 2020

epriestley closed T13489: Fix implicit "XMLWriter" requirement when loading lint sinks, a subtask of T13395: Strip libphutil for parts, as Resolved.
Feb 13 2020, 9:38 PM · libphutil
epriestley closed T13489: Fix implicit "XMLWriter" requirement when loading lint sinks as Resolved by committing rARC0d62a10eda68: Don't depend on "XMLWriter" to load the lint renderer class tree.
Feb 13 2020, 9:38 PM · Lint, libphutil
epriestley closed D20989: Don't depend on "XMLWriter" to load the lint renderer class tree.
Feb 13 2020, 9:38 PM
epriestley requested review of D20989: Don't depend on "XMLWriter" to load the lint renderer class tree.
Feb 13 2020, 9:38 PM
epriestley added a revision to T13489: Fix implicit "XMLWriter" requirement when loading lint sinks: D20989: Don't depend on "XMLWriter" to load the lint renderer class tree.
Feb 13 2020, 9:37 PM · Lint, libphutil
epriestley triaged T13489: Fix implicit "XMLWriter" requirement when loading lint sinks as Low priority.
Feb 13 2020, 9:32 PM · Lint, libphutil
epriestley requested review of D20988: Merge utility/support changes from "wilds" to "master".
Feb 13 2020, 4:00 PM
epriestley added a revision to T13395: Strip libphutil for parts: D20988: Merge utility/support changes from "wilds" to "master".
Feb 13 2020, 3:59 PM · libphutil
avivey awarded T13488: Upgrading: Early 2020 Changes to Arcanist a Party Time token.
Feb 13 2020, 2:11 PM · Arcanist, Installing & Upgrading
epriestley committed rARC8c4f6ce1617e: Merge the remainder of the "experimental" branch (authored by epriestley).
Merge the remainder of the "experimental" branch
Feb 13 2020, 2:05 PM
epriestley closed D20987: Merge the remainder of the "experimental" branch.
Feb 13 2020, 2:05 PM
epriestley committed rARC4c36860c4303: Merge Arcanist lint changes from "experimental" branch (authored by epriestley).
Merge Arcanist lint changes from "experimental" branch
Feb 13 2020, 2:04 PM
epriestley closed D20986: Merge Arcanist lint changes from "experimental" branch.
Feb 13 2020, 2:04 PM
epriestley requested review of D20987: Merge the remainder of the "experimental" branch.
Feb 13 2020, 2:04 PM
epriestley added a revision to T13395: Strip libphutil for parts: D20987: Merge the remainder of the "experimental" branch.
Feb 13 2020, 2:03 PM · libphutil
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Feb 13 2020, 2:01 PM · Arcanist, Installing & Upgrading
epriestley requested review of D20986: Merge Arcanist lint changes from "experimental" branch.
Feb 13 2020, 1:52 PM
epriestley added a revision to T13395: Strip libphutil for parts: D20986: Merge Arcanist lint changes from "experimental" branch.
Feb 13 2020, 1:51 PM · libphutil
epriestley added a comment to T13395: Strip libphutil for parts.

I'm also going to collapse as much of experimental into master as I can here, make the minimum required PHP version 5.5 (see T11968), and attempt to collapse wilds.

Feb 13 2020, 1:51 PM · libphutil
epriestley triaged T13488: Upgrading: Early 2020 Changes to Arcanist as Low priority.
Feb 13 2020, 1:49 PM · Arcanist, Installing & Upgrading
epriestley added a comment to T11968: Decide the fate of FutureGraph.

Probably require PHP 5.4 regardless.

Feb 13 2020, 1:29 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a comment to T11968: Decide the fate of FutureGraph.

A problem in moving forward here is that we ultimately do very little complex data access in Phabricator, and what complex data access we do perform can often be faked. We likely have more use cases in Arcanist and provisioning code: API calls are slower, workflows are more parallel/interactive, and we can't just fake it all with AJAX.

Feb 13 2020, 3:59 AM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley committed rARC26f853b63430: Merge "--draft" flag and related changes from "experimental" to "master" (authored by epriestley).
Merge "--draft" flag and related changes from "experimental" to "master"
Feb 13 2020, 12:54 AM
epriestley closed D20985: Merge "--draft" flag and related changes from "experimental" to "master".
Feb 13 2020, 12:54 AM
epriestley requested review of D20985: Merge "--draft" flag and related changes from "experimental" to "master".
Feb 13 2020, 12:37 AM
epriestley added a revision to T13010: Upgrading: Differential Draft State: D20985: Merge "--draft" flag and related changes from "experimental" to "master".
Feb 13 2020, 12:36 AM · Installing & Upgrading
epriestley updated the task description for T13010: Upgrading: Differential Draft State.
Feb 13 2020, 12:31 AM · Installing & Upgrading
epriestley closed T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential, a subtask of T9123: Build Phabricator in Harbormaster (v2), as Resolved.
Feb 13 2020, 12:20 AM · Prioritized, Harbormaster
epriestley closed T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential as Resolved by committing rPdc35ce79e484: Unprototype "Draft" mode in Differential.
Feb 13 2020, 12:20 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley committed rPdc35ce79e484: Unprototype "Draft" mode in Differential (authored by epriestley).
Unprototype "Draft" mode in Differential
Feb 13 2020, 12:20 AM
epriestley closed D20983: Unprototype "Draft" mode in Differential.
Feb 13 2020, 12:20 AM
epriestley committed rARCa8a50b2fc004: Make "arcanist/" unit tests pass (authored by epriestley).
Make "arcanist/" unit tests pass
Feb 13 2020, 12:20 AM
epriestley closed D20984: Make "arcanist/" unit tests pass.
Feb 13 2020, 12:20 AM

Feb 12 2020

epriestley requested review of D20984: Make "arcanist/" unit tests pass.
Feb 12 2020, 11:59 PM
epriestley added a revision to T13395: Strip libphutil for parts: D20984: Make "arcanist/" unit tests pass.
Feb 12 2020, 11:58 PM · libphutil
epriestley committed rARC61e059984a15: Merge "phage" from "experimental" (authored by epriestley).
Merge "phage" from "experimental"
Feb 12 2020, 11:53 PM
epriestley closed D20982: Merge "phage" from "experimental".
Feb 12 2020, 11:53 PM
epriestley requested review of D20983: Unprototype "Draft" mode in Differential.
Feb 12 2020, 11:52 PM
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: D20983: Unprototype "Draft" mode in Differential.
Feb 12 2020, 11:48 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T13395: Strip libphutil for parts: D20982: Merge "phage" from "experimental".
Feb 12 2020, 11:45 PM · libphutil
epriestley closed D20980: Fully merge "libphutil/" into "arcanist/".
Feb 12 2020, 11:18 PM
epriestley committed rARC9b74cb4ee641: Fully merge "libphutil/" into "arcanist/" (authored by epriestley).
Fully merge "libphutil/" into "arcanist/"
Feb 12 2020, 11:18 PM
epriestley committed rP35a18146a28f: Merge a small amount of remaining "libphutil/" code with Phabricator, break… (authored by epriestley).
Merge a small amount of remaining "libphutil/" code with Phabricator, break…
Feb 12 2020, 11:17 PM
epriestley closed D20981: Merge a small amount of remaining "libphutil/" code with Phabricator, break libphutil dependency.
Feb 12 2020, 11:17 PM
epriestley requested review of D20981: Merge a small amount of remaining "libphutil/" code with Phabricator, break libphutil dependency.

Depends on harness changes to even plausibly build.

Feb 12 2020, 11:17 PM
epriestley requested review of D20980: Fully merge "libphutil/" into "arcanist/".

This won't build until the harness is updated.

Feb 12 2020, 11:16 PM
epriestley closed D20979: Fully deprecate "libphutil/".
Feb 12 2020, 11:16 PM
epriestley committed rPHU720c8116845b: Fully deprecate "libphutil/" (authored by epriestley).
Fully deprecate "libphutil/"
Feb 12 2020, 11:16 PM
epriestley requested review of D20979: Fully deprecate "libphutil/".

Among other considerations, the test harness needs to be updated before this will pass.

Feb 12 2020, 11:15 PM
epriestley added a revision to T13395: Strip libphutil for parts: D20981: Merge a small amount of remaining "libphutil/" code with Phabricator, break libphutil dependency.
Feb 12 2020, 11:11 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: D20980: Fully merge "libphutil/" into "arcanist/".
Feb 12 2020, 11:06 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: D20979: Fully deprecate "libphutil/".
Feb 12 2020, 10:37 PM · libphutil
epriestley updated the description for U47 "libphutil" Library Now Deprecated.
Feb 12 2020, 10:30 PM
epriestley created U47 "libphutil" Library Now Deprecated.
Feb 12 2020, 10:30 PM
epriestley committed rPf9b3e3360b0c: Continue moving classes with no callers in libphutil or Arcanist to Phabricator (authored by epriestley).
Continue moving classes with no callers in libphutil or Arcanist to Phabricator
Feb 12 2020, 9:14 PM
epriestley closed D20977: Continue moving classes with no callers in libphutil or Arcanist to Phabricator.
Feb 12 2020, 9:14 PM
epriestley committed rARCa36e60f0a37e: Move HTML-only intraline diff code to Phabricator (authored by epriestley).
Move HTML-only intraline diff code to Phabricator
Feb 12 2020, 9:13 PM
epriestley closed D20978: Move HTML-only intraline diff code to Phabricator.
Feb 12 2020, 9:13 PM
epriestley committed rPHUce63d5b45049: Move additional classes out of libphutil, to Phabricator (authored by epriestley).
Move additional classes out of libphutil, to Phabricator
Feb 12 2020, 9:13 PM
epriestley closed D20976: Move additional classes out of libphutil, to Phabricator.
Feb 12 2020, 9:13 PM
epriestley requested review of D20978: Move HTML-only intraline diff code to Phabricator.
Feb 12 2020, 8:30 PM
epriestley added a revision to T13395: Strip libphutil for parts: D20978: Move HTML-only intraline diff code to Phabricator.
Feb 12 2020, 8:30 PM · libphutil
epriestley requested review of D20976: Move additional classes out of libphutil, to Phabricator.
Feb 12 2020, 8:29 PM
epriestley updated the diff for D20977: Continue moving classes with no callers in libphutil or Arcanist to Phabricator.
  • Also move the "Pygmentize" parser.
Feb 12 2020, 8:08 PM
epriestley requested review of D20977: Continue moving classes with no callers in libphutil or Arcanist to Phabricator.
Feb 12 2020, 8:04 PM
epriestley added a revision to T13395: Strip libphutil for parts: D20977: Continue moving classes with no callers in libphutil or Arcanist to Phabricator.
Feb 12 2020, 8:01 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: D20976: Move additional classes out of libphutil, to Phabricator.
Feb 12 2020, 7:58 PM · libphutil
epriestley committed rP8cc6fe465c53: Fix diffusion.branchquery returning dictionary instead of array when branches… (authored by Arturas Moskvinas arturas@uber.com <arturas@uber.com>).
Fix diffusion.branchquery returning dictionary instead of array when branches…
Feb 12 2020, 7:50 PM
epriestley closed D20973: Fix diffusion.branchquery returning dictionary instead of array when branches are filtered out.
Feb 12 2020, 7:50 PM
epriestley committed rPaf84f215f9b8: Move lingering "Aphront" classes to Phabricator (authored by epriestley).
Move lingering "Aphront" classes to Phabricator
Feb 12 2020, 7:50 PM
epriestley closed D20975: Move lingering "Aphront" classes to Phabricator.
Feb 12 2020, 7:50 PM
epriestley accepted D20973: Fix diffusion.branchquery returning dictionary instead of array when branches are filtered out.

Thanks!

Feb 12 2020, 7:50 PM
epriestley requested review of D20975: Move lingering "Aphront" classes to Phabricator.
Feb 12 2020, 7:49 PM
epriestley committed rPHU893fe11a5e38: Move lingering "Aphront" classes out of libphutil (authored by epriestley).
Move lingering "Aphront" classes out of libphutil
Feb 12 2020, 7:48 PM
epriestley closed D20974: Move lingering "Aphront" classes out of libphutil.
Feb 12 2020, 7:48 PM
epriestley added a revision to T13395: Strip libphutil for parts: D20975: Move lingering "Aphront" classes to Phabricator.
Feb 12 2020, 7:48 PM · libphutil
epriestley requested review of D20974: Move lingering "Aphront" classes out of libphutil.
Feb 12 2020, 7:47 PM
epriestley added a revision to T13395: Strip libphutil for parts: D20974: Move lingering "Aphront" classes out of libphutil.
Feb 12 2020, 7:47 PM · libphutil
epriestley edited the content of Changelog.
Feb 12 2020, 7:35 PM
epriestley committed rPff6f24db2bc0: (stable) Promote 2020 Week 6 (authored by epriestley).
(stable) Promote 2020 Week 6
Feb 12 2020, 7:34 PM
epriestley created an object: 2020 Week 6 (Early February).
Feb 12 2020, 7:34 PM

Feb 7 2020

epriestley added a comment to T2383: Run PHP environment checks from CLI.

https://discourse.phabricator-community.org/t/activities-notifications-spam/3286/ is likely a case where curl was not installed on the CLI, but was installed in the web SAPI.

Feb 7 2020, 8:52 PM · Setup
epriestley added a comment to T13426: Add a "Saved States" indirection layer on top of "Staging Areas".

A saved state is likely something like this:

Feb 7 2020, 4:54 PM · Harbormaster, Drydock, Arcanist
epriestley added a comment to T11402: Garbage collect and/or compress/archive harbormaster build unit messages.

I'd like to leave behind a "Results were GC'd on X/Y/Z" message when we GC these so it's clear what's going on.

Feb 7 2020, 2:07 PM · Restricted Project, Harbormaster, Feature Request

Feb 6 2020

epriestley committed rP2327578adc94: Respect linebreaks in full HTML tables in Remarkup (authored by epriestley).
Respect linebreaks in full HTML tables in Remarkup
Feb 6 2020, 11:01 PM
epriestley closed T5427: Force a line break in a table cell as Resolved by committing rP2327578adc94: Respect linebreaks in full HTML tables in Remarkup.
Feb 6 2020, 11:01 PM · Remarkup
epriestley closed D20971: Respect linebreaks in full HTML tables in Remarkup.
Feb 6 2020, 11:01 PM
epriestley requested review of D20971: Respect linebreaks in full HTML tables in Remarkup.
Feb 6 2020, 10:54 PM
epriestley added a revision to T5427: Force a line break in a table cell: D20971: Respect linebreaks in full HTML tables in Remarkup.
Feb 6 2020, 10:53 PM · Remarkup
epriestley added a comment to T5427: Force a line break in a table cell.

(See also T13160, and D20568 for additional rationale.)

Feb 6 2020, 10:50 PM · Remarkup
epriestley reopened T5427: Force a line break in a table cell as "Open".

See also PHI1630.

Feb 6 2020, 10:49 PM · Remarkup

Feb 5 2020

epriestley committed rP9d1af762d518: In summary interfaces, don't render very large inline remarkup details for unit… (authored by epriestley).
In summary interfaces, don't render very large inline remarkup details for unit…
Feb 5 2020, 10:26 PM
epriestley closed D20970: In summary interfaces, don't render very large inline remarkup details for unit test messages.
Feb 5 2020, 10:26 PM
epriestley requested review of D20970: In summary interfaces, don't render very large inline remarkup details for unit test messages.
Feb 5 2020, 3:46 PM
epriestley added a revision to T10635: Loading differential revision slow when lots of unit test messages exist: D20970: In summary interfaces, don't render very large inline remarkup details for unit test messages.
Feb 5 2020, 3:45 PM · Restricted Project, Haskell.org, Harbormaster, Performance
epriestley triaged T10635: Loading differential revision slow when lots of unit test messages exist as Wishlist priority.
Feb 5 2020, 3:41 PM · Restricted Project, Haskell.org, Harbormaster, Performance

Feb 4 2020

epriestley committed rPfd46c597aec5: When sorting subscriber references for display in the curtain UI, sort without… (authored by epriestley).
When sorting subscriber references for display in the curtain UI, sort without…
Feb 4 2020, 11:26 PM
epriestley closed D20969: When sorting subscriber references for display in the curtain UI, sort without case sensitivity.
Feb 4 2020, 11:26 PM
epriestley requested review of D20969: When sorting subscriber references for display in the curtain UI, sort without case sensitivity.
Feb 4 2020, 11:08 PM
epriestley committed rPfdbe9ba149b6: Improve Remarkup parsing performance for certain large input blocks (authored by epriestley).
Improve Remarkup parsing performance for certain large input blocks
Feb 4 2020, 11:07 PM