To attempt to justify micro-optimizing this loop:

See also PHI1628, which reports that a 4MB blob of test details is slow to render.

I might make some more tweaks to the UI, but this looks like it's in better shape now.

The actual replacement is Authorization: token <token>, I believe:

• Rebase and use "PHUILauncherView" in the new UIs.

I just wanted to hold it across the release cut, it's headed to master shortly.

Both of these hosts restarted cleanly.

AWS is also rebooting web007.

For posterity, here's the trace I hit:

See https://discourse.phabricator-community.org/t/herald-rule-not-adding-auditors-to-commits-following-upgrade/3505 for one bug with this.

Sounds good. It felt slightly odd to me at first, too, but I think I also got used to it.

This appears to be working. T13481 fixed one straggling issue with changes to remote handling in very old versions of Git but nothing else has cropped up.

The empty space means "this is a normal commit with no special audit state", and the column collapses if no commits have issues (see this task for an example). That seems fairly reasonable to me?

I think D20905 is as good as we're going to get.

The underlying code is still a bit shaky, so let me know if you catch other issues.

In DifferentialHunkParser->generateVisibleLinesMask(), we pass a 0-based array in and get a 1-based ("line number") array out. The loop condition stops us from reaching the last line of the 0-based array.

We have no open customer requests for this and it's very complex, so I don't currently plan to implement it.