Page MenuHomePhabricator
Feed Advanced Search

Aug 7 2019

epriestley added a revision to T13368: Correct several issues with "Move to Project..." on Workboards: D20701: Fix a warning in BoardLayoutEngine when no objects are being updated.
Aug 7 2019, 4:20 PM · Workboards
epriestley requested review of D20700: In "Move task to..." workflow, separate visible and hidden columns in the dropdown.
Aug 7 2019, 4:20 PM
epriestley added a revision to T13368: Correct several issues with "Move to Project..." on Workboards: D20700: In "Move task to..." workflow, separate visible and hidden columns in the dropdown.
Aug 7 2019, 4:18 PM · Workboards
epriestley requested review of D20699: Don't show proxy (subproject/milestone) columns as options in "Move tasks..." workflows from workboards.
Aug 7 2019, 4:12 PM
epriestley added a revision to T13368: Correct several issues with "Move to Project..." on Workboards: D20699: Don't show proxy (subproject/milestone) columns as options in "Move tasks..." workflows from workboards.
Aug 7 2019, 4:10 PM · Workboards
epriestley requested review of D20698: Correct column options presented in "Move tasks to project..." on workboards.
Aug 7 2019, 4:09 PM
epriestley added a revision to T13368: Correct several issues with "Move to Project..." on Workboards: D20698: Correct column options presented in "Move tasks to project..." on workboards.
Aug 7 2019, 4:08 PM · Workboards
epriestley triaged T13368: Correct several issues with "Move to Project..." on Workboards as Low priority.
Aug 7 2019, 4:06 PM · Workboards
epriestley added a comment to T13358: Generate PDFs for Phortune invoices.

Yeah, I'm really hoping to not require us to run an entire browser or depend on an external service to generate PDFs. The approaches I found in my research were:

Aug 7 2019, 3:36 PM · Phortune, Phacility

Aug 5 2019

epriestley added a comment to T13358: Generate PDFs for Phortune invoices.

When I apt-get install wkhtmltopdf (or something like that) on aux001, which is Ubuntu 14, I get this:

Aug 5 2019, 12:33 AM · Phortune, Phacility

Aug 2 2019

epriestley added a comment to T13358: Generate PDFs for Phortune invoices.

Just some observations after popping open PDF invoices which have shown up in my inbox recently:

Aug 2 2019, 11:18 PM · Phortune, Phacility
epriestley added a comment to T13111: Periodically run `git prune` on Git working copies.

See PHI1367, which featured a specific case where git repack unambiguously did something good instead of being magic fairy dust that we sprinkle around to ward off demons.

Aug 2 2019, 10:07 PM · Phacility, Diffusion
epriestley requested review of D20697: Refactor the Phortune account detail page into a series of smaller, more focused sections.
Aug 2 2019, 6:57 PM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20697: Refactor the Phortune account detail page into a series of smaller, more focused sections.
Aug 2 2019, 6:55 PM · Phortune, Phacility
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Aug 2 2019, 6:52 PM · Phortune, Phacility
epriestley triaged T13367: Phortune "enterprise" update errata as Low priority.
Aug 2 2019, 6:49 PM · Phortune, Phacility
epriestley added a comment to T13366: Update Phortune to work better with "enterprise" billing/accounts departments.

This is also more "while I'm here", but there's no web UI way to void an invoice right now. It would be nice to have a "Void Invoice" button for staff instead of requiring database fiddling, since this comes up occasionally.

Aug 2 2019, 6:37 PM · Phortune, Phacility
epriestley committed rP87f878ec8a77: Stop trying to CC merchants on invoices/receipts (authored by epriestley).
Stop trying to CC merchants on invoices/receipts
Aug 2 2019, 5:51 PM
epriestley closed T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22, a subtask of T13366: Update Phortune to work better with "enterprise" billing/accounts departments, as Resolved.
Aug 2 2019, 5:51 PM · Phortune, Phacility
epriestley closed T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22 as Resolved by committing rP87f878ec8a77: Stop trying to CC merchants on invoices/receipts.
Aug 2 2019, 5:51 PM · Phortune, Phacility
epriestley closed D20696: Stop trying to CC merchants on invoices/receipts.
Aug 2 2019, 5:51 PM
epriestley requested review of D20696: Stop trying to CC merchants on invoices/receipts.
Aug 2 2019, 5:50 PM
epriestley added a revision to T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22: D20696: Stop trying to CC merchants on invoices/receipts.
Aug 2 2019, 5:48 PM · Phortune, Phacility
epriestley added a comment to T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22.

Per T13366, I'm just going to get rid of this behavior for now, with the expectation that we'll soon begin generating side-channel emails for "Billing Department Email Address" under the umbrella of T8389 and could put "Merchant Emails" on a similar channel if we want.

Aug 2 2019, 5:43 PM · Phortune, Phacility
epriestley added a parent task for T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails: T13366: Update Phortune to work better with "enterprise" billing/accounts departments.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley added a parent task for T7607: Invoicing emails probably need some work: T13366: Update Phortune to work better with "enterprise" billing/accounts departments.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley added a parent task for T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22: T13366: Update Phortune to work better with "enterprise" billing/accounts departments.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley added a parent task for T13358: Generate PDFs for Phortune invoices: T13366: Update Phortune to work better with "enterprise" billing/accounts departments.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley added subtasks for T13366: Update Phortune to work better with "enterprise" billing/accounts departments: T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22, T13358: Generate PDFs for Phortune invoices, T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails, T7607: Invoicing emails probably need some work.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley triaged T13366: Update Phortune to work better with "enterprise" billing/accounts departments as Normal priority.
Aug 2 2019, 5:40 PM · Phortune, Phacility
epriestley committed rP6c4150890677: Fix an issue where lines with more than one pattern match highlighted… (authored by epriestley).
Fix an issue where lines with more than one pattern match highlighted…
Aug 2 2019, 4:45 PM
epriestley closed D20695: Fix an issue where lines with more than one pattern match highlighted improperly in Diffusion.
Aug 2 2019, 4:45 PM
epriestley requested review of D20695: Fix an issue where lines with more than one pattern match highlighted improperly in Diffusion.
Aug 2 2019, 4:43 PM
epriestley added a revision to T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases: D20695: Fix an issue where lines with more than one pattern match highlighted improperly in Diffusion.
Aug 2 2019, 4:42 PM · Diffusion, Conduit
epriestley committed rP1fe631116771: Modernize user and repository "delete" workflows and improve documentation (authored by epriestley).
Modernize user and repository "delete" workflows and improve documentation
Aug 2 2019, 4:31 PM
epriestley closed D20694: Modernize user and repository "delete" workflows and improve documentation.
Aug 2 2019, 4:31 PM
epriestley closed T8830: `bin/remove destroy` is dangerous and leaves dangling edges as Resolved by committing rP1fe631116771: Modernize user and repository "delete" workflows and improve documentation.
Aug 2 2019, 4:31 PM · Infrastructure, Restricted Project
epriestley closed T13364: Clarify that deleting repositories (and users?) from the web UI is explicitly not supported, not a resource limitation as Resolved by committing rP1fe631116771: Modernize user and repository "delete" workflows and improve documentation.
Aug 2 2019, 4:30 PM · Diffusion, Policy, Documentation
epriestley requested review of D20694: Modernize user and repository "delete" workflows and improve documentation.
Aug 2 2019, 4:25 PM
epriestley added a revision to T8830: `bin/remove destroy` is dangerous and leaves dangling edges: D20694: Modernize user and repository "delete" workflows and improve documentation.
Aug 2 2019, 4:23 PM · Infrastructure, Restricted Project
epriestley added a revision to T13364: Clarify that deleting repositories (and users?) from the web UI is explicitly not supported, not a resource limitation: D20694: Modernize user and repository "delete" workflows and improve documentation.
Aug 2 2019, 4:23 PM · Diffusion, Policy, Documentation
epriestley triaged T13365: Conduit API method "diffusion.historyquery" fatals under Git/Mercurial if passed a bad "commit" as Low priority.
Aug 2 2019, 1:58 PM · Diffusion

Aug 1 2019

epriestley triaged T13364: Clarify that deleting repositories (and users?) from the web UI is explicitly not supported, not a resource limitation as Low priority.
Aug 1 2019, 9:53 PM · Diffusion, Policy, Documentation
aklapper awarded T13255: transaction.search should accept user PHIDs as constraints a Love token.
Aug 1 2019, 8:32 PM · Conduit, Transactions
epriestley added a comment to T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases.

See also https://phabricator.wikimedia.org/T197935.

Aug 1 2019, 7:55 PM · Diffusion, Conduit
epriestley committed rP3069ef41662d: Prevent object titles in the "Object Attacher" dialog from triggering Quicksand… (authored by epriestley).
Prevent object titles in the "Object Attacher" dialog from triggering Quicksand…
Aug 1 2019, 7:25 PM
epriestley closed D20693: Prevent object titles in the "Object Attacher" dialog from triggering Quicksand "Close Dialog on Navigation" behavior.
Aug 1 2019, 7:25 PM
epriestley closed T13363: In "Edit Subtasks" dialog, clicking a task tile sometimes (?) closes the dialog as Resolved by committing rP3069ef41662d: Prevent object titles in the "Object Attacher" dialog from triggering Quicksand….
Aug 1 2019, 7:25 PM · Quicksand
epriestley requested review of D20693: Prevent object titles in the "Object Attacher" dialog from triggering Quicksand "Close Dialog on Navigation" behavior.
Aug 1 2019, 7:08 PM
epriestley added a revision to T13363: In "Edit Subtasks" dialog, clicking a task tile sometimes (?) closes the dialog: D20693: Prevent object titles in the "Object Attacher" dialog from triggering Quicksand "Close Dialog on Navigation" behavior.
Aug 1 2019, 7:06 PM · Quicksand
epriestley triaged T13363: In "Edit Subtasks" dialog, clicking a task tile sometimes (?) closes the dialog as Normal priority.
Aug 1 2019, 6:59 PM · Quicksand
20after4 awarded D20648: Update one straggling "CAN_INTERACT" check in comment removal a Love token.
Aug 1 2019, 6:56 PM
epriestley triaged T13362: Push the "Config" application UI out to full-width as Low priority.
Aug 1 2019, 6:53 PM · Design, Config
epriestley triaged T13361: Get rid of the "Actions" dropdown in Diffusion as Low priority.
Aug 1 2019, 6:10 PM · Design, Diffusion
epriestley triaged T13360: Document the pull and push logs in Diffusion as Low priority.
Aug 1 2019, 6:05 PM · Documentation, Diffusion
epriestley committed rPf5c380bfc94c: Add very basic support for generating PDF documents (authored by epriestley).
Add very basic support for generating PDF documents
Aug 1 2019, 5:50 PM
epriestley closed D20692: Add very basic support for generating PDF documents.
Aug 1 2019, 5:50 PM
epriestley triaged T13359: Phacility deploy workflow should not conflate versions-for-deployment with "latest stable release" as Low priority.
Aug 1 2019, 5:48 PM · Phacility, Ops
epriestley requested review of D20692: Add very basic support for generating PDF documents.
Aug 1 2019, 5:39 PM
epriestley added a revision to T13358: Generate PDFs for Phortune invoices: D20692: Add very basic support for generating PDF documents.
Aug 1 2019, 5:37 PM · Phortune, Phacility
epriestley added a comment to T13358: Generate PDFs for Phortune invoices.

$info_object = new PhabricatorPDFInfoObject();

Aug 1 2019, 5:20 PM · Phortune, Phacility
epriestley added a comment to T13358: Generate PDFs for Phortune invoices.

PDF files appear to consist of a series of objects that (mostly) look like this:

Aug 1 2019, 2:36 AM · Phortune, Phacility
epriestley triaged T13358: Generate PDFs for Phortune invoices as Low priority.
Aug 1 2019, 12:55 AM · Phortune, Phacility

Jul 31 2019

epriestley committed rPb81c8380fb97: Document support for "limit" in tokenizer-based Custom Fields (authored by epriestley).
Document support for "limit" in tokenizer-based Custom Fields
Jul 31 2019, 8:13 PM
epriestley closed D20691: Document support for "limit" in tokenizer-based Custom Fields.
Jul 31 2019, 8:13 PM
epriestley closed T13356: Support a "limit" configuration option for tokenizer-based custom fields as Resolved by committing rPb81c8380fb97: Document support for "limit" in tokenizer-based Custom Fields.
Jul 31 2019, 8:13 PM · Custom Fields
epriestley closed T4900: Workboards updating in real time as Resolved.

See T13357 for followup.

Jul 31 2019, 8:13 PM · Workboards (v3), User Delight, Wikimedia
epriestley triaged T13357: Improvements to Workboard Real-Time Updates as Low priority.
Jul 31 2019, 8:12 PM · Aphlict, Workboards
epriestley committed rP8e263a2f6482: Support "date" custom fields in "*.edit" endpoints (authored by epriestley).
Support "date" custom fields in "*.edit" endpoints
Jul 31 2019, 8:10 PM
epriestley closed D20690: Support "date" custom fields in "*.edit" endpoints.
Jul 31 2019, 8:10 PM
epriestley closed T13355: Support editing "date" custom fields via Conduit as Resolved by committing rP8e263a2f6482: Support "date" custom fields in "*.edit" endpoints.
Jul 31 2019, 8:10 PM · Custom Fields, Conduit
epriestley requested review of D20691: Document support for "limit" in tokenizer-based Custom Fields.
Jul 31 2019, 8:03 PM
epriestley added a revision to T13356: Support a "limit" configuration option for tokenizer-based custom fields: D20691: Document support for "limit" in tokenizer-based Custom Fields.
Jul 31 2019, 8:02 PM · Custom Fields
epriestley added a comment to T13356: Support a "limit" configuration option for tokenizer-based custom fields.

This is likely straightforward.

Jul 31 2019, 7:55 PM · Custom Fields
epriestley triaged T13356: Support a "limit" configuration option for tokenizer-based custom fields as Low priority.
Jul 31 2019, 7:51 PM · Custom Fields
epriestley requested review of D20690: Support "date" custom fields in "*.edit" endpoints.
Jul 31 2019, 7:50 PM
epriestley committed rP8e1600ba83fd: (stable) Don't try to emit project board update events if there are no projects… (authored by epriestley).
(stable) Don't try to emit project board update events if there are no projects…
Jul 31 2019, 7:49 PM
epriestley committed rP76cd181bf379: Don't try to emit project board update events if there are no projects to update (authored by epriestley).
Don't try to emit project board update events if there are no projects to update
Jul 31 2019, 7:48 PM
epriestley closed D20689: Don't try to emit project board update events if there are no projects to update.
Jul 31 2019, 7:48 PM
epriestley added a revision to T13355: Support editing "date" custom fields via Conduit: D20690: Support "date" custom fields in "*.edit" endpoints.
Jul 31 2019, 7:48 PM · Custom Fields, Conduit
epriestley requested review of D20689: Don't try to emit project board update events if there are no projects to update.
Jul 31 2019, 7:43 PM
epriestley added a revision to T4900: Workboards updating in real time: D20689: Don't try to emit project board update events if there are no projects to update.
Jul 31 2019, 7:42 PM · Workboards (v3), User Delight, Wikimedia
epriestley triaged T13355: Support editing "date" custom fields via Conduit as Low priority.
Jul 31 2019, 7:38 PM · Custom Fields, Conduit
epriestley added a comment to T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes.

See also PHI1358, which is an actual concrete request for sensible relabeling of "Description" in a subtype.

Jul 31 2019, 7:32 PM · Custom Fields, Maniphest
epriestley committed rPHU8df85007f38e: (stable) Promote 2019 Week 31 (authored by epriestley).
(stable) Promote 2019 Week 31
Jul 31 2019, 7:02 PM
epriestley edited the content of Changelog.
Jul 31 2019, 7:02 PM
epriestley created an object: 2019 Week 31 (July).
Jul 31 2019, 7:01 PM
epriestley committed rP6f6ae61f00a8: (stable) Promote 2019 Week 31 (authored by epriestley).
(stable) Promote 2019 Week 31
Jul 31 2019, 7:00 PM
Krinkle awarded D20688: When users visit a Phame post URI with an old blog ID, canonicalize the URI instead of 404'ing a Orange Medal token.
Jul 31 2019, 6:58 PM
epriestley committed rP47d497aa6045: When users visit a Phame post URI with an old blog ID, canonicalize the URI… (authored by epriestley).
When users visit a Phame post URI with an old blog ID, canonicalize the URI…
Jul 31 2019, 6:44 PM
epriestley closed D20688: When users visit a Phame post URI with an old blog ID, canonicalize the URI instead of 404'ing.
Jul 31 2019, 6:44 PM
epriestley closed T13353: When Phame posts move between blogs, the old URIs 404 instead of canonicalizing as Resolved by committing rP47d497aa6045: When users visit a Phame post URI with an old blog ID, canonicalize the URI….
Jul 31 2019, 6:44 PM · Phame
epriestley closed T13354: Test: Workboards Real-Time Updates!? as Invalid.
Jul 31 2019, 6:43 PM · Workboards
epriestley reopened T13354: Test: Workboards Real-Time Updates!? as "Open".
Jul 31 2019, 6:43 PM · Workboards
epriestley closed T13354: Test: Workboards Real-Time Updates!? as Invalid.
Jul 31 2019, 6:42 PM · Workboards
epriestley renamed T13354: Test: Workboards Real-Time Updates!? from Test: Workboards Real-Time Updates! to Test: Workboards Real-Time Updates!?.
Jul 31 2019, 6:42 PM · Workboards
epriestley moved T13354: Test: Workboards Real-Time Updates!? from Future Work to Backlog on the Workboards board.
Jul 31 2019, 6:42 PM · Workboards
epriestley renamed T13354: Test: Workboards Real-Time Updates!? from Test: Workboards Real-Time Updates to Test: Workboards Real-Time Updates!.
Jul 31 2019, 6:42 PM · Workboards
epriestley created T13354: Test: Workboards Real-Time Updates!?.
Jul 31 2019, 6:42 PM · Workboards
epriestley requested review of D20688: When users visit a Phame post URI with an old blog ID, canonicalize the URI instead of 404'ing.
Jul 31 2019, 6:41 PM