• Fix "users" typo.

This and two other followups also all have some flavor of "convert tabs to spaces" or vice versa. I suspect we can have fewer copies of this code eventually, but since it's like 10 lines of code I'm not worrying about it too much for now.

In D20193#253040, @epriestley wrote:

I suppose we could resolve most of these issues simply and very surgically by putting <span></span> tags around exactly the replaced text, e.g. helic<span data-copy-text="🐑">o</span>pter.

I suppose we could resolve most of these issues simply and very surgically by putting <span></span> tags around exactly the replaced text, e.g. helic<span data-copy-text="🐑">o</span>pter.

Objectively great diff, but not planning to move forward with it for now.

I'm probably not going to fix this since it's pretty minor and moderately complicated to fix, but this interaction is not ideal:

This is the documentation:

In Firefox, selecting a range which crosses an inline comment currently drops the line after the comment. Here, return arra does not copy:

(The actual rendering of that new diff is still a little bit sketchy since some of the pixel alignment isn't quite right and I want to tweak the colors, but all the elements are in the right places.)

Builds depend on D20182.

Tests depend on D20182.

Note that T6791 has an example of a change where removing the whitespace options is going to cause a behavioral regression. Here's an example:

This report is generally unclear / hard to reproduce / unusual so I'm not sure how to move forward. It's likely mooted by D20181.

See PHI701. This behavior is not ideal:

I'm going to start here, and implement this proposed rule, which I think is the simpler and more intuitive of the proposals:

It sounds like real-time updates will more-or-less moot this.

(See T13251 for followup.)

I believe all (?) of these are now fixed in both master and stable.