This reproduces for me as described.

See also T11401, although this started life as a Pholio task and that's now a code-specific UI task so I don't know if they're actually the same.

(T11357 is a companion issue for Files.)

Excellent! Thanks for this so very detailed answer. I will try the way of the phid.lookup to work this issue around in the while.

Thanks for the extra context!

reopening due to additional details

Let me add some more detailed and specific information. We wrote (and released) https://github.com/Gandi/hubot-phabs

Please read Contributing Feature Requests carefully before filing feature requests. In particular, we need you to describe a root problem (see Describing Root Problems).

Hello! What you think about make correct behavior while clicking on inline comment thumbnails? Its hard work? I can try to contribute it?

Merging this over and re-opening.

Some earlier discussion in T3612.

oh man, I even filed it.

Any particular system this doesn't work on?

News to me that we don't support it.

I believe this is now fixed and all the business stuff is wrapped up on our side. If anyone runs into issues, feel free to file a followup describing what you're hitting.

After D16088:

We haven't seen other requests for this and it's consistent with the similar behavior in Differential.

This should also fix the mobile workflow stragglers from T2644.

My plan is to put an on-hover (always available on mobile) edit icon on top of the thumbs on the edit UI, similar to how the interaction works on workboard cards:

Great, thanks! (And with clarity I meant instant visual clarity for people who haven't been involved in designing them)

I went with checkered for now.

@chad Do I understand you correctly, there would be just outright white background for transparent areas with your patch?
The checker background gives clarity as we have to make sure that many of our interface elements shown in Pholio mocks are working on dark and white backgrounds.

I'm more inclined to remove the checkerboard outright from view. The main concern here is if it's confusing on the edit page, then it's also confusing on the thumb and embed views. The only place we use checkerboard is on the full view page itself.

(See also T2636 for previous discussion).

Pholio itself is getting fairly old, not sure when it'll get re-visited, maybe 6-12 months?

This is consistent with inline comments across all of Phabricator.

We could also maybe do something ridiculous like assume it's @2x if both dimensions are even, but M1461 has a 2X image with an odd height (1717px!) so that probably won't get us very far ignoring all the false positives for 400x300px images and such.

I think this is reasonable to build as:

It looks like Invision makes you append @2x to the filename to indicate that the files should be displayed at 50% to low dpi displays. So, file_name@2x.png would trigger appropriate CSS to handle layout.

The benefit is merely the lack of requirement for people to zoom out from an image in order to see it at the correct scale. I upload entire UIs to Pholio to explain flows and changes. If the UI is displayed at twice the size it will eventually be, it's rather difficult to get a true feel for how it looks. Would be great for people to be able to see my work in the intended zoom.

Oops, sorry, I mis-remembered that other task.

That one might be better to merge here, since it's probably impossible (at least, in the general case) but this talks about some things we can do in the general case.

I don't think we can detect this automatically -- a, say, web-ready PNG from Photoshop generally won't have DPI information, as far as I know.

That would likely work fine as long as you can see all of the comments together (like you can if you go to a diff line and view all comments there).

In general we'll likely show the full conversation about an inline point on Pholio on the dialog that you can pop up, sort of like a thread on a diff line.