Page MenuHomePhabricator
Feed Advanced Search

Mar 7 2018

epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19184: Treat Owners paths like "/src/backend" and "/src/backend/" identically.
Mar 7 2018, 4:14 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19183: Allow owners paths to be arbitrarily long and add storage for display paths.
Mar 7 2018, 3:54 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19182: Add a unique key to OwnersPath on "<packageID, repositoryPHID, pathIndex>".
Mar 7 2018, 3:47 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19181: Add and populate a `pathIndex` column for OwnersPath.
Mar 7 2018, 3:37 AM · Owners, Bug Report
epriestley added a comment to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash.

Probably better is to add pathIndex

Mar 7 2018, 3:25 AM · Owners, Bug Report
epriestley added a revision to T12787: Creating a subtask 'reopens' the new task: D19179: Hide "abraham landed Dxyz irresponsibly" stories from feed.
Mar 7 2018, 1:41 AM · Feed, Bug Report

Mar 5 2018

epriestley moved T10608: Arc diff failing to generate diff with svn 1.9.3 from Backlog to Diff Parsing on the Arcanist board.
Mar 5 2018, 2:19 PM · Arcanist, Bug Report
epriestley moved T12382: ArcanistJSONLintRenderer fails to produce JSON output with non-UTF-8 encodings from Backlog to arc patch on the Arcanist board.
Mar 5 2018, 2:17 PM · Lint, Arcanist, Bug Report
epriestley moved T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs from Backlog to Diff Parsing on the Arcanist board.
Mar 5 2018, 2:16 PM · Arcanist, Bug Report
epriestley moved T12785: Arc unit command fails with PHPUnit 6 from Backlog to Unit/Lint Bindings on the Arcanist board.
Mar 5 2018, 2:16 PM · Arcanist, Bug Report
epriestley moved T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit from Backlog to arc patch on the Arcanist board.
Mar 5 2018, 2:15 PM · Arcanist, Mercurial, Bug Report

Feb 26 2018

epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

See T13092; tangentially, it might be nice to render these stories more explicitly as "X added Y, removed Z (because Z is a subproject of Y, and objects may not be tagged with multiple mutual ancestors/descendant projects)", if some sufficiently terse phrasing can be found.

Feb 26 2018, 6:17 PM · Bug Report

Feb 21 2018

epriestley moved T10635: Loading differential revision slow when lots of unit test messages exist from Backlog to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:40 PM · Restricted Project, Haskell.org, Harbormaster, Performance

Feb 16 2018

epriestley added a comment to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax.

D19111 doesn't fix this in the general case, but should produce the desired behavior for most inputs such that the input is in the form [x](y) and y is the URI of a Wikipedia article.

Feb 16 2018, 7:07 PM · Remarkup, Bug Report
epriestley added a comment to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax.

The intent isn't unambiguous in the general case, consider: Blah blah (see also [x](y)).

Feb 16 2018, 7:06 PM · Remarkup, Bug Report
epriestley added a revision to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax: D19111: Tweak handling of "[[ / ]]" and "[x](y)" where "y" has parentheses.
Feb 16 2018, 7:05 PM · Remarkup, Bug Report
epriestley merged T5333: Linking to a wiki URL with % encoding in the URL breaks the link into T12344: Relative links to Phriction pages misinterprets URL-encoded characters.
Feb 16 2018, 6:28 PM · Phriction, Remarkup, Bug Report
cspeckmim added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Ah thanks!

Feb 16 2018, 6:23 PM · Phriction, Remarkup, Bug Report
epriestley added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

The non-bold ones also open in a new tab.

Feb 16 2018, 6:20 PM · Phriction, Remarkup, Bug Report
epriestley added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Oh! Yes. Sort of.

Feb 16 2018, 6:17 PM · Phriction, Remarkup, Bug Report
cspeckmim added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Just curious, but is the bold effect intentional in the "No Encoding Relative" scenario?

Feb 16 2018, 5:57 PM · Phriction, Remarkup, Bug Report
epriestley closed T12344: Relative links to Phriction pages misinterprets URL-encoded characters as Resolved by committing rPb8bb4d3ad590: Accept either "[[ %24doge ]]" or "[[ $doge ]]" as references to the "/w/$doge/"….
Feb 16 2018, 5:55 PM · Phriction, Remarkup, Bug Report
epriestley closed T10969: Incorrect Phriction link in email as Resolved by committing rPbfdc9411f705: Provide context objects for remarkup mail rendering, fixing Phriction relative….
Feb 16 2018, 5:55 PM · Phriction, Bug Report
epriestley added a revision to T12344: Relative links to Phriction pages misinterprets URL-encoded characters: D19106: Accept either "[[ %24doge ]]" or "[[ $doge ]]" as references to the "/w/$doge/" Phriction document.
Feb 16 2018, 2:44 PM · Phriction, Remarkup, Bug Report
epriestley added a revision to T10969: Incorrect Phriction link in email: D19105: Provide context objects for remarkup mail rendering, fixing Phriction relative URIs in initial email.
Feb 16 2018, 1:18 PM · Phriction, Bug Report

Feb 14 2018

epriestley moved T12344: Relative links to Phriction pages misinterprets URL-encoded characters from Backlog to Next on the Phriction board.
Feb 14 2018, 2:43 PM · Phriction, Remarkup, Bug Report
epriestley moved T10969: Incorrect Phriction link in email from Backlog to Next on the Phriction board.
Feb 14 2018, 2:33 PM · Phriction, Bug Report
epriestley moved T12793: Unable to move Phriction documents from Backlog to Next on the Phriction board.
Feb 14 2018, 2:31 PM · Customer Impact, Bug Report, Phriction

Feb 13 2018

epriestley closed T10559: Lease Working Copy Hangs on lease failure, but should fail as Resolved.

After changes T13073, I am no longer able to reproduce this. That task has made some improvements and may have fixed whatever happened here.

Feb 13 2018, 4:03 PM · Drydock, Bug Report

Feb 11 2018

epriestley closed T12714: `differential.createcomment` can race automatic revision closure as Resolved by committing rP653bc0fa019f: Read lock all transaction edits.
Feb 11 2018, 4:07 AM · Transactions, Bug Report, Restricted Project
epriestley added a revision to T12714: `differential.createcomment` can race automatic revision closure: D19059: Read lock all transaction edits.
Feb 11 2018, 2:05 AM · Transactions, Bug Report, Restricted Project
epriestley added a comment to T10746: Aborted build in Harbormaster still shows as building in Diffusion.

It isn't currently retroactive: the fix is in transition logic and the transition just didn't trigger before.

Feb 11 2018, 12:41 AM · Restricted Project, Harbormaster, Bug Report
swisspol added a comment to T10746: Aborted build in Harbormaster still shows as building in Diffusion.

Is this retroactive to builds in this half state prior to this commit and
deploy?

Feb 11 2018, 12:17 AM · Restricted Project, Harbormaster, Bug Report
epriestley closed T10746: Aborted build in Harbormaster still shows as building in Diffusion as Resolved by committing rPa2d02aed2211: When a build is aborted, fail the buildable.
Feb 11 2018, 12:08 AM · Restricted Project, Harbormaster, Bug Report
epriestley closed T11154: Build results don't always get conferred to their buildable as Resolved by committing rPa2d02aed2211: When a build is aborted, fail the buildable.
Feb 11 2018, 12:08 AM · Restricted Project, Harbormaster, Bug Report

Feb 10 2018

epriestley added a revision to T11154: Build results don't always get conferred to their buildable: D19055: When a build is aborted, fail the buildable.
Feb 10 2018, 7:38 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a revision to T10746: Aborted build in Harbormaster still shows as building in Diffusion: D19055: When a build is aborted, fail the buildable.
Feb 10 2018, 7:38 PM · Restricted Project, Harbormaster, Bug Report

Feb 8 2018

epriestley closed T11389: Object links merged in plain text email as Resolved by committing rP0402a79e0e57: Render object remarkup references in a text context as "Dxxx <uri>".
Feb 8 2018, 5:52 PM · Remarkup, Bug Report, Mail
epriestley added a comment to T11389: Object links merged in plain text email.

D19032 now renders D123 in text contexts (plaintext email) as D123 <https://dev.tyrellcorp.com/D123> instead of https://dev.tyrellcorp.com/D123.

Feb 8 2018, 5:51 PM · Remarkup, Bug Report, Mail
epriestley added a revision to T11389: Object links merged in plain text email: D19032: Render object remarkup references in a text context as "Dxxx <uri>".
Feb 8 2018, 5:50 PM · Remarkup, Bug Report, Mail
epriestley moved T11389: Object links merged in plain text email from Backlog to Stamps/Failover on the Mail board.
Feb 8 2018, 5:50 PM · Remarkup, Bug Report, Mail
epriestley closed T10189: Differential email headers seem to be missing as Resolved by committing rP6186f0aa91b6: Briefly document mail stamps and remove obsolete header documentation.
Feb 8 2018, 5:31 PM · Differential, Mail, Bug Report
epriestley added a comment to T10189: Differential email headers seem to be missing.

D19030 marks this as fixed: it removes this documentation.

Feb 8 2018, 5:23 PM · Differential, Mail, Bug Report
epriestley moved T10189: Differential email headers seem to be missing from v3 to Stamps/Failover on the Mail board.
Feb 8 2018, 5:21 PM · Differential, Mail, Bug Report
epriestley added a revision to T10189: Differential email headers seem to be missing: D19030: Briefly document mail stamps and remove obsolete header documentation.
Feb 8 2018, 5:21 PM · Differential, Mail, Bug Report
epriestley closed T12689: Mail is still received after resigning from a revision as Resolved by committing rP1cd3a593784a: When users resign from revisions, stop expanding projects/packages to include….
Feb 8 2018, 2:29 PM · Mail, Differential, Bug Report
epriestley closed T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place as Resolved by committing rPdbe479f0d9de: Don't send error/exception mail to unverified addresses.
Feb 8 2018, 2:26 PM · Mail, Bug Report

Feb 7 2018

epriestley added a revision to T12644: Emoji autocomplete ordering doesn't follow unicode standards: D19023: Improve handling of skin tone variant emoji.
Feb 7 2018, 6:53 PM · Remarkup, Bug Report
epriestley added a revision to T12689: Mail is still received after resigning from a revision: D19021: When users resign from revisions, stop expanding projects/packages to include them.
Feb 7 2018, 4:08 PM · Mail, Differential, Bug Report
epriestley added a revision to T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place: D19018: Don't send error/exception mail to unverified addresses.
Feb 7 2018, 1:18 PM · Mail, Bug Report
tolbrino added a comment to T10725: Can't access binary files of differential revision.

I've been running into the same issue for a while now. Using the Default Policy set to Subscribers for Files works well when adding files to Phriction pages and Maniphest tickets. However, when adding binary files as part of a Diff the creator of that Diff needs to change each files permissions by hand before a reviewer can download the Diff. Moreover, this needs to be repeated for every new version of that Diff.

Feb 7 2018, 8:58 AM · Restricted Project, Differential, Bug Report
epriestley added a revision to T12907: Unable to download large files through alternative file domain: D19011: Provide a streaming HTTP response parser.
Feb 7 2018, 12:14 AM · Bug Report

Feb 4 2018

epriestley added a comment to T12807: Diffusion's "Grep File Content" doesn't work with UTF characters.

See T13060 and T7339 for followups and additional discussion.

Feb 4 2018, 3:01 PM · Diffusion, Bug Report

Feb 2 2018

ofbeaton added a comment to T12359: Registration does not accept valid email addresses.

We have also found legitimate users who have valid email addresses (Irish users) that are not accepted.

Feb 2 2018, 8:35 PM · Bug Report
ofbeaton added a comment to T12718: Local email validation with apostrophe.

For those visiting from the future via search, I have decided to publish an unofficial bug patch in a github repo, as it breaks once in awhile due to upstream changes.

Feb 2 2018, 8:31 PM · Bug Report
cmmata added a comment to T12785: Arc unit command fails with PHPUnit 6.

Thanks @mcorteel, I'll take a look.

Feb 2 2018, 5:01 PM · Arcanist, Bug Report

Feb 1 2018

epriestley closed T11138: mail is not delivered if metamta.placeholder-to-recipient is null as Invalid.

This report doesn't include working reproduction instructions so we can't move forward.

Feb 1 2018, 10:58 PM · Mail, Bug Report
epriestley closed T12630: Phabricator fails with a fatal PHP error if it receives a mail with no plain text part as Resolved.

I can't reproduce this; it may have been fixed by D18776 + D18778.

Feb 1 2018, 10:54 PM · Mail, Bug Report
mcorteel added a comment to T12785: Arc unit command fails with PHPUnit 6.

@cmmata here is my diff. It can probably be improved, but it works for me:

1diff --git a/src/unit/engine/PhpunitTestEngine.php b/src/unit/engine/PhpunitTestEngine.php
2index 8206b787..ef01fda4 100644
3--- a/src/unit/engine/PhpunitTestEngine.php
4+++ b/src/unit/engine/PhpunitTestEngine.php
5@@ -52,7 +52,7 @@ final class PhpunitTestEngine extends ArcanistUnitTestEngine {
6 if (!Filesystem::pathExists($test_path)) {
7 continue;
8 }
9- $json_tmp = new TempFile();
10+ $xml_tmp = new TempFile();
11 $clover_tmp = null;
12 $clover = null;
13 if ($this->getEnableCoverage() !== false) {
14@@ -64,10 +64,10 @@ final class PhpunitTestEngine extends ArcanistUnitTestEngine {
15
16 $stderr = '-d display_errors=stderr';
17
18- $futures[$test_path] = new ExecFuture('%C %C %C --log-json %s %C %s',
19- $this->phpunitBinary, $config, $stderr, $json_tmp, $clover, $test_path);
20+ $futures[$test_path] = new ExecFuture('%C %C %C --log-junit %s %C %s',
21+ $this->phpunitBinary, $config, $stderr, $xml_tmp, $clover, $test_path);
22 $tmpfiles[$test_path] = array(
23- 'json' => $json_tmp,
24+ 'xml' => $xml_tmp,
25 'clover' => $clover_tmp,
26 );
27 }
28@@ -81,7 +81,7 @@ final class PhpunitTestEngine extends ArcanistUnitTestEngine {
29
30 $results[] = $this->parseTestResults(
31 $test,
32- $tmpfiles[$test]['json'],
33+ $tmpfiles[$test]['xml'],
34 $tmpfiles[$test]['clover'],
35 $stderr);
36 }
37@@ -90,17 +90,17 @@ final class PhpunitTestEngine extends ArcanistUnitTestEngine {
38 }
39
40 /**
41- * Parse test results from phpunit json report.
42+ * Parse test results from phpunit XML report.
43 *
44 * @param string $path Path to test
45- * @param string $json_tmp Path to phpunit json report
46+ * @param string $xml_tmp Path to phpunit XML report
47 * @param string $clover_tmp Path to phpunit clover report
48 * @param string $stderr Data written to stderr
49 *
50 * @return array
51 */
52- private function parseTestResults($path, $json_tmp, $clover_tmp, $stderr) {
53- $test_results = Filesystem::readFile($json_tmp);
54+ private function parseTestResults($path, $xml_tmp, $clover_tmp, $stderr) {
55+ $test_results = Filesystem::readFile($xml_tmp);
56 return id(new ArcanistPhpunitTestResultParser())
57 ->setEnableCoverage($this->getEnableCoverage())
58 ->setProjectRoot($this->projectRoot)
59diff --git a/src/unit/parser/ArcanistPhpunitTestResultParser.php b/src/unit/parser/ArcanistPhpunitTestResultParser.php
60index 5ccff970..3d7fcd77 100644
61--- a/src/unit/parser/ArcanistPhpunitTestResultParser.php
62+++ b/src/unit/parser/ArcanistPhpunitTestResultParser.php
63@@ -9,10 +9,10 @@
64 final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
65
66 /**
67- * Parse test results from phpunit json report
68+ * Parse test results from phpunit XML report
69 *
70 * @param string $path Path to test
71- * @param string $test_results String containing phpunit json report
72+ * @param string $test_results String containing phpunit XML report
73 *
74 * @return array
75 */
76@@ -25,7 +25,7 @@ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
77 return array($result);
78 }
79
80- $report = $this->getJsonReport($test_results);
81+ $report = simplexml_load_string($test_results);
82
83 // coverage is for all testcases in the executed $path
84 $coverage = array();
85@@ -36,56 +36,36 @@ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
86 $last_test_finished = true;
87
88 $results = array();
89- foreach ($report as $event) {
90- switch (idx($event, 'event')) {
91- case 'test':
92- break;
93- case 'testStart':
94- $last_test_finished = false;
95- // fall through
96- default:
97- continue 2; // switch + loop
98- }
99-
100+ foreach ($report->testsuite as $test_suite) {
101 $status = ArcanistUnitTestResult::RESULT_PASS;
102 $user_data = '';
103
104- if ('fail' == idx($event, 'status')) {
105+ if ((int)$test_suite['failures'] > 0) {
106 $status = ArcanistUnitTestResult::RESULT_FAIL;
107- $user_data .= idx($event, 'message')."\n";
108- foreach (idx($event, 'trace') as $trace) {
109- $user_data .= sprintf(
110- "\n%s:%s",
111- idx($trace, 'file'),
112- idx($trace, 'line'));
113+ foreach ($test_suite->testcase as $test_case) {
114+ foreach ($test_case->failure as $failure) {
115+ $user_data .= sprintf(
116+ "\n%s",
117+ (string)$failure);
118+ }
119 }
120- } else if ('error' == idx($event, 'status')) {
121- if (strpos(idx($event, 'message'), 'Skipped Test') !== false) {
122- $status = ArcanistUnitTestResult::RESULT_SKIP;
123- $user_data .= idx($event, 'message');
124- } else if (strpos(
125- idx($event, 'message'),
126- 'Incomplete Test') !== false) {
127- $status = ArcanistUnitTestResult::RESULT_SKIP;
128- $user_data .= idx($event, 'message');
129- } else {
130- $status = ArcanistUnitTestResult::RESULT_BROKEN;
131- $user_data .= idx($event, 'message');
132- foreach (idx($event, 'trace') as $trace) {
133- $user_data .= sprintf(
134- "\n%s:%s",
135- idx($trace, 'file'),
136- idx($trace, 'line'));
137+ } else if ($test_suite['errors'] > 0) {
138+ $status = ArcanistUnitTestResult::RESULT_BROKEN;
139+ foreach ($test_suite->testcase as $test_case) {
140+ foreach ($test_case->error as $error) {
141+ $user_data .= sprintf(
142+ "\n%s",
143+ (string)$error);
144 }
145 }
146 }
147
148- $name = preg_replace('/ \(.*\)/s', '', idx($event, 'test'));
149+ $name = preg_replace('/ \(.*\)/s', '', $test_suite['name']);
150
151 $result = new ArcanistUnitTestResult();
152 $result->setName($name);
153 $result->setResult($status);
154- $result->setDuration(idx($event, 'time'));
155+ $result->setDuration((float)$test_suite['time']);
156 $result->setCoverage($coverage);
157 $result->setUserData($user_data);
158
159@@ -95,7 +75,7 @@ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
160
161 if (!$last_test_finished) {
162 $results[] = id(new ArcanistUnitTestResult())
163- ->setName(idx($event, 'test')) // use last event
164+ ->setName($test_suite['name']) // use last event
165 ->setUserData($this->stderr)
166 ->setResult(ArcanistUnitTestResult::RESULT_BROKEN);
167 }
168@@ -161,28 +141,4 @@ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
169 return $reports;
170 }
171
172- /**
173- * We need this non-sense to make json generated by phpunit
174- * valid.
175- *
176- * @param string $json String containing JSON report
177- * @return array JSON decoded array
178- */
179- private function getJsonReport($json) {
180-
181- if (empty($json)) {
182- throw new Exception(
183- pht(
184- 'JSON report file is empty, it probably means that phpunit '.
185- 'failed to run tests. Try running %s with %s option and then run '.
186- 'generated phpunit command yourself, you might get the answer.',
187- 'arc unit',
188- '--trace'));
189- }
190-
191- $json = preg_replace('/}{\s*"/', '},{"', $json);
192- $json = '['.$json.']';
193- return phutil_json_decode($json);
194- }
195-
196 }

Feb 1 2018, 11:00 AM · Arcanist, Bug Report
cmmata added a comment to T12785: Arc unit command fails with PHPUnit 6.

@mcorteel I have the same problem, arc unit only works with phpunit 5.7. If I use 6.5, it fails. Do you have that patch anywhere with public access so we can use it while it's not published?

Feb 1 2018, 9:47 AM · Arcanist, Bug Report

Jan 27 2018

epriestley moved T11138: mail is not delivered if metamta.placeholder-to-recipient is null from v3 to Stamps/Failover on the Mail board.
Jan 27 2018, 9:58 PM · Mail, Bug Report
epriestley closed T12033: Large diffs can still repeatedly fail to insert as Resolved.

This is resolved as far as I'm aware. See also T11767 (improvements to these limits), PHI125 (similar issue with non-UTF8 attachments failing to insert) and T13053 (planning).

Jan 27 2018, 9:55 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley moved T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place from Backlog to Stamps/Failover on the Mail board.
Jan 27 2018, 9:54 PM · Mail, Bug Report
epriestley moved T12630: Phabricator fails with a fatal PHP error if it receives a mail with no plain text part from Backlog to Stamps/Failover on the Mail board.
Jan 27 2018, 9:54 PM · Mail, Bug Report
epriestley moved T12689: Mail is still received after resigning from a revision from Backlog to Stamps/Failover on the Mail board.
Jan 27 2018, 9:54 PM · Mail, Differential, Bug Report

Jan 26 2018

epriestley closed T11112: Herald allows setting multiple values in fields that should only accept one value as Resolved by committing rP4b5a78e3435b: Add "you can only enter one value" UI limits to Herald "set status" and "set….
Jan 26 2018, 9:23 PM · Herald, Bug Report
epriestley moved T11112: Herald allows setting multiple values in fields that should only accept one value from Backlog to Next on the Herald board.
Jan 26 2018, 5:53 PM · Herald, Bug Report
epriestley closed T11349: Herald has the wrong list of "Author's Projects" as Invalid.

This is quite old and I have no idea how to reproduce it and thus no idea how to fix it. Locally, I tried a few things and wasn't able to identify a case where the Herald field value differed from my actual project list.

Jan 26 2018, 5:49 PM · Restricted Project, Herald, Bug Report
epriestley added a revision to T11112: Herald allows setting multiple values in fields that should only accept one value: D18943: Add "you can only enter one value" UI limits to Herald "set status" and "set priority" actions.
Jan 26 2018, 5:42 PM · Herald, Bug Report

Jan 24 2018

epriestley added a parent task for T11135: Ctrl-click symbol lookup language in Diffusion ignores `syntax.filemap`: T13047: Plans: Symbol Indexes.
Jan 24 2018, 4:24 PM · Symbols, Bug Report

Jan 21 2018

epriestley closed T11827: ssh-auth hangs on FreeBSD as Resolved.

From https://bugzilla.mindrot.org/show_bug.cgi?id=2496, this is apparently fixed in the OpenSSH upstream (https://github.com/openssh/openssh-portable/commit/ddd3d34e5c7979ca6f4a3a98a7d219a4ed3d98c2). Since this is a bug in OpenSSH, an upstream fix is available, and the impact is fairly narrow, I don't plan to work around it in Phabricator.

Jan 21 2018, 2:58 AM · Diffusion, Bug Report

Jan 19 2018

epriestley closed T12415: Comment field action in batch action doesn't render correctly as Resolved by committing rP687fada5af43: Restore bulk edit support for remarkup fields (description, add comment).
Jan 19 2018, 8:45 PM · Bug Report
epriestley added a comment to T12415: Comment field action in batch action doesn't render correctly.

I've marked D18867 as fixing this. It isn't a perfect fix, but it's closer to the realm of reasonable (you have a sensible amount of area to work with and a readable font):

Jan 19 2018, 2:38 PM · Bug Report
epriestley added a revision to T12415: Comment field action in batch action doesn't render correctly: D18867: Restore bulk edit support for remarkup fields (description, add comment).
Jan 19 2018, 2:32 PM · Bug Report

Jan 5 2018

epriestley moved T12453: Using `arc patch` will leave behind a bookmark when answering 'No' in attempt to apply to current state in Mercurial repository from Backlog to arc patch on the Mercurial board.
Jan 5 2018, 6:56 PM · Arcanist, Mercurial, Bug Report
epriestley moved T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit from Backlog to arc patch on the Mercurial board.
Jan 5 2018, 6:56 PM · Arcanist, Mercurial, Bug Report

Jan 4 2018

epriestley moved T10900: Repository content search with `hg grep` returns matches found in old versions of files from Backlog to Far Future on the Mercurial board.
Jan 4 2018, 7:40 PM · Mercurial, Diffusion
epriestley added a comment to T10900: Repository content search with `hg grep` returns matches found in old versions of files.

Actually, this is less crazy than I thought.

Jan 4 2018, 7:39 PM · Mercurial, Diffusion
epriestley added a comment to T10900: Repository content search with `hg grep` returns matches found in old versions of files.

This appears to date back to the introduction of the feature in D5738, where I suggested we use ancestors() without a legitimate reason (or maybe very old Mercurial had weird behavior).

Jan 4 2018, 7:26 PM · Mercurial, Diffusion

Dec 26 2017

epriestley closed T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to as Resolved by committing rPead5f4fd9c03: Add an "Accepting reviewers" Herald field for commits.
Dec 26 2017, 11:59 PM · Differential, Herald, Bug Report

Dec 22 2017

epriestley added a revision to T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to: D18839: Add an "Accepting reviewers" Herald field for commits.
Dec 22 2017, 6:19 PM · Differential, Herald, Bug Report

Dec 13 2017

epriestley archived Bug Report.
Dec 13 2017, 1:14 PM

Dec 12 2017

epriestley merged task T9915: Audit Changes TOC fail redirecting to right subdirectory when clicking on fa-folder-open icon and produces an unhandled exception into T13030: Accessing a submodule path directly in Diffusion has less than optimal UX.
Dec 12 2017, 8:54 PM · Restricted Project, Diffusion, Bug Report

Dec 9 2017

aklapper added a comment to T10221: upgrading to ubuntu 15.10 breaks google authentication.

Support for Ubuntu 15.10 ended on 2016-07-28.
Did this problem also happen with any later, still supported Ubuntu version (like 16.04) or can this task be closed as obsolete?

Dec 9 2017, 7:48 PM · Auth, Bug Report

Nov 30 2017

epriestley closed T10233: arc error message unclear for accepted revision in "plan change" state as Resolved by committing rARCf4c80a114d36: Make "arc land" prompt on "Changes Planned" revisions more explicit.
Nov 30 2017, 9:51 PM · Restricted Project, Bug Report
epriestley closed T12592: User awaiting approval has no image as Resolved.

This should be fixed by changes in T13024.

Nov 30 2017, 9:43 PM · Bug Report, Auth
epriestley closed T12657: Add Authentication Factor fails silently for users without a verified email address as Resolved.

This should be fixed by changes in T13024.

Nov 30 2017, 9:43 PM · Auth, Bug Report
epriestley merged T12570: Installs without `gd` are unable to reach the setup warning telling them to install `gd` into T10405: Phabricator should generally work properly even if "gd" is not installed.
Nov 30 2017, 9:42 PM · Setup, Restricted Project
epriestley merged task T12570: Installs without `gd` are unable to reach the setup warning telling them to install `gd` into T10405: Phabricator should generally work properly even if "gd" is not installed.
Nov 30 2017, 9:42 PM · Setup, Bug Report
epriestley added a revision to T10233: arc error message unclear for accepted revision in "plan change" state: D18808: Add an explicit warning in the Differential transaction log when users skip review.
Nov 30 2017, 4:26 PM · Restricted Project, Bug Report
epriestley added a revision to T10233: arc error message unclear for accepted revision in "plan change" state: D18807: Make "arc land" prompt on "Changes Planned" revisions more explicit.
Nov 30 2017, 3:53 PM · Restricted Project, Bug Report

Nov 29 2017

epriestley added a comment to T10233: arc error message unclear for accepted revision in "plan change" state.

In PHI231, a more experienced user went through this workflow:

Nov 29 2017, 7:24 PM · Restricted Project, Bug Report

Nov 28 2017

lpriestley added a comment to T12544: Cannot add invitees to all future instances of a recurring event.

@epriestley what do you think of creating another column in the calendar_eventinvitee table, something like a bool futureStatus so that when we get a list of invitees back, we can check for that flag. I think this would mean a lot of date comparisons (seems inefficient), and I'm not quite sure when to populate event stubs. For example, if the futureStatus flag is set to true for instance 10, and there are stubs for instances 15 and 20, when would 15 and 20 get converted to have the updated status?

Nov 28 2017, 11:16 PM · Calendar, Bug Report

Nov 23 2017

aik099 added a comment to T12098: Create Revision from FavoritesMenuItem doesn't work.

Obviously not a particularly important issue, but this now will populate a link in the favorites menu which leads to an exception:

Screen Shot 2017-11-22 at 10.31.09 PM.png (559×1 px, 48 KB)

Nov 23 2017, 7:28 AM · Dashboards, Differential
sshannin added a comment to T12098: Create Revision from FavoritesMenuItem doesn't work.

Obviously not a particularly important issue, but this now will populate a link in the favorites menu which leads to an exception:

Screen Shot 2017-11-22 at 10.31.09 PM.png (559×1 px, 48 KB)

Nov 23 2017, 3:33 AM · Dashboards, Differential

Nov 21 2017

Basheer added a comment to T12741: Phabricator IP address or Mac Address level Blocking Issue..

Hi Epriestley,

Nov 21 2017, 2:59 PM · Bug Report
Basheer renamed T12741: Phabricator IP address or Mac Address level Blocking Issue. from Unhandled Exception ("HTTPFutureCURLResponseStatus") to Phabricator IP address or Mac Address level Blocking Issue..
Nov 21 2017, 2:58 PM · Bug Report
mcorteel updated subscribers of T12785: Arc unit command fails with PHPUnit 6.

@epriestley I tried submitting a patch, but I get a Permission denied (publickey) which results in Unable to push changes to the staging area..
I added my public key and created a config rule to use it for requests to secure.phabricator.com, I'm not sure what else to do.

Nov 21 2017, 1:37 PM · Arcanist, Bug Report
mcorteel added a comment to T12785: Arc unit command fails with PHPUnit 6.

So, to recap:

  • PhpunitTestEngine::run must be updated to use --log-junit which will output XML instead of JSON
  • ArcanistPhpunitTestResultParser::parseTestResults must be updated to parse this XML file.

This seems simple enough, I will try to make it work.

Nov 21 2017, 11:28 AM · Arcanist, Bug Report

Nov 1 2017

epriestley added a revision to T12689: Mail is still received after resigning from a revision: D18758: Don't include resigned reviewers in the Differential "To" list.
Nov 1 2017, 6:12 PM · Mail, Differential, Bug Report