Page MenuHomePhabricator
Feed Advanced Search

Feb 7 2018

tolbrino added a comment to T10725: Can't access binary files of differential revision.

I've been running into the same issue for a while now. Using the Default Policy set to Subscribers for Files works well when adding files to Phriction pages and Maniphest tickets. However, when adding binary files as part of a Diff the creator of that Diff needs to change each files permissions by hand before a reviewer can download the Diff. Moreover, this needs to be repeated for every new version of that Diff.

Feb 7 2018, 8:58 AM · Restricted Project, Differential, Bug Report
epriestley added a revision to T12907: Unable to download large files through alternative file domain: D19011: Provide a streaming HTTP response parser.
Feb 7 2018, 12:14 AM · Bug Report

Feb 4 2018

epriestley added a comment to T12807: Diffusion's "Grep File Content" doesn't work with UTF characters.

See T13060 and T7339 for followups and additional discussion.

Feb 4 2018, 3:01 PM · Diffusion, Bug Report

Feb 2 2018

ofbeaton added a comment to T12359: Registration does not accept valid email addresses.

We have also found legitimate users who have valid email addresses (Irish users) that are not accepted.

Feb 2 2018, 8:35 PM · Bug Report
ofbeaton added a comment to T12718: Local email validation with apostrophe.

For those visiting from the future via search, I have decided to publish an unofficial bug patch in a github repo, as it breaks once in awhile due to upstream changes.

Feb 2 2018, 8:31 PM · Bug Report
cmmata added a comment to T12785: Arc unit command fails with PHPUnit 6.

Thanks @mcorteel, I'll take a look.

Feb 2 2018, 5:01 PM · Arcanist, Bug Report

Feb 1 2018

epriestley closed T11138: mail is not delivered if metamta.placeholder-to-recipient is null as Invalid.

This report doesn't include working reproduction instructions so we can't move forward.

Feb 1 2018, 10:58 PM · Mail, Bug Report
epriestley closed T12630: Phabricator fails with a fatal PHP error if it receives a mail with no plain text part as Resolved.

I can't reproduce this; it may have been fixed by D18776 + D18778.

Feb 1 2018, 10:54 PM · Mail, Bug Report
mcorteel added a comment to T12785: Arc unit command fails with PHPUnit 6.

@cmmata here is my diff. It can probably be improved, but it works for me:

1diff --git a/src/unit/engine/PhpunitTestEngine.php b/src/unit/engine/PhpunitTestEngine.php
2index 8206b787..ef01fda4 100644
3--- a/src/unit/engine/PhpunitTestEngine.php
4+++ b/src/unit/engine/PhpunitTestEngine.php
5@@ -52,7 +52,7 @@ final class PhpunitTestEngine extends ArcanistUnitTestEngine {
6 if (!Filesystem::pathExists($test_path)) {
7 continue;
8 }
9- $json_tmp = new TempFile();
10+ $xml_tmp = new TempFile();
11 $clover_tmp = null;
12 $clover = null;
13 if ($this->getEnableCoverage() !== false) {
14@@ -64,10 +64,10 @@ final class PhpunitTestEngine extends ArcanistUnitTestEngine {
15
16 $stderr = '-d display_errors=stderr';
17
18- $futures[$test_path] = new ExecFuture('%C %C %C --log-json %s %C %s',
19- $this->phpunitBinary, $config, $stderr, $json_tmp, $clover, $test_path);
20+ $futures[$test_path] = new ExecFuture('%C %C %C --log-junit %s %C %s',
21+ $this->phpunitBinary, $config, $stderr, $xml_tmp, $clover, $test_path);
22 $tmpfiles[$test_path] = array(
23- 'json' => $json_tmp,
24+ 'xml' => $xml_tmp,
25 'clover' => $clover_tmp,
26 );
27 }
28@@ -81,7 +81,7 @@ final class PhpunitTestEngine extends ArcanistUnitTestEngine {
29
30 $results[] = $this->parseTestResults(
31 $test,
32- $tmpfiles[$test]['json'],
33+ $tmpfiles[$test]['xml'],
34 $tmpfiles[$test]['clover'],
35 $stderr);
36 }
37@@ -90,17 +90,17 @@ final class PhpunitTestEngine extends ArcanistUnitTestEngine {
38 }
39
40 /**
41- * Parse test results from phpunit json report.
42+ * Parse test results from phpunit XML report.
43 *
44 * @param string $path Path to test
45- * @param string $json_tmp Path to phpunit json report
46+ * @param string $xml_tmp Path to phpunit XML report
47 * @param string $clover_tmp Path to phpunit clover report
48 * @param string $stderr Data written to stderr
49 *
50 * @return array
51 */
52- private function parseTestResults($path, $json_tmp, $clover_tmp, $stderr) {
53- $test_results = Filesystem::readFile($json_tmp);
54+ private function parseTestResults($path, $xml_tmp, $clover_tmp, $stderr) {
55+ $test_results = Filesystem::readFile($xml_tmp);
56 return id(new ArcanistPhpunitTestResultParser())
57 ->setEnableCoverage($this->getEnableCoverage())
58 ->setProjectRoot($this->projectRoot)
59diff --git a/src/unit/parser/ArcanistPhpunitTestResultParser.php b/src/unit/parser/ArcanistPhpunitTestResultParser.php
60index 5ccff970..3d7fcd77 100644
61--- a/src/unit/parser/ArcanistPhpunitTestResultParser.php
62+++ b/src/unit/parser/ArcanistPhpunitTestResultParser.php
63@@ -9,10 +9,10 @@
64 final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
65
66 /**
67- * Parse test results from phpunit json report
68+ * Parse test results from phpunit XML report
69 *
70 * @param string $path Path to test
71- * @param string $test_results String containing phpunit json report
72+ * @param string $test_results String containing phpunit XML report
73 *
74 * @return array
75 */
76@@ -25,7 +25,7 @@ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
77 return array($result);
78 }
79
80- $report = $this->getJsonReport($test_results);
81+ $report = simplexml_load_string($test_results);
82
83 // coverage is for all testcases in the executed $path
84 $coverage = array();
85@@ -36,56 +36,36 @@ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
86 $last_test_finished = true;
87
88 $results = array();
89- foreach ($report as $event) {
90- switch (idx($event, 'event')) {
91- case 'test':
92- break;
93- case 'testStart':
94- $last_test_finished = false;
95- // fall through
96- default:
97- continue 2; // switch + loop
98- }
99-
100+ foreach ($report->testsuite as $test_suite) {
101 $status = ArcanistUnitTestResult::RESULT_PASS;
102 $user_data = '';
103
104- if ('fail' == idx($event, 'status')) {
105+ if ((int)$test_suite['failures'] > 0) {
106 $status = ArcanistUnitTestResult::RESULT_FAIL;
107- $user_data .= idx($event, 'message')."\n";
108- foreach (idx($event, 'trace') as $trace) {
109- $user_data .= sprintf(
110- "\n%s:%s",
111- idx($trace, 'file'),
112- idx($trace, 'line'));
113+ foreach ($test_suite->testcase as $test_case) {
114+ foreach ($test_case->failure as $failure) {
115+ $user_data .= sprintf(
116+ "\n%s",
117+ (string)$failure);
118+ }
119 }
120- } else if ('error' == idx($event, 'status')) {
121- if (strpos(idx($event, 'message'), 'Skipped Test') !== false) {
122- $status = ArcanistUnitTestResult::RESULT_SKIP;
123- $user_data .= idx($event, 'message');
124- } else if (strpos(
125- idx($event, 'message'),
126- 'Incomplete Test') !== false) {
127- $status = ArcanistUnitTestResult::RESULT_SKIP;
128- $user_data .= idx($event, 'message');
129- } else {
130- $status = ArcanistUnitTestResult::RESULT_BROKEN;
131- $user_data .= idx($event, 'message');
132- foreach (idx($event, 'trace') as $trace) {
133- $user_data .= sprintf(
134- "\n%s:%s",
135- idx($trace, 'file'),
136- idx($trace, 'line'));
137+ } else if ($test_suite['errors'] > 0) {
138+ $status = ArcanistUnitTestResult::RESULT_BROKEN;
139+ foreach ($test_suite->testcase as $test_case) {
140+ foreach ($test_case->error as $error) {
141+ $user_data .= sprintf(
142+ "\n%s",
143+ (string)$error);
144 }
145 }
146 }
147
148- $name = preg_replace('/ \(.*\)/s', '', idx($event, 'test'));
149+ $name = preg_replace('/ \(.*\)/s', '', $test_suite['name']);
150
151 $result = new ArcanistUnitTestResult();
152 $result->setName($name);
153 $result->setResult($status);
154- $result->setDuration(idx($event, 'time'));
155+ $result->setDuration((float)$test_suite['time']);
156 $result->setCoverage($coverage);
157 $result->setUserData($user_data);
158
159@@ -95,7 +75,7 @@ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
160
161 if (!$last_test_finished) {
162 $results[] = id(new ArcanistUnitTestResult())
163- ->setName(idx($event, 'test')) // use last event
164+ ->setName($test_suite['name']) // use last event
165 ->setUserData($this->stderr)
166 ->setResult(ArcanistUnitTestResult::RESULT_BROKEN);
167 }
168@@ -161,28 +141,4 @@ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
169 return $reports;
170 }
171
172- /**
173- * We need this non-sense to make json generated by phpunit
174- * valid.
175- *
176- * @param string $json String containing JSON report
177- * @return array JSON decoded array
178- */
179- private function getJsonReport($json) {
180-
181- if (empty($json)) {
182- throw new Exception(
183- pht(
184- 'JSON report file is empty, it probably means that phpunit '.
185- 'failed to run tests. Try running %s with %s option and then run '.
186- 'generated phpunit command yourself, you might get the answer.',
187- 'arc unit',
188- '--trace'));
189- }
190-
191- $json = preg_replace('/}{\s*"/', '},{"', $json);
192- $json = '['.$json.']';
193- return phutil_json_decode($json);
194- }
195-
196 }

Feb 1 2018, 11:00 AM · Arcanist, Bug Report
cmmata added a comment to T12785: Arc unit command fails with PHPUnit 6.

@mcorteel I have the same problem, arc unit only works with phpunit 5.7. If I use 6.5, it fails. Do you have that patch anywhere with public access so we can use it while it's not published?

Feb 1 2018, 9:47 AM · Arcanist, Bug Report

Jan 27 2018

epriestley moved T11138: mail is not delivered if metamta.placeholder-to-recipient is null from v3 to Stamps/Failover on the Mail board.
Jan 27 2018, 9:58 PM · Mail, Bug Report
epriestley closed T12033: Large diffs can still repeatedly fail to insert as Resolved.

This is resolved as far as I'm aware. See also T11767 (improvements to these limits), PHI125 (similar issue with non-UTF8 attachments failing to insert) and T13053 (planning).

Jan 27 2018, 9:55 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley moved T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place from Backlog to Stamps/Failover on the Mail board.
Jan 27 2018, 9:54 PM · Mail, Bug Report
epriestley moved T12630: Phabricator fails with a fatal PHP error if it receives a mail with no plain text part from Backlog to Stamps/Failover on the Mail board.
Jan 27 2018, 9:54 PM · Mail, Bug Report
epriestley moved T12689: Mail is still received after resigning from a revision from Backlog to Stamps/Failover on the Mail board.
Jan 27 2018, 9:54 PM · Mail, Differential, Bug Report

Jan 26 2018

epriestley closed T11112: Herald allows setting multiple values in fields that should only accept one value as Resolved by committing rP4b5a78e3435b: Add "you can only enter one value" UI limits to Herald "set status" and "set….
Jan 26 2018, 9:23 PM · Herald, Bug Report
epriestley moved T11112: Herald allows setting multiple values in fields that should only accept one value from Backlog to Next on the Herald board.
Jan 26 2018, 5:53 PM · Herald, Bug Report
epriestley closed T11349: Herald has the wrong list of "Author's Projects" as Invalid.

This is quite old and I have no idea how to reproduce it and thus no idea how to fix it. Locally, I tried a few things and wasn't able to identify a case where the Herald field value differed from my actual project list.

Jan 26 2018, 5:49 PM · Restricted Project, Herald, Bug Report
epriestley added a revision to T11112: Herald allows setting multiple values in fields that should only accept one value: D18943: Add "you can only enter one value" UI limits to Herald "set status" and "set priority" actions.
Jan 26 2018, 5:42 PM · Herald, Bug Report

Jan 24 2018

epriestley added a parent task for T11135: Ctrl-click symbol lookup language in Diffusion ignores `syntax.filemap`: T13047: Plans: Symbol Indexes.
Jan 24 2018, 4:24 PM · Symbols, Bug Report

Jan 21 2018

epriestley closed T11827: ssh-auth hangs on FreeBSD as Resolved.

From https://bugzilla.mindrot.org/show_bug.cgi?id=2496, this is apparently fixed in the OpenSSH upstream (https://github.com/openssh/openssh-portable/commit/ddd3d34e5c7979ca6f4a3a98a7d219a4ed3d98c2). Since this is a bug in OpenSSH, an upstream fix is available, and the impact is fairly narrow, I don't plan to work around it in Phabricator.

Jan 21 2018, 2:58 AM · Diffusion, Bug Report

Jan 19 2018

epriestley closed T12415: Comment field action in batch action doesn't render correctly as Resolved by committing rP687fada5af43: Restore bulk edit support for remarkup fields (description, add comment).
Jan 19 2018, 8:45 PM · Bug Report
epriestley added a comment to T12415: Comment field action in batch action doesn't render correctly.

I've marked D18867 as fixing this. It isn't a perfect fix, but it's closer to the realm of reasonable (you have a sensible amount of area to work with and a readable font):

Jan 19 2018, 2:38 PM · Bug Report
epriestley added a revision to T12415: Comment field action in batch action doesn't render correctly: D18867: Restore bulk edit support for remarkup fields (description, add comment).
Jan 19 2018, 2:32 PM · Bug Report

Jan 5 2018

epriestley moved T12453: Using `arc patch` will leave behind a bookmark when answering 'No' in attempt to apply to current state in Mercurial repository from Backlog to arc patch on the Mercurial board.
Jan 5 2018, 6:56 PM · Arcanist, Mercurial, Bug Report
epriestley moved T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit from Backlog to arc patch on the Mercurial board.
Jan 5 2018, 6:56 PM · Arcanist, Mercurial, Bug Report

Jan 4 2018

epriestley moved T10900: Repository content search with `hg grep` returns matches found in old versions of files from Backlog to Far Future on the Mercurial board.
Jan 4 2018, 7:40 PM · Mercurial, Diffusion
epriestley added a comment to T10900: Repository content search with `hg grep` returns matches found in old versions of files.

Actually, this is less crazy than I thought.

Jan 4 2018, 7:39 PM · Mercurial, Diffusion
epriestley added a comment to T10900: Repository content search with `hg grep` returns matches found in old versions of files.

This appears to date back to the introduction of the feature in D5738, where I suggested we use ancestors() without a legitimate reason (or maybe very old Mercurial had weird behavior).

Jan 4 2018, 7:26 PM · Mercurial, Diffusion

Dec 26 2017

epriestley closed T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to as Resolved by committing rPead5f4fd9c03: Add an "Accepting reviewers" Herald field for commits.
Dec 26 2017, 11:59 PM · Differential, Herald, Bug Report

Dec 22 2017

epriestley added a revision to T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to: D18839: Add an "Accepting reviewers" Herald field for commits.
Dec 22 2017, 6:19 PM · Differential, Herald, Bug Report

Dec 13 2017

epriestley archived Bug Report.
Dec 13 2017, 1:14 PM

Dec 12 2017

epriestley merged task T9915: Audit Changes TOC fail redirecting to right subdirectory when clicking on fa-folder-open icon and produces an unhandled exception into T13030: Accessing a submodule path directly in Diffusion has less than optimal UX.
Dec 12 2017, 8:54 PM · Restricted Project, Diffusion, Bug Report

Dec 9 2017

aklapper added a comment to T10221: upgrading to ubuntu 15.10 breaks google authentication.

Support for Ubuntu 15.10 ended on 2016-07-28.
Did this problem also happen with any later, still supported Ubuntu version (like 16.04) or can this task be closed as obsolete?

Dec 9 2017, 7:48 PM · Auth, Bug Report

Nov 30 2017

epriestley closed T10233: arc error message unclear for accepted revision in "plan change" state as Resolved by committing rARCf4c80a114d36: Make "arc land" prompt on "Changes Planned" revisions more explicit.
Nov 30 2017, 9:51 PM · Restricted Project, Bug Report
epriestley closed T12592: User awaiting approval has no image as Resolved.

This should be fixed by changes in T13024.

Nov 30 2017, 9:43 PM · Bug Report, Auth
epriestley closed T12657: Add Authentication Factor fails silently for users without a verified email address as Resolved.

This should be fixed by changes in T13024.

Nov 30 2017, 9:43 PM · Auth, Bug Report
epriestley merged T12570: Installs without `gd` are unable to reach the setup warning telling them to install `gd` into T10405: Phabricator should generally work properly even if "gd" is not installed.
Nov 30 2017, 9:42 PM · Setup, Restricted Project
epriestley merged task T12570: Installs without `gd` are unable to reach the setup warning telling them to install `gd` into T10405: Phabricator should generally work properly even if "gd" is not installed.
Nov 30 2017, 9:42 PM · Setup, Bug Report
epriestley added a revision to T10233: arc error message unclear for accepted revision in "plan change" state: D18808: Add an explicit warning in the Differential transaction log when users skip review.
Nov 30 2017, 4:26 PM · Restricted Project, Bug Report
epriestley added a revision to T10233: arc error message unclear for accepted revision in "plan change" state: D18807: Make "arc land" prompt on "Changes Planned" revisions more explicit.
Nov 30 2017, 3:53 PM · Restricted Project, Bug Report

Nov 29 2017

epriestley added a comment to T10233: arc error message unclear for accepted revision in "plan change" state.

In PHI231, a more experienced user went through this workflow:

Nov 29 2017, 7:24 PM · Restricted Project, Bug Report

Nov 28 2017

lpriestley added a comment to T12544: Cannot add invitees to all future instances of a recurring event.

@epriestley what do you think of creating another column in the calendar_eventinvitee table, something like a bool futureStatus so that when we get a list of invitees back, we can check for that flag. I think this would mean a lot of date comparisons (seems inefficient), and I'm not quite sure when to populate event stubs. For example, if the futureStatus flag is set to true for instance 10, and there are stubs for instances 15 and 20, when would 15 and 20 get converted to have the updated status?

Nov 28 2017, 11:16 PM · Calendar, Bug Report

Nov 23 2017

aik099 added a comment to T12098: Create Revision from FavoritesMenuItem doesn't work.

Obviously not a particularly important issue, but this now will populate a link in the favorites menu which leads to an exception:

Screen Shot 2017-11-22 at 10.31.09 PM.png (559×1 px, 48 KB)

Nov 23 2017, 7:28 AM · Dashboards, Differential
sshannin added a comment to T12098: Create Revision from FavoritesMenuItem doesn't work.

Obviously not a particularly important issue, but this now will populate a link in the favorites menu which leads to an exception:

Screen Shot 2017-11-22 at 10.31.09 PM.png (559×1 px, 48 KB)

Nov 23 2017, 3:33 AM · Dashboards, Differential

Nov 21 2017

Basheer added a comment to T12741: Phabricator IP address or Mac Address level Blocking Issue..

Hi Epriestley,

Nov 21 2017, 2:59 PM · Bug Report
Basheer renamed T12741: Phabricator IP address or Mac Address level Blocking Issue. from Unhandled Exception ("HTTPFutureCURLResponseStatus") to Phabricator IP address or Mac Address level Blocking Issue..
Nov 21 2017, 2:58 PM · Bug Report
mcorteel updated subscribers of T12785: Arc unit command fails with PHPUnit 6.

@epriestley I tried submitting a patch, but I get a Permission denied (publickey) which results in Unable to push changes to the staging area..
I added my public key and created a config rule to use it for requests to secure.phabricator.com, I'm not sure what else to do.

Nov 21 2017, 1:37 PM · Arcanist, Bug Report
mcorteel added a comment to T12785: Arc unit command fails with PHPUnit 6.

So, to recap:

  • PhpunitTestEngine::run must be updated to use --log-junit which will output XML instead of JSON
  • ArcanistPhpunitTestResultParser::parseTestResults must be updated to parse this XML file.

This seems simple enough, I will try to make it work.

Nov 21 2017, 11:28 AM · Arcanist, Bug Report

Nov 1 2017

epriestley added a revision to T12689: Mail is still received after resigning from a revision: D18758: Don't include resigned reviewers in the Differential "To" list.
Nov 1 2017, 6:12 PM · Mail, Differential, Bug Report
epriestley updated the task description for T12689: Mail is still received after resigning from a revision.
Nov 1 2017, 6:10 PM · Mail, Differential, Bug Report
epriestley merged T7704: Rejecting then accepting a revision with blocking reviewers doesn't correctly change state into T12920: Retracting requested changes can leave revision in "Needs Revision" state.
Nov 1 2017, 6:05 PM · Restricted Project, Differential, Bug Report
epriestley added a comment to T12920: Retracting requested changes can leave revision in "Needs Revision" state.

Pretty sure T7704 is the same as this.

Nov 1 2017, 6:05 PM · Restricted Project, Differential, Bug Report

Oct 31 2017

epriestley added a comment to T10109: Differental does not trigger Herald for mundane updates.

Ah, thanks. I think your guess is right. I'll make a note in T2543, should be a one-line fix I think.

Oct 31 2017, 1:51 PM · Differential, Restricted Project, Herald, Bug Report
avivey added a comment to T10109: Differental does not trigger Herald for mundane updates.

From https://discourse.phabricator-community.org/t/644 - it appears that HM now triggers a build on revisions when they are closed via landing, which fails because the build expects a Staging ref. I don't have the setup to test any of it, but the latest revision landed here doesn't show the behavior, so either f7f3dd5b2084 hasn't rolled in here yet, or that user is doing something funny.

Oct 31 2017, 11:09 AM · Differential, Restricted Project, Herald, Bug Report

Oct 27 2017

epriestley closed T10109: Differental does not trigger Herald for mundane updates as Resolved by committing rPf7f3dd5b2084: Don't run Herald build and mail rules when they don't make sense.
Oct 27 2017, 3:44 PM · Differential, Restricted Project, Herald, Bug Report

Oct 24 2017

epriestley added a revision to T10109: Differental does not trigger Herald for mundane updates: D18731: Don't run Herald build and mail rules when they don't make sense.
Oct 24 2017, 9:21 PM · Differential, Restricted Project, Herald, Bug Report

Oct 16 2017

mruuska added a comment to T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs.

I'm getting the same #1048: Column 'filename' cannot be null running just regular "arc diff". It used to work and then at some point after updates started failing.

Oct 16 2017, 3:52 PM · Arcanist, Bug Report

Oct 7 2017

epriestley added a comment to T13004: [Stable] bin/storage dump fails if there's a password set.

We should probably update the documentation to recommend --output and --compress, since the error behavior (e.g., in the event of a full disk) is better.

Oct 7 2017, 8:26 PM · Bug Report
borna.emami added a comment to T13004: [Stable] bin/storage dump fails if there's a password set.

Thanks for the fix on that. I have my nightly backups running again, however I had to switch from

./bin/storage dump | gzip > file.sql.gz

to

phab/bin/storage dump --output file.sql.gz --compress
Oct 7 2017, 7:51 PM · Bug Report
epriestley closed T13004: [Stable] bin/storage dump fails if there's a password set as Resolved by committing rP1ee7b3ab8cbb: Correct "bin/storage dump" command construction with passwords.
Oct 7 2017, 12:00 PM · Bug Report
borna.emami added a comment to T13004: [Stable] bin/storage dump fails if there's a password set.

Thanks for the quick response. I'll try the workaround in the morning.

Oct 7 2017, 11:38 AM · Bug Report
avivey renamed T13004: [Stable] bin/storage dump fails if there's a password set from bin/storage dump fails if there's a password set to [Stable] bin/storage dump fails if there's a password set.
Oct 7 2017, 9:20 AM · Bug Report
avivey created T13004: [Stable] bin/storage dump fails if there's a password set.
Oct 7 2017, 9:16 AM · Bug Report

Oct 5 2017

epriestley added a comment to T12907: Unable to download large files through alternative file domain.

On the bin/files download side of things, we currently buffer the whole file into a string and then hit this:

Oct 5 2017, 8:41 PM · Bug Report
epriestley added a comment to T12907: Unable to download large files through alternative file domain.

For consistency, I gave the content Cloudfront distribution a 60-second timeout as well.

Oct 5 2017, 8:28 PM · Bug Report
epriestley added a comment to T12907: Unable to download large files through alternative file domain.

Pulling stuff from admin.phacility.com via Cloudfront, I get this instead:

Oct 5 2017, 8:20 PM · Bug Report
epriestley added a comment to T12907: Unable to download large files through alternative file domain.

In the log above, this download should have worked:

Oct 5 2017, 7:43 PM · Bug Report
ragnalinux added a comment to T10632: Error displaying a Differential revision.

i encountered same problem , but it happened on libphutil/src/xsprintf/xsprintf.php. I resolved this problem by setting max_nesting_level on php xdebug .

Oct 5 2017, 9:14 AM · Bug Report

Oct 2 2017

jkrets added a comment to T11030: Cannot clone public repository over HTTP anonymously..

Sorry to leave this hanging, but the issue was with our server configuration. We did not have the correct sudo rights confgured

Oct 2 2017, 3:18 PM · Diffusion, Bug Report

Sep 25 2017

epriestley closed T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs as Resolved.

This is now in stable, and deployed here and to the Phacility production cluster.

Sep 25 2017, 1:40 PM · Customer Impact, Diffusion, Bug Report

Sep 15 2017

epriestley added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

This is now deployed on this server, we'll see how it holds up. It won't promote to stable until next week, and I'd discourage anyone from picking it up right away.

Sep 15 2017, 5:45 PM · Customer Impact, Diffusion, Bug Report
epriestley added a revision to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs: D18615: Update utility "bin/repository parents" workflow to work with RefPosition.
Sep 15 2017, 4:24 PM · Customer Impact, Diffusion, Bug Report
epriestley added a revision to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs: D18614: Update major RefCursor callsites to work properly with RefPosition.
Sep 15 2017, 4:20 PM · Customer Impact, Diffusion, Bug Report
epriestley added a revision to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs: D18613: Remove obsolete columns from RefCursor table.
Sep 15 2017, 3:36 PM · Customer Impact, Diffusion, Bug Report
epriestley added a revision to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs: D18612: Migrate RefCursor data to RefPosition table.
Sep 15 2017, 3:28 PM · Customer Impact, Diffusion, Bug Report

Sep 14 2017

epriestley added a revision to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs: D18602: Add a RefPosition table to hold branch/tag positions once the RefCursor table is split.
Sep 14 2017, 12:13 PM · Customer Impact, Diffusion, Bug Report
epriestley added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

In Mercurial, can a branch have some open heads and some closed heads?

Sep 14 2017, 12:03 PM · Customer Impact, Diffusion, Bug Report

Sep 13 2017

epriestley added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

See also PHI68.

Sep 13 2017, 10:55 PM · Customer Impact, Diffusion, Bug Report
epriestley added a comment to T12033: Large diffs can still repeatedly fail to insert.

Oh, yes, sorry, looked at the wrong tab.

Sep 13 2017, 10:49 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
alexmv added a comment to T12033: Large diffs can still repeatedly fail to insert.

Do you mean "follow up in PHI55"?

Sep 13 2017, 10:40 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley added a comment to T12033: Large diffs can still repeatedly fail to insert.

I'm going to presume this is resolved by D18598 -- I updated T11767 with more plans and context for smoothing over the behavior, but I think it will no longer be disastrously bad. I'll follow up in PHI36 PHI55.

Sep 13 2017, 10:34 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley added a revision to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs: D18599: Work around workflow blocking error with duplicate "master" refs in "Land Revision".
Sep 13 2017, 7:21 PM · Customer Impact, Diffusion, Bug Report

Sep 12 2017

epriestley added a revision to T12033: Large diffs can still repeatedly fail to insert: D18598: Stop the bleeding caused by attaching enormous patches to revision mail.
Sep 12 2017, 10:43 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley closed T12443: Applying fulltext limits first causes missing results as Resolved.

This is resolved by the Ferret engine, which can execute all parts of the query logic in MySQL.

Sep 12 2017, 3:09 PM · Restricted Project, Search, Bug Report

Sep 6 2017

epriestley closed T12118: Differential email does not contain reviewers/subscribers information anymore as Resolved by committing rPe91d72fefbf9: Un-hide the "X added reviewers: ..." transactions in revision creation mail.
Sep 6 2017, 5:23 PM · Restricted Project, Differential, Bug Report
epriestley added a revision to T12118: Differential email does not contain reviewers/subscribers information anymore: D18542: Un-hide the "X added reviewers: ..." transactions in revision creation mail.
Sep 6 2017, 4:45 PM · Restricted Project, Differential, Bug Report

Sep 1 2017

epriestley added a parent task for T12443: Applying fulltext limits first causes missing results: T12974: Upgrading: "Ferret" Fulltext Engine.
Sep 1 2017, 5:06 PM · Restricted Project, Search, Bug Report

Aug 28 2017

epriestley added a revision to T12443: Applying fulltext limits first causes missing results: D18484: Build a prototype fulltext engine ("Ferret") using only basic MySQL primitives.
Aug 28 2017, 9:35 PM · Restricted Project, Search, Bug Report

Aug 24 2017

jkrets added a comment to T11030: Cannot clone public repository over HTTP anonymously..

I'm not sure it's a bug. The error message was surprising; HTTP/1.0 500 Error 1: sudo: a password is required. I see a matching error message in Q261. The solution there seems to be allowing the webserver process owner to have sudo rights. I now found there are docs on the subject diffusion_hosting#configuring-sudo.

Aug 24 2017, 11:59 AM · Diffusion, Bug Report

Aug 23 2017

epriestley added a comment to T11030: Cannot clone public repository over HTTP anonymously..

If you believe you've found a bug in Phabricator, please follow the instructions in Contributing Bug Reports to file a report.

Aug 23 2017, 6:01 PM · Diffusion, Bug Report
jkrets added a comment to T11030: Cannot clone public repository over HTTP anonymously..

This might be useful debugging information:

>> export GIT_CURL_VERBOSE=1
>> git clone http://phabricator.internal/diffusion/TRACTORAPI/tractor-api.git
Cloning into 'tractor-api'...
* Couldn't find host phabricator.internal in the .netrc file; using defaults
* About to connect() to phabricator.internal port 80 (#0)
*   Trying 10.11.45.21... * Connected to phabricator.internal (10.11.45.21) port 80 (#0)
> GET /diffusion/TRACTORAPI/tractor-api.git/info/refs?service=git-upload-pack HTTP/1.1
User-Agent: git/2.14.1
Host: phabricator.internal
Accept: */*
Accept-Encoding: gzip
Accept-Language: en-US, *;q=0.9
Pragma: no-cache
Aug 23 2017, 4:58 PM · Diffusion, Bug Report
remusvrm added a comment to T11030: Cannot clone public repository over HTTP anonymously..

This doesn't work again.

Aug 23 2017, 4:52 PM · Diffusion, Bug Report

Aug 22 2017

chad added a comment to T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.

Somewhat related, if you have a disabled "Home" as your top item, we still show that regardless of the active dashboard below it.

Aug 22 2017, 10:23 PM · Policy, Dashboards, Bug Report

Aug 17 2017

chad added a project to T12967: Mercurical branches don't display tracking status properly: Bug Report.
Aug 17 2017, 7:32 PM · Diffusion, Bug Report

Aug 16 2017

OCram added a comment to T10252: Username autocompletion doesn't work with some non-US keyboard layouts.

It works great now with Windows + Chrome + German keyboard layout!

Aug 16 2017, 6:41 AM · Restricted Project, Bug Report

Aug 15 2017

epriestley moved T12689: Mail is still received after resigning from a revision from Backlog to Reviewer Rules on the Differential board.
Aug 15 2017, 5:53 PM · Mail, Differential, Bug Report
epriestley moved T12920: Retracting requested changes can leave revision in "Needs Revision" state from Backlog to Reviewer Rules on the Differential board.
Aug 15 2017, 5:53 PM · Restricted Project, Differential, Bug Report
epriestley closed T12548: Unable to initialize database with invalid credentials in configuration file as Invalid.

Closing this for lack of feedback, feel free to resurrect it if you get back to it.

Aug 15 2017, 5:34 PM · Database, Bug Report
epriestley closed T12602: Assignees of tasks don't count as subscribers in maniphest search as Invalid.

This isn't a bug; they aren't subscribers, and aren't listed in "Subscribers" in the right-hand column or in "Subscribers" in "Edit Task".

Aug 15 2017, 5:32 PM · Maniphest, Bug Report