Page MenuHomePhabricator
Feed Advanced Search

Aug 18 2015

epriestley added a comment to T9175: XHPAST doesn't build automatically.

I think using FileLock is pretty reasonable. It's a little gross, but I'm not aware of any way to do this synchronization in make itself (although it's possible there is one), and if the process doesn't have write access to the lock it isn't going to be able to run make anyway, so it shouldn't be adding new failure modes.

Aug 18 2015, 6:06 PM · XHPAST, Arcanist

Aug 14 2015

joshuaspence added a comment to T9175: XHPAST doesn't build automatically.

I can sorta fix with using PhutilFileLock, but it feels a bit gross. Here is something I threw together real quick: https://secure.phabricator.com/differential/diff/33545/

Aug 14 2015, 8:38 AM · XHPAST, Arcanist
joshuaspence created T9175: XHPAST doesn't build automatically.
Aug 14 2015, 12:46 AM · XHPAST, Arcanist

Aug 13 2015

epriestley closed T9158: XHPAST is out-of-date as Resolved.
Aug 13 2015, 12:40 AM · Phacility, XHPAST

Aug 12 2015

joshuaspence created T9158: XHPAST is out-of-date.
Aug 12 2015, 10:56 PM · Phacility, XHPAST

Aug 4 2015

joshuaspence created T9062: Generalize PHPAST application.
Aug 4 2015, 9:12 AM · XHPAST

Jul 10 2015

richardvanvelzen added a comment to T4334: Support PHP5.4+ syntax in XHPAST.

Missing finally support is now starting to affect a large portion of my colleagues.

Jul 10 2015, 2:40 PM · XHPAST

Jun 24 2015

hach-que added a comment to T8653: xhpast generation does not work properly under MinGW if the repo has CRLF line endings.

Another option is to add the following to .gitattributes:

Jun 24 2015, 7:30 AM · XHPAST
hach-que created T8653: xhpast generation does not work properly under MinGW if the repo has CRLF line endings.
Jun 24 2015, 7:21 AM · XHPAST

Jun 14 2015

joshuaspence added a comment to T8534: Need a way to retrieve fully qualified class name.

I considered putting a getClassName() method on the XHPASTNode class, but I'm not entirely convinced that this is a good idea.

Jun 14 2015, 10:45 AM · XHPAST
joshuaspence created T8534: Need a way to retrieve fully qualified class name.
Jun 14 2015, 6:50 AM · XHPAST

Jun 2 2015

joshuaspence closed T8379: ArcanistFormattedStringXHPASTLinterRule fails as Resolved by committing rPHU9a21607bf50b: Revert "Don't consider strings with variables to be static".
Jun 2 2015, 12:13 PM · Lint, XHPAST
joshuaspence added a revision to T8379: ArcanistFormattedStringXHPASTLinterRule fails: D13113: Revert "Don't consider strings with variables to be static".
Jun 2 2015, 12:06 PM · Lint, XHPAST
joshuaspence added a comment to T8379: ArcanistFormattedStringXHPASTLinterRule fails.

The same thing applies to ArcanistDuplicateKeysInArrayXHPASTLinterRule.

Jun 2 2015, 8:50 AM · Lint, XHPAST

Jun 1 2015

joshuaspence claimed T8379: ArcanistFormattedStringXHPASTLinterRule fails.
Jun 1 2015, 9:43 PM · Lint, XHPAST
joshuaspence created T8379: ArcanistFormattedStringXHPASTLinterRule fails.
Jun 1 2015, 9:42 PM · Lint, XHPAST

May 27 2015

fabe created T8325: XHPASTLinter does not scope parameters to closures correctly.
May 27 2015, 10:01 AM · XHPAST, Lint
joshuaspence closed T6154: XHPAST fails to recognise some syntax errors as Resolved.

This was sorta fixed by D12922.

May 27 2015, 9:28 AM · XHPAST

May 24 2015

joshuaspence claimed T8049: Improve parsing of variables embedded in strings in XHPAST.
May 24 2015, 10:10 AM · XHPAST

May 7 2015

epriestley triaged T8049: Improve parsing of variables embedded in strings in XHPAST as Wishlist priority.
May 7 2015, 1:50 PM · XHPAST

May 4 2015

epriestley renamed T8049: Improve parsing of variables embedded in strings in XHPAST from Improve parsing of strings to Improve parsing of variables embedded in strings in XHPAST.
May 4 2015, 1:31 PM · XHPAST

May 3 2015

joshuaspence created T8049: Improve parsing of variables embedded in strings in XHPAST.
May 3 2015, 11:38 PM · XHPAST

Apr 11 2015

joshuaspence closed T7801: XHPAST is behaving strangely as Resolved by committing rPHUefc338d50f17: Fix XHPAST parsing of casts.
Apr 11 2015, 11:50 PM · XHPAST

Apr 10 2015

joshuaspence added a revision to T7801: XHPAST is behaving strangely: D12344: Fix XHPAST parsing of casts.
Apr 10 2015, 1:58 PM · XHPAST
joshuaspence added a comment to T7801: XHPAST is behaving strangely.

Actually, nevermind... my development install was a bit old. I can replicate this on my development host.

Apr 10 2015, 1:28 PM · XHPAST
joshuaspence created T7801: XHPAST is behaving strangely.
Apr 10 2015, 1:25 PM · XHPAST

Apr 9 2015

epriestley closed T7793: Building xhpast is broken as Resolved by committing rPHU01f860e0ec7f: Fix compile failure in xhpast.
Apr 9 2015, 3:53 PM · XHPAST
epriestley added a revision to T7793: Building xhpast is broken: D12335: Fix compile failure in xhpast.
Apr 9 2015, 3:24 PM · XHPAST
richardvanvelzen updated subscribers of T7793: Building xhpast is broken.

These changes fix it:

diff --git a/support/xhpast/scanner.l b/support/xhpast/scanner.l
index 28cf40f..bbdde72 100644
--- a/support/xhpast/scanner.l
+++ b/support/xhpast/scanner.l
@@ -313,8 +313,8 @@ NEWLINE ("\r\n"|"\n"|"\r")
   "("{TABS_AND_SPACES}unset{TABS_AND_SPACES}")" tok(T_UNSET_CAST);
 }
Apr 9 2015, 7:43 AM · XHPAST
richardvanvelzen created T7793: Building xhpast is broken.
Apr 9 2015, 7:43 AM · XHPAST

Feb 28 2015

joshuaspence added a revision to T6195: Replace XHPAST with a pure PHP implementation: D11905: [Draft] Replace XHPAST with a pure PHP implementation.
Feb 28 2015, 1:46 AM · XHPAST

Feb 18 2015

epriestley added a comment to T7301: XHPAST application is not optimized for mobile.

Yes. My clever plan is to wait for mobile devices to have an effective resolution of 3600x8200 and MindMouse technology.

Feb 18 2015, 5:22 AM · XHPAST, Mobile
chad added a comment to T7301: XHPAST application is not optimized for mobile.

after the IPO

Feb 18 2015, 5:21 AM · XHPAST, Mobile
epriestley triaged T7301: XHPAST application is not optimized for mobile as Wishlist priority.
Feb 18 2015, 5:17 AM · XHPAST, Mobile
epriestley claimed T7301: XHPAST application is not optimized for mobile.

I'll show you! I'll make this the greatest mobile app the world has ever seen!

Feb 18 2015, 5:17 AM · XHPAST, Mobile
Mnkras added a comment to T7301: XHPAST application is not optimized for mobile.

Yea, there are just certain things you can't make mobile friendly, I think this may be one of them.

Feb 18 2015, 5:07 AM · XHPAST, Mobile
chad removed a project from T7301: XHPAST application is not optimized for mobile: Design.
Feb 18 2015, 4:39 AM · XHPAST, Mobile
chad added a comment to T7301: XHPAST application is not optimized for mobile.

This is "working as intended" on mobile. We should maybe mark XHPAST as developer/prototype or something.

Feb 18 2015, 4:38 AM · XHPAST, Mobile

Feb 17 2015

joshuaspence closed T7242: Wrong script name, when building xhpast from linter as Resolved by committing rPHU399c694ebae5: Fix XHPAST build instructions.
Feb 17 2015, 9:04 PM · XHPAST
joshuaspence updated the task description for T7301: XHPAST application is not optimized for mobile.
Feb 17 2015, 8:56 PM · XHPAST, Mobile
joshuaspence created T7301: XHPAST application is not optimized for mobile.
Feb 17 2015, 8:55 PM · XHPAST, Mobile

Feb 12 2015

joshuaspence added a revision to T7242: Wrong script name, when building xhpast from linter: D11758: Fix XHPAST build instructions.
Feb 12 2015, 8:34 PM · XHPAST

Feb 11 2015

joshuaspence claimed T7242: Wrong script name, when building xhpast from linter.

Oh, I forgot to change that.

Feb 11 2015, 8:47 PM · XHPAST
aik099 created T7242: Wrong script name, when building xhpast from linter.
Feb 11 2015, 8:15 PM · XHPAST

Feb 3 2015

joshuaspence placed T6154: XHPAST fails to recognise some syntax errors up for grabs.
Feb 3 2015, 7:37 PM · XHPAST

Jan 29 2015

michaeloa closed T7067: Fatal error running XHPast (arc lint) as Resolved.

Thanks - seems that had failed to upgrade for a while now. Problem solved.

Jan 29 2015, 8:10 AM · XHPAST

Jan 28 2015

joshuaspence added a comment to T7067: Fatal error running XHPast (arc lint).

Update libphutil, it seems that you are not using the latest version.

Jan 28 2015, 7:45 PM · XHPAST
michaeloa updated the task description for T7067: Fatal error running XHPast (arc lint).
Jan 28 2015, 11:13 AM · XHPAST
michaeloa created T7067: Fatal error running XHPast (arc lint).
Jan 28 2015, 11:11 AM · XHPAST

Jan 11 2015

richardvanvelzen added a revision to T6925: XHPAST is out of date on Windows: D11335: Rebuild xhpast.exe.
Jan 11 2015, 9:10 PM · Windows, XHPAST
joshuaspence added a project to T6925: XHPAST is out of date on Windows: Windows.
Jan 11 2015, 8:33 PM · Windows, XHPAST
joshuaspence added a comment to T6925: XHPAST is out of date on Windows.

I tried to give this a go, but with no luck:

Jan 11 2015, 3:35 AM · Windows, XHPAST

Jan 9 2015

richardvanvelzen created T6925: XHPAST is out of date on Windows.
Jan 9 2015, 10:46 PM · Windows, XHPAST

Jan 7 2015

epriestley closed T6885: XHPAST does not include modifiers in n_METHOD_DECLARATION's concrete string as Resolved.
Jan 7 2015, 1:59 PM · XHPAST
richardvanvelzen added a comment to T6885: XHPAST does not include modifiers in n_METHOD_DECLARATION's concrete string.

Yeah, it did indeed. D11268 does solve the issue correctly for me in all cases I tested.

Jan 7 2015, 1:42 PM · XHPAST
epriestley added a comment to T6885: XHPAST does not include modifiers in n_METHOD_DECLARATION's concrete string.

I expect that patch breaks this:

Jan 7 2015, 1:40 PM · XHPAST
epriestley added a revision to T6885: XHPAST does not include modifiers in n_METHOD_DECLARATION's concrete string: D11268: Extend nodes in both directions in XHPAST.
Jan 7 2015, 1:38 PM · XHPAST
richardvanvelzen added a comment to T6885: XHPAST does not include modifiers in n_METHOD_DECLARATION's concrete string.

FWIW, this patch fixes it for me

diff --git a/support/xhpast/parser.y b/support/xhpast/parser.y
index 1697c26..e07704b 100644
--- a/support/xhpast/parser.y
+++ b/support/xhpast/parser.y
@@ -1176,7 +1176,7 @@ class_statement:
     yyextra->expecting_xhp_class_statements = yyextra->old_expecting_xhp_class_statements;
Jan 7 2015, 1:06 PM · XHPAST
richardvanvelzen created T6885: XHPAST does not include modifiers in n_METHOD_DECLARATION's concrete string.
Jan 7 2015, 1:03 PM · XHPAST

Nov 12 2014

epriestley removed a project from T4725: `arc liberate` should throw when encountering (and eventually support) namespaces and traits: Badge Awarded.
Nov 12 2014, 1:10 PM · XHPAST, Arcanist

Oct 12 2014

joshuaspence triaged T6154: XHPAST fails to recognise some syntax errors as Normal priority.
Oct 12 2014, 8:08 PM · XHPAST

Sep 26 2014

joshuaspence added a comment to T6195: Replace XHPAST with a pure PHP implementation.

Here's a very basic test I did for profiling XHPAST against PHP-Parser:

Sep 26 2014, 8:37 AM · XHPAST
joshuaspence created T6195: Replace XHPAST with a pure PHP implementation.
Sep 26 2014, 8:35 AM · XHPAST

Sep 22 2014

richardvanvelzen added a comment to T6154: XHPAST fails to recognise some syntax errors.

A related case with try..catch..finally (see D10337) works in the same way as @epriestley described. However, in that case it's easy to fix. This may be less trivial, but still worth fixing.

Sep 22 2014, 8:42 PM · XHPAST

Sep 21 2014

epriestley added a comment to T6154: XHPAST fails to recognise some syntax errors.

This is not a syntax error, per se, in PHP -- the error would say something like "PHP Parse error: syntax error, unexpected 'final'..." if it was. I think it gets raised a little later on in the compile phase. So that's the technical reason why we don't detect it.

Sep 21 2014, 8:17 PM · XHPAST
joshuaspence claimed T6154: XHPAST fails to recognise some syntax errors.

I don't mind working on this, but I'm not sure what the correct fix is.

Sep 21 2014, 9:16 AM · XHPAST
joshuaspence updated subscribers of T6154: XHPAST fails to recognise some syntax errors.
Sep 21 2014, 9:16 AM · XHPAST
joshuaspence created T6154: XHPAST fails to recognise some syntax errors.
Sep 21 2014, 9:15 AM · XHPAST

Sep 12 2014

btrahan added projects to T4725: `arc liberate` should throw when encountering (and eventually support) namespaces and traits: Arcanist, XHPAST.
Sep 12 2014, 8:06 PM · XHPAST, Arcanist

Aug 22 2014

richardvanvelzen added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D10337: Correctly support try..catch..finally in xhpast.
Aug 22 2014, 12:50 PM · XHPAST

Aug 21 2014

richardvanvelzen added a comment to T4334: Support PHP5.4+ syntax in XHPAST.

@epriestley: could you take a look at the comment above? I'd push out a diff but for some reason the values of the tokens change when I rebuild xhpast.

Aug 21 2014, 9:57 AM · XHPAST