Page MenuHomePhabricator
Feed Advanced Search

Jun 16 2016

eadler added a project to T11150: ArcanistTextLinter: Support UTF8: Restricted Project.
Jun 16 2016, 6:26 PM · Restricted Project, Lint, Feature Request
epriestley merged T11155: Please add Linter for perl into T10038: Plan the mid-term pathway for unit-test/linter bindings.
Jun 16 2016, 10:41 AM · Lint, Arcanist
epriestley merged task T11155: Please add Linter for perl into T10038: Plan the mid-term pathway for unit-test/linter bindings.
Jun 16 2016, 10:41 AM · Lint, Arcanist, Feature Request
rehnathomas added a project to T11155: Please add Linter for perl: Lint.
Jun 16 2016, 7:06 AM · Lint, Arcanist, Feature Request

Jun 15 2016

johnny-bit added a comment to T11150: ArcanistTextLinter: Support UTF8.

Another, very legitimate example, would be diacritic characters in localized README (or other) files. Until UTF-8 support is not present in text linter, i simply have to disable linter for files that have words like "żółć" in them. Plus using ¯\_(ツ)_/¯ in doc would be beneficial to some 😉

Jun 15 2016, 4:01 PM · Restricted Project, Lint, Feature Request
avivey added a project to T11150: ArcanistTextLinter: Support UTF8: Lint.
Jun 15 2016, 12:15 AM · Restricted Project, Lint, Feature Request

Jun 8 2016

chad added projects to T11105: ExecFuture performs blocking reads on Windows, causing deadlocks with `arc lint`: Lint, Arcanist, Windows.
Jun 8 2016, 7:11 PM · Windows, Arcanist, Lint, Bug Report

May 21 2016

benmarten added a comment to T11001: Unrecognized lint message code "I003"..

Yes, but I is also reported by jsHint: https://github.com/jshint/jshint/blob/2.1.4/src/shared/messages.js#L195

May 21 2016, 7:12 PM · Lint, Bug Report
avivey added a comment to T11001: Unrecognized lint message code "I003"..

jshint linter only allow W and E prefixes - https://secure.phabricator.com/diffusion/ARC/browse/master/src/lint/linter/ArcanistJSHintLinter.php;2234c8cacc21ce61c9c10e8e5918b6a63cc38fc8$145

May 21 2016, 7:05 PM · Lint, Bug Report
chad added a project to T11001: Unrecognized lint message code "I003".: Lint.
May 21 2016, 6:52 PM · Lint, Bug Report

May 17 2016

joshuaspence added a subtask for T10971: php lint: catch `"${var}"` vs `"{$var}"`: T8049: Improve parsing of variables embedded in strings in XHPAST.
May 17 2016, 9:09 AM · XHPAST, Lint, Feature Request

May 16 2016

avivey renamed T10971: php lint: catch `"${var}"` vs `"{$var}"` from php lint: catch `"${var}"` vs `"{$var}" to php lint: catch `"${var}"` vs `"{$var}"`.
May 16 2016, 8:23 PM · XHPAST, Lint, Feature Request
avivey created T10971: php lint: catch `"${var}"` vs `"{$var}"`.
May 16 2016, 8:22 PM · XHPAST, Lint, Feature Request

May 15 2016

hach-que closed T8922: Clarify csharp linter requirements as Wontfix.

cslint is deprecated, see T8978.

May 15 2016, 5:45 AM · Lint, Documentation, Arcanist
hach-que closed T4483: ArcanistCSharpLinter not reporting linter warnings as Wontfix.

cslint is deprecated, see T8978 for more information.

May 15 2016, 5:40 AM · Lint, Arcanist

May 11 2016

jparise added a comment to T9030: Need specify the minimal version of each linter.

This is also a duplicate of T4954, which was fixed by the addition of per-linter version support in D14298.

May 11 2016, 4:12 PM · Lint

May 2 2016

chad added a project to T10731: Script-and-regex linter documentation does not make it clear enough that you really have to do what it says: Lint.
May 2 2016, 7:56 PM · Lint, Bug Report
chad added a project to T10817: Allow more characters for built-in `filename` linter: Lint.
May 2 2016, 6:57 PM · Lint, Feature Request

Apr 29 2016

eadler closed T10892: Recommend pip instead of easy_install for Python linters as Resolved by committing rARCc58f1b9a2507: Prefer pip to easy_install.
Apr 29 2016, 3:45 PM · Lint, Arcanist, Feature Request
eadler added a revision to T10038: Plan the mid-term pathway for unit-test/linter bindings: D15818: Prefer pip to easy_install.
Apr 29 2016, 4:57 AM · Lint, Arcanist
eadler added a revision to T10892: Recommend pip instead of easy_install for Python linters: D15818: Prefer pip to easy_install.
Apr 29 2016, 4:57 AM · Lint, Arcanist, Feature Request
eadler claimed T10892: Recommend pip instead of easy_install for Python linters.
Apr 29 2016, 4:55 AM · Lint, Arcanist, Feature Request

Apr 28 2016

tjstum created T10892: Recommend pip instead of easy_install for Python linters.
Apr 28 2016, 1:27 PM · Lint, Arcanist, Feature Request

Apr 20 2016

cburroughs moved T7780: Add linter for Foodcritic from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 20 2016, 3:56 PM · Restricted Project, Lint
cburroughs added a project to T7780: Add linter for Foodcritic: Restricted Project.
Apr 20 2016, 3:10 PM · Restricted Project, Lint

Mar 29 2016

maccath added a comment to T6653: Script and regex linter could use some examples.

For reference and the benefit of people Googling how to configure a script and regex linter, here is a full example (using sass-lint):

Mar 29 2016, 9:59 AM · Lint, Documentation, Arcanist

Mar 26 2016

epriestley closed T10365: Support passing generated annotation to ArcanistGeneratedLinter as Invalid.

We don't have enough information about this problem to design a solution, and haven't received more information in more than a month. See Describing Root Problems and Contributing Feature Requests for details on how to submit an actionable feature request.

Mar 26 2016, 7:08 PM · Feature Request (Needs Information), Lint

Mar 21 2016

chad updated the question details for Q336: Configuring lint when called as workflow procedure of arc diff.
Mar 21 2016, 2:03 PM · Arcanist, Lint
claudiomelis edited projects for Q336: Configuring lint when called as workflow procedure of arc diff, added: Arcanist (Milestone 1); removed Arcanist.
Mar 21 2016, 9:34 AM · Arcanist, Lint

Mar 16 2016

getaaron added a comment to T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver.

I don't know RuboCop well enough to definitively answer the question about whether that mode exists, or to volunteer to maintain the driver. But I opened a parallel issue in the RuboCop repo, so hopefully we'll find out whether RuboCop has this mode soon enough.

Mar 16 2016, 8:23 PM · Lint, Feature Request
epriestley added a comment to T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver.

Assuming this mode does not exist, the clearest pathway forward is for you or someone else to:

Mar 16 2016, 6:03 PM · Lint, Feature Request
epriestley added a comment to T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver.

Does RuboCop actually have a mode where it emits errors and replacement text?

Mar 16 2016, 5:59 PM · Lint, Feature Request
avivey added a project to T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver: Lint.
Mar 16 2016, 5:58 PM · Lint, Feature Request

Mar 10 2016

claudiomelis added a project to Q336: Configuring lint when called as workflow procedure of arc diff: Lint.
Mar 10 2016, 1:31 PM · Arcanist, Lint

Feb 23 2016

cspeckmim added a comment to T9886: Add Java linters, checkstyle and PMD.

I've been avoiding those tools as compiling our project for .class files requires a lengthy amount of time, which would be better integrated into our jenkins test runners.

Feb 23 2016, 2:38 AM · Restricted Project, Arcanist, Lint
avivey added a comment to T9886: Add Java linters, checkstyle and PMD.

It does require .class files - I run it in the CI along with the tests (And PMD).

Feb 23 2016, 2:01 AM · Restricted Project, Arcanist, Lint

Feb 22 2016

cspeckmim added a comment to T9886: Add Java linters, checkstyle and PMD.

I thought FindBugs required analysis of the .class files which I didn't think would make useful for linting, but perhaps as UT or something?

Feb 22 2016, 9:34 PM · Restricted Project, Arcanist, Lint

Feb 20 2016

epriestley moved T10365: Support passing generated annotation to ArcanistGeneratedLinter from Backlog to Needs Information on the Feature Request board.
Feb 20 2016, 12:37 PM · Feature Request (Needs Information), Lint

Feb 18 2016

chad added a project to T10365: Support passing generated annotation to ArcanistGeneratedLinter: Lint.
Feb 18 2016, 9:30 PM · Feature Request (Needs Information), Lint

Feb 14 2016

avivey added a comment to T9886: Add Java linters, checkstyle and PMD.

Findbugs produces HTML, so I've made it into remarkup at https://github.com/avivey/remarkup-java (In Community Resources).

Feb 14 2016, 10:45 PM · Restricted Project, Arcanist, Lint

Jan 30 2016

chad removed a project from T2077: Write CSS Linter: Arcanist.
Jan 30 2016, 4:46 AM · Lint

Jan 28 2016

avivey added a project to T10237: Pylint Linter fails on some specific python cases: Lint.
Jan 28 2016, 10:21 PM · Lint, Bug Report
Luke081515.2 updated the question details for Q291: Which lint script is it....?.
Jan 28 2016, 9:36 AM · Lint

Jan 27 2016

avivey updated the task description for T10038: Plan the mid-term pathway for unit-test/linter bindings.
Jan 27 2016, 1:51 AM · Lint, Arcanist

Jan 26 2016

Luke081515.2 updated Q291: Which lint script is it....? from to Which lint script is it....?.
Jan 26 2016, 9:29 PM · Lint
chad added projects to T10219: Show suggested lint autofix in Differential web view: Differential, Lint.
Jan 26 2016, 6:26 PM · Lint, Differential

Jan 14 2016

epriestley closed T10118: regex for parsing severity codes in ArcanistCppLinter is wrong as Resolved.

Resolved by D15019.

Jan 14 2016, 3:00 PM · Lint, Arcanist, Bug Report
epriestley renamed T10118: regex for parsing severity codes in ArcanistCppLinter is wrong from regex in ArcanistCppLinter is wrong to regex for parsing severity codes in ArcanistCppLinter is wrong.
Jan 14 2016, 2:59 PM · Lint, Arcanist, Bug Report
michaeloa added a comment to T10118: regex for parsing severity codes in ArcanistCppLinter is wrong.

Added a proposed patch. See additional comments in the diff.

Jan 14 2016, 2:58 PM · Lint, Arcanist, Bug Report
michaeloa added a revision to T10118: regex for parsing severity codes in ArcanistCppLinter is wrong: D15019: Minor fixes to arcanist cpplint.
Jan 14 2016, 2:53 PM · Lint, Arcanist, Bug Report

Jan 12 2016

epriestley merged task T10137: Add comments to .arclint json into T8258: Allow comments in JSON.
Jan 12 2016, 9:41 PM · Lint, Feature Request
chad added a project to T10137: Add comments to .arclint json: Lint.
Jan 12 2016, 9:25 PM · Lint, Feature Request
michaeloa added a comment to T10118: regex for parsing severity codes in ArcanistCppLinter is wrong.

That shouldn't be a problem. I'll take a look at doing something later in the week, time permitting.

Jan 12 2016, 9:07 PM · Lint, Arcanist, Bug Report
epriestley added a comment to T10118: regex for parsing severity codes in ArcanistCppLinter is wrong.

I'll upstream regex changes if they include unit tests.

Jan 12 2016, 1:35 PM · Lint, Arcanist, Bug Report
michaeloa added a comment to T10118: regex for parsing severity codes in ArcanistCppLinter is wrong.

Different (albeit related) bugs:

Jan 12 2016, 10:35 AM · Lint, Arcanist, Bug Report

Jan 11 2016

eadler moved T9957: Arcanist cpplint install information is out of date from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jan 11 2016, 9:42 PM · Restricted Project, Lint, Bug Report
eadler moved T9886: Add Java linters, checkstyle and PMD from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jan 11 2016, 9:42 PM · Restricted Project, Arcanist, Lint
eadler moved T9870: Include clang-format-lint as a linter from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jan 11 2016, 9:42 PM · Restricted Project, Lint, Arcanist
eadler moved T9846: Diff on `arc lint` misleading when the replacement has newlines from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jan 11 2016, 9:42 PM · Restricted Project, Arcanist, Lint
eadler moved T9749: `arc lint --only-new` doesn't work as expected from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jan 11 2016, 9:42 PM · Restricted Project, Lint, Arcanist
eadler added a project to T9749: `arc lint --only-new` doesn't work as expected: Restricted Project.
Jan 11 2016, 9:40 PM · Restricted Project, Lint, Arcanist
eadler added a project to T9846: Diff on `arc lint` misleading when the replacement has newlines: Restricted Project.
Jan 11 2016, 9:39 PM · Restricted Project, Arcanist, Lint
eadler added a project to T9870: Include clang-format-lint as a linter: Restricted Project.
Jan 11 2016, 9:39 PM · Restricted Project, Lint, Arcanist
eadler added a project to T9886: Add Java linters, checkstyle and PMD: Restricted Project.
Jan 11 2016, 9:39 PM · Restricted Project, Arcanist, Lint
eadler added a project to T9957: Arcanist cpplint install information is out of date: Restricted Project.
Jan 11 2016, 9:39 PM · Restricted Project, Lint, Bug Report
avivey added a comment to T10118: regex for parsing severity codes in ArcanistCppLinter is wrong.

Looks like you are already aware of T8404, and this is a dup; Why did you submit another ticket?

Jan 11 2016, 8:59 PM · Lint, Arcanist, Bug Report
michaeloa added a comment to T10038: Plan the mid-term pathway for unit-test/linter bindings.

This sounds awesome.

Jan 11 2016, 12:04 PM · Lint, Arcanist
michaeloa created T10118: regex for parsing severity codes in ArcanistCppLinter is wrong.
Jan 11 2016, 11:59 AM · Lint, Arcanist, Bug Report

Jan 6 2016

jra3 added a revision to T8404: Running the cpplint linter through arcanist no longer works: D14960: Fix cpplint message regex.
Jan 6 2016, 5:59 PM · Lint, Arcanist

Jan 2 2016

cspeckmim added a comment to T9886: Add Java linters, checkstyle and PMD.

I renamed the task to indicate specifically which linters are being asked for, so as not to just request generic "Java" ones. Initially this task was just for checkstyle, but after I got it working in D14632 I decided to give PMD a shot as well. In hindsight it probably would have been beneficial to keep them separate, though there is a dependency on some changes in order to get a java jar to run as a linter. Let me know if you prefer them to be separated to different revisions/tasks.

Jan 2 2016, 1:39 AM · Restricted Project, Arcanist, Lint
cspeckmim renamed T9886: Add Java linters, checkstyle and PMD from Add linters for Java to Add Java linters, checkstyle and PMD.
Jan 2 2016, 1:23 AM · Restricted Project, Arcanist, Lint

Dec 22 2015

epriestley added a comment to T10038: Plan the mid-term pathway for unit-test/linter bindings.

Basically all of this also applies to Unit binders, right?

Dec 22 2015, 6:18 PM · Lint, Arcanist
johnny-bit added a comment to T10038: Plan the mid-term pathway for unit-test/linter bindings.

Given how much of a backlog there is here and how slowly I've been able to move through it historically, my initial thought is that there may be no mid-term and T5055 is the pathway forward.

Although T5055 is a large amount of work, it helps us in the long term, while work against these issues directly does not, and I suspect T5055 is more like 10x more work than dealing with all this stuff directly rather than, say, 100x more work.

Dec 22 2015, 5:36 PM · Lint, Arcanist
avivey added a comment to T10038: Plan the mid-term pathway for unit-test/linter bindings.

Basically all of this also applies to Unit binders, right?

Dec 22 2015, 5:30 PM · Lint, Arcanist
cspeckmim added a comment to T10038: Plan the mid-term pathway for unit-test/linter bindings.

One of my first thoughts was similar to @cburroughs', that developing phabricator extensions with the phabricator community could be helpful/fun. However managing that seems like it wouldn't come "for free" and would involve non-insignificant maintenance.

Dec 22 2015, 5:00 PM · Lint, Arcanist
epriestley added a comment to T10038: Plan the mid-term pathway for unit-test/linter bindings.

Do you see there being a "Blessed" foo-linter (maybe as a repo on this instance?), or will there be multiple foo-tributes fending themselves in the wilds of github?

Dec 22 2015, 3:36 PM · Lint, Arcanist
cburroughs added a comment to T10038: Plan the mid-term pathway for unit-test/linter bindings.

Do you see there being a "Blessed" foo-linter (maybe as a repo on this instance?), or will there be multiple foo-tributes fending themselves in the wilds of github? At least one nice thing about having linters upstream is that you get to use phabricator (including arc lint!) to develop them.

Dec 22 2015, 2:49 PM · Lint, Arcanist
epriestley added a comment to T10038: Plan the mid-term pathway for unit-test/linter bindings.

Given how much of a backlog there is here and how slowly I've been able to move through it historically, my initial thought is that there may be no mid-term and T5055 is the pathway forward.

Dec 22 2015, 1:22 PM · Lint, Arcanist
epriestley updated the task description for T10038: Plan the mid-term pathway for unit-test/linter bindings.
Dec 22 2015, 1:07 PM · Lint, Arcanist
epriestley updated the task description for T10038: Plan the mid-term pathway for unit-test/linter bindings.
Dec 22 2015, 12:59 PM · Lint, Arcanist
epriestley moved T4483: ArcanistCSharpLinter not reporting linter warnings from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:47 PM · Lint, Arcanist
epriestley moved T4701: Linter for <?hh code from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:47 PM · Lint, Arcanist
epriestley moved T6867: Add linter and unit test engine for Go(lang) from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:47 PM · Lint
epriestley moved T7170: Support beta versions of PHP Code Sniffer from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:47 PM · Lint
epriestley moved T7293: Add support for ansible-lint from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:47 PM · Arcanist, Lint
epriestley moved T7780: Add linter for Foodcritic from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:46 PM · Restricted Project, Lint
epriestley moved T8404: Running the cpplint linter through arcanist no longer works from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:46 PM · Lint, Arcanist
epriestley moved T8474: Fix linter severity customization from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:46 PM · Lint
epriestley moved T8495: Write a linter wrapper for PHPDCD from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:46 PM · Lint
epriestley moved T8492: Add a lint wrapper for PHPMD from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:46 PM · Lint
epriestley moved T8506: LESS Linter does not use path in linter message from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:46 PM · Lint
epriestley moved T8922: Clarify csharp linter requirements from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:46 PM · Lint, Documentation, Arcanist
epriestley moved T8978: cslint, used by CSharpArcanistLinter, will be deprecated and replaced in the future from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:46 PM · Lint, Arcanist
epriestley moved T9047: arc lint can not find php and phpcs from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Windows, Lint, Arcanist
epriestley moved T7653: XUnitTestEngine ignores failures for xUnit 2.0 from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Lint
epriestley moved T9262: Community and Upstream interests for a flowtype linter from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Lint
epriestley moved T9518: In diff summary linting error code shown instead of message, when PHP_CodeSniffer linter was used from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Lint
epriestley moved T9957: Arcanist cpplint install information is out of date from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Restricted Project, Lint, Bug Report
epriestley moved T9734: Cppcheck linter seems to show warnings from other files from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Lint, Arcanist
epriestley moved T9785: Add ESLint Linter from Backlog to Bindings on the Lint board.
Dec 22 2015, 12:45 PM · Lint