Page MenuHomePhabricator
Feed Advanced Search

Jan 24 2016

chad updated the image for ApplicationSearch from F176125: profile-project.png to F1068545: profile.
Jan 24 2016, 5:42 AM

Jan 22 2016

pilsetnieks added a comment to T10188: Maniphest Advanced Search exhibits weird paging behavior when non-default grouping and ordering is used.

I've retested everything here and in my installation and it seems that this solves all cases re: grouping, ordering, and paging.

Jan 22 2016, 3:11 PM · Maniphest, ApplicationSearch, Bug Report

Jan 21 2016

epriestley added a comment to T10188: Maniphest Advanced Search exhibits weird paging behavior when non-default grouping and ordering is used.

I think case (1) (and maybe cases (3) and (4)) is resolved at HEAD.

Jan 21 2016, 7:15 PM · Maniphest, ApplicationSearch, Bug Report
epriestley added a revision to T10188: Maniphest Advanced Search exhibits weird paging behavior when non-default grouping and ordering is used: D15076: Fix an issue with paginating queries which reverse vector ordering components.
Jan 21 2016, 6:39 PM · Maniphest, ApplicationSearch, Bug Report
chad added projects to T10188: Maniphest Advanced Search exhibits weird paging behavior when non-default grouping and ordering is used: ApplicationSearch, Maniphest.
Jan 21 2016, 4:47 PM · Maniphest, ApplicationSearch, Bug Report

Jan 8 2016

eadler moved T8690: Modernize PhabricatorCommitSearchEngine from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jan 8 2016, 10:40 PM · Audit, Restricted Project, ApplicationSearch, Diffusion
eadler added a project to T8690: Modernize PhabricatorCommitSearchEngine: Restricted Project.
Jan 8 2016, 10:36 PM · Audit, Restricted Project, ApplicationSearch, Diffusion

Dec 23 2015

chad changed the edit policy for ApplicationSearch.
Dec 23 2015, 12:40 AM

Dec 21 2015

epriestley added a comment to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).

D14846 should fix the package case, but I'm going to leave this open for followup work: Files, Pastes, Maniphest should get indexes; and we should replace the powerful systems in Projects and People.

Dec 21 2015, 9:08 PM · Owners, Files, ApplicationSearch
epriestley added a revision to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles): D14846: Implement basic ngram search for Owners Package names.
Dec 21 2015, 9:07 PM · Owners, Files, ApplicationSearch
epriestley added a comment to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).

As general infrastructure cleanup, I would like to split the existing SearchEngine and DestructionEngine components apart...
As part of this cleanup, we should also fix T9890.

Dec 21 2015, 7:25 PM · Owners, Files, ApplicationSearch
epriestley added a revision to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles): D14843: Rename "SearchEngine" to "FulltextStorageEngine".
Dec 21 2015, 6:29 PM · Owners, Files, ApplicationSearch
epriestley added a revision to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles): D14842: Convert all "DocumentIndexers" into "FulltextEngines".
Dec 21 2015, 6:18 PM · Owners, Files, ApplicationSearch
epriestley added a revision to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles): D14841: Lift Conpherence indexing up out of the Fulltext index.
Dec 21 2015, 5:56 PM · Owners, Files, ApplicationSearch
epriestley added a revision to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles): D14837: Modularize transaction/comment indexing in the FulltextEngine.
Dec 21 2015, 3:23 PM · Owners, Files, ApplicationSearch
epriestley added a revision to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles): D14836: Remove TYPE_SEARCH_DIDUPDATEINDEX event.
Dec 21 2015, 2:58 PM · Owners, Files, ApplicationSearch
epriestley added a revision to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles): D14835: Modularize fulltext indexing of Projects, Subscriptions and Custom Fields.
Dec 21 2015, 2:49 PM · Owners, Files, ApplicationSearch
epriestley added a revision to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles): D14834: Begin improving modularity of IndexEngine, add locks.
Dec 21 2015, 1:50 PM · Owners, Files, ApplicationSearch

Dec 20 2015

epriestley added a revision to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles): D14832: Fully modularize DestructionEngine.
Dec 20 2015, 4:33 PM · Owners, Files, ApplicationSearch
epriestley added a revision to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles): D14831: Prepare DestructionEngine to be modularized.
Dec 20 2015, 3:54 PM · Owners, Files, ApplicationSearch

Dec 17 2015

epriestley added a parent task for T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles): T6721: Would like ability to search tasks by title.
Dec 17 2015, 4:41 PM · Owners, Files, ApplicationSearch
epriestley renamed T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles) from Plan the future of string-within-string searches to Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).
Dec 17 2015, 4:40 PM · Owners, Files, ApplicationSearch

Dec 16 2015

epriestley added a comment to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).

Maybe IndexEngine is a better name than FulltextEngine.

Dec 16 2015, 11:48 PM · Owners, Files, ApplicationSearch
epriestley added a comment to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).

Upshot is that this seems very promising to me. I think the pathway forward here is something like:

Dec 16 2015, 11:47 PM · Owners, Files, ApplicationSearch
epriestley added a comment to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).

Okay, here's a query script:

Dec 16 2015, 11:36 PM · Owners, Files, ApplicationSearch
epriestley added a comment to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).

I created an ngrams table like this:

Dec 16 2015, 11:11 PM · Owners, Files, ApplicationSearch
epriestley added a comment to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).

Try the dedicated table on the files dataset and see how happy MySQL is about that (if it's better but still not great, we might still do this in conjunction with bigrams/trigrams).

Dec 16 2015, 10:52 PM · Owners, Files, ApplicationSearch
epriestley updated the task description for T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).
Dec 16 2015, 9:48 PM · Owners, Files, ApplicationSearch

Dec 14 2015

nickz added a comment to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).

Thanks for thinking through all of these! Let me know if there is anything I can help with.

Dec 14 2015, 5:29 PM · Owners, Files, ApplicationSearch
epriestley created T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).
Dec 14 2015, 11:50 AM · Owners, Files, ApplicationSearch

Dec 11 2015

epriestley renamed T7216: Make it easier to update the ApplicationSearch saved query used by a dashboard panel from Support Editing Queries to Make it easier to update the query a Dashboard panel uses.
Dec 11 2015, 12:39 PM · Dashboards

Nov 24 2015

epriestley updated subscribers of T7805: Use ApplicationSearch in the ObjectSelector dialog.
Nov 24 2015, 6:52 PM · Restricted Project, Restricted Project, ApplicationSearch

Sep 23 2015

chad closed T9388: Convert Phame to ApplicationSearch as Resolved by committing rPbe9cc235b2ed: Add Application Routes to Phame AppSearch queries.
Sep 23 2015, 7:48 PM · ApplicationSearch, Dashboards, Phame
chad added a revision to T9388: Convert Phame to ApplicationSearch: D14146: Add Application Routes to Phame AppSearch queries.
Sep 23 2015, 6:52 PM · ApplicationSearch, Dashboards, Phame

Sep 10 2015

chad removed a subtask for T9388: Convert Phame to ApplicationSearch: T9360: Unbeta Phame.
Sep 10 2015, 3:32 PM · ApplicationSearch, Dashboards, Phame
chad added a subtask for T9388: Convert Phame to ApplicationSearch: T9360: Unbeta Phame.
Sep 10 2015, 3:32 PM · ApplicationSearch, Dashboards, Phame
chad added a comment to T9388: Convert Phame to ApplicationSearch.

at least, I think I converted it all the way.

Sep 10 2015, 3:18 PM · ApplicationSearch, Dashboards, Phame
chad added a comment to T9388: Convert Phame to ApplicationSearch.

Phame is on ApplicationSearch, so the bug is something else.

Sep 10 2015, 3:16 PM · ApplicationSearch, Dashboards, Phame
epriestley added a project to T9388: Convert Phame to ApplicationSearch: ApplicationSearch.
Sep 10 2015, 1:05 PM · ApplicationSearch, Dashboards, Phame

Sep 9 2015

epriestley added a parent task for T9372: Plan the future of "Bucketing" Query UIs: T9367: Add another accept state for code review.
Sep 9 2015, 11:11 PM · Restricted Project, Audit, ApplicationSearch, Differential
epriestley created T9372: Plan the future of "Bucketing" Query UIs.
Sep 9 2015, 6:34 PM · Restricted Project, Audit, ApplicationSearch, Differential

Aug 6 2015

chad added a comment to T9086: Hide "Edit Query" if there are no fields to search on.

I couldn't think of any non prototypes. Dashboards recently got them.

Aug 6 2015, 1:11 AM · ApplicationSearch
epriestley added a comment to T9086: Hide "Edit Query" if there are no fields to search on.

Some SearchEngines don't provide any fields.

Aug 6 2015, 1:05 AM · ApplicationSearch
chad added a comment to T9086: Hide "Edit Query" if there are no fields to search on.

We should always have something to search, otherwise there isn't a reason to use application search.

Aug 6 2015, 1:03 AM · ApplicationSearch
chad closed T9086: Hide "Edit Query" if there are no fields to search on as Wontfix.
Aug 6 2015, 1:02 AM · ApplicationSearch

Aug 5 2015

joshuaspence updated the task description for T9086: Hide "Edit Query" if there are no fields to search on.
Aug 5 2015, 11:44 PM · ApplicationSearch
joshuaspence created T9086: Hide "Edit Query" if there are no fields to search on.
Aug 5 2015, 11:42 PM · ApplicationSearch
epriestley closed T2628: Add project tags to Pholio, Ponder, Differential, and other applications, a subtask of T5595: Allow all applications to filter results by project, as Resolved.
Aug 5 2015, 8:59 PM · ApplicationSearch, Projects

Jul 7 2015

epriestley closed T8774: Crash when viewing search with viewer() while logged out as Resolved by committing rP1a001ca03379: Render ApplicationSearch errors correctly.
Jul 7 2015, 6:52 PM · ApplicationSearch
epriestley triaged T8774: Crash when viewing search with viewer() while logged out as Normal priority.
Jul 7 2015, 12:56 PM · ApplicationSearch

Jun 29 2015

epriestley renamed T8690: Modernize PhabricatorCommitSearchEngine from Ability to query commits to Modernize PhabricatorCommitSearchEngine.
Jun 29 2015, 1:58 PM · Audit, Restricted Project, ApplicationSearch, Diffusion

May 22 2015

epriestley added a comment to T7805: Use ApplicationSearch in the ObjectSelector dialog.

In related tasks:

May 22 2015, 3:40 PM · Restricted Project, Restricted Project, ApplicationSearch
epriestley added a parent task for T7805: Use ApplicationSearch in the ObjectSelector dialog: T3562: Design Meme/Macro Picker.
May 22 2015, 3:39 PM · Restricted Project, Restricted Project, ApplicationSearch
epriestley renamed T7805: Use ApplicationSearch in the ObjectSelector dialog from Attaching recently closed Differential revision to a Maniphest task to Use ApplicationSearch in the ObjectSelector dialog.
May 22 2015, 2:53 PM · Restricted Project, Restricted Project, ApplicationSearch
epriestley added a parent task for T7805: Use ApplicationSearch in the ObjectSelector dialog: T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.
May 22 2015, 2:50 PM · Restricted Project, Restricted Project, ApplicationSearch

May 20 2015

angie added a project to T7805: Use ApplicationSearch in the ObjectSelector dialog: Restricted Project.
May 20 2015, 3:57 AM · Restricted Project, Restricted Project, ApplicationSearch

May 7 2015

epriestley closed T8105: Diffusion search for "not in project" doesn't work as Resolved by committing rP1c399476798f: Fix "not(project)" in Diffusion.
May 7 2015, 5:16 PM · ApplicationSearch, Diffusion
epriestley added a comment to T8105: Diffusion search for "not in project" doesn't work.

Thanks for the report!

May 7 2015, 12:22 PM · ApplicationSearch, Diffusion
epriestley claimed T8105: Diffusion search for "not in project" doesn't work.
May 7 2015, 12:22 PM · ApplicationSearch, Diffusion
epriestley added a revision to T8105: Diffusion search for "not in project" doesn't work: D12746: Fix "not(project)" in Diffusion.
May 7 2015, 12:21 PM · ApplicationSearch, Diffusion
chad added projects to T8105: Diffusion search for "not in project" doesn't work: Diffusion, ApplicationSearch.
May 7 2015, 4:10 AM · ApplicationSearch, Diffusion

Apr 29 2015

chad closed T7980: Allow application search to search by "is deprecated" as Wontfix.

We don't plan to pursue this in the upstream. Recommend subscribing to the Changelog to keep up with when things leave prototype.

Apr 29 2015, 6:45 AM · ApplicationSearch, Applications
eadler created T7980: Allow application search to search by "is deprecated".
Apr 29 2015, 6:20 AM · ApplicationSearch, Applications

Apr 23 2015

epriestley lowered the priority of T6187: Allow query results to be exported to spreadsheet rendered in the browser from Normal to Wishlist.
Apr 23 2015, 7:27 PM · ApplicationSearch
epriestley added a comment to T6187: Allow query results to be exported to spreadsheet rendered in the browser.

T5307 discusses finding some way to fit "Export to spreadsheet.." -- and various other options -- into the UI in the general case.

Apr 23 2015, 7:27 PM · ApplicationSearch
epriestley added a subtask for T6187: Allow query results to be exported to spreadsheet rendered in the browser: T5307: UX for taking actions with search results.
Apr 23 2015, 7:27 PM · ApplicationSearch
epriestley added a comment to T6187: Allow query results to be exported to spreadsheet rendered in the browser.

We're vanishingly unlikely to redesign search results in the general case, and this request isn't compatible with responsive "object" list search results.

Apr 23 2015, 7:26 PM · ApplicationSearch
epriestley renamed T6187: Allow query results to be exported to spreadsheet rendered in the browser from Make ApplicationSearch better on large result sets to Allow query results to be exported to spreadsheet rendered in the browser.
Apr 23 2015, 7:22 PM · ApplicationSearch
epriestley closed T5595: Allow all applications to filter results by project as Resolved.

Diffusion, Pholio, Differential and Maniphest now support generic, full-power modern project filtering. I think that covers all the applications we're aware of significant interest in for this feature. It will come to other applications as they get modernized and updated over time.

Apr 23 2015, 7:12 PM · ApplicationSearch, Projects
epriestley closed T4100: Support query parameterization in typeaheads, a subtask of T5595: Allow all applications to filter results by project, as Resolved.
Apr 23 2015, 7:08 PM · ApplicationSearch, Projects
epriestley added a revision to T5595: Allow all applications to filter results by project: D12533: Support tokenizer functions in Diffusion.
Apr 23 2015, 3:26 PM · Projects, ApplicationSearch
epriestley added a revision to T5595: Allow all applications to filter results by project: D12531: Parameterize search in Pholio.
Apr 23 2015, 3:05 PM · Projects, ApplicationSearch

Apr 18 2015

epriestley added a revision to T5595: Allow all applications to filter results by project: D12463: Implement function-driven logical project queries in Differential.
Apr 18 2015, 6:39 PM · Projects, ApplicationSearch
epriestley added a revision to T5595: Allow all applications to filter results by project: D12462: Make "user's projects" a logical datasource and add viewerprojects().
Apr 18 2015, 6:17 PM · Projects, ApplicationSearch
epriestley added a revision to T5595: Allow all applications to filter results by project: D12460: Implement a project logic datasource.
Apr 18 2015, 5:23 PM · Projects, ApplicationSearch
epriestley added a revision to T5595: Allow all applications to filter results by project: D12455: Add "Edge Logic" support to PolicyAwareQuery.
Apr 18 2015, 3:07 PM · Projects, ApplicationSearch
epriestley added a revision to T5595: Allow all applications to filter results by project: D12454: Provide more buildXClause() and buildXClauseParts() on PolicyAwareQuery.
Apr 18 2015, 2:52 PM · Projects, ApplicationSearch
epriestley added a revision to T5595: Allow all applications to filter results by project: D12453: Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery.
Apr 18 2015, 2:38 PM · Projects, ApplicationSearch

Apr 13 2015

btrahan closed T7815: Conpherence threads ordering messed up; perf maybe too bad now too? as Resolved by committing rPf12839ffd414: Conpherenece - improve performance by not fetching data as often from D12347.
Apr 13 2015, 7:43 PM · ApplicationSearch, Conpherence
btrahan added a revision to T7815: Conpherence threads ordering messed up; perf maybe too bad now too?: D12399: Conpherenece - improve performance by not fetching data as often from D12347.
Apr 13 2015, 7:42 PM · ApplicationSearch, Conpherence
epriestley reassigned T7815: Conpherence threads ordering messed up; perf maybe too bad now too? from epriestley to btrahan.

Looks like you've got the other half of this.

Apr 13 2015, 7:42 PM · ApplicationSearch, Conpherence
btrahan added a comment to T7815: Conpherence threads ordering messed up; perf maybe too bad now too?.

perfypoo diff in a sec

Apr 13 2015, 7:36 PM · ApplicationSearch, Conpherence
chad added a comment to T7815: Conpherence threads ordering messed up; perf maybe too bad now too?.

well ?.

Apr 13 2015, 7:35 PM · ApplicationSearch, Conpherence
epriestley added a revision to T7815: Conpherence threads ordering messed up; perf maybe too bad now too?: D12398: Fix Conpherence transaction ordering.
Apr 13 2015, 7:33 PM · ApplicationSearch, Conpherence
epriestley added a comment to T7815: Conpherence threads ordering messed up; perf maybe too bad now too?.

Oh, well the "upside down" part at least.

Apr 13 2015, 7:31 PM · ApplicationSearch, Conpherence
epriestley claimed T7815: Conpherence threads ordering messed up; perf maybe too bad now too?.

yeah this is 100% me

Apr 13 2015, 7:31 PM · ApplicationSearch, Conpherence
btrahan created T7815: Conpherence threads ordering messed up; perf maybe too bad now too?.
Apr 13 2015, 7:31 PM · ApplicationSearch, Conpherence

Apr 11 2015

epriestley added a comment to T7805: Use ApplicationSearch in the ObjectSelector dialog.
  • Using ApplicationSearch here is roughly 8 hours of work.
  • We'd like to ship that first and see how it feels, but if we need to provide separate ordering/filtering for queries in this dialog vs queries in general that's probably 2-3 hours.
Apr 11 2015, 3:40 PM · Restricted Project, Restricted Project, ApplicationSearch
epriestley updated subscribers of T7805: Use ApplicationSearch in the ObjectSelector dialog.
Apr 11 2015, 3:37 PM · Restricted Project, Restricted Project, ApplicationSearch
epriestley added a comment to T7805: Use ApplicationSearch in the ObjectSelector dialog.

Ah, thanks! I'm just going to merge that here since I think this is more complete than that one, now.

Apr 11 2015, 3:37 PM · Restricted Project, Restricted Project, ApplicationSearch
hach-que added a comment to T7805: Use ApplicationSearch in the ObjectSelector dialog.

The other task that had this discussion is T4002: The "Edit Dependencies" dialog should use the saved search architecture.

Apr 11 2015, 12:23 PM · Restricted Project, Restricted Project, ApplicationSearch
epriestley added a project to T7805: Use ApplicationSearch in the ObjectSelector dialog: ApplicationSearch.
Apr 11 2015, 9:44 AM · Restricted Project, Restricted Project, ApplicationSearch

Mar 30 2015

chad added a comment to T7701: Surface Code/File search better in Diffusion.

We don't know if you'd be able to see them (vpn, policies). There is a task somewhere.

Mar 30 2015, 8:57 PM · Restricted Project, Design, Diffusion
joshuaspence added a comment to T7701: Surface Code/File search better in Diffusion.

On an unrelated note... Is there a reason why {Fxxx} doesn't show the image content in emails?

Mar 30 2015, 8:56 PM · Restricted Project, Design, Diffusion
chad added a comment to T7701: Surface Code/File search better in Diffusion.

It is terribly hidden.

Mar 30 2015, 8:55 PM · Restricted Project, Design, Diffusion
joshuaspence added a comment to T7701: Surface Code/File search better in Diffusion.

Oh wow, I've never seen that before.

Mar 30 2015, 8:55 PM · Restricted Project, Design, Diffusion
chad added a comment to T7701: Surface Code/File search better in Diffusion.

We should probably surface this better?

Mar 30 2015, 8:53 PM · Restricted Project, Design, Diffusion
joshuaspence created T7701: Surface Code/File search better in Diffusion.
Mar 30 2015, 8:51 PM · Restricted Project, Design, Diffusion

Feb 8 2015

chad edited projects for T7216: Make it easier to update the ApplicationSearch saved query used by a dashboard panel, added: ApplicationSearch; removed Maniphest.
Feb 8 2015, 10:32 PM · Dashboards
chad merged task T7217: Support Creating / Editing Custom Queries Inline in Dashboard into T5307: UX for taking actions with search results.
Feb 8 2015, 10:32 PM · Dashboards, ApplicationSearch