Page MenuHomePhabricator
Feed Advanced Search

Jul 22 2015

chad added a comment to T8924: Add push notification support.

I think that's maybe better resolved with T7004. My concern is this solves no new problems (or problems we're already tracking and would resolve in other ways). I prefer email notifications when out and about on my phone since they contain more information and are easily replied to. Push Notifications seems like a step backwards from a usability perspective.

Jul 22 2015, 5:21 PM · Notifications
richardvanvelzen added a comment to T8924: Add push notification support.

I have email notifications disabled wherever possible. When I shut down my computer, it'd be super useful to be able to get push notifications to my phone.

Jul 22 2015, 5:12 PM · Notifications
chad added a comment to T8924: Add push notification support.

What problem does Push Notifications solve that other notification mechanics, like say email or desktop notifications, don't solve? I'm not saying we'll never do this, just it seems exceedingly complex and generally marginal actual value.

Jul 22 2015, 4:16 PM · Notifications
eadler added a project to T8924: Add push notification support: Notifications.
Jul 22 2015, 6:22 AM · Notifications

Jul 21 2015

swisspol added a comment to T8880: Task creation form is reset if marking all tasks as read from notification menu.

Actually the same problem if you are looking at the result of a query in Maniphest, so it's a generic problem.

Jul 21 2015, 1:38 AM · Notifications, Maniphest

Jul 19 2015

joshuaspence renamed T8883: Allow desktop notifications to replace normal notifications from Allow desktop notifications to replacement normal notifications to Allow desktop notifications to replace normal notifications.
Jul 19 2015, 12:51 AM · Notifications
joshuaspence added a comment to T8878: Make desktop notifications more discoverable.
In T8878#126901, @chad wrote:

I'd rather over-engineer a more generalized "new in phabricator" type feature, so people understand what new functionality was added since their last update.

Jul 19 2015, 12:50 AM · User Preferences, Notifications

Jul 18 2015

chad added a comment to T8878: Make desktop notifications more discoverable.

Safari's Push Notifications for Websites, for example, sounds pretty awesome.

Jul 18 2015, 6:39 PM · User Preferences, Notifications
chad added a comment to T8878: Make desktop notifications more discoverable.

I don't think desktop notifications in it's current state is worth additional touting (it doesn't do Conpherence, for example). Even if it were, I'd rather over-engineer a more generalized "new in phabricator" type feature, so people understand what new functionality was added since their last update.

Jul 18 2015, 6:36 PM · User Preferences, Notifications
tycho.tatitscheff added a comment to T8878: Make desktop notifications more discoverable.

The slack way of doing think can be a possibility, no ?

pasted_file (289×640 px, 63 KB)

Jul 18 2015, 5:02 PM · User Preferences, Notifications
sshannin added a comment to T8878: Make desktop notifications more discoverable.

Woah, same thing for me. Had no idea.

Jul 18 2015, 1:54 PM · User Preferences, Notifications
avivey added a comment to T8883: Allow desktop notifications to replace normal notifications.

When we do this, I think I'd like to keep the persistent "This page has been updated" notice.

Jul 18 2015, 6:42 AM · Notifications
chad added a comment to T8878: Make desktop notifications more discoverable.

Did you have something specific in mind? It feels about right to me. "New" settings are always going to be somewhat under-discovered.

Jul 18 2015, 4:33 AM · User Preferences, Notifications
chad added projects to T8880: Task creation form is reset if marking all tasks as read from notification menu: Maniphest, Notifications.
Jul 18 2015, 3:44 AM · Notifications, Maniphest
joshuaspence created T8883: Allow desktop notifications to replace normal notifications.
Jul 18 2015, 2:36 AM · Notifications
joshuaspence created T8878: Make desktop notifications more discoverable.
Jul 18 2015, 1:57 AM · User Preferences, Notifications

Jul 14 2015

chad created T8846: Unable to turn off Desktop Notifications.
Jul 14 2015, 8:11 PM · Notifications

Jul 8 2015

chad removed a member for Notifications: chad.
Jul 8 2015, 7:42 PM

Jul 7 2015

chad closed T8769: Test notifications fail to leave as Wontfix.

I can't think a better means of handling this, and at least if you're an admin testing notifications, it seems more important that they're easily found and not automagically dismissed.

Jul 7 2015, 1:55 PM · Notifications

Jul 6 2015

chad renamed T8769: Test notifications fail to leave from Test notifications fail to leave. to Test notifications fail to leave.
Jul 6 2015, 10:05 PM · Notifications

Jul 3 2015

epriestley closed T8631: Straighten out the fetch plan for feed stories as Resolved.

This seems to be stable now, I don't immediately see any more ridiculously dumb slow stuff in the /feed/ profile. Remarkup handle fetches are still a bit loopy but that's a topic for another task.

Jul 3 2015, 4:21 PM · Notifications, Feed, Performance

Jul 1 2015

epriestley closed T8731: Logged out secure.phabricator.com feed error, a subtask of T8631: Straighten out the fetch plan for feed stories, as Resolved.
Jul 1 2015, 10:07 PM · Notifications, Feed, Performance
epriestley added a subtask for T8631: Straighten out the fetch plan for feed stories: T8731: Logged out secure.phabricator.com feed error.
Jul 1 2015, 5:53 PM · Notifications, Feed, Performance

Jun 30 2015

nateguchi2 added a comment to T8723: Issue with project description notification being too long.

Cheers!

Jun 30 2015, 2:16 PM · Notifications, Projects
epriestley closed T8723: Issue with project description notification being too long as Resolved by committing rP12c6e63d5bad: Don't put the entire corpus into project edit feed stories.
Jun 30 2015, 1:05 PM · Notifications, Projects
epriestley added a revision to T8723: Issue with project description notification being too long: D13485: Don't put the entire corpus into project edit feed stories.
Jun 30 2015, 12:43 PM · Notifications, Projects
nateguchi2 created T8723: Issue with project description notification being too long.
Jun 30 2015, 10:36 AM · Notifications, Projects

Jun 29 2015

epriestley added a revision to T8631: Straighten out the fetch plan for feed stories: D13480: Cache remarkup engines in Feed.
Jun 29 2015, 10:18 PM · Notifications, Feed, Performance
epriestley added a revision to T8631: Straighten out the fetch plan for feed stories: D13479: Dramatically increase cache hit rate for feed.
Jun 29 2015, 10:16 PM · Notifications, Feed, Performance
epriestley added a revision to T8631: Straighten out the fetch plan for feed stories: D13476: Don't try to load profile images for projects with no profile image.
Jun 29 2015, 9:52 PM · Notifications, Feed, Performance
epriestley claimed T8631: Straighten out the fetch plan for feed stories.
Jun 29 2015, 9:50 PM · Notifications, Feed, Performance

Jun 26 2015

chad added a comment to T8682: Commit hooks should have better notification options for committers.

Also, Herald is intentionally stronger than self-actions.

Jun 26 2015, 1:43 PM · Notifications, Herald
epriestley triaged T8682: Commit hooks should have better notification options for committers as Wishlist priority.
Jun 26 2015, 1:33 PM · Notifications, Herald
epriestley added a comment to T8682: Commit hooks should have better notification options for committers.

This is a very niche use case. It also tends to conflate the pusher (who we may not know, for imported repositories), the committer, and the author. This makes me hesitant about implementing it.

Jun 26 2015, 1:31 PM · Notifications, Herald
hartman created T8682: Commit hooks should have better notification options for committers.
Jun 26 2015, 11:52 AM · Notifications, Herald

Jun 23 2015

qgil created T8649: When unsubscribing from task via email, Phab mail notification said a comment was left, but none was.
Jun 23 2015, 7:11 PM · Notifications

Jun 21 2015

epriestley created T8631: Straighten out the fetch plan for feed stories.
Jun 21 2015, 11:31 AM · Notifications, Feed, Performance

Jun 16 2015

btrahan closed T8524: Email preferences doesn't contain an entry for Project Subscriber updates as Resolved by committing rP8965c7ec9b89: Email Preferences - round out options for Projects and Phriction.
Jun 16 2015, 9:24 PM · FreeBSD, Wikimedia, Notifications
btrahan added a revision to T8524: Email preferences doesn't contain an entry for Project Subscriber updates: D13313: Email Preferences - round out options for Projects and Phriction.
Jun 16 2015, 9:22 PM · FreeBSD, Wikimedia, Notifications
btrahan claimed T8524: Email preferences doesn't contain an entry for Project Subscriber updates.
Jun 16 2015, 9:21 PM · FreeBSD, Wikimedia, Notifications

Jun 14 2015

eadler moved T8524: Email preferences doesn't contain an entry for Project Subscriber updates from Backlog to Nits on the FreeBSD board.
Jun 14 2015, 4:36 AM · FreeBSD, Wikimedia, Notifications
eadler added a project to T8524: Email preferences doesn't contain an entry for Project Subscriber updates: FreeBSD.
Jun 14 2015, 4:35 AM · FreeBSD, Wikimedia, Notifications

Jun 13 2015

Krenair added a project to T8524: Email preferences doesn't contain an entry for Project Subscriber updates: Wikimedia.
Jun 13 2015, 4:39 PM · FreeBSD, Wikimedia, Notifications

Jun 12 2015

jdloft updated the task description for T8524: Email preferences doesn't contain an entry for Project Subscriber updates.
Jun 12 2015, 4:04 PM · FreeBSD, Wikimedia, Notifications
epriestley closed T8525: Notification filtering is not working correctly as Invalid.

This seems to have resolved itself (after I pushed?) so I now have zero repros. Assuming I am just insane.

Jun 12 2015, 2:40 PM · Notifications
epriestley created T8525: Notification filtering is not working correctly.
Jun 12 2015, 2:26 PM · Notifications
qgil created T8524: Email preferences doesn't contain an entry for Project Subscriber updates.
Jun 12 2015, 9:29 AM · FreeBSD, Wikimedia, Notifications
Miserlou added a comment to T8519: Email Notification Settings for New Projects and Tasks.

For instance.. your action there just gave me an email I didn't want. But I guess you guys must know this, already.

Jun 12 2015, 12:46 AM · Notifications
epriestley merged task T8519: Email Notification Settings for New Projects and Tasks into T5791: Write Herald rules for outbound mail.
Jun 12 2015, 12:44 AM · Notifications
Miserlou created T8519: Email Notification Settings for New Projects and Tasks.
Jun 12 2015, 12:42 AM · Notifications

Jun 10 2015

joshuaspence closed T8473: Garbage collect old notifications as Resolved by committing rP5a00b5f6f62e: Garbage collect old notifications.
Jun 10 2015, 8:55 PM · Notifications
joshuaspence added a revision to T8473: Garbage collect old notifications: D13233: Garbage collect old notifications.
Jun 10 2015, 12:16 PM · Notifications
joshuaspence claimed T8473: Garbage collect old notifications.
Jun 10 2015, 11:00 AM · Notifications

Jun 8 2015

joshuaspence added a comment to T8473: Garbage collect old notifications.

On our install, this data is ~250MB.

Jun 8 2015, 9:08 PM · Notifications
epriestley created T8473: Garbage collect old notifications.
Jun 8 2015, 8:30 PM · Notifications

Jun 3 2015

chad merged task T8395: Not able to filter email notifications by project name or tag into T5791: Write Herald rules for outbound mail.
Jun 3 2015, 5:44 AM · Projects, Notifications
michiel3 renamed T8395: Not able to filter email notifications by project name or tag from Not able to filter email notifications on Project to Not able to filter email notifications by project name or tag.
Jun 3 2015, 5:39 AM · Projects, Notifications
michiel3 created T8395: Not able to filter email notifications by project name or tag.
Jun 3 2015, 5:37 AM · Projects, Notifications

May 15 2015

btrahan closed T8164: Notifications of project membership cannot be Ignored as Resolved by committing rPfa82c17079de: Projects - add mail to project updates.
May 15 2015, 11:33 PM · Notifications
btrahan added a revision to T8164: Notifications of project membership cannot be Ignored: D12868: Projects - add mail to project updates.
May 15 2015, 10:29 PM · Notifications
btrahan triaged T8164: Notifications of project membership cannot be Ignored as Normal priority.
May 15 2015, 9:08 PM · Notifications
btrahan claimed T8164: Notifications of project membership cannot be Ignored.
May 15 2015, 9:08 PM · Notifications

May 13 2015

joshuaspence closed T7107: When destroying an object, destroy associated worker tasks and notifications as Resolved by committing rPf3d5e22a4505: Destroy associated worker tasks and notifications.
May 13 2015, 8:49 PM · Notifications, Daemons
anton.vladimirov added a comment to T7435: Test notifications don't show up until I refresh the page.

I belive in our case it may have been a case of bad SSL config.
It no longer reproduces on our setup.

May 13 2015, 6:50 PM · Notifications
grinich added a comment to T7435: Test notifications don't show up until I refresh the page.

I may be having this same issue.

May 13 2015, 12:12 PM · Notifications
grinich renamed T8180: Notifications UI stuck in "Setting Up Client" after configuring websockets & aphlic from Websocket to Notifications UI stuck in "Setting Up Client" after configuring websockets & aphlic.
May 13 2015, 12:09 PM · Notifications
grinich created T8180: Notifications UI stuck in "Setting Up Client" after configuring websockets & aphlic.
May 13 2015, 12:08 PM · Notifications
joshuaspence added a revision to T7107: When destroying an object, destroy associated worker tasks and notifications: D12822: Destroy associated worker tasks and notifications.
May 13 2015, 11:42 AM · Notifications, Daemons

May 12 2015

epriestley added a comment to T8164: Notifications of project membership cannot be Ignored.

Yeah, the second issue should be fixed in HEAD, see T8112.

May 12 2015, 12:04 PM · Notifications
qgil updated the task description for T8164: Notifications of project membership cannot be Ignored.
May 12 2015, 6:01 AM · Notifications
qgil created T8164: Notifications of project membership cannot be Ignored.
May 12 2015, 6:01 AM · Notifications

May 11 2015

epriestley added a comment to T8145: Support global/broadcast notifications.

Does anyone have a use case for this which isn't maintenance notifications?

May 11 2015, 2:54 PM · Notifications
cburroughs added a comment to T8145: Support global/broadcast notifications.

See also: T5231

May 11 2015, 12:23 PM · Notifications
chad added a project to T8145: Support global/broadcast notifications: Notifications.
May 11 2015, 3:59 AM · Notifications

May 9 2015

chad updated subscribers of T7004: Don't send email whilst online.
May 9 2015, 3:08 PM · Notifications, Mail

May 7 2015

epriestley closed T7448: WebSocket error occurs when navigating phabricator pages as Wontfix.

I don't think this is worth fixing in general. It doesn't do anything bad (just dump a warning to a developer log which users normally don't see) and fixing it isn't trivial.

May 7 2015, 8:18 PM · Firefox, Notifications
btrahan added a comment to T7448: WebSocket error occurs when navigating phabricator pages.

I removed this as a blocker for shipping Quicksand, though shipping Quicksand may help obviate this issue since we will do less page loads.

May 7 2015, 8:07 PM · Firefox, Notifications
btrahan removed a parent task for T7448: WebSocket error occurs when navigating phabricator pages: T7573: Ship Quicksand.
May 7 2015, 8:03 PM · Firefox, Notifications

Apr 23 2015

matmarex added a comment to T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.

These containers can both contain <a /> elements, which aren't valid inside an <a /> even in HTML5, which is why the containers are <div /> instead of <a />. We can possibly either add some sort of floating invisible <a /> under them to solve this in CSS/HTML, or implement additional behaviors in JS to simulate link clicks.

Apr 23 2015, 8:38 PM · Typeahead, Notifications
epriestley triaged T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked as Wishlist priority.
Apr 23 2015, 8:28 PM · Typeahead, Notifications
chad added a comment to T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.

Apr 23 2015, 8:25 PM · Typeahead, Notifications
epriestley renamed T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked from Event Listeners should respect middle and right clicks if possible to Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.
Apr 23 2015, 8:25 PM · Typeahead, Notifications
epriestley added a comment to T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.

Event listeners do, generally speaking, respect middle and right clicks. This isn't a case of event listeners just being too ambitious.

Apr 23 2015, 8:24 PM · Typeahead, Notifications
chad renamed T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked from notifications are no longer middle-clickable to Event Listeners should respect middle and right clicks if possible.
Apr 23 2015, 8:14 PM · Typeahead, Notifications
chad updated subscribers of T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.
Apr 23 2015, 8:02 PM · Typeahead, Notifications
johnny-bit added a comment to T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.

I wanted to test it and... Clicking Links in notifications work flawlessly regardless of durable column. Clicking notifications themselves opens in same tab regardless of durable colum state.

Apr 23 2015, 7:42 PM · Typeahead, Notifications
sshannin added a comment to T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.

The plot thickens...

Apr 23 2015, 7:29 PM · Typeahead, Notifications
epriestley added a comment to T7887: method to dismiss/acknowledge individual notifications.

As much as I hate features, this is relatively easy to build from a JS/eng point of view, fixes T7132 more easily than giving it a real target, and might let us just not pursue T7843.

Apr 23 2015, 6:45 PM · Restricted Project, Notifications
epriestley updated subscribers of T7887: method to dismiss/acknowledge individual notifications.
Apr 23 2015, 6:42 PM · Restricted Project, Notifications
btrahan placed T7887: method to dismiss/acknowledge individual notifications up for grabs.
Apr 23 2015, 6:36 PM · Restricted Project, Notifications
btrahan triaged T7887: method to dismiss/acknowledge individual notifications as Low priority.

Oh, just realized you probably meant the Facebook notifications dropdown. That has the same single line that may overflow to many lines problem, and they use consistent padding / space on the right hand side to work around it.

Apr 23 2015, 6:36 PM · Restricted Project, Notifications
btrahan added a comment to T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.

I was just guessing at a possible cause, especially as I am working to get Quicksand in a better state. Its only in play if the durable column is open. Basically, don't mind me. :D

Apr 23 2015, 6:29 PM · Typeahead, Notifications
sshannin added a comment to T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.

We've messed with a bit but do not actively use it. The ctrl-click and middle-click on notifications don't seem to work on secure.phab either (unless you're implying that maybe quicksand made them work?)

Apr 23 2015, 6:19 PM · Typeahead, Notifications
btrahan added a comment to T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.

Do you all use the durable conpherence column perchance? (Hit "\" to check it out if you have no idea what I am talking about.)

Apr 23 2015, 6:16 PM · Typeahead, Notifications
sshannin added a comment to T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.

Almost certain it did. Updated last night and one of my users called this out first thing in the morning. Not sure exactly which version I updated from, but my database dump from the previous update was timestamped phab.20150407_034445Z.sql.gz

Apr 23 2015, 6:15 PM · Typeahead, Notifications
btrahan reopened T7887: method to dismiss/acknowledge individual notifications as "Open".

I think we currently keep "someday" tasks open - even if we can't predict when someday is - so I'm re-opening. (I like to update tasks from the "need triage" aggressively so definitely feel free to change my updates if I'm wrong.)

Apr 23 2015, 6:13 PM · Restricted Project, Notifications
chad added a comment to T7887: method to dismiss/acknowledge individual notifications.

This is doable, but not something the upstream devs would likely build in any reasonable timeframe. 

Apr 23 2015, 6:03 PM · Restricted Project, Notifications
chad added a comment to T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.

As far as I know this has never worked. See T6700. This is likely a duplicate on how we listen to clicks on all menus.

Apr 23 2015, 5:56 PM · Typeahead, Notifications
sshannin added a comment to T7887: method to dismiss/acknowledge individual notifications.

kk. As a note, in my opinion at least, I think the main burden is not that it has to be clicked, it's that often I don't want to leave the page I'm on. So what I do now usually is just open in new tab and then immediately close the new tab.

Apr 23 2015, 5:32 PM · Restricted Project, Notifications
btrahan added a comment to T7887: method to dismiss/acknowledge individual notifications.

I heard you. :D

Apr 23 2015, 5:27 PM · Restricted Project, Notifications