Page MenuHomePhabricator
Feed Advanced Search

Feb 7 2020

epriestley added a comment to T13426: Add a "Saved States" indirection layer on top of "Staging Areas".

A saved state is likely something like this:

Feb 7 2020, 4:54 PM · Harbormaster, Drydock, Arcanist

Sep 27 2019

epriestley added a comment to T13426: Add a "Saved States" indirection layer on top of "Staging Areas".

One broad problem here is "chain of custody" issues in T182. A "Saved State" can easily accommodate multiple representations, and the plan above imagines using Drydock to build tags/branches out of non-repository representations, so we'd have cases where a given "Saved State" has a way to build it with a "patch list" (from the client) or a "ref pointer" (from Drydock).

Sep 27 2019, 6:43 PM · Harbormaster, Drydock, Arcanist
epriestley triaged T13426: Add a "Saved States" indirection layer on top of "Staging Areas" as Normal priority.
Sep 27 2019, 6:28 PM · Harbormaster, Drydock, Arcanist

Aug 20 2019

epriestley closed T13383: Provide a "drydock.resource.search" API method as Resolved by committing rP721a86401ff4: Implement "drydock.resource.search".
Aug 20 2019, 8:07 PM · Conduit, Drydock
epriestley added a revision to T13383: Provide a "drydock.resource.search" API method: D20723: Implement "drydock.resource.search".
Aug 20 2019, 8:02 PM · Conduit, Drydock
epriestley triaged T13383: Provide a "drydock.resource.search" API method as Normal priority.
Aug 20 2019, 3:52 PM · Conduit, Drydock

Dec 12 2018

joshuaspence added a comment to T12145: Resource allocator does not create new host resources when one is already active.

I'm having some trouble getting this new behaviour (which IIUC basically means that multiple hosts in a Drydock pool should be load-balanced across). In "active resources" I see three Drydock hosts, which all belong to the same Almanac service. In "active leases", however, I see only a single host lease and many working copy leases.

Dec 12 2018, 10:15 AM · Bug Report, Drydock

Dec 9 2018

joshuaspence added a comment to T12145: Resource allocator does not create new host resources when one is already active.

I'm having some trouble getting this new behaviour (which IIUC basically means that multiple hosts in a Drydock pool should be load-balanced across). In "active resources" I see three Drydock hosts, which all belong to the same Almanac service. In "active leases", however, I see only a single host lease and many working copy leases.

Dec 9 2018, 11:39 PM · Bug Report, Drydock

Nov 26 2018

epriestley added a project to T13223: "Land Revision" builds a commit message as an omnipotent user, not the revision author or landing user: Drydock.
Nov 26 2018, 5:53 PM · Drydock, Policy, Differential, Security

Nov 10 2018

epriestley updated the task description for T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.
Nov 10 2018, 1:31 PM · Plans, Drydock

Nov 1 2018

epriestley closed T12145: Resource allocator does not create new host resources when one is already active as Resolved by committing rPb950f877c50c: Allow Drydock Blueprints to control "supplemental allocation" behavior so all….
Nov 1 2018, 1:06 AM · Bug Report, Drydock

Oct 30 2018

jwarner added a comment to T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call.

Fantastic, thanks very much @epriestley! I had indeed intended to take care of this myself was on other work this and last week and planned to come back to this. It also would have taken me much longer to realize that drydock.lease.search wasn't yet upstream and how to proceed from there, so I'm glad to see you were able to handle this so easily!

Oct 30 2018, 9:39 PM · Drydock

Oct 26 2018

epriestley closed T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call as Resolved by committing rP5f3a7cb41b17: Expose Drydock leases via Conduit.
Oct 26 2018, 1:12 PM · Drydock
epriestley closed T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call, a subtask of T11694: Allow clients to generally reason about Drydock leases over the API, as Resolved.
Oct 26 2018, 1:12 PM · Restricted Project, Drydock

Oct 25 2018

epriestley added a comment to T12145: Resource allocator does not create new host resources when one is already active.

D19762 adds a "supplemental allocation" behavior, which basically lets blueprints say "I want to grow the pool instead of allowing this otherwise valid lease acquisition".

Oct 25 2018, 2:03 PM · Bug Report, Drydock
epriestley added a revision to T12145: Resource allocator does not create new host resources when one is already active: D19762: Allow Drydock Blueprints to control "supplemental allocation" behavior so all hosts in an Almanac pool get used.
Oct 25 2018, 1:59 PM · Bug Report, Drydock
epriestley added a comment to T12145: Resource allocator does not create new host resources when one is already active.

After that, both hosts will have resources and jobs will allocate randomly, which should be good enough.

Oct 25 2018, 12:57 PM · Bug Report, Drydock
epriestley added a revision to T12145: Resource allocator does not create new host resources when one is already active: D19761: When a Drydock host based on an Almanac blueprint has its binding disabled, stop handing out leases.
Oct 25 2018, 12:48 PM · Bug Report, Drydock
epriestley added a comment to T12145: Resource allocator does not create new host resources when one is already active.

I believe you can work around this today by disabling the binding to host "A" in Almanac, running one job (which will be forced to allocate on host "B"), then re-enabling the binding. After that, both hosts will have resources and jobs will allocate randomly, which should be good enough. This is exceptionally cumbersome and ridiculous, of course (and it's possible that it doesn't even work).

Oct 25 2018, 12:42 PM · Bug Report, Drydock
epriestley added a comment to T8153: Improve detection and recovery when resources are mangled outside of Drydock's control.

A specific subcase here is when the binding to an Almanac host has been disabled. We should possibly test this during Interface construction, treat it as a failure, then recover from it.

Oct 25 2018, 12:40 PM · Prioritized, Drydock
epriestley moved T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call from Backlog to Now on the Drydock board.
Oct 25 2018, 12:05 PM · Drydock
epriestley moved T12145: Resource allocator does not create new host resources when one is already active from Backlog to Now on the Drydock board.
Oct 25 2018, 12:03 PM · Bug Report, Drydock
epriestley added a comment to T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call.

I believe D16594 should implement this, one way or another, unless I'm misunderstanding the request.

Oct 25 2018, 11:49 AM · Drydock
epriestley added a parent task for T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call: T11694: Allow clients to generally reason about Drydock leases over the API.
Oct 25 2018, 11:48 AM · Drydock
epriestley added a subtask for T11694: Allow clients to generally reason about Drydock leases over the API: T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call.
Oct 25 2018, 11:48 AM · Restricted Project, Drydock
epriestley added a revision to T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call: D16594: Expose Drydock leases via Conduit.
Oct 25 2018, 11:40 AM · Drydock
epriestley added a comment to T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call.

Complicating this: there is no drydock.lease.search call upstream. So you're probably running some variation of D16594? But that already has ownerPHIDs.

Oct 25 2018, 11:38 AM · Drydock

Oct 24 2018

epriestley added a comment to T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call.

I'm happy to make these changes myself, or you mentioned wanting to contribute a patch?

Oct 24 2018, 12:17 AM · Drydock

Oct 23 2018

epriestley moved T13205: Perhaps, provide options for hardening long-lived and relatively stable directories in Drydock? from Backlog to Far Future on the Drydock board.
Oct 23 2018, 8:59 PM · Drydock

Oct 16 2018

epriestley added a project to T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call: Drydock.
Oct 16 2018, 2:32 PM · Drydock
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Oct 16 2018, 1:36 PM · Plans, Harbormaster

Oct 12 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Oct 12 2018, 3:19 PM · Plans, Harbormaster

Oct 10 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Oct 10 2018, 11:42 PM · Plans, Harbormaster

Oct 1 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Oct 1 2018, 3:50 PM · Plans, Harbormaster

Sep 21 2018

epriestley triaged T13205: Perhaps, provide options for hardening long-lived and relatively stable directories in Drydock? as Wishlist priority.
Sep 21 2018, 11:27 PM · Drydock

Sep 19 2018

epriestley updated the task description for T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.
Sep 19 2018, 12:53 PM · Plans, Drydock
epriestley updated the task description for T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.
Sep 19 2018, 12:43 PM · Plans, Drydock
epriestley updated the task description for T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds.
Sep 19 2018, 12:37 PM · Plans, Drydock

Sep 14 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Sep 14 2018, 4:01 PM · Plans, Harbormaster

Sep 13 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Sep 13 2018, 2:44 PM · Plans, Harbormaster

Sep 7 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Sep 7 2018, 3:05 PM · Plans, Harbormaster

Aug 28 2018

epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19615: Allow unit test results to specify that their details are formatted with remarkup when reporting to "harbormaster.sendmessage".
Aug 28 2018, 8:24 PM · Plans, Harbormaster
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

The unit test results also don't currently show on individual builds, which is a little whack?

Aug 28 2018, 8:05 PM · Plans, Harbormaster
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

See T13189#240682 for some planning on the Unit Test result table.

Aug 28 2018, 7:52 PM · Plans, Harbormaster

Aug 27 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Aug 27 2018, 10:21 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Aug 27 2018, 10:16 PM · Plans, Harbormaster

Aug 3 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Aug 3 2018, 7:23 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Aug 3 2018, 7:21 PM · Plans, Harbormaster

Jun 20 2018

hach-que added a comment to T11195: Drydock's working copy should run "git lfs fetch && git lfs checkout" for repositories known to use Git LFS.

Back when this was originally reported, I'm pretty sure git lfs clone didn't exist (or at least I wasn't aware of it's existence). The appropriate fix now is probably different to the fix suggested in the original report.

Jun 20 2018, 6:31 AM · Drydock, Feature Request
aeiser added a comment to T11195: Drydock's working copy should run "git lfs fetch && git lfs checkout" for repositories known to use Git LFS.

We have a similar issue - however I think the "fix" is probably worse then the workaround.

Jun 20 2018, 2:37 AM · Drydock, Feature Request

Jun 5 2018

joshuaspence added a member for Drydock: joshuaspence.
Jun 5 2018, 10:45 PM

Apr 16 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Apr 16 2018, 5:18 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Apr 16 2018, 5:18 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Apr 16 2018, 5:17 PM · Plans, Harbormaster

Apr 13 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Apr 13 2018, 3:46 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Apr 13 2018, 1:58 PM · Plans, Harbormaster

Mar 16 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Mar 16 2018, 10:33 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Mar 16 2018, 8:20 PM · Plans, Harbormaster

Mar 13 2018

epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19217: Add a UI element for reviewing older generations of Harbormaster builds.
Mar 13 2018, 11:12 PM · Plans, Harbormaster

Mar 12 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Mar 12 2018, 11:43 PM · Plans, Harbormaster

Mar 7 2018

epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19187: Correct line highlighting behavior in Diffusion.
Mar 7 2018, 3:04 PM · Plans, Harbormaster

Mar 5 2018

epriestley moved T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds from Backlog to Future on the Plans board.

This is effectively paused until I'm more convinced that the stabilizations changes really stabilized things -- I'm hoping to stabilize first, then work on improvements from there.

Mar 5 2018, 3:06 PM · Plans, Drydock
epriestley moved T13088: Plans: Harbormaster UI usability and interconnectedness from Backlog to Soon on the Plans board.
Mar 5 2018, 3:02 PM · Plans, Harbormaster

Mar 2 2018

epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

Current state of the world here is:

Mar 2 2018, 6:15 PM · Plans, Harbormaster

Mar 1 2018

epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19167: Improve live Harbormaster log follow behaviors.
Mar 1 2018, 6:53 PM · Plans, Harbormaster
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

Add line numbers and links to the log page with proper copy/paste behavior.

Mar 1 2018, 4:27 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19166: Prevent copying Harbormaster build log line numbers with CSS psuedocontent instead of ZWS.
Mar 1 2018, 4:18 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19165: Share the Paste line highlighting behavior for Harbormaster build logs.
Mar 1 2018, 4:04 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19164: Make Paste source code line highlighting behavior more generic.
Mar 1 2018, 3:46 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19163: Support rendering arbitrary sections in the middle of a Harbormaster build log so links to line 3500 work.
Mar 1 2018, 3:12 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19162: Move Paste line range reading code into AphrontRequest.
Mar 1 2018, 2:11 PM · Plans, Harbormaster
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

Add line numbers and links to the log page ... This is actually legitimately hard without scanning the entire file. Maybe we can emit a map as part of finalization which shows which has line markers every megabyte or so.

Mar 1 2018, 1:28 PM · Plans, Harbormaster

Feb 28 2018

epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19153: When viewing a live build log, trap users in a small personal hell where nothing but slavish devotion to the log exists.
Feb 28 2018, 7:39 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Feb 28 2018, 6:00 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19152: Add a "--rate" flag to `bin/harbormaster write-log` to support testing live log streaming.
Feb 28 2018, 3:46 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19151: Provide API read access to Harbormaster build logs.
Feb 28 2018, 3:14 PM · Plans, Harbormaster
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

Maybe summarization and highlighting aren't the same object?

Feb 28 2018, 2:53 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19150: Add a "(prototype)" link to the standalone build log on build pages.
Feb 28 2018, 2:48 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19149: When showing a small piece of a Harbormaster build log, load a small piece of data instead of the entire log.
Feb 28 2018, 2:22 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19148: Fix a Harbormaster build log issue where too few header lines were returned when expanding logs in the middle.
Feb 28 2018, 1:45 PM · Plans, Harbormaster

Feb 27 2018

epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

Very rough version of the new log:

Feb 27 2018, 2:05 AM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19142: Fix some of the most egregious errors in Harbormaster log paging.
Feb 27 2018, 1:49 AM · Plans, Harbormaster

Feb 26 2018

epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19141: Sort of make Harbormaster build logs page properly.
Feb 26 2018, 10:50 PM · Plans, Harbormaster

Feb 25 2018

epriestley added a project to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds: Plans.
Feb 25 2018, 3:28 PM · Plans, Drydock
epriestley added a project to T13088: Plans: Harbormaster UI usability and interconnectedness: Plans.
Feb 25 2018, 3:28 PM · Plans, Harbormaster

Feb 23 2018

epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19139: As Harbormaster logs are processed, build a sparse map of byte offsets to line numbers.
Feb 23 2018, 7:12 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19138: Store the Harbormaster log chunk format on the log record.
Feb 23 2018, 2:15 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19137: Add "--all" and an explicit "--force" flag to `bin/harbormaster rebuild-log`.
Feb 23 2018, 2:03 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19136: In Harbormaster, record byte length on the build logs.
Feb 23 2018, 1:52 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19135: Manage log locks on the Log object to prepare for multiple writers.
Feb 23 2018, 1:39 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19134: Implement DestructibleInterface on BuildLog.
Feb 23 2018, 1:18 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19133: Add a very basic standalone view for build logs with a "Download Log" button.
Feb 23 2018, 3:20 AM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19132: Add a "filePHID" to HarbormasterBuildLog and copy logs into Files during finalization.
Feb 23 2018, 2:46 AM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19131: Move Harbormaster log compression to the worker task queue.
Feb 23 2018, 2:20 AM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19130: Add `bin/harbormaster write-log` to write some arbitrary content into a new Harbormaster log.
Feb 23 2018, 2:06 AM · Plans, Harbormaster

Feb 22 2018

asherkin added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

As a note, pv can rate limit a pipe and is generally very useful all around.

Feb 22 2018, 10:33 AM · Plans, Harbormaster

Feb 21 2018

epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

this is a very good task :)

Feb 21 2018, 8:14 PM · Plans, Harbormaster
yelirekim added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

i used gem install so that i could remain ignorant of those types of problems

Feb 21 2018, 8:02 PM · Plans, Harbormaster
avivey added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.
$ sudo apt install lolcat
 ...
 ...
 ...
After this operation, 27.6 MB of additional disk space will be used.
Do you want to continue? [Y/n]
Feb 21 2018, 8:00 PM · Plans, Harbormaster
yelirekim added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

cat.gif (1×3 px, 7 MB)

Feb 21 2018, 7:50 PM · Plans, Harbormaster