I tried doing an arc diff to submit my patch but ran into this,

I'm on the freenode IRC channel. Studying the code now. If I need any help and assuming I don't give up in between, I'll ask my questions.
And as for this thread, I think I've understood both your points.
Being an admirer of Phab's current documentation, I'll try imitating it in my work as well.

Right, yeah. CSI is somewhat separate, since most of it isn't intended to be picked up by autodoc tools, but it is also designed to not conflict with those. (I should have the published standard up on my site in the next week.) Docs are "what does the code do" and "how do I use it", CSI is "why is the code like this and what is it doing?"

I'm referring to that as well. Diviner builds docs from his comment blocks. Most of it is only on abstractions though like libphutil.

I'll admit, his docs are quite impressive. What I'm referring to is effectively inline-documentation of the code's intent itself, which is inherently separate from docs, and is solely to make maintenance by any programmer who takes the code on possible, without involving the previous dev in person, and largely without invoking the consequences of Brooks' Law.

In general @epriestley writes more documentation than any engineer I've ever met. At least, most abstractions are well documented.

I'd have to agree not to write things twice. That said, I do know that when we undertook starting our own animation system, we first dismantled the open source one we were considering prior (that's where we commented everything), and figured out the inherent problems at its core, which in turn prevented making the same mistakes in our system. Plus, some approaches may be at least partially salvageable for v2, tying back in with the basic idea of "don't code things twice".

For the record I did try to do this myself with my limited eng skills, and I gave up. If you're a natural with JavaScript, it's likely an easy task. I'm not.

There are two main issues. First being we prefer not to context switch ourselves to whatever the issue-du-jour is. That is, we're a very small team (2 people) on a very large project. We maintain throughput by being focused on the current task. We're not currently focused on Conpherence.

Right about now, it might be worth mentioning that my company instituted a standard of commenting every single logical statement in code, stating the intent of the logical statement (not just restating the code).

But maybe you are an adventurous soul! Code is reasonably organized by application, so src/applications/conpherence/ contains PHP and webroot/rsrc/js/application/conpherence/ contains the JavaScript.

The engineer who built Conpherence is no longer contributing code, which means another developer would have to learn it first to give you pointers on where to start. This isn't a great use of our time. I expect Conpherence to get overhauled sometime in the next 3-6 months.

Why is that?

This isn't a good task to learn how to contribute to Phabricator.

I'd like to contribute and help in finishing this. Where do I go?

Yes, I know. I also know bugs can get buried or resolve themselves over time (seen both), so since this is a bit old, I'm just confirming on stable for reference. Take your time. :)

Yep, we'll close issues once we resolve them.

Confirming that this bug is still kicking in the latest stable.

Correct... I'll dive into that. Although it doesn't look like its a quick/simple config change. I'll report back when I have it running.

It sounds like neither of you have actually configured Phabricator's real-time infrastructure. See:

I'd like to not have the users drop back to other means like hangouts. I was happy to wind down the rocket instance, but I might have to bring it back if there are situations arising where real-time coms are required.

In T7755#156496, @storrgie wrote:

[...]. It currently feels like you have to _send_ a message to get the updates in the chat room.

Migrated over from rocket.chat (to pick up all the other awesome things within phabricator) and this is one of the first 'issues' I'm seeing with users. Almost everyone is connecting from Fedora 23 boxes with the latex Firefox release (44). It currently feels like you have to _send_ a message to get the updates in the chat room.

just got an instance set up and ran into this, adding my voice to say issue is obnoxious.

Thanks for the quick fix !

Quicksand issue most likely. Thanks for the report. I was mostly curious is people are using the column in the real world.

Hi chad,
We ran into this bug because a colleague use it and couldn't display project tasks.

This does not describe a root problem. See Contributing Feature Requests and Describing Root Problems.

There is no such option.

I'm going to merge this into T8488 since I think we ended up just removing this distinction.

Along similar lines, has their been any discussion of adding direct support for integrating with a service like http://pushbullet.com or http://pushover.net? It would be *so* cool to get push notifications on my phone for events I care about.

u wot m8 ill +1 u

+1

Also as an aside, I prefer the raw markup in the meme case at least. I know what success_kid is, so I can actually envision the meme. Changing this markup would need to convey all the same information.

Oh! I had forgot about that task. Sounds like a good place to merge.

Remarkup does have multiple rendering modes. There are currently three: email-text (used for text email bodies), email-html (used for html email bodies) and html (used elsewhere).

T2849 has a sort of better explanation of what Remarkup is/does.

Remarkup doesn't work like this, there is the raw and there is marked up. We don't cache/build other outputs like raw-ish.

@stophi, this is essentially the same. Phabricator does not currently update the 'jewels' or 'messages/notifications' in real-time. Would love to, just haven't built it.

yeah I know this is super minor, but it's also not an obvious thing to discover so I figured I'd document it so you're aware of it

This feels unexpected/weird enough to me to consider fixing at some point, but not really broken or particularly problematic.

I feel like you got some fresh french fries and are complaining there is a yummy curly fry in the midst. Just enjoy the curly fry. mmmm http://onecurlyfryinaboxoftheregular.com/

I'd actually like this functionality in other places such as Maniphest. That is, I'd like a stronger notification if I am mentioned on an object that I am subscribed to rather than just a plain comment which doesn't contain a mention.

Idea: Displaying Last-Seen: 5 minutes ago should already help many people and might not require you to track open connections.

I would argue differently ("T8972 is the reason I noticed that conpherence does not allow me to revert mistakes when editing rooms"). If fixing T8972 also allows me to revert the room picture to the original state, then that's fine with me.

something like T8972

My primary concern is the picture. While I can unset the picture of projects, I cannot do so for conferences. Thus there is no way to return to the original state after something like T8972 (or simply a mistake) occurred.

Isn't T8972 the actual core problem. Or if it isn't, can you explain how users need to edit and undo Conpherence Room settings so frequently?

P.S: Since you use transactions everywhere, I assumed they would make the implementation of an undo action rather simple.

Problem: The settings of a Conpherence room were changed mistakenly. I need to undo the change. Resetting Conpherence room images (part of the accidental change) to the default is not possible.

I can confirm this bug, and we should resolve it soon. Sorry if it slid under our radar.

I can't really figure out what happened in Phabricator that you would need such a feature, or only need it in Conpherence. We don't have undo elements as a common pattern (its in diff comments only).

What actually happens is even more annoying: The dialogue displays the values of the previous room, but saving it edits the values of the current room.

Confirmed. Quite annoying, too.

Thanks for the hint with \! From watching some commits, I knew there was such a column, but I didn't figure out how to open it... ;)

No, I don't use it at all.

There is supposed to be a menu icon there, so there is a bug somewhere. Do you have no Conpherences at all, perhaps?