Page MenuHomePhabricator
Feed Advanced Search

Jan 11 2015

joshuaspence committed rARCb780ef0868e2: Use the `raw` formatter for `coffeelint` (authored by joshuaspence).
Use the `raw` formatter for `coffeelint`
Jan 11 2015, 8:24 PM · Blessed Reviewers
joshuaspence committed rARC23bc9f294c8d: Change the default value for `ArcanistExternalLinter::shouldExpectCommandErrors` (authored by joshuaspence).
Change the default value for `ArcanistExternalLinter::shouldExpectCommandErrors`
Jan 11 2015, 8:21 PM · Blessed Reviewers
joshuaspence committed rARC564dab098964: Fix a lint renderering issue (authored by joshuaspence).
Fix a lint renderering issue
Jan 11 2015, 7:49 PM · Blessed Reviewers
joshuaspence committed rARCc2a9d88711c5: Don't explicitly pass `--color=never` to `coffeelint` (authored by joshuaspence).
Don't explicitly pass `--color=never` to `coffeelint`
Jan 11 2015, 7:49 PM · Blessed Reviewers
joshuaspence committed rARC5455fe443060: Don't explicitly implement `ArcanistPuppetLintLinter::supportsReadDataFromStdin` (authored by joshuaspence).
Don't explicitly implement `ArcanistPuppetLintLinter::supportsReadDataFromStdin`
Jan 11 2015, 7:49 PM · Blessed Reviewers
joshuaspence committed rARCe4149e43cd19: Improve parsing of `csslint` output (authored by joshuaspence).
Improve parsing of `csslint` output
Jan 11 2015, 7:49 PM · Blessed Reviewers
joshuaspence committed rARC1b3d60009819: Don't pass `--quiet` to `csslint` (authored by joshuaspence).
Don't pass `--quiet` to `csslint`
Jan 11 2015, 7:47 PM · Blessed Reviewers
joshuaspence committed rARC7b383632dde1: Minor tidying of `ArcanistCSSLintLinter` (authored by joshuaspence).
Minor tidying of `ArcanistCSSLintLinter`
Jan 11 2015, 7:47 PM · Blessed Reviewers
joshuaspence committed rARC1c3278e3fb6e: Move linter exception classes to `src/lint/linter/exception` (authored by joshuaspence).
Move linter exception classes to `src/lint/linter/exception`
Jan 11 2015, 7:47 PM · Blessed Reviewers
joshuaspence committed rARC14e5fbbd6bfd: Fix parsing of `puppet-lint --version` (authored by joshuaspence).
Fix parsing of `puppet-lint --version`
Jan 11 2015, 7:46 PM · Blessed Reviewers
joshuaspence committed rARC9c0568e12dae: Delete a problematic test case (authored by joshuaspence).
Delete a problematic test case
Jan 11 2015, 7:46 PM · Blessed Reviewers
joshuaspence committed rARC50a5d54e7157: Minor tidying of the `ArcanistPuppetLintLinter` class (authored by joshuaspence).
Minor tidying of the `ArcanistPuppetLintLinter` class
Jan 11 2015, 7:46 PM · Blessed Reviewers
joshuaspence committed rARCfa37d3135f37: Minor improvements to `ArcanistJSONLinter` (authored by joshuaspence).
Minor improvements to `ArcanistJSONLinter`
Jan 11 2015, 7:46 PM · Blessed Reviewers
joshuaspence committed rARCce7e8f28f586: Pass `--error-level=all` to `puppet-lint` (authored by joshuaspence).
Pass `--error-level=all` to `puppet-lint`
Jan 11 2015, 7:46 PM · Blessed Reviewers
joshuaspence committed rPHUbd0d806758e5: Fix a possible segfault when parsing JSON containing very large strings (authored by joshuaspence).
Fix a possible segfault when parsing JSON containing very large strings
Jan 11 2015, 7:41 PM · Blessed Reviewers
joshuaspence committed rPHUa95dd1c1db5f: Add an `xhpast_version` function (authored by joshuaspence).
Add an `xhpast_version` function
Jan 11 2015, 7:39 PM · Blessed Reviewers
joshuaspence committed rPHU94ce6528525a: Use `Filesystem::pathExists` (authored by joshuaspence).
Use `Filesystem::pathExists`
Jan 11 2015, 7:39 PM · Blessed Reviewers
epriestley committed rP9853ff2cff3b: T6856 Make Project Images that match Typeahead choices (authored by lpriestley).
T6856 Make Project Images that match Typeahead choices
Jan 11 2015, 5:41 PM · Blessed Reviewers

Jan 9 2015

joshuaspence committed rP9b21274138cf: Allow `PhabricatorRepositoryCommitHeraldWorker` to continue on certain types… (authored by joshuaspence).
Allow `PhabricatorRepositoryCommitHeraldWorker` to continue on certain types…
Jan 9 2015, 10:43 PM · Blessed Reviewers
epriestley committed rP7a6f4ab75a1f: T6594, Logged out users should see "View Raw" in dropdown of timeline items (authored by lpriestley).
T6594, Logged out users should see "View Raw" in dropdown of timeline items
Jan 9 2015, 2:47 PM · Blessed Reviewers
elite.liao added inline comments to rARC4e38fac47d99: Make properties in the `PhutilUnitTestEngineTestCase` class private.
Jan 9 2015, 8:35 AM · Blessed Reviewers
joshuaspence committed rP420f955c2ad8: Fix an incorrect file name (authored by joshuaspence).
Fix an incorrect file name
Jan 9 2015, 7:36 AM · Blessed Reviewers
joshuaspence committed rP44f2195eec21: Add documentation for routing WebSockets through a reverse proxy (authored by joshuaspence).
Add documentation for routing WebSockets through a reverse proxy
Jan 9 2015, 7:15 AM · Blessed Reviewers
epriestley committed rP4aea5325fd9a: T6883, Button to save document in legalpad should say "Save Document" instead… (authored by lpriestley).
T6883, Button to save document in legalpad should say "Save Document" instead…
Jan 9 2015, 12:12 AM · Blessed Reviewers
joshuaspence committed rP638cf20c9de4: Allow the Aphlict server to bind to localhost (authored by joshuaspence).
Allow the Aphlict server to bind to localhost
Jan 9 2015, 12:11 AM · Blessed Reviewers
epriestley committed rP8ddb9e28750d: T6869, Mailing list "Public (No Login Required)" name should be visible to… (authored by lpriestley).
T6869, Mailing list "Public (No Login Required)" name should be visible to…
Jan 9 2015, 12:01 AM · Blessed Reviewers

Jan 8 2015

epriestley committed rP6c7e0e280713: T6870, Return to previous page after login via header (authored by lpriestley).
T6870, Return to previous page after login via header
Jan 8 2015, 11:56 PM · Blessed Reviewers
joshuaspence committed rP5c25f380389a: Pass `--host` to `aphlict_server.js` (authored by joshuaspence).
Pass `--host` to `aphlict_server.js`
Jan 8 2015, 10:02 PM · Blessed Reviewers
joshuaspence committed rPa87f2cd61053: Fix `--ssl-cert` for Aphlict (authored by joshuaspence).
Fix `--ssl-cert` for Aphlict
Jan 8 2015, 10:02 PM · Blessed Reviewers
fabe accepted rP8b7561776f3f: Rename `PhabricatorPolicyRule` subclasses for consistency.
Jan 8 2015, 11:46 AM · Blessed Reviewers
joshuaspence committed rARC4e38fac47d99: Make properties in the `PhutilUnitTestEngineTestCase` class private (authored by joshuaspence).
Make properties in the `PhutilUnitTestEngineTestCase` class private
Jan 8 2015, 11:44 AM · Blessed Reviewers
joshuaspence committed rARC5492f0fad6c6: Minor improvements to `ArcanistPhpLinter` (authored by joshuaspence).
Minor improvements to `ArcanistPhpLinter`
Jan 8 2015, 8:41 AM · Blessed Reviewers
hach-que committed rPHUd0bc7bf0d911: Treat non-string arguments as normal arguments in PhutilArgumentParser (authored by hach-que).
Treat non-string arguments as normal arguments in PhutilArgumentParser
Jan 8 2015, 3:29 AM · Blessed Reviewers
joshuaspence committed rPHUb264db10ea7e: Remove references to `Futures()` from the documentation (authored by joshuaspence).
Remove references to `Futures()` from the documentation
Jan 8 2015, 12:04 AM · Blessed Reviewers
joshuaspence committed rPHU7013bb4a19d2: Minor linter fix (authored by joshuaspence).
Minor linter fix
Jan 8 2015, 12:04 AM · Blessed Reviewers

Jan 7 2015

joshuaspence committed rARCa232f7d5b874: Improvements to `LINT_IMPLICIT_VISIBILITY` (authored by joshuaspence).
Improvements to `LINT_IMPLICIT_VISIBILITY`
Jan 7 2015, 8:33 PM · Blessed Reviewers
joshuaspence committed rARCff3d3792ba19: Minor tidying of the `ArcanistXMLLinter` class (authored by joshuaspence).
Minor tidying of the `ArcanistXMLLinter` class
Jan 7 2015, 1:31 PM · Blessed Reviewers
joshuaspence committed rARC2ad2c04774e2: Simplify version parsing for `ArcanistPhpLinter` (authored by joshuaspence).
Simplify version parsing for `ArcanistPhpLinter`
Jan 7 2015, 1:31 PM · Blessed Reviewers
joshuaspence committed rARCa28bf8763391: Fix unit parser tests (authored by joshuaspence).
Fix unit parser tests
Jan 7 2015, 1:31 PM · Blessed Reviewers

Jan 6 2015

joshuaspence committed rARC4f5203375e0b: Add a linter rule to detect implict method visibility (authored by joshuaspence).
Add a linter rule to detect implict method visibility
Jan 6 2015, 8:44 PM · Blessed Reviewers
joshuaspence committed rPHU00fe30dd9ebf: Fix a minor XHPAST bug (authored by joshuaspence).
Fix a minor XHPAST bug
Jan 6 2015, 8:42 PM · Blessed Reviewers
joshuaspence committed rPc2b4ed1f7eaf: Use `PhutilLibraryTestCase` (authored by joshuaspence).
Use `PhutilLibraryTestCase`
Jan 6 2015, 8:41 PM · Blessed Reviewers
joshuaspence committed rARCfbefe61fb9c5: Use `PhutilLibraryTestCase` (authored by joshuaspence).
Use `PhutilLibraryTestCase`
Jan 6 2015, 8:41 PM · Blessed Reviewers
joshuaspence committed rPHUe583bc6de6be: Add a `PhutilLibraryTestCase` class (authored by joshuaspence).
Add a `PhutilLibraryTestCase` class
Jan 6 2015, 8:41 PM · Blessed Reviewers
joshuaspence committed rARCc70009d90f7f: Fix visibility of various `ArcanistWorkflow` methods (authored by joshuaspence).
Fix visibility of various `ArcanistWorkflow` methods
Jan 6 2015, 8:38 PM · Blessed Reviewers
joshuaspence committed rARC828fb41ea729: Fix visibility of various `ArcanistLinter` methods (authored by joshuaspence).
Fix visibility of various `ArcanistLinter` methods
Jan 6 2015, 8:38 PM · Blessed Reviewers
joshuaspence committed rARCcd591318ca65: Fix visibility of the `ArcanistLintEngine::buildLinters()` method (authored by joshuaspence).
Fix visibility of the `ArcanistLintEngine::buildLinters()` method
Jan 6 2015, 8:38 PM · Blessed Reviewers
joshuaspence committed rPe448386d39a6: Fix method visibility for `PhabricatorApplicationSearchEngine` methods (authored by joshuaspence).
Fix method visibility for `PhabricatorApplicationSearchEngine` methods
Jan 6 2015, 8:38 PM · Blessed Reviewers
joshuaspence committed rPe7f8e7974217: Fix method visibility for `PhabricatorController` subclasses (authored by joshuaspence).
Fix method visibility for `PhabricatorController` subclasses
Jan 6 2015, 8:38 PM · Blessed Reviewers
joshuaspence committed rP367918aac1cf: Fix method visibility for `PhabricatorApplication` methods (authored by joshuaspence).
Fix method visibility for `PhabricatorApplication` methods
Jan 6 2015, 8:38 PM · Blessed Reviewers
joshuaspence committed rP0715bce4a1b6: Fix visibility of `AphrontBarView::getDefaultColor()` methods (authored by joshuaspence).
Fix visibility of `AphrontBarView::getDefaultColor()` methods
Jan 6 2015, 8:38 PM · Blessed Reviewers
joshuaspence committed rPade6f82dd578: Fix method visibility for `LiskFixtureTestCase… (authored by joshuaspence).
Fix method visibility for `LiskFixtureTestCase…
Jan 6 2015, 8:38 PM · Blessed Reviewers
joshuaspence committed rP2c855a899348: Fix method visibility for `PhabricatorConfigStorageSchema` methods (authored by joshuaspence).
Fix method visibility for `PhabricatorConfigStorageSchema` methods
Jan 6 2015, 8:38 PM · Blessed Reviewers
joshuaspence committed rP78b19a43e143: Fix method visibility for `PhabricatorApplicationTransactionEditor` methods (authored by joshuaspence).
Fix method visibility for `PhabricatorApplicationTransactionEditor` methods
Jan 6 2015, 8:38 PM · Blessed Reviewers
joshuaspence committed rP81972b61d752: Fix method visibility for `PhabricatorBitbucketAuthProvider… (authored by joshuaspence).
Fix method visibility for `PhabricatorBitbucketAuthProvider…
Jan 6 2015, 8:38 PM · Blessed Reviewers
joshuaspence committed rP44093da93c9a: Fix method visibility for `PhabricatorRepositoryCommitParserWorker` subclasses (authored by joshuaspence).
Fix method visibility for `PhabricatorRepositoryCommitParserWorker` subclasses
Jan 6 2015, 8:38 PM · Blessed Reviewers
joshuaspence committed rP7756484a000c: Fix method visibility for `AphrontFormControl` methods (authored by joshuaspence).
Fix method visibility for `AphrontFormControl` methods
Jan 6 2015, 8:38 PM · Blessed Reviewers
joshuaspence committed rPHU916e8545308a: Fix visibility of the `LinesOfALargeFile::readMore()` method (authored by joshuaspence).
Fix visibility of the `LinesOfALargeFile::readMore()` method
Jan 6 2015, 8:37 PM · Blessed Reviewers
epriestley committed rP9c568802bb77: T6555, When creating a task with a non existing parent parameter, phabricator… (authored by lpriestley).
T6555, When creating a task with a non existing parent parameter, phabricator…
Jan 6 2015, 7:49 PM · Blessed Reviewers
richardvanvelzen accepted rPf33e2de09286: make repo callsigns optional.

The concern was resolved in rPd4f992d2ed09349755757d02bc887f80b464ad9b

Jan 6 2015, 5:17 PM · Blessed Reviewers
epriestley committed rARC439413ae29b5: Remove the noconfig flag (authored by jjoos).
Remove the noconfig flag
Jan 6 2015, 2:59 PM · Blessed Reviewers
joshuaspence committed rARC7e2df9a5bfc6: `pht`ize some strings (authored by joshuaspence).
`pht`ize some strings
Jan 6 2015, 12:17 PM · Blessed Reviewers
joshuaspence committed rPf2e87aad89e9: Rename the `PhabricatorAuthFactorTOTP` class for consistency (authored by joshuaspence).
Rename the `PhabricatorAuthFactorTOTP` class for consistency
Jan 6 2015, 11:57 AM · Blessed Reviewers
joshuaspence committed rARC6eed5c251411: Create a custom exception class for missing linter dependencies (authored by joshuaspence).
Create a custom exception class for missing linter dependencies
Jan 6 2015, 11:52 AM · Blessed Reviewers
joshuaspence committed rARC0b51f4d7c9b6: `pht`ize some strings (authored by joshuaspence).
`pht`ize some strings
Jan 6 2015, 11:45 AM · Blessed Reviewers
richardvanvelzen raised a concern with rPf33e2de09286: make repo callsigns optional.

I'm getting an error via Conduit when adding a Conpherence message. See inline for where it goes wrong.

Jan 6 2015, 9:06 AM · Blessed Reviewers
joshuaspence committed rP7c124d78542f: Rename `PhutilRealnameContextFreeGrammar` for consistency (authored by joshuaspence).
Rename `PhutilRealnameContextFreeGrammar` for consistency
Jan 6 2015, 1:05 AM · Blessed Reviewers
joshuaspence committed rPHU07631983d419: Rename `PhutilRealnameContextFreeGrammar` for consistency (authored by joshuaspence).
Rename `PhutilRealnameContextFreeGrammar` for consistency
Jan 6 2015, 1:04 AM · Blessed Reviewers
joshuaspence committed rPHUb8732112b4d1: Rename `PhutilLogfileChannel` for consistency (authored by joshuaspence).
Rename `PhutilLogfileChannel` for consistency
Jan 6 2015, 1:04 AM · Blessed Reviewers
epriestley committed rP87c1d004be02: T6597, Uninstalled applications are still linked on Application launcher (authored by lpriestley).
T6597, Uninstalled applications are still linked on Application launcher
Jan 6 2015, 12:25 AM · Blessed Reviewers
epriestley committed rP204ae221d270: Fixes T6637, "closing by commit" should update task status and specify… (authored by lpriestley).
Fixes T6637, "closing by commit" should update task status and specify…
Jan 6 2015, 12:22 AM · Blessed Reviewers

Jan 5 2015

joshuaspence committed rPdd42020ef3bc: Use `PhabricatorAuditEditor` to write revert edges (authored by joshuaspence).
Use `PhabricatorAuditEditor` to write revert edges
Jan 5 2015, 8:30 PM · Blessed Reviewers
joshuaspence committed rPHU35209a3fe3e7: Blacklist the use of `eval()` (authored by joshuaspence).
Blacklist the use of `eval()`
Jan 5 2015, 8:28 PM · Blessed Reviewers
joshuaspence committed rPHU994a138b6d12: Fix an XHPAST bug (authored by joshuaspence).
Fix an XHPAST bug
Jan 5 2015, 8:28 PM · Blessed Reviewers

Jan 4 2015

joshuaspence committed rPca0262ef6b4d: Blacklist the use of `eval()` (authored by joshuaspence).
Blacklist the use of `eval()`
Jan 4 2015, 11:53 PM · Blessed Reviewers
joshuaspence committed rARCd477df00eb5b: Add a linter rule to detect the use of blacklisted functions (authored by joshuaspence).
Add a linter rule to detect the use of blacklisted functions
Jan 4 2015, 11:52 PM · Blessed Reviewers
joshuaspence committed rPe12f0bb53aaf: Correctly pass worker priority from reparse script (authored by joshuaspence).
Correctly pass worker priority from reparse script
Jan 4 2015, 9:34 PM · Blessed Reviewers
joshuaspence committed rP4e7c10cec54f: Fix a duplicate `case` statement (authored by joshuaspence).
Fix a duplicate `case` statement
Jan 4 2015, 9:24 PM · Blessed Reviewers
joshuaspence committed rP85b26964f1b8: Attempt to workaround non-deterministic `sort` behavior (authored by joshuaspence).
Attempt to workaround non-deterministic `sort` behavior
Jan 4 2015, 9:24 PM · Blessed Reviewers
joshuaspence committed rARCeb3129408bba: Various improvements for `ArcanistClosureLinter` (authored by joshuaspence).
Various improvements for `ArcanistClosureLinter`
Jan 4 2015, 8:44 PM · Blessed Reviewers
joshuaspence committed rPfe618772fd79: Show unit test namespaces (authored by joshuaspence).
Show unit test namespaces
Jan 4 2015, 7:50 PM · Blessed Reviewers
joshuaspence committed rARC9e6f876a68b4: Export namespace in `ArcanistUnitTestResult` dictionary (authored by joshuaspence).
Export namespace in `ArcanistUnitTestResult` dictionary
Jan 4 2015, 7:50 PM · Blessed Reviewers
joshuaspence committed rARC4fe5243d8103: Use `PhutilMethodNotImplementedException` in `ArcanistExternalLinter` (authored by joshuaspence).
Use `PhutilMethodNotImplementedException` in `ArcanistExternalLinter`
Jan 4 2015, 7:50 PM · Blessed Reviewers
joshuaspence committed rARC44f81f435134: Rename `PHPUnitTestEngineTestCase` for consistency (authored by joshuaspence).
Rename `PHPUnitTestEngineTestCase` for consistency
Jan 4 2015, 7:50 PM · Blessed Reviewers
joshuaspence committed rARC1c0fd5ce5db0: Move `ArcanistTestResultParser` subclasses (authored by joshuaspence).
Move `ArcanistTestResultParser` subclasses
Jan 4 2015, 7:50 PM · Blessed Reviewers
joshuaspence committed rARC63c9c6c4ffd2: Rename `ArcanistTestResultParser` subclasses for consistency (authored by joshuaspence).
Rename `ArcanistTestResultParser` subclasses for consistency
Jan 4 2015, 7:50 PM · Blessed Reviewers
joshuaspence committed rARCda02add6c818: Create an `ArcanistExternalLinterTestCase` class (authored by joshuaspence).
Create an `ArcanistExternalLinterTestCase` class
Jan 4 2015, 7:50 PM · Blessed Reviewers
joshuaspence committed rARC9fdf53452c15: Rename `UnitTestableArcanistLintEngine` for consistency (authored by joshuaspence).
Rename `UnitTestableArcanistLintEngine` for consistency
Jan 4 2015, 7:49 PM · Blessed Reviewers
joshuaspence committed rARC23f9a3ae66db: Minor tidying of `ArcanistCoffeeLintLinter` (authored by joshuaspence).
Minor tidying of `ArcanistCoffeeLintLinter`
Jan 4 2015, 7:49 PM · Blessed Reviewers
joshuaspence committed rARC9c07016ee46c: Don't pass `--quiet` to `coffeelint` (authored by joshuaspence).
Don't pass `--quiet` to `coffeelint`
Jan 4 2015, 7:49 PM · Blessed Reviewers
joshuaspence committed rARC784033dc1aa5: Update flags for `coffeelint` (authored by joshuaspence).
Update flags for `coffeelint`
Jan 4 2015, 7:49 PM · Blessed Reviewers
joshuaspence committed rARCf6b3f3c46a04: Ignore environment variables for `coffeelint` (authored by joshuaspence).
Ignore environment variables for `coffeelint`
Jan 4 2015, 7:49 PM · Blessed Reviewers
joshuaspence committed rPa7a3c90f145b: Fix a file name to match the PHP class name (authored by joshuaspence).
Fix a file name to match the PHP class name
Jan 4 2015, 7:39 PM · Blessed Reviewers
joshuaspence committed rPe33f5b785e73: Remove unused `phabricator_on_relative_date` function (authored by joshuaspence).
Remove unused `phabricator_on_relative_date` function
Jan 4 2015, 7:39 PM · Blessed Reviewers
joshuaspence committed rP02710ee779f4: Rename the `_phutil_date_format` function for consistency (authored by joshuaspence).
Rename the `_phutil_date_format` function for consistency
Jan 4 2015, 7:38 PM · Blessed Reviewers
joshuaspence committed rPHU15e0669609d3: Rename the `_phutil_date_format` function for consistency (authored by joshuaspence).
Rename the `_phutil_date_format` function for consistency
Jan 4 2015, 7:37 PM · Blessed Reviewers
joshuaspence committed rP3c64cb4d0a7a: Rename `DifferentialLandingStrategy` subclasses for consistency (authored by joshuaspence).
Rename `DifferentialLandingStrategy` subclasses for consistency
Jan 4 2015, 7:36 PM · Blessed Reviewers
joshuaspence committed rP94ac3c084b27: Rename `PhabricatorDashboardPanelType` subclasses for consistency (authored by joshuaspence).
Rename `PhabricatorDashboardPanelType` subclasses for consistency
Jan 4 2015, 7:36 PM · Blessed Reviewers
joshuaspence committed rP78f525396462: Rename the `_phabricator_time_format` function for consistency (authored by joshuaspence).
Rename the `_phabricator_time_format` function for consistency
Jan 4 2015, 7:36 PM · Blessed Reviewers
joshuaspence committed rP97cd8c1c75b5: Rename `DiffusionSSHWorkflow` subclasses for consistency (authored by joshuaspence).
Rename `DiffusionSSHWorkflow` subclasses for consistency
Jan 4 2015, 7:36 PM · Blessed Reviewers