Page MenuHomePhabricator
Feed All Stories

Feb 23 2019

20after4 awarded D20204: Fix URI construction of typeahead browse "more" pager a Mountain of Wealth token.
Feb 23 2019, 2:09 AM
epriestley committed rPa08a03876ff2: (stable) Fix URI construction of typeahead browse "more" pager (authored by epriestley).
(stable) Fix URI construction of typeahead browse "more" pager
Feb 23 2019, 2:09 AM
epriestley committed rP90064a350a02: Fix URI construction of typeahead browse "more" pager (authored by epriestley).
Fix URI construction of typeahead browse "more" pager
Feb 23 2019, 2:09 AM
epriestley closed D20204: Fix URI construction of typeahead browse "more" pager.
Feb 23 2019, 2:09 AM
amckinley accepted D20204: Fix URI construction of typeahead browse "more" pager.
Feb 23 2019, 2:08 AM
epriestley requested review of D20206: Fix Facebook login on mobile violating CSP after form redirect.
Feb 23 2019, 1:00 AM
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Feb 23 2019, 12:59 AM · Plans
epriestley renamed T13249: 2019 Week 7 - 10 Bonus Content from 2019 Week 7 - 8 Bonus Content to 2019 Week 7 - 9 Bonus Content.
Feb 23 2019, 12:58 AM · Plans
epriestley added a revision to T13254: "Login with Facebook" may fail CSP after redirect to "m.facebook.com": D20206: Fix Facebook login on mobile violating CSP after form redirect.
Feb 23 2019, 12:58 AM · Auth

Feb 22 2019

epriestley requested review of D20204: Fix URI construction of typeahead browse "more" pager.
Feb 22 2019, 11:55 PM
epriestley requested review of D20205: Refine checks against "cwd" before "proc_open()".
Feb 22 2019, 11:52 PM
epriestley added a revision to T10853: Make `setCWD('/does/not/exist')` safer on ExecFuture: D20205: Refine checks against "cwd" before "proc_open()".
Feb 22 2019, 11:40 PM · Infrastructure
epriestley added a revision to T13251: Upgrading: PhutilURI Query Parameter Changes: D20204: Fix URI construction of typeahead browse "more" pager.
Feb 22 2019, 10:55 PM · Installing & Upgrading, Guides, Infrastructure
20after4 added a comment to T13251: Upgrading: PhutilURI Query Parameter Changes.

This change broke the search dialog on tags typeaheads...

Feb 22 2019, 9:28 PM · Installing & Upgrading, Guides, Infrastructure
amckinley accepted D20203: Fix a typo.

Thanks! I've added you to Community and Blessed Committers, so you should be able to land this yourself. See the project description for Blessed Committers if you run into trouble, or let me know if that isn't helpful.

Feb 22 2019, 5:56 PM
amckinley added a member for Blessed Committers: arielyang.
Feb 22 2019, 5:56 PM
amckinley added a member for Community: arielyang.
Feb 22 2019, 5:56 PM

Feb 21 2019

epriestley triaged T13254: "Login with Facebook" may fail CSP after redirect to "m.facebook.com" as Low priority.
Feb 21 2019, 5:22 PM · Auth
arielyang requested review of D20203: Fix a typo.
Feb 21 2019, 3:48 PM
leoluk awarded T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes a Like token.
Feb 21 2019, 1:53 PM · Custom Fields, Maniphest

Feb 20 2019

epriestley closed T12746: Add support for PHUIPinboardItemView to timeline/transactions as Wontfix.

Probably a good idea, but not worth keeping a task around for.

Feb 20 2019, 11:33 PM · Maniphest, Macros, Transactions
epriestley closed T11824: Use Pinboard view in Maniphest Mocks tab as Wontfix.

This is probably a natural feature if we iterate here, but not worth keeping a task around for.

Feb 20 2019, 11:32 PM · Pholio, Maniphest
epriestley edited projects for T10571: Default quote action breaks text between lists, added: Remarkup; removed Maniphest, Bug Report.
Feb 20 2019, 11:31 PM · Remarkup, Wikimedia
epriestley closed T10567: Ability to know who can do what in Maniphest EditEngine as Wontfix.
Feb 20 2019, 11:30 PM · ApplicationEditor, Maniphest, Feature Request
epriestley edited projects for T7443: Include full link to Maniphest tasks in commit messages, added: Diffusion; removed Maniphest.
Feb 20 2019, 11:29 PM · Diffusion, Arcanist
epriestley moved T6896: Add group by 'author' to maniphest search results from Backlog to vNext on the Maniphest board.
Feb 20 2019, 11:29 PM · Maniphest
epriestley moved T5679: Search daemon fails when document title >255 chars from Backlog to vNext on the Maniphest board.
Feb 20 2019, 11:28 PM · Maniphest
epriestley closed T4548: Support "Mylyn" Eclipse plugin as Wontfix.

We have no customer interest in this and no current plans to pursue it.

Feb 20 2019, 11:27 PM · Feature Request, Maniphest
epriestley moved T4316: Allow a comment to be added on the Maniphest edit interface from vNext to Far Future on the Maniphest board.
Feb 20 2019, 11:25 PM · Maniphest
epriestley committed rPHU671ec8fb8f7a: Add "random_int" and "random_bytes" as builtins so the linter stops complaining… (authored by epriestley).
Add "random_int" and "random_bytes" as builtins so the linter stops complaining…
Feb 20 2019, 11:03 PM
epriestley closed D20202: Add "random_int" and "random_bytes" as builtins so the linter stops complaining about them.
Feb 20 2019, 11:03 PM
amckinley accepted D20202: Add "random_int" and "random_bytes" as builtins so the linter stops complaining about them.
Feb 20 2019, 11:00 PM
epriestley requested review of D20202: Add "random_int" and "random_bytes" as builtins so the linter stops complaining about them.
Feb 20 2019, 10:59 PM
amckinley closed T5401: Record total time in queue for tasks as Resolved.
Feb 20 2019, 10:56 PM · Daemons
amckinley committed rPabc26aa96f4c: Track total time from task creation to task archival (authored by amckinley).
Track total time from task creation to task archival
Feb 20 2019, 10:44 PM
amckinley closed D20200: Track total time from task creation to task archival.
Feb 20 2019, 10:44 PM
amckinley added inline comments to D20200: Track total time from task creation to task archival.
Feb 20 2019, 10:42 PM
amckinley committed rPHUc6bd8315c188: Add milliseconds and microseconds to phutil_units (authored by amckinley).
Add milliseconds and microseconds to phutil_units
Feb 20 2019, 10:40 PM
amckinley closed D20201: Add milliseconds and microseconds to phutil_units.
Feb 20 2019, 10:40 PM
epriestley accepted D20201: Add milliseconds and microseconds to phutil_units.
Feb 20 2019, 10:38 PM
amckinley requested review of D20201: Add milliseconds and microseconds to phutil_units.
Feb 20 2019, 10:37 PM
amckinley updated the summary of D20200: Track total time from task creation to task archival.
Feb 20 2019, 10:37 PM
epriestley accepted D20200: Track total time from task creation to task archival.

Looks good to me. I'll see about getting random_bytes and random_int into the builtins map to fix that lint thing.

Feb 20 2019, 10:29 PM
amckinley requested review of D20200: Track total time from task creation to task archival.

Can you take a quick look at this with the added UI changes?

Feb 20 2019, 10:25 PM
amckinley updated the summary of D20200: Track total time from task creation to task archival.
Feb 20 2019, 10:23 PM
amckinley updated the diff for D20200: Track total time from task creation to task archival.

Update unarchive, add code to daemon console to use this new data.

Feb 20 2019, 10:21 PM
epriestley added a comment to D20200: Track total time from task creation to task archival.

I think it's fine to let dateModified update to the current time -- you're technically modifying the thing.

Feb 20 2019, 10:10 PM
amckinley added inline comments to D20200: Track total time from task creation to task archival.
Feb 20 2019, 10:10 PM
amckinley added inline comments to D20200: Track total time from task creation to task archival.
Feb 20 2019, 10:03 PM
amckinley created P2114 (An Untitled Masterwork).
Feb 20 2019, 9:03 PM
epriestley accepted D20200: Track total time from task creation to task archival.
Feb 20 2019, 7:21 PM
amckinley requested review of D20200: Track total time from task creation to task archival.
Feb 20 2019, 7:20 PM
amckinley added a revision to T5401: Record total time in queue for tasks: D20200: Track total time from task creation to task archival.
Feb 20 2019, 7:18 PM · Daemons
epriestley committed rP1b8325642112: Don't enable the "ScopeEngine" or try to identify scope context for diffs… (authored by epriestley).
Don't enable the "ScopeEngine" or try to identify scope context for diffs…
Feb 20 2019, 6:16 PM
epriestley closed D20198: Don't enable the "ScopeEngine" or try to identify scope context for diffs without context.
Feb 20 2019, 6:16 PM
epriestley committed rPf1a035d5c2c6: In Differential, give the "moved/copied from" gutter a more clear visual look (authored by epriestley).
In Differential, give the "moved/copied from" gutter a more clear visual look
Feb 20 2019, 6:12 PM
epriestley closed D20197: In Differential, give the "moved/copied from" gutter a more clear visual look.
Feb 20 2019, 6:12 PM
amckinley accepted D20198: Don't enable the "ScopeEngine" or try to identify scope context for diffs without context.
Feb 20 2019, 6:11 PM
amckinley accepted D20197: In Differential, give the "moved/copied from" gutter a more clear visual look.
Feb 20 2019, 6:09 PM
epriestley committed rPa33409991c27: Remove an old Differential selection behavior (authored by epriestley).
Remove an old Differential selection behavior
Feb 20 2019, 6:09 PM
epriestley closed D20196: Remove an old Differential selection behavior.
Feb 20 2019, 6:09 PM
amckinley accepted D20196: Remove an old Differential selection behavior.
Feb 20 2019, 6:08 PM
epriestley added a comment to T13253: Plans: Daemon Status Reporting.

I'm looking at these storage/backend changes:

Feb 20 2019, 6:05 PM · Plans, Daemons
epriestley committed rPc10b283b9270: Remove some ancient daemon log code (authored by epriestley).
Remove some ancient daemon log code
Feb 20 2019, 5:52 PM
epriestley closed D20199: Remove some ancient daemon log code.
Feb 20 2019, 5:52 PM
amckinley accepted D20199: Remove some ancient daemon log code.
Feb 20 2019, 5:51 PM
epriestley requested review of D20199: Remove some ancient daemon log code.
Feb 20 2019, 5:36 PM
epriestley added a revision to T13253: Plans: Daemon Status Reporting: D20199: Remove some ancient daemon log code.
Feb 20 2019, 5:34 PM · Plans, Daemons
epriestley closed T8343: Copied code detection takes >30s on 48MB diff as Resolved.

Presuming resolved by D19748 since we don't have an actual reproduction case.

Feb 20 2019, 2:52 PM · Differential
epriestley closed T11714: Unified diffs don't allow selecting text in inline comments as Resolved.

D20196 removes this code.

Feb 20 2019, 2:50 PM · Differential, Bug Report
epriestley added a comment to T7878: strange "moved from" signal in [Phriction] diff.

I think it had some white-space removed from its end.

Feb 20 2019, 2:15 PM · Differential
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Feb 20 2019, 1:15 PM · Differential, Plans
epriestley requested review of D20198: Don't enable the "ScopeEngine" or try to identify scope context for diffs without context.
Feb 20 2019, 1:12 PM
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20198: Don't enable the "ScopeEngine" or try to identify scope context for diffs without context.
Feb 20 2019, 1:10 PM · Differential, Plans
epriestley requested review of D20197: In Differential, give the "moved/copied from" gutter a more clear visual look.
Feb 20 2019, 12:46 PM
leoluk awarded D20191: Behold! Copy text from either side of a diff! a Mountain of Wealth token.
Feb 20 2019, 9:36 AM
epriestley added a comment to T2495: Improve whitespace expansion of tab literals.

After D20194, expansion of tabs now uses the correct rule (expand tabs to the next tabstop) instead of the old rule (hard-coded replacement with a fixed number of spaces).

Feb 20 2019, 5:44 AM · Restricted Project, FreeBSD, Differential, Diffusion
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Feb 20 2019, 5:04 AM · Differential, Plans
epriestley requested review of D20196: Remove an old Differential selection behavior.
Feb 20 2019, 5:00 AM
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: D20196: Remove an old Differential selection behavior.
Feb 20 2019, 4:58 AM · Differential
epriestley committed rARC2c494385ffd6: Merge branch "master" into "experimental" (authored by epriestley).
Merge branch "master" into "experimental"
Feb 20 2019, 4:57 AM
epriestley closed T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery, a subtask of T13161: Plans: Improve Differential diff display behaviors, as Resolved.
Feb 20 2019, 4:48 AM · Differential, Plans
epriestley closed T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery as Resolved.

There are probably still a few remaining kinks to work out here, but I believe this is substantially resolved:

Feb 20 2019, 4:48 AM · Differential

Feb 19 2019

epriestley committed rPcf048f4402fe: Tweak some display behaviors for indent indicators (authored by epriestley).
Tweak some display behaviors for indent indicators
Feb 19 2019, 11:34 PM
epriestley closed D20195: Tweak some display behaviors for indent indicators.
Feb 19 2019, 11:34 PM
amckinley accepted D20195: Tweak some display behaviors for indent indicators.
Feb 19 2019, 11:33 PM
epriestley committed rPfe7047d12d69: Display some invisible/nonprintable characters in diffs by default (authored by epriestley).
Display some invisible/nonprintable characters in diffs by default
Feb 19 2019, 11:22 PM
epriestley closed D20194: Display some invisible/nonprintable characters in diffs by default.
Feb 19 2019, 11:21 PM
epriestley added inline comments to D20194: Display some invisible/nonprintable characters in diffs by default.
Feb 19 2019, 11:20 PM
epriestley committed rPefccd75ae371: Correct various minor diff copy behaviors (authored by epriestley).
Correct various minor diff copy behaviors
Feb 19 2019, 11:19 PM
epriestley closed D20192: Correct various minor diff copy behaviors.
Feb 19 2019, 11:18 PM
epriestley committed rP37f12a05ea62: Behold! Copy text from either side of a diff! (authored by epriestley).
Behold! Copy text from either side of a diff!
Feb 19 2019, 11:17 PM
epriestley closed D20191: Behold! Copy text from either side of a diff!.
Feb 19 2019, 11:17 PM
epriestley committed rP3ded5d3e8ca8: Disable the JSHint "function called before it is defined" and "unused… (authored by epriestley).
Disable the JSHint "function called before it is defined" and "unused…
Feb 19 2019, 11:14 PM
epriestley closed D20190: Disable the JSHint "function called before it is defined" and "unused parameter" warnings.
Feb 19 2019, 11:14 PM
amckinley accepted D20194: Display some invisible/nonprintable characters in diffs by default.
Feb 19 2019, 11:11 PM
epriestley committed rPd4b96bcf6b01: Remove hidden zero-width spaces affecting copy behavior (authored by epriestley).
Remove hidden zero-width spaces affecting copy behavior
Feb 19 2019, 11:10 PM
epriestley closed D20189: Remove hidden zero-width spaces affecting copy behavior.
Feb 19 2019, 11:10 PM
epriestley committed rP98fe8fae4a90: Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers (authored by epriestley).
Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers
Feb 19 2019, 11:07 PM
epriestley closed D20188: Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers.
Feb 19 2019, 11:07 PM