Page MenuHomePhabricator
Feed All Stories

Apr 23 2019

epriestley requested review of D20465: Remove nearly all remaining references to "Autoclose".
Apr 23 2019, 12:14 AM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20465: Remove nearly all remaining references to "Autoclose".
Apr 23 2019, 12:12 AM · Plans, Diffusion

Apr 22 2019

epriestley added inline comments to D20464: Remove "--force-autoclose" from "bin/repository reparse".
Apr 22 2019, 11:17 PM
epriestley requested review of D20464: Remove "--force-autoclose" from "bin/repository reparse".
Apr 22 2019, 11:11 PM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20464: Remove "--force-autoclose" from "bin/repository reparse".
Apr 22 2019, 11:10 PM · Plans, Diffusion
epriestley added inline comments to D20463: Move "update related object after commit" to a separate worker in the task queue.
Apr 22 2019, 10:53 PM
epriestley requested review of D20463: Move "update related object after commit" to a separate worker in the task queue.
Apr 22 2019, 10:52 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20463: Move "update related object after commit" to a separate worker in the task queue.
Apr 22 2019, 10:51 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added inline comments to D20462: When applying transactions, acquire a read lock sooner.
Apr 22 2019, 10:32 PM
epriestley requested review of D20462: When applying transactions, acquire a read lock sooner.
Apr 22 2019, 10:27 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20462: When applying transactions, acquire a read lock sooner.
Apr 22 2019, 10:26 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction: D20462: When applying transactions, acquire a read lock sooner.
Apr 22 2019, 10:26 PM · Plans, Differential, Harbormaster
epriestley added inline comments to D20461: Remove all remaining readers and writers for TABLE_COMMIT.
Apr 22 2019, 8:31 PM
epriestley requested review of D20461: Remove all remaining readers and writers for TABLE_COMMIT.
Apr 22 2019, 7:53 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20461: Remove all remaining readers and writers for TABLE_COMMIT.
Apr 22 2019, 7:51 PM · Diffusion, Harbormaster, Herald, Audit
epriestley requested review of D20460: Change "Revision Close" story to use commit identities only with no fallback to commit data.
Apr 22 2019, 7:47 PM
epriestley requested review of D20459: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table.
Apr 22 2019, 7:36 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20459: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table.
Apr 22 2019, 7:34 PM · Diffusion, Harbormaster, Herald, Audit
epriestley requested review of D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".
Apr 22 2019, 7:08 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".
Apr 22 2019, 7:06 PM · Diffusion, Harbormaster, Herald, Audit
epriestley requested review of D20457: Move BlameController away from ancient "TABLE_COMMIT".
Apr 22 2019, 6:49 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20457: Move BlameController away from ancient "TABLE_COMMIT".
Apr 22 2019, 6:47 PM · Diffusion, Harbormaster, Herald, Audit
epriestley moved T10945: Replace "repository.query" with "diffusion.repository.search" in Arcanist from Backlog to Staging Areas on the Diffusion board.
Apr 22 2019, 6:10 PM · Restricted Project, Conduit, Arcanist, Diffusion
epriestley moved T11502: Expose raw Git refs in the Diffusion UI, but very subtly from Backlog to "Track Only" on the Diffusion board.
Apr 22 2019, 6:10 PM · Restricted Project, Diffusion
epriestley moved T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance from Backlog to "Track Only" on the Diffusion board.
Apr 22 2019, 6:07 PM · Plans, Diffusion
epriestley renamed T8370: Index "TODO" comments and other references present in source code from Allow mentions in commit contents to Index "TODO" comments and other references present in source code.
Apr 22 2019, 6:06 PM · Transactions, Diffusion
epriestley moved T13280: Permanent Refs Errata from Backlog to "Track Only" on the Diffusion board.
Apr 22 2019, 6:04 PM · Diffusion
epriestley requested review of D20456: Fix "before/after" cursor paging for API call "feed.query".
Apr 22 2019, 5:43 PM
epriestley added a revision to T13266: Upgrading: Minor Changes to Query Paging / Cursors: D20456: Fix "before/after" cursor paging for API call "feed.query".
Apr 22 2019, 5:42 PM · Installing & Upgrading
aklapper added a comment to T13282: Allow unsetting assignee when bulk editing tasks.

Argh, big thanks. Indeed that was not obvious at all to me.

Apr 22 2019, 2:51 PM · Maniphest
epriestley requested review of D20455: Fix an issue where internal paging of notifications could fail if some notifications are not visible.
Apr 22 2019, 2:28 PM
epriestley added a revision to T13266: Upgrading: Minor Changes to Query Paging / Cursors: D20455: Fix an issue where internal paging of notifications could fail if some notifications are not visible.
Apr 22 2019, 2:27 PM · Installing & Upgrading
epriestley committed rP4e37184862d2: (stable) Don't warn about a locked database value after users run "bin/auth… (authored by epriestley).
(stable) Don't warn about a locked database value after users run "bin/auth…
Apr 22 2019, 2:00 PM
epriestley triaged T13282: Allow unsetting assignee when bulk editing tasks as Low priority.

Leaving the "Assign To: [...]" field blank will remove assignees, but this is not obvious:

Apr 22 2019, 1:58 PM · Maniphest
aklapper created T13282: Allow unsetting assignee when bulk editing tasks.
Apr 22 2019, 10:01 AM · Maniphest

Apr 20 2019

joshuaspence added a comment to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".

I believe there is very little reason for the "Autoclose" and "Publish" behaviors to actually be separate. That is, there are very few use cases where users want a commit to trigger only Herald or only feed or only audits. These use cases do exist (see T9210 for an example of "Herald, No Feed") but they're overwhelmingly niche and off-label.

Apr 20 2019, 2:19 AM · Plans, Diffusion

Apr 19 2019

avivey added a comment to T6722: Support "Create similar repository..." in Diffusion.

I think a more powerful approach is to support some kind of "templates", so that we can create a new "Android App" repo or "COM Module" repo directly, similar to how IDEs have project templates.

Apr 19 2019, 7:44 PM · Diffusion (v3), Restricted Project
remusvrm awarded Changelog a Like token.
Apr 19 2019, 7:09 PM
epriestley committed rPa82a2b84599d: Simplify non-bare working copy rules for the new "git fetch" strategy (authored by epriestley).
Simplify non-bare working copy rules for the new "git fetch" strategy
Apr 19 2019, 2:06 PM
epriestley closed D20450: Simplify non-bare working copy rules for the new "git fetch" strategy.
Apr 19 2019, 2:06 PM
epriestley committed rPe1076528ef76: Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest >… (authored by epriestley).
Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest >…
Apr 19 2019, 2:05 PM
epriestley closed D20449: Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest > Reports" working.
Apr 19 2019, 2:05 PM
epriestley planned changes to D20454: Separate the "configuration" and "evaluation" phases of chart functions.

Sleeping on this, "FunctionChain" should just be a function chain(...) or compose(...) or something, which evaluates as compose(f, g, h)(x) => f(g(h(x))).

Apr 19 2019, 1:49 PM
amckinley committed rPde743326394b: Improve timeline rendering for old macros (authored by amckinley).
Improve timeline rendering for old macros
Apr 19 2019, 1:25 AM
amckinley closed D20453: Improve timeline rendering for old macros.
Apr 19 2019, 1:25 AM
epriestley added inline comments to D20454: Separate the "configuration" and "evaluation" phases of chart functions.
Apr 19 2019, 1:25 AM
epriestley requested review of D20454: Separate the "configuration" and "evaluation" phases of chart functions.
Apr 19 2019, 1:14 AM
epriestley accepted D20453: Improve timeline rendering for old macros.
Apr 19 2019, 1:12 AM
amckinley accepted D20449: Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest > Reports" working.
Apr 19 2019, 12:26 AM
amckinley requested review of D20453: Improve timeline rendering for old macros.
Apr 19 2019, 12:19 AM
epriestley added inline comments to D20446: Simplify implementation of "pure" Chart functions.
Apr 19 2019, 12:13 AM
amckinley accepted D20446: Simplify implementation of "pure" Chart functions.
Apr 19 2019, 12:07 AM
epriestley added a comment to D20452: Separate "accumulate(...)" from Fact functions.

On selecting a domain, you can build a chain like this:

Apr 19 2019, 12:02 AM

Apr 18 2019

epriestley added inline comments to D20446: Simplify implementation of "pure" Chart functions.
Apr 18 2019, 11:45 PM
amckinley added inline comments to D20442: Select the domain (X-axis range) for charts before pulling data.
Apr 18 2019, 11:42 PM
epriestley added a comment to D20445: Make chart function argument parsing modular/flexible with 900 pages of error messages.

In a future diff, scale() and shift() take two arguments and work, although I'm likely rethinking exactly how the composition/chaining part of this works (see D20452 for rambling).

Apr 18 2019, 11:41 PM
amckinley created Image Macro "gimli".
Apr 18 2019, 11:41 PM
amckinley accepted D20445: Make chart function argument parsing modular/flexible with 900 pages of error messages.
Apr 18 2019, 11:37 PM
amckinley accepted D20450: Simplify non-bare working copy rules for the new "git fetch" strategy.
Apr 18 2019, 11:27 PM
epriestley abandoned D20452: Separate "accumulate(...)" from Fact functions.

I'm think I'm going to tackle this a little differently. Mostly more rambling:

Apr 18 2019, 11:15 PM
epriestley added a comment to D20452: Separate "accumulate(...)" from Fact functions.

Also featured here is "load the data for all functions in the call tree, not just top-level functions".

Apr 18 2019, 9:11 PM
epriestley requested review of D20452: Separate "accumulate(...)" from Fact functions.
Apr 18 2019, 9:09 PM
epriestley added a revision to T13279: Build Charting for Facts: D20452: Separate "accumulate(...)" from Fact functions.
Apr 18 2019, 9:07 PM · Plans, Facts
epriestley committed rPd8dba26a08f4: Add a "sin()" function to charts (authored by epriestley).
Add a "sin()" function to charts
Apr 18 2019, 8:19 PM
epriestley closed D20444: Add a "sin()" function to charts.
Apr 18 2019, 8:19 PM
epriestley committed rPc4e4448ee649: Add chart functions "x()" and "constant(3)" (authored by epriestley).
Add chart functions "x()" and "constant(3)"
Apr 18 2019, 8:17 PM
epriestley closed D20443: Add chart functions "x()" and "constant(3)".
Apr 18 2019, 8:16 PM
epriestley added inline comments to D20443: Add chart functions "x()" and "constant(3)".
Apr 18 2019, 8:15 PM
epriestley committed rPcd2215fd4a69: Don't warn that workboard columns need a name when editing milestone columns (authored by epriestley).
Don't warn that workboard columns need a name when editing milestone columns
Apr 18 2019, 8:13 PM
epriestley closed D20448: Don't warn that workboard columns need a name when editing milestone columns.
Apr 18 2019, 8:13 PM
epriestley committed rP23d8f000f709: Select the domain (X-axis range) for charts before pulling data (authored by epriestley).
Select the domain (X-axis range) for charts before pulling data
Apr 18 2019, 8:11 PM
epriestley closed D20442: Select the domain (X-axis range) for charts before pulling data.
Apr 18 2019, 8:11 PM
epriestley updated the diff for D20442: Select the domain (X-axis range) for charts before pulling data.
  • Small simplification.
Apr 18 2019, 8:08 PM
epriestley added inline comments to D20442: Select the domain (X-axis range) for charts before pulling data.
Apr 18 2019, 8:07 PM
epriestley committed rP954831f5336b: Separate chart functions into a class tree (authored by epriestley).
Separate chart functions into a class tree
Apr 18 2019, 8:06 PM
epriestley closed D20441: Separate chart functions into a class tree.
Apr 18 2019, 8:06 PM
amckinley accepted D20448: Don't warn that workboard columns need a name when editing milestone columns.
Apr 18 2019, 4:40 PM
epriestley added a comment to D20441: Separate chart functions into a class tree.

Maybe the algorithm is:

Apr 18 2019, 2:59 PM
epriestley added inline comments to D20441: Separate chart functions into a class tree.
Apr 18 2019, 2:20 PM
epriestley committed rP45b3c23148d0: Fetch chart data via async request and redraw charts when the window is resized (authored by epriestley).
Fetch chart data via async request and redraw charts when the window is resized
Apr 18 2019, 2:10 PM
epriestley closed D20440: Fetch chart data via async request and redraw charts when the window is resized.
Apr 18 2019, 2:10 PM
epriestley committed rP044c6fbc19d4: Support drawing multiple functions on the same chart (authored by epriestley).
Support drawing multiple functions on the same chart
Apr 18 2019, 2:07 PM
epriestley closed D20439: Support drawing multiple functions on the same chart.
Apr 18 2019, 2:07 PM
epriestley added inline comments to D20439: Support drawing multiple functions on the same chart.
Apr 18 2019, 2:07 PM
epriestley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: Unknown Object (Differential Revision).
Apr 18 2019, 2:05 PM · Auth, Security
epriestley added a comment to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI.

This could be made slightly cleaner with a setSummary() to set a shorter summary:

Apr 18 2019, 2:02 PM · Auth, Security
epriestley requested review of D20450: Simplify non-bare working copy rules for the new "git fetch" strategy.
Apr 18 2019, 2:01 PM
epriestley committed rP02981f0add6d: Fix negative chart values, add storage for charts (authored by epriestley).
Fix negative chart values, add storage for charts
Apr 18 2019, 1:59 PM
epriestley closed D20438: Fix negative chart values, add storage for charts.
Apr 18 2019, 1:59 PM
epriestley added a revision to T13280: Permanent Refs Errata: D20450: Simplify non-bare working copy rules for the new "git fetch" strategy.
Apr 18 2019, 1:58 PM · Diffusion
epriestley added a comment to T13280: Permanent Refs Errata.

The git fetch change in D20421 does actually affect non-bare repositories:

Apr 18 2019, 1:53 PM · Diffusion
epriestley added a comment to D20421: When observing a repository in Git, just "fetch <url>" without worrying about the "origin" remote.

It looks like this does actually cause some issues with very old non-bare repositories. I'll follow up in T13280. I'm likely to move toward "users should convert these to bare repositories" over retaining non-bare support, since it's been at least like 4-5 years since we created non-bare repositories.

Apr 18 2019, 1:45 PM
epriestley requested review of D20449: Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest > Reports" working.
Apr 18 2019, 1:43 PM
epriestley added a revision to T13279: Build Charting for Facts: D20449: Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest > Reports" working.
Apr 18 2019, 1:41 PM · Plans, Facts
epriestley added a comment to T13281: Draft revisions and the Herald "Is newly created" condition interact badly.

This is expected: the revision is not newly created.

Apr 18 2019, 1:03 PM
epriestley added inline comments to D20435: In Git repositories, use "git symbolic-ref HEAD ..." to select the default branch.
Apr 18 2019, 1:01 PM
epriestley closed T13281: Draft revisions and the Herald "Is newly created" condition interact badly as Invalid.

This is expected: the revision is not newly created.

Apr 18 2019, 1:00 PM
leoluk updated the task description for T13281: Draft revisions and the Herald "Is newly created" condition interact badly.
Apr 18 2019, 12:50 PM
leoluk created T13281: Draft revisions and the Herald "Is newly created" condition interact badly.
Apr 18 2019, 12:49 PM
epriestley committed rPfaf0a311ec9e: In Git repositories, use "git symbolic-ref HEAD ..." to select the default… (authored by epriestley).
In Git repositories, use "git symbolic-ref HEAD ..." to select the default…
Apr 18 2019, 12:46 PM