Page MenuHomePhabricator
Feed All Stories

Feb 19 2019

epriestley requested review of D20195: Tweak some display behaviors for indent indicators.
Feb 19 2019, 11:02 PM
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20195: Tweak some display behaviors for indent indicators.
Feb 19 2019, 11:00 PM · Differential, Plans
amckinley accepted D20192: Correct various minor diff copy behaviors.
Feb 19 2019, 10:50 PM
epriestley added a comment to T13161: Plans: Improve Differential diff display behaviors.
  • The "<<" and ">>" indicators are rendering in places where indentation has changed but the entire line is also different. This is not intended.
  • The ScopeEngine can raise an exception on diffs with partial context. We should probably just skip this feature if we're missing context.
  • The indent depth indicators are probably generally too bright / high-vis.
  • There's no color blind scheme for the indicators.
  • The indentation indicators in one-up mode aren't great (?)
Feb 19 2019, 10:42 PM · Differential, Plans
amckinley accepted D20191: Behold! Copy text from either side of a diff!.
Feb 19 2019, 10:29 PM
amckinley awarded D20191: Behold! Copy text from either side of a diff! a Mountain of Wealth token.
Feb 19 2019, 10:09 PM
amckinley accepted D20190: Disable the JSHint "function called before it is defined" and "unused parameter" warnings.
Feb 19 2019, 9:27 PM
amckinley accepted D20189: Remove hidden zero-width spaces affecting copy behavior.
Feb 19 2019, 9:26 PM
amckinley accepted D20188: Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers.
Feb 19 2019, 9:19 PM
epriestley committed rP3f8eccdaec8f: Put some whitespace behaviors back, but only for "diff alignment", not display (authored by epriestley).
Put some whitespace behaviors back, but only for "diff alignment", not display
Feb 19 2019, 9:12 PM
epriestley closed T6791: Side-by-side diff for source code is noisier than other tools as Resolved by committing rP3f8eccdaec8f: Put some whitespace behaviors back, but only for "diff alignment", not display.
Feb 19 2019, 9:12 PM · Diffusion, Differential
epriestley closed D20187: Put some whitespace behaviors back, but only for "diff alignment", not display.
Feb 19 2019, 9:11 PM
epriestley added a comment to D20187: Put some whitespace behaviors back, but only for "diff alignment", not display.

...since some of the pixel alignment isn't quite right

Feb 19 2019, 9:09 PM
epriestley closed T3498: Allow ignore whitespace in Audit/Diffusion diffs as Resolved by committing rP5310f1cdd90e: Remove all whitespace options/configuration everywhere.
Feb 19 2019, 9:09 PM · Diffusion
epriestley committed rP5310f1cdd90e: Remove all whitespace options/configuration everywhere (authored by epriestley).
Remove all whitespace options/configuration everywhere
Feb 19 2019, 9:09 PM
epriestley closed D20185: Remove all whitespace options/configuration everywhere.
Feb 19 2019, 9:09 PM
amckinley accepted D20187: Put some whitespace behaviors back, but only for "diff alignment", not display.
Feb 19 2019, 9:06 PM
epriestley committed rP661c758ff9d1: Render indent depth changes more clearly (authored by epriestley).
Render indent depth changes more clearly
Feb 19 2019, 8:40 PM
epriestley closed D20181: Render indent depth changes more clearly.
Feb 19 2019, 8:40 PM
epriestley added inline comments to D20185: Remove all whitespace options/configuration everywhere.
Feb 19 2019, 8:38 PM
epriestley updated the diff for D20181: Render indent depth changes more clearly.
  • Fix a bug with the copied code column; could cause concerns with ">>" alignment.
Feb 19 2019, 8:36 PM
amckinley accepted D20185: Remove all whitespace options/configuration everywhere.
Feb 19 2019, 8:21 PM
epriestley committed rARC9581dd0f5272: Add Arcanist support for highlighting indent change intraline diffs (authored by epriestley).
Add Arcanist support for highlighting indent change intraline diffs
Feb 19 2019, 8:17 PM
epriestley closed D20182: Add Arcanist support for highlighting indent change intraline diffs.
Feb 19 2019, 8:17 PM
amckinley accepted D20182: Add Arcanist support for highlighting indent change intraline diffs.
Feb 19 2019, 8:09 PM
amckinley added a comment to D20181: Render indent depth changes more clearly.

The "whitespace added" side of your screenshot looks a little weird. It would be nice to give the chevron the same amount of green background padding on both sides.

Feb 19 2019, 8:03 PM
jcox awarded rPdeea2f01f5d2: Allow unit tests to have arbitrarily long names (>255 characters) a Cup of Joe token.
Feb 19 2019, 7:55 PM
amckinley accepted D20181: Render indent depth changes more clearly.
Feb 19 2019, 7:52 PM
epriestley added a comment to T13158: View query results as annotatable "spreadsheets".

Feb 19 2019, 7:34 PM · Design
epriestley committed rPdeea2f01f5d2: Allow unit tests to have arbitrarily long names (>255 characters) (authored by epriestley).
Allow unit tests to have arbitrarily long names (>255 characters)
Feb 19 2019, 7:22 PM
epriestley closed D20180: Allow unit tests to have arbitrarily long names (>255 characters).
Feb 19 2019, 7:21 PM
epriestley added inline comments to D20180: Allow unit tests to have arbitrarily long names (>255 characters).
Feb 19 2019, 7:21 PM
epriestley committed rP312ba3071485: Don't report search indexing errors to the daemon log except from "bin/search… (authored by epriestley).
Don't report search indexing errors to the daemon log except from "bin/search…
Feb 19 2019, 7:17 PM
epriestley closed T12425: User-initiated search reindex tasks can end up stuck behind import tasks in the daemon queue as Resolved by committing rP312ba3071485: Don't report search indexing errors to the daemon log except from "bin/search….
Feb 19 2019, 7:17 PM · Customer Impact, Daemons, Search, Diffusion
epriestley closed D20178: Don't report search indexing errors to the daemon log except from "bin/search index".
Feb 19 2019, 7:17 PM
epriestley added inline comments to D20178: Don't report search indexing errors to the daemon log except from "bin/search index".
Feb 19 2019, 7:16 PM
amckinley accepted D20180: Allow unit tests to have arbitrarily long names (>255 characters).
Feb 19 2019, 7:13 PM
amckinley accepted D20178: Don't report search indexing errors to the daemon log except from "bin/search index".
Feb 19 2019, 7:08 PM
epriestley committed rPaa470d21549c: Show user availability dots (red = away, orange = busy) in typeaheads… (authored by epriestley).
Show user availability dots (red = away, orange = busy) in typeaheads…
Feb 19 2019, 6:57 PM
epriestley closed D20173: Show user availability dots (red = away, orange = busy) in typeaheads, tokenizer tokens, and autocompletes.
Feb 19 2019, 6:57 PM
epriestley committed rP92abe3c8fb84: Extract scope line selection logic from the diff rendering engine so it can… (authored by epriestley).
Extract scope line selection logic from the diff rendering engine so it can…
Feb 19 2019, 6:55 PM
epriestley closed D20171: Extract scope line selection logic from the diff rendering engine so it can reasonably be iterated on.
Feb 19 2019, 6:55 PM
epriestley committed rP8d348e2eebbe: Clean up a couple of %Q issues in "Has Parents" task queries (authored by epriestley).
Clean up a couple of %Q issues in "Has Parents" task queries
Feb 19 2019, 6:54 PM
epriestley closed D20183: Clean up a couple of %Q issues in "Has Parents" task queries.
Feb 19 2019, 6:54 PM
epriestley committed rPe44b40ca4d83: Make "Subscribe/Unsubscribe" require only "CAN_VIEW", not "CAN_INTERACT" (authored by epriestley).
Make "Subscribe/Unsubscribe" require only "CAN_VIEW", not "CAN_INTERACT"
Feb 19 2019, 6:52 PM
epriestley closed D20174: Make "Subscribe/Unsubscribe" require only "CAN_VIEW", not "CAN_INTERACT".
Feb 19 2019, 6:52 PM
epriestley updated the diff for D20174: Make "Subscribe/Unsubscribe" require only "CAN_VIEW", not "CAN_INTERACT".
  • Fix "users" typo.
Feb 19 2019, 6:49 PM
epriestley added a comment to D20171: Extract scope line selection logic from the diff rendering engine so it can reasonably be iterated on.

This and two other followups also all have some flavor of "convert tabs to spaces" or vice versa. I suspect we can have fewer copies of this code eventually, but since it's like 10 lines of code I'm not worrying about it too much for now.

Feb 19 2019, 6:48 PM
amckinley accepted D20174: Make "Subscribe/Unsubscribe" require only "CAN_VIEW", not "CAN_INTERACT".
Feb 19 2019, 6:41 PM
amckinley accepted D20173: Show user availability dots (red = away, orange = busy) in typeaheads, tokenizer tokens, and autocompletes.
Feb 19 2019, 6:34 PM
amckinley accepted D20171: Extract scope line selection logic from the diff rendering engine so it can reasonably be iterated on.
Feb 19 2019, 6:19 PM
epriestley committed rP884b8bd694f0: (stable) Fix a PhutilURI issue in workboards (authored by epriestley).
(stable) Fix a PhutilURI issue in workboards
Feb 19 2019, 5:01 PM
epriestley committed rP8cf6c68c9520: Fix a PhutilURI issue in workboards (authored by epriestley).
Fix a PhutilURI issue in workboards
Feb 19 2019, 5:01 PM

Feb 18 2019

vostok4 added a comment to T6118: Support for Mercurial extensions in hosted repositories.

I'd propose for simplicity that the focus switch from largefiles to lfs support for Mercurial repositories. lfs has been added to Phabricator for Git already T7789 and it seems that there'd be less work involved to piggyback on that.

Feb 18 2019, 10:55 PM · Mercurial, Diffusion
epriestley added a comment to D20193: In revisions, replace "o" with "🐑".

I suppose we could resolve most of these issues simply and very surgically by putting <span></span> tags around exactly the replaced text, e.g. helic<span data-copy-text="🐑">o</span>pter.

Feb 18 2019, 3:44 AM
epriestley committed rPHU795d7ec4a575: (stable) Correct a typo of "phutil" as "phtuil" (authored by epriestley).
(stable) Correct a typo of "phutil" as "phtuil"
Feb 18 2019, 2:58 AM
epriestley committed rPHU25023f245430: Correct a typo of "phutil" as "phtuil" (authored by epriestley).
Correct a typo of "phutil" as "phtuil"
Feb 18 2019, 2:58 AM
Harbormaster failed to build B22053: rPadab70240390: Fix a PhutilURI issue in Multimeter for rPadab70240390: Fix a PhutilURI issue in Multimeter!
Feb 18 2019, 1:41 AM
epriestley committed rPd4f28640eb51: (stable) Fix a PhutilURI issue in Multimeter (authored by epriestley).
(stable) Fix a PhutilURI issue in Multimeter
Feb 18 2019, 1:40 AM
epriestley committed rPadab70240390: Fix a PhutilURI issue in Multimeter (authored by epriestley).
Fix a PhutilURI issue in Multimeter
Feb 18 2019, 1:40 AM
epriestley committed rPHU4d21f105b17f: (stable) Fix a PhutilURI issue with "scope" in OAuth (authored by epriestley).
(stable) Fix a PhutilURI issue with "scope" in OAuth
Feb 18 2019, 1:39 AM
epriestley committed rPHUba76d400319d: Fix a PhutilURI issue with "scope" in OAuth (authored by epriestley).
Fix a PhutilURI issue with "scope" in OAuth
Feb 18 2019, 1:38 AM
avivey retitled D20194: Display some invisible/nonprintable characters in diffs by default from Display some invisible/nonprintable characters by in diffs by default to Display some invisible/nonprintable characters in diffs by default.
Feb 18 2019, 12:08 AM

Feb 17 2019

epriestley requested review of D20194: Display some invisible/nonprintable characters in diffs by default.
Feb 17 2019, 10:16 PM
epriestley added a revision to T2495: Improve whitespace expansion of tab literals: D20194: Display some invisible/nonprintable characters in diffs by default.
Feb 17 2019, 10:15 PM · Restricted Project, FreeBSD, Differential, Diffusion
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: D20194: Display some invisible/nonprintable characters in diffs by default.
Feb 17 2019, 10:15 PM · Differential
epriestley added a comment to D20193: In revisions, replace "o" with "🐑".

I suppose we could resolve most of these issues simply and very surgically by putting <span></span> tags around exactly the replaced text, e.g. helic<span data-copy-text="🐑">o</span>pter.

Feb 17 2019, 5:29 PM
epriestley abandoned D20193: In revisions, replace "o" with "🐑".

Objectively great diff, but not planning to move forward with it for now.

Feb 17 2019, 5:25 PM
epriestley requested review of D20193: In revisions, replace "o" with "🐑".
Feb 17 2019, 5:19 PM
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: D20193: In revisions, replace "o" with "🐑".
Feb 17 2019, 5:18 PM · Differential
epriestley requested review of D20192: Correct various minor diff copy behaviors.
Feb 17 2019, 4:45 PM
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: D20192: Correct various minor diff copy behaviors.
Feb 17 2019, 4:44 PM · Differential
epriestley added a comment to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.

I'm probably not going to fix this since it's pretty minor and moderately complicated to fix, but this interaction is not ideal:

Feb 17 2019, 4:08 PM · Differential
epriestley requested review of D20191: Behold! Copy text from either side of a diff!.
Feb 17 2019, 3:40 PM
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20191: Behold! Copy text from either side of a diff!.
Feb 17 2019, 3:38 PM · Differential, Plans
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: D20191: Behold! Copy text from either side of a diff!.
Feb 17 2019, 3:38 PM · Differential
epriestley updated the summary of D20190: Disable the JSHint "function called before it is defined" and "unused parameter" warnings.
Feb 17 2019, 2:43 PM
epriestley added a comment to D20190: Disable the JSHint "function called before it is defined" and "unused parameter" warnings.

This is the documentation:

Feb 17 2019, 2:41 PM
epriestley requested review of D20190: Disable the JSHint "function called before it is defined" and "unused parameter" warnings.
Feb 17 2019, 2:37 PM
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: D20190: Disable the JSHint "function called before it is defined" and "unused parameter" warnings.
Feb 17 2019, 2:36 PM · Differential
epriestley added a comment to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.

In Firefox, selecting a range which crosses an inline comment currently drops the line after the comment. Here, return arra does not copy:

Feb 17 2019, 1:47 PM · Differential
epriestley requested review of D20189: Remove hidden zero-width spaces affecting copy behavior.
Feb 17 2019, 12:15 PM
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: D20189: Remove hidden zero-width spaces affecting copy behavior.
Feb 17 2019, 12:13 PM · Differential
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20189: Remove hidden zero-width spaces affecting copy behavior.
Feb 17 2019, 12:13 PM · Differential, Plans

Feb 16 2019

epriestley requested review of D20188: Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers.
Feb 16 2019, 7:39 PM
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20188: Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers.
Feb 16 2019, 7:37 PM · Differential, Plans
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: D20188: Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers.
Feb 16 2019, 7:37 PM · Differential
epriestley added a subtask for T13161: Plans: Improve Differential diff display behaviors: T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.
Feb 16 2019, 5:51 PM · Differential, Plans
epriestley added a parent task for T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: T13161: Plans: Improve Differential diff display behaviors.
Feb 16 2019, 5:51 PM · Differential
cspeckmim awarded T13161: Plans: Improve Differential diff display behaviors a Party Time token.
Feb 16 2019, 5:02 PM · Differential, Plans
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Feb 16 2019, 4:42 PM · Differential, Plans
epriestley added a comment to D20187: Put some whitespace behaviors back, but only for "diff alignment", not display.

(The actual rendering of that new diff is still a little bit sketchy since some of the pixel alignment isn't quite right and I want to tweak the colors, but all the elements are in the right places.)

Feb 16 2019, 4:34 PM
Harbormaster failed remote builds in B22043: Diff 48195 for D20187: Put some whitespace behaviors back, but only for "diff alignment", not display!
Feb 16 2019, 4:33 PM
epriestley requested review of D20187: Put some whitespace behaviors back, but only for "diff alignment", not display.

Builds depend on D20182.

Feb 16 2019, 4:32 PM
epriestley added a revision to T6791: Side-by-side diff for source code is noisier than other tools: D20187: Put some whitespace behaviors back, but only for "diff alignment", not display.
Feb 16 2019, 4:31 PM · Diffusion, Differential
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20187: Put some whitespace behaviors back, but only for "diff alignment", not display.
Feb 16 2019, 4:31 PM · Differential, Plans
amckinley accepted D20183: Clean up a couple of %Q issues in "Has Parents" task queries.
Feb 16 2019, 4:29 PM
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20182: Add Arcanist support for highlighting indent change intraline diffs.
Feb 16 2019, 4:12 PM · Differential, Plans
epriestley updated the summary of D20182: Add Arcanist support for highlighting indent change intraline diffs.
Feb 16 2019, 4:12 PM
epriestley committed rP005eb5f9fcec: (stable) Fix a couple more "URI->alter()" callsites in paging code (authored by epriestley).
(stable) Fix a couple more "URI->alter()" callsites in paging code
Feb 16 2019, 3:53 PM