- The "<<" and ">>" indicators are rendering in places where indentation has changed but the entire line is also different. This is not intended.
- The ScopeEngine can raise an exception on diffs with partial context. We should probably just skip this feature if we're missing context.
- The indent depth indicators are probably generally too bright / high-vis.
- There's no color blind scheme for the indicators.
- The indentation indicators in one-up mode aren't great (?)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Feb 19 2019
...since some of the pixel alignment isn't quite right
- Fix a bug with the copied code column; could cause concerns with ">>" alignment.
The "whitespace added" side of your screenshot looks a little weird. It would be nice to give the chevron the same amount of green background padding on both sides.
- Fix "users" typo.
This and two other followups also all have some flavor of "convert tabs to spaces" or vice versa. I suspect we can have fewer copies of this code eventually, but since it's like 10 lines of code I'm not worrying about it too much for now.
Feb 18 2019
I'd propose for simplicity that the focus switch from largefiles to lfs support for Mercurial repositories. lfs has been added to Phabricator for Git already T7789 and it seems that there'd be less work involved to piggyback on that.
In D20193#253040, @epriestley wrote:I suppose we could resolve most of these issues simply and very surgically by putting <span></span> tags around exactly the replaced text, e.g. helic<span data-copy-text="🐑">o</span>pter.
Feb 17 2019
I suppose we could resolve most of these issues simply and very surgically by putting <span></span> tags around exactly the replaced text, e.g. helic<span data-copy-text="🐑">o</span>pter.
Objectively great diff, but not planning to move forward with it for now.
I'm probably not going to fix this since it's pretty minor and moderately complicated to fix, but this interaction is not ideal:
This is the documentation:
In Firefox, selecting a range which crosses an inline comment currently drops the line after the comment. Here, return arra does not copy:
Feb 16 2019
(The actual rendering of that new diff is still a little bit sketchy since some of the pixel alignment isn't quite right and I want to tweak the colors, but all the elements are in the right places.)
Builds depend on D20182.