Page MenuHomePhabricator
Feed All Stories

Feb 16 2019

epriestley added a comment to D20187: Put some whitespace behaviors back, but only for "diff alignment", not display.

(The actual rendering of that new diff is still a little bit sketchy since some of the pixel alignment isn't quite right and I want to tweak the colors, but all the elements are in the right places.)

Feb 16 2019, 4:34 PM
Harbormaster failed remote builds in B22043: Diff 48195 for D20187: Put some whitespace behaviors back, but only for "diff alignment", not display!
Feb 16 2019, 4:33 PM
epriestley requested review of D20187: Put some whitespace behaviors back, but only for "diff alignment", not display.

Builds depend on D20182.

Feb 16 2019, 4:32 PM
epriestley added a revision to T6791: Side-by-side diff for source code is noisier than other tools: D20187: Put some whitespace behaviors back, but only for "diff alignment", not display.
Feb 16 2019, 4:31 PM · Diffusion, Differential
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20187: Put some whitespace behaviors back, but only for "diff alignment", not display.
Feb 16 2019, 4:31 PM · Differential, Plans
amckinley accepted D20183: Clean up a couple of %Q issues in "Has Parents" task queries.
Feb 16 2019, 4:29 PM
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20182: Add Arcanist support for highlighting indent change intraline diffs.
Feb 16 2019, 4:12 PM · Differential, Plans
epriestley updated the summary of D20182: Add Arcanist support for highlighting indent change intraline diffs.
Feb 16 2019, 4:12 PM
epriestley committed rP005eb5f9fcec: (stable) Fix a couple more "URI->alter()" callsites in paging code (authored by epriestley).
(stable) Fix a couple more "URI->alter()" callsites in paging code
Feb 16 2019, 3:53 PM
Harbormaster failed to build B22041: rPdbcf41dbea00: Fix a couple more "URI->alter()" callsites in paging code for rPdbcf41dbea00: Fix a couple more "URI->alter()" callsites in paging code!
Feb 16 2019, 3:30 PM
epriestley committed rPdbcf41dbea00: Fix a couple more "URI->alter()" callsites in paging code (authored by epriestley).
Fix a couple more "URI->alter()" callsites in paging code
Feb 16 2019, 3:28 PM
epriestley added inline comments to D20185: Remove all whitespace options/configuration everywhere.
Feb 16 2019, 2:49 PM
epriestley requested review of D20185: Remove all whitespace options/configuration everywhere.

Tests depend on D20182.

Feb 16 2019, 2:44 PM
epriestley added a comment to T13161: Plans: Improve Differential diff display behaviors.

Note that T6791 has an example of a change where removing the whitespace options is going to cause a behavioral regression. Here's an example:

Feb 16 2019, 2:43 PM · Differential, Plans
epriestley closed T11142: Side-by-side diff viewer breaks lines on word boundaries and makes diffing difficult in some situations as Wontfix.

This report is generally unclear / hard to reproduce / unusual so I'm not sure how to move forward. It's likely mooted by D20181.

Feb 16 2019, 2:20 PM · Restricted Project, Bug Report (Needs Information), Differential
epriestley added a comment to T13161: Plans: Improve Differential diff display behaviors.

See PHI701. This behavior is not ideal:

Feb 16 2019, 2:18 PM · Differential, Plans
epriestley added a revision to T3498: Allow ignore whitespace in Audit/Diffusion diffs: D20185: Remove all whitespace options/configuration everywhere.
Feb 16 2019, 2:16 PM · Diffusion
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20185: Remove all whitespace options/configuration everywhere.
Feb 16 2019, 2:16 PM · Differential, Plans
epriestley added a comment to T13074: Plans: Workboard triggers, groups, and subproject columns.

I'm going to start here, and implement this proposed rule, which I think is the simpler and more intuitive of the proposals:

Feb 16 2019, 2:07 PM · Workboards (v3), Plans, Projects
epriestley closed T12165: Maybe add a (fullscreen workboard) menu item or URL for link as Wontfix.

It sounds like real-time updates will more-or-less moot this.

Feb 16 2019, 1:39 PM · Workboards, Profile Menu Item
epriestley moved T5474: Support workboard column triggers which activate when a task is dropped into a column from Future Work to v3 on the Workboards board.
Feb 16 2019, 1:36 PM · Workboards (v3), Restricted Project
epriestley moved T11036: Put subproject columns on workboards from Backlog to v3 on the Workboards board.
Feb 16 2019, 1:36 PM · Workboards (v3), Projects (v3)
epriestley moved T13074: Plans: Workboard triggers, groups, and subproject columns from Backlog to v3 on the Workboards board.
Feb 16 2019, 1:34 PM · Workboards (v3), Plans, Projects
epriestley renamed T13249: 2019 Week 7 - 10 Bonus Content from 2019 Week 7 Bonus Content to 2019 Week 7 - 8 Bonus Content.
Feb 16 2019, 3:20 AM · Plans
epriestley added a comment to T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules.

(See T13251 for followup.)

Feb 16 2019, 3:20 AM · Typeahead
epriestley closed T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules as Resolved.

I believe all (?) of these are now fixed in both master and stable.

Feb 16 2019, 3:19 AM · Typeahead
epriestley committed rP3058cae4b82e: Allow task statuses to specify that either "comments" or "edits" are "locked" (authored by epriestley).
Allow task statuses to specify that either "comments" or "edits" are "locked"
Feb 16 2019, 3:18 AM
epriestley closed D20165: Allow task statuses to specify that either "comments" or "edits" are "locked".
Feb 16 2019, 3:18 AM
epriestley committed rP0b2d25778d8f: Add basic, rough support for changing field behavior based on object subtype (authored by epriestley).
Add basic, rough support for changing field behavior based on object subtype
Feb 16 2019, 3:18 AM
epriestley closed D20161: Add basic, rough support for changing field behavior based on object subtype.
Feb 16 2019, 3:18 AM
epriestley committed rP4b10bc2b643d: Correct schema irregularities (including weird keys) with worker task tables (authored by epriestley).
Correct schema irregularities (including weird keys) with worker task tables
Feb 16 2019, 3:17 AM
epriestley closed T6615: Worker task table has some remaining awkward keys as Resolved by committing rP4b10bc2b643d: Correct schema irregularities (including weird keys) with worker task tables.
Feb 16 2019, 3:17 AM · Infrastructure, Daemons
epriestley closed D20175: Correct schema irregularities (including weird keys) with worker task tables.
Feb 16 2019, 3:17 AM
epriestley committed rPc5e16f9bd996: Give HarbormasterBuildUnitMessage a real Query class (authored by epriestley).
Give HarbormasterBuildUnitMessage a real Query class
Feb 16 2019, 3:17 AM
epriestley closed D20179: Give HarbormasterBuildUnitMessage a real Query class.
Feb 16 2019, 3:16 AM
epriestley committed rPHU650bdfa65f2f: (stable) Promote 2019 Week 7 (authored by epriestley).
(stable) Promote 2019 Week 7
Feb 16 2019, 3:10 AM
epriestley committed rARC5e0722296b19: (stable) Promote 2019 Week 7 (authored by epriestley).
(stable) Promote 2019 Week 7
Feb 16 2019, 3:07 AM
epriestley committed rPdd060b94f0d0: (stable) Promote 2019 Week 7 (authored by epriestley).
(stable) Promote 2019 Week 7
Feb 16 2019, 3:07 AM
epriestley edited the content of Changelog.
Feb 16 2019, 3:05 AM
epriestley created 2019 Week 7 (Mid February).
Feb 16 2019, 3:04 AM
epriestley updated the task description for T13251: Upgrading: PhutilURI Query Parameter Changes.
Feb 16 2019, 2:21 AM · Installing & Upgrading, Guides, Infrastructure

Feb 15 2019

epriestley committed rARC07a208d8fc47: In "arc diff", warn when some reviewers are away even if not everyone is away (authored by epriestley).
In "arc diff", warn when some reviewers are away even if not everyone is away
Feb 15 2019, 10:44 PM
epriestley closed D20172: In "arc diff", warn when some reviewers are away even if not everyone is away.
Feb 15 2019, 10:44 PM
epriestley committed rP8810cd2f4d15: Add a standalone view for the Maniphest task graph (authored by epriestley).
Add a standalone view for the Maniphest task graph
Feb 15 2019, 10:43 PM
epriestley closed D20164: Add a standalone view for the Maniphest task graph.
Feb 15 2019, 10:43 PM
epriestley committed rP8f8e863613c0: When users follow an email login link but an install does not use passwords… (authored by epriestley).
When users follow an email login link but an install does not use passwords…
Feb 15 2019, 10:41 PM
epriestley closed D20170: When users follow an email login link but an install does not use passwords, try to get them to link an account.
Feb 15 2019, 10:41 PM
epriestley committed rP2ca316d652d8: When users confirm Duo MFA in the mobile app, live-update the UI (authored by epriestley).
When users confirm Duo MFA in the mobile app, live-update the UI
Feb 15 2019, 10:38 PM
epriestley closed D20169: When users confirm Duo MFA in the mobile app, live-update the UI.
Feb 15 2019, 10:38 PM
epriestley committed rP454a76256228: Queue search indexing tasks at a new PRIORITY_INDEX, not PRIORITY_IMPORT (authored by epriestley).
Queue search indexing tasks at a new PRIORITY_INDEX, not PRIORITY_IMPORT
Feb 15 2019, 10:16 PM
epriestley closed D20177: Queue search indexing tasks at a new PRIORITY_INDEX, not PRIORITY_IMPORT.
Feb 15 2019, 10:16 PM
epriestley committed rP66060b294bce: Fix a URI construction in remarkup macro/meme rules (authored by epriestley).
Fix a URI construction in remarkup macro/meme rules
Feb 15 2019, 10:09 PM
epriestley closed D20176: Fix a URI construction in remarkup macro/meme rules.
Feb 15 2019, 10:08 PM
epriestley committed rPb09cf166a8bd: Clean up a couple more URI alter() calls (authored by epriestley).
Clean up a couple more URI alter() calls
Feb 15 2019, 10:07 PM
epriestley closed D20184: Clean up a couple more URI alter() calls.
Feb 15 2019, 10:07 PM
amckinley accepted D20170: When users follow an email login link but an install does not use passwords, try to get them to link an account.
Feb 15 2019, 10:04 PM
amckinley accepted D20184: Clean up a couple more URI alter() calls.
Feb 15 2019, 10:01 PM
epriestley requested review of D20184: Clean up a couple more URI alter() calls.
Feb 15 2019, 10:00 PM
epriestley requested review of D20183: Clean up a couple of %Q issues in "Has Parents" task queries.
Feb 15 2019, 9:53 PM
epriestley added a comment to D20172: In "arc diff", warn when some reviewers are away even if not everyone is away.

Today, this (normally/usually?) only fires against reviewers that the user actually typed in using their real keyboard, so I think we have some kind of reasonable-ish expectation that they believe those reviewers are currently (or soon) active.

Feb 15 2019, 9:49 PM
amckinley accepted D20179: Give HarbormasterBuildUnitMessage a real Query class.
Feb 15 2019, 9:12 PM
amckinley added a comment to D20180: Allow unit tests to have arbitrarily long names (>255 characters).

Can't wait for unit tests like

Feb 15 2019, 9:02 PM
amckinley accepted D20172: In "arc diff", warn when some reviewers are away even if not everyone is away.

This is clearly the smallest possible change that fixes PHI810, but what would be cooler would be detecting "this revision is unapprovable because of the combination of current away statuses and review requirements" so we only show this message when it's definitely a problem. Don't we have most of that code server-side already for deciding when a revision has reached the "approved" status?

Feb 15 2019, 9:00 PM
epriestley updated the summary of D20181: Render indent depth changes more clearly.
Feb 15 2019, 5:57 PM
epriestley requested review of D20182: Add Arcanist support for highlighting indent change intraline diffs.
Feb 15 2019, 5:57 PM
epriestley requested review of D20181: Render indent depth changes more clearly.

Unit test failure is because this needs a small support change in arcanist/, see next diff.

Feb 15 2019, 5:53 PM
epriestley added inline comments to D20169: When users confirm Duo MFA in the mobile app, live-update the UI.
Feb 15 2019, 5:52 PM
epriestley added inline comments to D20165: Allow task statuses to specify that either "comments" or "edits" are "locked".
Feb 15 2019, 5:49 PM
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20181: Render indent depth changes more clearly.
Feb 15 2019, 5:39 PM · Differential, Plans
amckinley accepted D20175: Correct schema irregularities (including weird keys) with worker task tables.
Feb 15 2019, 5:08 PM
amckinley accepted D20169: When users confirm Duo MFA in the mobile app, live-update the UI.
Feb 15 2019, 4:59 PM
amckinley accepted D20177: Queue search indexing tasks at a new PRIORITY_INDEX, not PRIORITY_IMPORT.
Feb 15 2019, 4:38 PM
amckinley accepted D20176: Fix a URI construction in remarkup macro/meme rules.
Feb 15 2019, 4:37 PM
amckinley accepted D20165: Allow task statuses to specify that either "comments" or "edits" are "locked".
Feb 15 2019, 4:37 PM
amckinley accepted D20164: Add a standalone view for the Maniphest task graph.
Feb 15 2019, 3:23 PM
epriestley requested review of D20180: Allow unit tests to have arbitrarily long names (>255 characters).
Feb 15 2019, 3:20 PM
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D20180: Allow unit tests to have arbitrarily long names (>255 characters).
Feb 15 2019, 3:19 PM · Plans, Harbormaster
epriestley requested review of D20179: Give HarbormasterBuildUnitMessage a real Query class.
Feb 15 2019, 2:47 PM
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D20179: Give HarbormasterBuildUnitMessage a real Query class.
Feb 15 2019, 2:46 PM · Plans, Harbormaster
epriestley claimed T13052: Differentiate "Waiting" from "Restarting after an error" on the daemon console.
Feb 15 2019, 1:35 PM · Daemons
epriestley requested review of D20178: Don't report search indexing errors to the daemon log except from "bin/search index".
Feb 15 2019, 1:32 PM
epriestley added a revision to T12425: User-initiated search reindex tasks can end up stuck behind import tasks in the daemon queue: D20178: Don't report search indexing errors to the daemon log except from "bin/search index".
Feb 15 2019, 1:30 PM · Customer Impact, Daemons, Search, Diffusion
epriestley requested review of D20177: Queue search indexing tasks at a new PRIORITY_INDEX, not PRIORITY_IMPORT.
Feb 15 2019, 1:11 PM
epriestley added a revision to T12425: User-initiated search reindex tasks can end up stuck behind import tasks in the daemon queue: D20177: Queue search indexing tasks at a new PRIORITY_INDEX, not PRIORITY_IMPORT.
Feb 15 2019, 1:09 PM · Customer Impact, Daemons, Search, Diffusion
epriestley added a revision to T13253: Plans: Daemon Status Reporting: D20177: Queue search indexing tasks at a new PRIORITY_INDEX, not PRIORITY_IMPORT.
Feb 15 2019, 1:09 PM · Plans, Daemons
epriestley added a comment to T12425: User-initiated search reindex tasks can end up stuck behind import tasks in the daemon queue.

A related issue here is exemplified in https://discourse.phabricator-community.org/t/importing-libphutil-repository-on-fresh-phabricator-triggers-an-error/2391/, which basically amounts to:

Feb 15 2019, 1:01 PM · Customer Impact, Daemons, Search, Diffusion
epriestley requested review of D20176: Fix a URI construction in remarkup macro/meme rules.
Feb 15 2019, 12:58 PM
epriestley requested review of D20175: Correct schema irregularities (including weird keys) with worker task tables.
Feb 15 2019, 12:56 PM
epriestley added a revision to T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules: D20176: Fix a URI construction in remarkup macro/meme rules.
Feb 15 2019, 12:56 PM · Typeahead
epriestley added a revision to T6615: Worker task table has some remaining awkward keys: D20175: Correct schema irregularities (including weird keys) with worker task tables.
Feb 15 2019, 12:54 PM · Infrastructure, Daemons
epriestley added a revision to T13253: Plans: Daemon Status Reporting: D20175: Correct schema irregularities (including weird keys) with worker task tables.
Feb 15 2019, 12:54 PM · Plans, Daemons
epriestley added a comment to T6615: Worker task table has some remaining awkward keys.

Both tables have this key:

Feb 15 2019, 12:37 PM · Infrastructure, Daemons
epriestley updated the task description for T13253: Plans: Daemon Status Reporting.
Feb 15 2019, 12:24 PM · Plans, Daemons
epriestley triaged T13253: Plans: Daemon Status Reporting as Normal priority.
Feb 15 2019, 12:20 PM · Plans, Daemons
epriestley moved T6768: Worker queue lease names are unwieldy and could be better implemented from Availability to vNext on the Daemons board.
Feb 15 2019, 12:05 PM · Daemons
epriestley lowered the priority of T8129: PHD init / lsb standard control mechanism from Normal to Wishlist.
Feb 15 2019, 3:50 AM · Daemons
epriestley moved T8129: PHD init / lsb standard control mechanism from Backlog to Far Future on the Daemons board.
Feb 15 2019, 3:50 AM · Daemons
epriestley closed T12115: ApplicationTransactionPublishWorker can retry indefinitely, sending email as a side effect, if a transaction takes more than 2 hours to publish as Resolved.

I believe we haven't seen more of this in two years, and "make the worker always exit in less than 2 hours" is a more-or-less reasonable remedy. Getting one extra email every two hours also isn't a huge problem even if we do get this wrong.

Feb 15 2019, 3:47 AM · Restricted Project, Daemons, Differential, Transactions
epriestley moved T13052: Differentiate "Waiting" from "Restarting after an error" on the daemon console from Backlog to vNext on the Daemons board.
Feb 15 2019, 3:44 AM · Daemons
epriestley moved T9170: parsing giganto-normous commits causes admin headaches from Backlog to Far Future on the Daemons board.
Feb 15 2019, 3:22 AM · Restricted Project, Daemons, Diffusion