Diffusion Arcanist (stable) History

rARC/src/lint
stable

Feb 10 2021

f501f85eb8bf Update golint install instructions
Author
vm
Revisions
D21552: Update golint install instructions
Browse Repository
Passed
No Audits

Feb 3 2021

32fe933f3ae7 Add a lint check for catching "Exception" without catching "Throwable"
Author
epriestley
Revisions
D21542: Add a lint check for catching "Exception" without catching "Throwable"
Browse Repository
Passed
No Audits

c51a996fb0bb Detect and correct "final private" methods in lint
Author
epriestley
Revisions
D21539: Detect and correct "final private" methods in lint
Browse Repository
Passed
No Audits

e2b6439a734b Allow lint to correct the spelling of builtin symbols
Author
epriestley
Revisions
D21538: Allow lint to correct the spelling of builtin symbols
Browse Repository
Passed
No Audits

08dbbbba5ade When lint identifies an unknown symbol, attempt to correct it if it is…
Author
epriestley
Revisions
D21537: When lint identifies an unknown symbol, attempt to correct it if it is miscapitalized
Browse Repository
Passed
No Audits

Jan 11 2021

172381260ee7 Fix pyflakes tests for recent pyflakes versions
Author
jrtc27
Revisions
D21504: Fix pyflakes tests for recent pyflakes versions
Browse Repository
Passed
No Audits

09cff8611ba4 Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint
Author
jrtc27
Revisions
D21503: Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint
Browse Repository
Passed
No Audits

687cb41ace6c Fix ArcanistFormattedStringXHPASTLinterRule on older PHP after D21500
Author
jrtc27
Revisions
D21505: Fix ArcanistFormattedStringXHPASTLinterRule on older PHP after D21500
Browse Repository
Passed
No Audits

90ac9a2ff281 Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8
Author
jrtc27
Revisions
D21500: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8
Browse Repository
Failed
Audited

Jan 10 2021

3ab2b407db4a Remove final from private functions for PHP 8 compatibility
Author
jrtc27
Revisions
D21496: Remove final from private functions for PHP 8 compatibility
Browse Repository
Passed
No Audits

Sep 30 2020

04e340ab0f46 Fix rubocop lint tests
Author
bootstraponline
Revisions
D21474: Fix rubocop lint tests
Browse Repository
Passed
No Audits

Sep 8 2020

83e63aeb078b Allow AAST to extract string literal values from HEREDOCs
Author
epriestley
Revisions
D21455: Allow AAST to extract string literal values from HEREDOCs
Browse Repository
Passed
No Audits

73847a4b194b Fix a false negative in lint for "xsprintf()"-family functions
Author
epriestley
Revisions
D21453: Fix a false negative in lint for "xsprintf()"-family functions
Browse Repository
Passed
No Audits

Jun 12 2020

1e09a0ee7e91 When a linter raises a message at a nonexistent line, don't fatal during…
Author
epriestley
Revisions
D21357: When a linter raises a message at a nonexistent line, don't fatal during rendering
Browse Repository
Passed
No Audits

May 27 2020

fce72b9c89d7 Make lint tests handle paths better and distinguish between "0" and "null" more…
Author
epriestley
Revisions
D21291: Make lint tests handle paths better and distinguish between "0" and "null" more carefully
Browse Repository
Passed
No Audits

e69aa3260388 Fix an issue when rendering a lint message which removes whitespace at the end…
Author
epriestley
Revisions
D21290: Fix an issue when rendering a lint message which removes whitespace at the end of a file
Browse Repository
Passed
No Audits

25ee39b657b8 In the "cpplint" binding, raise messages on "line 0" without a line
Author
epriestley
Revisions
D21289: In the "cpplint" binding, raise messages on "line 0" without a line
Browse Repository
Passed
No Audits

Mar 30 2020

cb80f6971537 Make "FutureIterator" queue management more formal
Author
epriestley
Revisions
D21036: Make "FutureIterator" queue management more formal
Browse Repository
Passed
No Audits

Mar 6 2020

66a6128239e2 Remove the "preg_quote()" lint rule and update the "__CLASS__" lint rule
Author
epriestley
Revisions
D21032: Remove the "preg_quote()" lint rule and update the "__CLASS__" lint rule
Browse Repository
Passed
No Audits

Feb 23 2020

de461bb1794f Fix two "implode()" order issues arising from wilds/experimental collapse
Author
epriestley
Revisions
D21024: Fix two "implode()" order issues arising from wilds/experimental collapse
Browse Repository
Passed
No Audits

Feb 13 2020

acf060768340 Merge utility/support changes from "wilds" to "master"
Author
epriestley
Revisions
D20988: Merge utility/support changes from "wilds" to "master"
Browse Repository
Passed
No Audits

0d62a10eda68 Don't depend on "XMLWriter" to load the lint renderer class tree
Author
epriestley
Revisions
D20989: Don't depend on "XMLWriter" to load the lint renderer class tree
Browse Repository
Passed
No Audits

4c36860c4303 Merge Arcanist lint changes from "experimental" branch
Author
epriestley
Revisions
D20986: Merge Arcanist lint changes from "experimental" branch
Browse Repository
Passed
No Audits

Feb 12 2020

9b74cb4ee641 Fully merge "libphutil/" into "arcanist/"
Author
epriestley
Revisions
D20980: Fully merge "libphutil/" into "arcanist/"
Browse Repository
Failed
No Audits

Oct 17 2019

da6d4f85eefb Add a lint check for deprecated argument order to "implode()"
Author
epriestley
Revisions
D20857: Add a lint check for deprecated argument order to "implode()"
Browse Repository
Passed
No Audits

May 21 2019

dd514e268b2c Modify the `lint-test` file format to allow for more powerful assertions
Author
joshuaspence
Revisions
D11176: Modify the `lint-test` file format to allow for more powerful assertions
Browse Repository
Passed
No Audits

May 15 2019

82445bb60534 Let lint rules support anonymous classes
Author
wjiang
Browse Repository
Passed
No Audits

May 14 2019

6a8e76db329e Allow `buildFutures` and `resolveFutures` to be overridden
Author
joshuaspence
Browse Repository
Passed
No Audits

fceac878f112 Allow `setCustomSeverityRules` to be overridden in subclasses
Author
joshuaspence
Browse Repository
Passed
No Audits

4f583dded366 Call `$linter->setEngine` in linter tests
Author
joshuaspence
Browse Repository
Passed
No Audits

b61e890a0ca8 Remove unnecessary "," from Pylint version regex
Author
epriestley
Browse Repository
Passed
No Audits

Feb 12 2019

7e61e43f6554 Add version check whitelists for constants to the version compatibility lint…
Author
epriestley
Revisions
D20146: Add version check whitelists for constants to the version compatibility lint rule
Browse Repository
Passed
No Audits

Dec 28 2018

25c2381959ac Statically detect "continue" inside "switch"
Author
epriestley
Revisions
D19931: Statically detect "continue" inside "switch"
Browse Repository
Passed
No Audits

Dec 12 2018

eb732555a71a Fix a "continue;" inside a switch in ArcanistPHPCompatibilityXHPASTLinterRule
Author
epriestley
Revisions
D19868: Fix a "continue;" inside a switch in ArcanistPHPCompatibilityXHPASTLinterRule
Browse Repository
Passed
No Audits

Sep 6 2018

30b7835c37b5 Allow `willLintPaths` and `didLintPaths` to be overridden
Author
joshuaspence
Revisions
D19630: Allow `willLintPaths` and `didLintPaths` to be overridden
Browse Repository
Passed
No Audits

Aug 3 2018

d9a4293ae734 Consolidate redundant "should should" from some linter help strings in Arcanist
Author
epriestley
Revisions
D19561: Consolidate redundant "should should" from some linter help strings in Arcanist
Browse Repository
Passed
No Audits

Nov 2 2017

90546042144f Fix some lint rendering issues when lines prior to other identical lines are…
Author
epriestley
Revisions
D18759: Fix some lint rendering issues when lines prior to other identical lines are removed
Browse Repository
Passed
No Audits

Oct 20 2017

0989343a4e0c Correct some lint console renderer issues with files missing trailing newlines
Author
epriestley
Revisions
D18716: Correct some lint console renderer issues with files missing trailing newlines
Browse Repository
Passed
No Audits

Oct 17 2017

617c2e46d6a5 Make "line" and "char" strictly optional in ArcanistLintMessage
Author
epriestley
Revisions
D18711: Make "line" and "char" strictly optional in ArcanistLintMessage
Browse Repository
Passed
No Audits

Sep 20 2017

b836557b12b3 Correct lint rendering when patching trailing whitespace in files
Author
epriestley
Revisions
D18631: Correct lint rendering when patching trailing whitespace in files
Browse Repository
Passed
No Audits

Sep 14 2017

df81d79d77f8 Add explicit limits to unit test/lint error names
Author
amckinley
Revisions
D18603: Add explicit limits to unit test/lint error names
Browse Repository
Passed
No Audits

Sep 6 2017

cbc785ddce71 Fix a similar lint rendering issue when trimming identical lines out of patches
Author
epriestley
Revisions
D18541: Fix a similar lint rendering issue when trimming identical lines out of patches
Browse Repository
Passed
No Audits

Sep 5 2017

7371277d2065 Fix a prefix/suffix counting issue in Arcanist lint rendering
Author
epriestley
Revisions
D18538: Fix a prefix/suffix counting issue in Arcanist lint rendering
Browse Repository
Passed
No Audits

Aug 31 2017

ad8214456add Restore ANSI highlighting of lint sections to lint output
Author
epriestley
Revisions
D18512: Restore ANSI highlighting of lint sections to lint output
Browse Repository
Passed
No Audits

213ed3ff15d7 Restore the caret pointer ("^") for lint lines which only have a character…
Author
epriestley
Revisions
D18511: Restore the caret pointer ("^") for lint lines which only have a character offset
Browse Repository
Passed
No Audits

86779b152654 Render lint patches which have newlines in a less misleading way
Author
epriestley
Revisions
D18510: Render lint patches which have newlines in a less misleading way
Browse Repository
Passed
No Audits

be67df611856 Extract and cover the logic for "trimming" a lint message
Author
epriestley
Revisions
D18509: Extract and cover the logic for "trimming" a lint message
Browse Repository
Passed
No Audits

ab0d81bca292 Add basic test coverage for lint console rendering
Author
epriestley
Revisions
D18508: Add basic test coverage for lint console rendering
Browse Repository
Passed
No Audits

Jul 22 2017

836768bdccd4 Fix ArcanistPHPCloseTagXHPASTLinterRule always bailing out
Author
asherkin
Revisions
D18271: Fix ArcanistPHPCloseTagXHPASTLinterRule always bailing out
Browse Repository
Passed
No Audits

May 3 2017

3c4735795a29 Detect trailing spaces and tabs
Author
johnny-bit
Revisions
D17814: Detect trailing spaces and tabs
Browse Repository
Passed
No Audits

Apr 25 2017

5d0f5afca8cd Add ArcanistRaggedClassTreeEdgeXHPASTLinterRule to Phutil linter map
Author
amckinley
Revisions
D17787: Add ArcanistRaggedClassTreeEdgeXHPASTLinterRule to Phutil linter map
Browse Repository
Passed
No Audits

Mar 24 2017

d1db9a72b552 Improve the flake8 line-matching regex
Author
jparise
Revisions
D17552: Improve the flake8 line-matching regex
Browse Repository
Passed
No Audits

Feb 18 2017

3b6b523c2b23 Fix errors found by PHPStan
Author
vrana
Revisions
D17376: Fix errors found by PHPStan
Browse Repository
Passed
No Audits

Feb 16 2017

d0353d238113 Fix errors found by PHPStan
Author
vrana
Revisions
D17367: Fix errors found by PHPStan
Browse Repository
Passed
No Audits

Sep 21 2016

483e985d08d2 Check both UNIX- and Windows-style paths from linter output
Author
alexmv
Revisions
D16579: Check both UNIX- and Windows-style paths from linter output
Browse Repository
Passed
No Audits

Aug 1 2016

f20d4b15c7e4 Add a lint error about use of PHP short array syntax ('[...]')
Author
epriestley
Revisions
D16357: Add a lint error about use of PHP short array syntax ('[...]')
Browse Repository
Passed
No Audits

Jul 12 2016

8f69a5c378c3 Use phutil functions to copy/move files
Author
alexmv
Revisions
D16273: Use phutil functions to copy/move files
Browse Repository
Passed
No Audits

Apr 29 2016

c58f1b9a2507 Prefer pip to easy_install
Author
eadler
Revisions
D15818: Prefer pip to easy_install
Browse Repository
Passed
No Audits

768e1a56bc5f When running XHPAST unit tests, include the "syntax error" lint rule
Author
epriestley
Revisions
D15819: When running XHPAST unit tests, include the "syntax error" lint rule
Browse Repository
Passed
No Audits

3ffed59bd7fb Update xhpast linter rules for new function AST format
Author
richardvanvelzen
Revisions
D15814: Update xhpast linter rules for new function AST format
Browse Repository
Passed
No Audits

ea6fc7789295 Fix incorrect variable for linter standards
Author
joshuaspence
Revisions
D15212: Fix incorrect variable for linter standards
Browse Repository
Passed
No Audits

Apr 27 2016

9b07d1c480f4 Recognize error codes from Flake8 extensions
Author
jparise
Revisions
D15810: Recognize error codes from Flake8 extensions
Browse Repository
Passed
No Audits

Jan 15 2016

b87138356a9c Cleans up some minor issues in cpplint
Author
michaeloa
Revisions
D15030: Cleans up some minor issues in cpplint
Browse Repository
Passed
No Audits

Jan 14 2016

22af67c1c05e Minor fixes to arcanist cpplint
Author
michaeloa
Revisions
D15019: Minor fixes to arcanist cpplint
Browse Repository
Passed
No Audits

Jan 12 2016

05c12eb9d9cb If the Script-and-Regex linter captures no "line" text, treat the message as…
Author
epriestley
Revisions
D15000: If the Script-and-Regex linter captures no "line" text, treat the message as affecting the entire file
Browse Repository
Passed
No Audits

Jan 6 2016

aeb374b33348 Fix cpplint message regex
Author
jra3
Revisions
D14960: Fix cpplint message regex
Browse Repository
Passed
No Audits

Dec 22 2015

b3e68c9f1793 Add a linter rule for use of `is_a`
Author
joshuaspence
Revisions
D14573: Add a linter rule for use of `is_a`
Browse Repository
Passed
No Audits

9ee14d28490c Improve the "self member reference" linter rule
Author
joshuaspence
Revisions
D13935: Improve the "self member reference" linter rule
Browse Repository
Passed
No Audits

Dec 8 2015

0c8124a2729d Fix handling of empty array index
Author
joshuaspence
Browse Repository
Passed
Audited

d2e778549727 Add a linter rule for curly brace array indexes
Author
joshuaspence
Revisions
D14603: Add a linter rule for curly brace array indexes
Browse Repository
Passed
No Audits

Dec 7 2015

a6e81daad1bb Improve brace formatting linter rule
Author
joshuaspence
Revisions
D14690: Improve brace formatting linter rule
Browse Repository
Passed
No Audits

b52e9dc702c2 Linter fixes
Author
joshuaspence
Revisions
D14633: Linter fixes
Browse Repository
Passed
No Audits

Dec 2 2015

cdaad096fa8d Add a linter rule for public properties
Author
joshuaspence
Revisions
D14641: Add a linter rule for public properties
Browse Repository
Passed
No Audits

3c193984da6f Add a "binary integer casing" linter rule
Author
joshuaspence
Revisions
D14644: Add a "binary integer casing" linter rule
Browse Repository
Passed
No Audits

ae3c2cb0e172 Add binary integers to `ArcanistPHPCompatibilityXHPASTLinterRule`
Author
joshuaspence
Revisions
D14643: Add binary integers to `ArcanistPHPCompatibilityXHPASTLinterRule`
Browse Repository
Passed
No Audits

560e4ae4919b Add a linter rule for invalid octals
Author
joshuaspence
Revisions
D14604: Add a linter rule for invalid octals
Browse Repository
Passed
No Audits

8ed3c45c8226 Use `CaseInsensitiveArray` in `ArcanistFunctionCallShouldBeTypeCastXHPASTLinter…
Author
joshuaspence
Revisions
D14625: Use `CaseInsensitiveArray` in `ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule`
Browse Repository
Passed
No Audits

76ae02325dd3 Fix another edge case for "function call should be type cast" linter rule
Author
joshuaspence
Revisions
D14623: Fix another edge case for "function call should be type cast" linter rule
Browse Repository
Passed
No Audits

09052d52470d Minor fix for typecast linter rule
Author
joshuaspence
Revisions
D14611: Minor fix for typecast linter rule
Browse Repository
Passed
No Audits

Dec 1 2015

00efcd294fd0 Add a linter rule for hexadecimal number casing
Author
joshuaspence
Revisions
D14612: Add a linter rule for hexadecimal number casing
Browse Repository
Passed
No Audits

5218ec357c5c Add a table showing all XHPAST linter rules to the output of `arc linters…
Author
joshuaspence
Revisions
D14563: Add a table showing all XHPAST linter rules to the output of `arc linters xhpast`
Browse Repository
Passed
No Audits

Nov 30 2015

87306cfe1453 Add a linter rule for variable reference spacing
Author
joshuaspence
Revisions
D14602: Add a linter rule for variable reference spacing
Browse Repository
Passed
No Audits

Nov 29 2015

578f540a92b1 Add a linter rule for `*val` functions
Author
joshuaspence
Revisions
D14572: Add a linter rule for `*val` functions
Browse Repository
Passed
No Audits

Nov 25 2015

eeaa176cfc5a Add a linter rule to ensure that `namespace` is the first statement in a file
Author
joshuaspence
Revisions
D14526: Add a linter rule to ensure that `namespace` is the first statement in a file
Browse Repository
Passed
No Audits

600dcf83dd11 Fix linter rule ID
Author
joshuaspence
Browse Repository
Passed
Audited

b323ad4d6484 Add a linter rule for `abstract` methods within an `interface`
Author
joshuaspence
Revisions
D14562: Add a linter rule for `abstract` methods within an `interface`
Browse Repository
Failed
No Audits

8183a458048c Add a linter rule for `interface` method bodies
Author
joshuaspence
Revisions
D14561: Add a linter rule for `interface` method bodies
Browse Repository
Passed
No Audits

28f5b0ddc6bb Fix a compatibility issue with `ArcanistUnsafeDynamicStringXHPASTLinterRule`
Author
joshuaspence
Revisions
D14567: Fix a compatibility issue with `ArcanistUnsafeDynamicStringXHPASTLinterRule`
Browse Repository
Passed
No Audits

Nov 23 2015

9e78d15fc0c7 Improve the "unexpected return value" linter rule
Author
joshuaspence
Revisions
D14564: Improve the "unexpected return value" linter rule
Browse Repository
Passed
No Audits

72d9013d29dc Add a linter rule for `abstract` methods containing a body
Author
joshuaspence
Revisions
D14560: Add a linter rule for `abstract` methods containing a body
Browse Repository
Passed
No Audits

37571d883952 Add a linter rule to determine whether a class should be marked as `abstract`
Author
joshuaspence
Revisions
D14559: Add a linter rule to determine whether a class should be marked as `abstract`
Browse Repository
Passed
No Audits

20e99acf0ad1 Add a linter rule for `abstract private` methods
Author
joshuaspence
Revisions
D14558: Add a linter rule for `abstract private` methods
Browse Repository
Passed
No Audits

6f908f633b7f Add a linter rule for unnecessary symbol aliases
Author
joshuaspence
Revisions
D14557: Add a linter rule for unnecessary symbol aliases
Browse Repository
Passed
No Audits

3b41e62f8700 Use Remarkup in linter messages
Author
joshuaspence
Revisions
D14489: Use Remarkup in linter messages
Browse Repository
Passed
No Audits

ae210fda9f4b Add a linter rule for `use` statement namespace prefixes
Author
joshuaspence
Revisions
D14517: Add a linter rule for `use` statement namespace prefixes
Browse Repository
Passed
No Audits

Nov 19 2015

2eada58960e5 Fix cppcheck linter test case
Author
joshuaspence
Revisions
D14524: Fix cppcheck linter test case
Browse Repository
Passed
No Audits

187e10e7810b Fix parsing of `ruby` version for `ArcanistRubyLinter`
Author
joshuaspence
Revisions
D14525: Fix parsing of `ruby` version for `ArcanistRubyLinter`
Browse Repository
Passed
No Audits

581829a99ee8 Write a linter rule for `$this` reassignment
Author
joshuaspence
Revisions
D14514: Write a linter rule for `$this` reassignment
Browse Repository
Passed
No Audits

426d535b13d7 Fix PHP compatibility linter after improvements to parsing of `use` statements
Author
joshuaspence
Revisions
D14519: Fix PHP compatibility linter after improvements to parsing of `use` statements
Browse Repository
Passed
No Audits

3ac313ad1e65 Write a linter rule for unexpected `return` values
Author
joshuaspence
Revisions
D14516: Write a linter rule for unexpected `return` values
Browse Repository
Passed
No Audits