Diffusion Arcanist (master) History

rARC/src/lint/linter/tests
master

Jan 12 2015

af4ab07381a5 Improve lint handling of `declare()` special statement blocks
Author
joshuaspence
Revisions
D11350: Improve lint handling of `declare()` special statement blocks
Browse Repository
No Builds
No Audits

f58642a8ab99 Add unit tests for `ArcanistFilenameLinter`
Author
joshuaspence
Revisions
D11341: Add unit tests for `ArcanistFilenameLinter`
Browse Repository
No Builds
No Audits

Jan 11 2015

e4149e43cd19 Improve parsing of `csslint` output
Author
joshuaspence
Revisions
D11311: Improve parsing of `csslint` output
Browse Repository
No Builds
No Audits

9c0568e12dae Delete a problematic test case
Author
joshuaspence
Revisions
D11313: Delete a problematic test case
Browse Repository
No Builds
No Audits

Jan 7 2015

a232f7d5b874 Improvements to `LINT_IMPLICIT_VISIBILITY`
Author
joshuaspence
Revisions
D11267: Improvements to `LINT_IMPLICIT_VISIBILITY`
Browse Repository
No Builds
No Audits

Jan 6 2015

4f5203375e0b Add a linter rule to detect implict method visibility
Author
joshuaspence
Revisions
D10687: Add a linter rule to detect implict method visibility
Browse Repository
No Builds
No Audits

6eed5c251411 Create a custom exception class for missing linter dependencies
Author
joshuaspence
Revisions
D11205: Create a custom exception class for missing linter dependencies
Browse Repository
No Builds
No Audits

Jan 4 2015

d477df00eb5b Add a linter rule to detect the use of blacklisted functions
Author
joshuaspence
Revisions
D10686: Add a linter rule to detect the use of blacklisted functions
Browse Repository
No Builds
No Audits

9fdf53452c15 Rename `UnitTestableArcanistLintEngine` for consistency
Author
joshuaspence
Revisions
D11200: Rename `UnitTestableArcanistLintEngine` for consistency
Browse Repository
No Builds
No Audits

da02add6c818 Create an `ArcanistExternalLinterTestCase` class
Author
joshuaspence
Revisions
D11197: Create an `ArcanistExternalLinterTestCase` class
Browse Repository
No Builds
No Audits

f5db41917be6 Reduce boilerplate code in `ArcanistLinterTestCase` subclasses
Author
joshuaspence
Revisions
D11172: Reduce boilerplate code in `ArcanistLinterTestCase` subclasses
Browse Repository
No Builds
No Audits

a10002adec13 Raise a linter error when removed symbols are used
Author
joshuaspence
Revisions
D10538: Raise a linter error when removed symbols are used
Browse Repository
No Builds
No Audits

b31e9c0cfee0 Add a linter rule to detect duplicate `case` statements
Author
joshuaspence
Revisions
D11171: Add a linter rule to detect duplicate `case` statements
Browse Repository
No Builds
No Audits

4e3df805844c Move `LINT_NO_COMMIT` from `ArcanistTextLinter` to a new linter
Author
joshuaspence
Revisions
D10473: Move `LINT_NO_COMMIT` from `ArcanistTextLinter` to a new linter
Browse Repository
No Builds
No Audits

Jan 3 2015

821ebcdd0727 `pht`ize some strings
Author
joshuaspence
Revisions
D11175: `pht`ize some strings
Browse Repository
No Builds
No Audits

a9cfc17688ec Specify the `config` property of `lint-test` files as a `map`
Author
joshuaspence
Revisions
D11174: Specify the `config` property of `lint-test` files as a `map`
Browse Repository
No Builds
No Audits

fba62c0d9d64 Remove `arcconfig` settings from `ArcanistLinterTestCase`
Author
joshuaspence
Revisions
D11173: Remove `arcconfig` settings from `ArcanistLinterTestCase`
Browse Repository
No Builds
No Audits

Dec 30 2014

a3c3d23dd770 Fix two linter issues
Author
epriestley
Revisions
D11087: Fix two linter issues
Browse Repository
No Builds
No Audits

841556134f6e Fix `puppet-lint` unit tests for the v1.1.0
Author
joshuaspence
Revisions
D11057: Fix `puppet-lint` unit tests for the v1.1.0
Browse Repository
No Builds
No Audits

Dec 8 2014

4ca3463df684 Extend `LINT_BRACE_FORMATTING` to support more scenarios
Author
joshuaspence
Revisions
D10572: Extend `LINT_BRACE_FORMATTING` to support more scenarios
Browse Repository
No Builds
No Audits

ee2070fadbc5 Extend `LINT_BRACE_FORMATTING` to warn on missing braces
Author
joshuaspence
Revisions
D10571: Extend `LINT_BRACE_FORMATTING` to warn on missing braces
Browse Repository
No Builds
No Audits

Oct 7 2014

e54725ec8918 Add a `LINT_CONSTRUCTOR_PARENTHESES` rule to `ArcanistXHPASTLinter`
Author
joshuaspence
Revisions
D10597: Add a `LINT_CONSTRUCTOR_PARENTHESES` rule to `ArcanistXHPASTLinter`
Browse Repository
No Builds
No Audits

Sep 25 2014

8ed1459ecdba Add a linter rule to detect variable arguments for `break` and `continue`
Author
joshuaspence
Revisions
D10567: Add a linter rule to detect variable arguments for `break` and `continue`
Browse Repository
No Builds
No Audits

247a4fabb8b6 Fix `LINT_ARRAY_SEPARATOR` for heredocs
Author
joshuaspence
Revisions
D10569: Fix `LINT_ARRAY_SEPARATOR` for heredocs
Browse Repository
No Builds
No Audits

cb2007825048 Fix `LINT_ARRAY_SEPARATOR` for nested arrays
Author
joshuaspence
Revisions
D10558: Fix `LINT_ARRAY_SEPARATOR` for nested arrays
Browse Repository
No Builds
No Audits

Sep 24 2014

be428e320700 Add a linter rule for array separators
Author
joshuaspence
Revisions
D10535: Add a linter rule for array separators
Browse Repository
No Builds
No Audits

13492c8043a4 Fix a fatal error in `ArcanistXHPASTLinter`
Author
joshuaspence
Revisions
D10551: Fix a fatal error in `ArcanistXHPASTLinter`
Browse Repository
No Builds
No Audits

888ada2f380c Improve `LINT_DOS_NEWLINE` behavior
Author
joshuaspence
Revisions
D10472: Improve `LINT_DOS_NEWLINE` behavior
Browse Repository
No Builds
No Audits

Sep 11 2014

be34693f236f Fix failing unit test
Author
joshuaspence
Browse Repository
No Builds
Audited

f4fd7ad612a9 Add a bunch of additional test cases for `ArcanistTextLinter`
Author
joshuaspence
Revisions
D10474: Add a bunch of additional test cases for `ArcanistTextLinter`
Browse Repository
No Builds
No Audits

Sep 10 2014

e043d22afd26 Fix PHP version check for function calls with static/variable functions
Author
epriestley
Revisions
D10467: Fix PHP version check for function calls with static/variable functions
Browse Repository
No Builds
No Audits

3f79ae258f34 Allow classes/functions from a later version if they are used conditionally
Author
joshuaspence
Revisions
D10132: Allow classes/functions from a later version if they are used conditionally
Browse Repository
No Builds
No Audits

16770ed2104e Fix linting for spacing around default parameter assignment in function/method…
Author
joshuaspence
Revisions
D10429: Fix linting for spacing around default parameter assignment in function/method declaration
Browse Repository
No Builds
No Audits

Sep 9 2014

04de9311511d Add an XHPAST lint rule for empty block statements
Author
joshuaspence
Revisions
D10434: Add an XHPAST lint rule for empty block statements
Browse Repository
No Builds
No Audits

Aug 29 2014

f17b1fa1c45b Update `puppet-lint` linter
Author
joshuaspence
Revisions
D10384: Update `puppet-lint` linter
Browse Repository
No Builds
No Audits

Aug 28 2014

9fc8a2f61b19 Adding php -l linter
Author
bluehawk
Revisions
D10370: Adding php -l linter
Browse Repository
No Builds
No Audits

Aug 13 2014

4c0edd296e33 [lint] Add HLint-based Haskell linter
Author
thoughtpolice
Revisions
D10250: [lint] Add HLint-based Haskell linter
Browse Repository
No Builds
No Audits

e9c80de73cf0 Make arcanist lint tests flexible about testcase formatting
Author
epriestley
Revisions
D10251: Make arcanist lint tests flexible about testcase formatting
Browse Repository
No Builds
No Audits

Aug 5 2014

7bd57bfd9c7e Rename a test class
Author
joshuaspence
Revisions
D10145: Rename a test class
Browse Repository
No Builds
No Audits

f6e26a71335e Add a linter rule for parentheses being used with PHP language constructs
Author
joshuaspence
Revisions
D10122: Add a linter rule for parentheses being used with PHP language constructs
Browse Repository
No Builds
No Audits

Jul 8 2014

d09beeb75c3e Remove `@group` annotations
Author
joshuaspence
Revisions
D9855: Remove `@group` annotations
Browse Repository
No Builds
No Audits

Jul 3 2014

494d974005eb Move `ArcanistSpellingDefaultData` into a configurable JSON file
Author
joshuaspence
Revisions
D9805: Move `ArcanistSpellingDefaultData` into a configurable JSON file
Browse Repository
No Builds
No Audits

Jul 2 2014

ca5f05e62b09 Enable unit tests for `ArcanistJscsLinterTestCase`
Author
joshuaspence
Revisions
D9789: Enable unit tests for `ArcanistJscsLinterTestCase`
Browse Repository
No Builds
No Audits

Jun 23 2014

213628ff34de Skip the "Too Many Errors" error that is raised by JSHint.
Author
joshuaspence
Revisions
D9693: Skip the "Too Many Errors" error that is raised by JSHint.
Browse Repository
No Builds
No Audits

Jun 22 2014

60d879fc8cc4 Add unit tests for `ArcanistPylintLinter`.
Author
joshuaspence
Revisions
D9661: Add unit tests for `ArcanistPylintLinter`.
Browse Repository
No Builds
No Audits

Jun 21 2014

cf998db5e07e Add a native JSON linter.
Author
joshuaspence
Revisions
D9628: Add a native JSON linter.
Browse Repository
No Builds
No Audits

Jun 20 2014

a428f22cbf07 Don't throw an exception if no configuration is set for linter tests
Author
joshuaspence
Revisions
D9643: Don't throw an exception if no configuration is set for linter tests
Browse Repository
No Builds
No Audits

5ee12bbad652 Update callsites of `phutil_json_decode`.
Author
joshuaspence
Revisions
D9641: Update callsites of `phutil_json_decode`.
Browse Repository
No Builds
No Audits

67b6bed92ec2 Tidying up of linter code.
Author
joshuaspence
Revisions
D9625: Tidying up of linter code.
Browse Repository
No Builds
No Audits

Jun 19 2014

212c41fbd085 Add unit tests for `ArcanistMergeConflictLinter`.
Author
joshuaspence
Revisions
D9626: Add unit tests for `ArcanistMergeConflictLinter`.
Browse Repository
No Builds
No Audits

Jun 17 2014

4c99a6556778 Allow PHP version to be customized with `ArcanistXHPASTLinter`
Author
joshuaspence
Revisions
D9576: Allow PHP version to be customized with `ArcanistXHPASTLinter`
Browse Repository
No Builds
No Audits

473c6d89d78e Move the "ragged classtree edge" linter rule to `ArcanistPhutilXHPASTLinter`.
Author
joshuaspence
Revisions
D9590: Move the "ragged classtree edge" linter rule to `ArcanistPhutilXHPASTLinter`.
Browse Repository
No Builds
No Audits

Jun 16 2014

b1ddd0f03b2a Add an `ArcanistJscsLinter`.
Author
joshuaspence
Revisions
D9565: Add an `ArcanistJscsLinter`.
Browse Repository
No Builds
No Audits

Jun 15 2014

4371cd81f511 Restore PEP8 errors.
Author
joshuaspence
Revisions
D9473: Restore PEP8 errors.
Browse Repository
No Builds
No Audits

Jun 9 2014

57f4bbae42c5 Allow spaces after the `.` operator if followed by a comment.
Author
joshuaspence
Revisions
D9438: Allow spaces after the `.` operator if followed by a comment.
Browse Repository
No Builds
No Audits

May 27 2014

ff97a77786d0 Add lint rules for `=>` (fat arrow) and `.` (string concatenation)
Author
epriestley
Revisions
D9314: Add lint rules for `=>` (fat arrow) and `.` (string concatenation)
Browse Repository
No Builds
No Audits

May 23 2014

17820442da3c Change double quotes to single quotes.
Author
joshuaspence
Revisions
D9269: Change double quotes to single quotes.
Browse Repository
No Builds
No Audits

042aa2ee38df Add an `ArcanistGoLintLinter`.
Author
joshuaspence
Revisions
D9246: Add an `ArcanistGoLintLinter`.
Browse Repository
No Builds
No Audits

May 21 2014

c999f3e6b5c7 Fix XHPAST to detect use of undeclared variables in `catch`
Author
epriestley
Revisions
D9239: Fix XHPAST to detect use of undeclared variables in `catch`
Browse Repository
No Builds
No Audits

May 19 2014

1b0ab48f15d4 Improve autofixing of double quotes in XHPAST linter.
Author
joshuaspence
Revisions
D9196: Improve autofixing of double quotes in XHPAST linter.
Browse Repository
No Builds
No Audits

b251615716b3 Add a rule to the XHPAST linter to check for whitespace before a semicolon.
Author
joshuaspence
Revisions
D9195: Add a rule to the XHPAST linter to check for whitespace before a semicolon.
Browse Repository
No Builds
No Audits

566c7e9c5cf4 Add a rule to the XHPAST linter for detecting `elseif` usage.
Author
joshuaspence
Revisions
D9193: Add a rule to the XHPAST linter for detecting `elseif` usage.
Browse Repository
No Builds
No Audits

May 18 2014

178b32c6c2d6 Fix the `ArcanistXHPASTLinter` single quote rule.
Author
joshuaspence
Revisions
D9182: Fix the `ArcanistXHPASTLinter` single quote rule.
Browse Repository
No Builds
No Audits

May 17 2014

1493e043e1e0 Add an `ArcanistCoffeeLintLinter` linter.
Author
joshuaspence
Revisions
D9051: Add an `ArcanistCoffeeLintLinter` linter.
Browse Repository
No Builds
No Audits

35a26718d861 Add a linter rule for determining when single quotes should be used over double…
Author
joshuaspence
Revisions
D9117: Add a linter rule for determining when single quotes should be used over double quotes.
Browse Repository
No Builds
No Audits

May 15 2014

6c6035d04b6c Add Closure linter to arcanist
Author
vm
Revisions
D9131: Add Closure linter to arcanist
Browse Repository
No Builds
No Audits

May 13 2014

d826bf65c620 Minor cleanup of linter testing code.
Author
joshuaspence
Revisions
D9096: Minor cleanup of linter testing code.
Browse Repository
No Builds
No Audits

c4c0fbd7cd53 Rename test method.
Author
joshuaspence
Revisions
D9095: Rename test method.
Browse Repository
No Builds
No Audits

May 12 2014

be803ce5777c Remove the `getConfig` and `setConfig` method.
Author
joshuaspence
Revisions
D9067: Remove the `getConfig` and `setConfig` method.
Browse Repository
No Builds
No Audits

315314425e9b Modernize `ArcanistCppcheckLinter`.
Author
joshuaspence
Revisions
D9068: Modernize `ArcanistCppcheckLinter`.
Browse Repository
No Builds
No Audits

86cbcb9f564b Allow linters to share resources by shoving them on the Engine
Author
epriestley
Revisions
D9059: Allow linters to share resources by shoving them on the Engine
Browse Repository
No Builds
No Audits

May 6 2014

88ff113f921c Add a LESS linter.
Author
joshuaspence
Revisions
D8992: Add a LESS linter.
Browse Repository
No Builds
No Audits

8523b98f396d Add a `puppet-lint` linter.
Author
joshuaspence
Revisions
D8990: Add a `puppet-lint` linter.
Browse Repository
No Builds
No Audits

e00ce652001b Add an XML linter.
Author
joshuaspence
Revisions
D8989: Add an XML linter.
Browse Repository
No Builds
No Audits

ab5c1562c0f6 Add a JSON linter.
Author
joshuaspence
Revisions
D8988: Add a JSON linter.
Browse Repository
No Builds
No Audits

213997dc9d6b Fix `flake8` unit test.
Author
joshuaspence
Revisions
D8987: Fix `flake8` unit test.
Browse Repository
No Builds
No Audits

c013124690e4 Convert more linters to modern formats with `.arclint` support
Author
joshuaspence
Browse Repository
No Builds
No Audits

May 5 2014

a7327ca0e943 Modernize `ArcanistJSHintLinter`.
Author
joshuaspence
Revisions
D8965: Modernize `ArcanistJSHintLinter`.
Browse Repository
No Builds
No Audits

Mar 9 2014

06cfe0746eaa Utilize `assertFalse` and `assertTrue` methods.
Author
epriestley
Revisions
D8461: Utilize `assertFalse` and `assertTrue` methods.
Browse Repository
No Builds
No Audits

Mar 7 2014

c6b1f3f070f6 Fail Arcanist tests when they make zero assertions
Author
epriestley
Revisions
D8437: Fail Arcanist tests when they make zero assertions
Browse Repository
No Builds
No Audits

22f62079205f Fail lint tests if no tests are found in the test directory
Author
epriestley
Revisions
D8434: Fail lint tests if no tests are found in the test directory
Browse Repository
No Builds
No Audits

Mar 4 2014

fb826bbf9cf0 Correctly identify `@todo` comments as TODOs.
Author
joshuaspence
Revisions
D8389: Correctly identify `@todo` comments as TODOs.
Browse Repository
No Builds
No Audits

9fb2a147f90b Made `ArcanistNoLintTestCaseMisnamed` final.
Author
joshuaspence
Revisions
D8386: Made `ArcanistNoLintTestCaseMisnamed` final.
Browse Repository
No Builds
No Audits

Jan 14 2014

d62bd48a8103 Added `ArcanistTextLinter::LINT_BOF_WHITESPACE` and `ArcanistTextLinter…
Author
joshuaspence
Revisions
D7957: Added `ArcanistTextLinter::LINT_BOF_WHITESPACE` and `ArcanistTextLinter::LINT_EOF_WHITESPACE`
Browse Repository
No Builds
No Audits

Jan 9 2014

ef598794a812 Skip unit tests if `ArcanistLinter::getCacheVersion` throws an…
Author
joshuaspence
Revisions
D7913: Skip unit tests if `ArcanistLinter::getCacheVersion` throws an `ArcanistUsageException`
Browse Repository
No Builds
No Audits

e2234a5be96a Allow `ArcanistLinterTestCase` to find "lint-test" files at an arbitrary depth
Author
joshuaspence
Revisions
D7910: Allow `ArcanistLinterTestCase` to find "lint-test" files at an arbitrary depth
Browse Repository
No Builds
No Audits

Oct 22 2013

0d212ccf5a7a rename getConfig -> getProjectConfig, make all linters use…
Author
avivey
Revisions
D7382: rename getConfig -> getProjectConfig, make all linters use getConfigFromAnySource
Browse Repository
No Builds
No Audits

Oct 20 2013

831fc9a92b8e Fixed typos
Author
pborreli
Browse Repository
No Builds
Audited

Sep 12 2013

c00d8c551c81 Correct capitalization of "new" in lint
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 10 2013

699f3b3c05e2 Fix an issue with PHPCS output formatting
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 29 2013

4a3d8292238c Fixup lint testing for changes in D6798
Author
wez
Browse Repository
No Builds
No Audits

2c5c9815c0c7 Support PHPCS as a `.arclint` linter
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 26 2013

0f30aca626f2 Ready more linters and linter functions for .arclint
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 23 2013

1f3cb63db201 Expose PEP8, Flake8 and CSSLint engines to .arclint
Author
epriestley
Browse Repository
No Builds
No Audits

6e5be59ad618 Port flake8 to ArcanistExternalLinter
Author
epriestley
Browse Repository
No Builds
No Audits

e23fc30c195a Introduce a rough abstract base class for "linters which run programs and read…
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 22 2013

f18130a6aa7a Simplify and demuck some of the linter test cases
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 10 2013

f5ceceea8755 Lint undeclared variables in strings
Author
vrana
Browse Repository
No Builds
No Audits

Apr 15 2013

2df40b544542 Lint `TRUE`, `nUlL`, etc., for Phabricator conventions
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 5 2013

263cf9a95f80 Complain about Reuse of By-ref Iterators
Author
Andrew Chen <achen1@fb.com>
Browse Repository
No Builds
No Audits