Diffusion Arcanist (master) History

rARC/src
masterf0f95e5b2612d011592f9db…

Mar 25 2020

33b9728b5f65 Run ls-files from the root of the directory
Author
ptarjan
Revisions
D21045: Run ls-files from the root of the directory
Browse Repository
Passed
No Audits

Mar 22 2020

4c12c3119b7a Treat all PHP language-level errors as exceptions by default
Author
epriestley
Revisions
D21044: Treat all PHP language-level errors as exceptions by default
Browse Repository
Passed
No Audits

Mar 20 2020

18799c182921 Switch file uploader in "arc diff" to use ConduitEngine
Author
epriestley
Revisions
D21043: Switch file uploader in "arc diff" to use ConduitEngine
Browse Repository
Passed
No Audits

97e050fce7a5 Use a named remote and branches for staging to help git-lfs
Author
ptarjan
Revisions
D21041: Use a named remote and branches for staging to help git-lfs
Browse Repository
Passed
No Audits

Mar 6 2020

66a6128239e2 Remove the "preg_quote()" lint rule and update the "__CLASS__" lint rule
Author
epriestley
Revisions
D21032: Remove the "preg_quote()" lint rule and update the "__CLASS__" lint rule
Browse Repository
Passed
No Audits

31653f6b7749 Fix an issue where "arc" may fail on startup when trying to read older…
Author
epriestley
Revisions
D21039: Fix an issue where "arc" may fail on startup when trying to read older "default" config
Browse Repository
Passed
No Audits

Feb 26 2020

1b97f8b4086d Update "arc upload" for Toolsets
Author
epriestley
Revisions
D21030: Update "arc upload" for Toolsets
Browse Repository
Passed
No Audits

Feb 25 2020

9bd5c23b2a3e Improve error handling in ArcanistRuntime when failing to load libraries
Author
epriestley
Revisions
D21029: Improve error handling in ArcanistRuntime when failing to load libraries
Browse Repository
Passed
No Audits

Feb 23 2020

9cd72baae92c Update Phage for toolsets and restore library loading behaviors
Author
epriestley
Revisions
D21025: Update Phage for toolsets and restore library loading behaviors
Browse Repository
Passed
No Audits

de461bb1794f Fix two "implode()" order issues arising from wilds/experimental collapse
Author
epriestley
Revisions
D21024: Fix two "implode()" order issues arising from wilds/experimental collapse
Browse Repository
Passed
No Audits

Feb 17 2020

ee66b15bd469 Port "arc upgrade" to Toolsets
Author
epriestley
Revisions
D21006: Port "arc upgrade" to Toolsets
Browse Repository
Passed
No Audits

d4e4271b57f6 Remove obscure features no longer supported by Toolsets from "classic" Arcanist
Author
epriestley
Revisions
D21005: Remove obscure features no longer supported by Toolsets from "classic" Arcanist
Browse Repository
Passed
No Audits

Feb 16 2020

d3b77af8a526 Require "--" as an argument terminator when running noninteractively
Author
epriestley
Revisions
D21002: Require "--" as an argument terminator when running noninteractively
Browse Repository
Passed
No Audits

db8419f19ba2 Port "arc weld" and "arc anoid" to Toolsets workflows, plus minor fixes
Author
epriestley
Revisions
D21001: Port "arc weld" and "arc anoid" to Toolsets workflows, plus minor fixes
Browse Repository
Passed
No Audits

Feb 14 2020

8cd79d38aff2 Port "arc shell-complete" to Toolsets
Author
epriestley
Revisions
D20997: Port "arc shell-complete" to Toolsets
Browse Repository
Passed
No Audits

70c6045c7f9f Update "arc alias" to modern workflows
Author
epriestley
Revisions
D20996: Update "arc alias" to modern workflows
Browse Repository
Passed
No Audits

0c6ae6bbcfb8 Port "arc version" to Toolsets
Author
epriestley
Revisions
D20993: Port "arc version" to Toolsets
Browse Repository
Passed
No Audits

cf9469e0d10b Port "arc liberate" to Toolsets
Author
epriestley
Revisions
D20992: Port "arc liberate" to Toolsets
Browse Repository
Passed
No Audits

0e95fcbb7fff Port "arc help" to Toolsets
Author
epriestley
Revisions
D20991: Port "arc help" to Toolsets
Browse Repository
Passed
No Audits

Feb 13 2020

c471983697b3 Collapse Arcanist toolsets from "wilds" into "master", as an overlay layer
Author
epriestley
Revisions
D20990: Collapse Arcanist toolsets from "wilds" into "master", as an overlay layer
Browse Repository
Passed
No Audits

acf060768340 Merge utility/support changes from "wilds" to "master"
Author
epriestley
Revisions
D20988: Merge utility/support changes from "wilds" to "master"
Browse Repository
Passed
No Audits

0d62a10eda68 Don't depend on "XMLWriter" to load the lint renderer class tree
Author
epriestley
Revisions
D20989: Don't depend on "XMLWriter" to load the lint renderer class tree
Browse Repository
Passed
No Audits

8c4f6ce1617e Merge the remainder of the "experimental" branch
Author
epriestley
Revisions
D20987: Merge the remainder of the "experimental" branch
Browse Repository
Passed
No Audits

4c36860c4303 Merge Arcanist lint changes from "experimental" branch
Author
epriestley
Revisions
D20986: Merge Arcanist lint changes from "experimental" branch
Browse Repository
Passed
No Audits

26f853b63430 Merge "--draft" flag and related changes from "experimental" to "master"
Author
epriestley
Revisions
D20985: Merge "--draft" flag and related changes from "experimental" to "master"
Browse Repository
Passed
No Audits

a8a50b2fc004 Make "arcanist/" unit tests pass
Author
epriestley
Revisions
D20984: Make "arcanist/" unit tests pass
Browse Repository
Passed
No Audits

Feb 12 2020

61e059984a15 Merge "phage" from "experimental"
Author
epriestley
Revisions
D20982: Merge "phage" from "experimental"
Browse Repository
Failed
No Audits

9b74cb4ee641 Fully merge "libphutil/" into "arcanist/"
Author
epriestley
Revisions
D20980: Fully merge "libphutil/" into "arcanist/"
Browse Repository
Failed
No Audits

a36e60f0a37e Move HTML-only intraline diff code to Phabricator
Author
epriestley
Revisions
D20978: Move HTML-only intraline diff code to Phabricator
Browse Repository
Passed
No Audits

Jan 24 2020

21a1828ea06c Omit "--" in older fallback commands for Git remote URIs
Author
epriestley
Revisions
D20952: Omit "--" in older fallback commands for Git remote URIs
Browse Repository
Passed
No Audits

Jan 23 2020

70c0fd3f2233 In Git, fall back across versions more cleanly when trying to get the URI for a…
Author
epriestley
Revisions
D20950: In Git, fall back across versions more cleanly when trying to get the URI for a remote
Browse Repository
Passed
No Audits

Nov 19 2019

cc850163f30c When "arc close-revision --finalize ..." skips closing a revision, print a…
Author
epriestley
Revisions
D20915: When "arc close-revision --finalize ..." skips closing a revision, print a message
Browse Repository
Passed
No Audits

Oct 29 2019

cc1ff38843c4 When generating diffs in "arc diff", disable Git config option "diff.
Author
epriestley
Revisions
D20877: When generating diffs in "arc diff", disable Git config option "diff.suppressBlankEmpty"
Browse Repository
Passed
No Audits

Oct 28 2019

73943d1bc9d3 Make "arc land --merge" an explicit error when targeting a Perforce remote
Author
epriestley
Revisions
D20871: Make "arc land --merge" an explicit error when targeting a Perforce remote
Browse Repository
Passed
No Audits

7383c2f4e6d2 In "arc land", when "remote/onto" does not exist locally, try to fetch it…
Author
epriestley
Revisions
D20870: In "arc land", when "remote/onto" does not exist locally, try to fetch it before giving up
Browse Repository
Passed
No Audits

a76054f8d66d Update "arc help land" to reference Perforce support
Author
epriestley
Revisions
D20869: Update "arc help land" to reference Perforce support
Browse Repository
Passed
No Audits

ca66743905fb Support Perforce/Git repositories in "arc land"
Author
epriestley
Revisions
D20868: Support Perforce/Git repositories in "arc land"
Browse Repository
Passed
No Audits

9c7bbb760a8b Move Git-specific "arc land" parsing of "--onto" and "--remote" into…
Author
epriestley
Revisions
D20867: Move Git-specific "arc land" parsing of "--onto" and "--remote" into GitLandEngine
Browse Repository
Passed
No Audits

Oct 17 2019

da6d4f85eefb Add a lint check for deprecated argument order to "implode()"
Author
epriestley
Revisions
D20857: Add a lint check for deprecated argument order to "implode()"
Browse Repository
Passed
No Audits

Sep 5 2019

3cdfe1fff806 When running "arc land" from a detached HEAD, don't try to delete the source ref
Author
epriestley
Revisions
D20786: When running "arc land" from a detached HEAD, don't try to delete the source ref
Browse Repository
Passed
No Audits

Jun 20 2019

d92fa96366c0 Fix two "msort()" vs "msortv()" issues in "arc land"
Author
epriestley
Revisions
D20605: Fix two "msort()" vs "msortv()" issues in "arc land"
Browse Repository
Passed
No Audits

1ef94098179f Update "arcanist/" for "topological" API changes
Author
epriestley
Revisions
D20598: Update "arcanist/" for "topological" API changes
Browse Repository
Passed
No Audits

May 23 2019

7329bc7c32b9 Fix arc land on odd/modern git-svn checkouts
Author
asherkin
Revisions
D19681: Fix arc land on odd/modern git-svn checkouts
Browse Repository
Passed
No Audits

May 21 2019

dd514e268b2c Modify the `lint-test` file format to allow for more powerful assertions
Author
joshuaspence
Revisions
D11176: Modify the `lint-test` file format to allow for more powerful assertions
Browse Repository
Passed
No Audits

May 15 2019

82445bb60534 Let lint rules support anonymous classes
Author
wjiang
Browse Repository
Passed
No Audits

May 14 2019

6a8e76db329e Allow `buildFutures` and `resolveFutures` to be overridden
Author
joshuaspence
Browse Repository
Passed
No Audits

fceac878f112 Allow `setCustomSeverityRules` to be overridden in subclasses
Author
joshuaspence
Browse Repository
Passed
No Audits

4f583dded366 Call `$linter->setEngine` in linter tests
Author
joshuaspence
Browse Repository
Passed
No Audits

9ccbbee33675 Fix a potential double-prompt in "arc land" when landing with ongoing builds
Author
epriestley
Browse Repository
Passed
No Audits

b61e890a0ca8 Remove unnecessary "," from Pylint version regex
Author
epriestley
Browse Repository
Passed
No Audits

Mar 7 2019

9830c9316d38 Make minor correctness changes to some "arc patch" command execution
Author
epriestley
Revisions
D20254: Make minor correctness changes to some "arc patch" command execution
Browse Repository
Passed
No Audits

73804f003972 Fix a case where "arc patch" could skip submodule changes
Author
epriestley
Revisions
D20253: Fix a case where "arc patch" could skip submodule changes
Browse Repository
Passed
No Audits

Mar 6 2019

f6b8480adce5 Implement "Warn When Landing" behavior for Build Plans in Arcanist
Author
epriestley
Revisions
D20236: Implement "Warn When Landing" behavior for Build Plans in Arcanist
Browse Repository
Passed
No Audits

Feb 28 2019

96fde137a1dc Improve performance of "arc diff" updates for changes with large diff text
Author
epriestley
Revisions
D20221: Improve performance of "arc diff" updates for changes with large diff text
Browse Repository
Passed
No Audits

Feb 19 2019

9581dd0f5272 Add Arcanist support for highlighting indent change intraline diffs
Author
epriestley
Revisions
D20182: Add Arcanist support for highlighting indent change intraline diffs
Browse Repository
Passed
No Audits

Feb 15 2019

07a208d8fc47 In "arc diff", warn when some reviewers are away even if not everyone is away
Author
epriestley
Revisions
D20172: In "arc diff", warn when some reviewers are away even if not everyone is away
Browse Repository
Passed
No Audits

Feb 12 2019

7e61e43f6554 Add version check whitelists for constants to the version compatibility lint…
Author
epriestley
Revisions
D20146: Add version check whitelists for constants to the version compatibility lint rule
Browse Repository
Passed
No Audits

Dec 28 2018

25c2381959ac Statically detect "continue" inside "switch"
Author
epriestley
Revisions
D19931: Statically detect "continue" inside "switch"
Browse Repository
Passed
No Audits

Dec 12 2018

eb732555a71a Fix a "continue;" inside a switch in ArcanistPHPCompatibilityXHPASTLinterRule
Author
epriestley
Revisions
D19868: Fix a "continue;" inside a switch in ArcanistPHPCompatibilityXHPASTLinterRule
Browse Repository
Passed
No Audits

Nov 8 2018

3534d2baca4b Small ReMarkup fix
Author
avivey
Revisions
D19794: Small ReMarkup fix
Browse Repository
Passed
No Audits

Oct 26 2018

83661809e532 Work around a Windows escaping issue and security conecern in "hg cat --output .
Author
epriestley
Revisions
D19758: Work around a Windows escaping issue and security conecern in "hg cat --output ..."
Browse Repository
Passed
No Audits

Sep 14 2018

2650e8627a20 Make the Arcanist comment remover less aggressive about stripping instructional…
Author
epriestley
Revisions
D19639: Make the Arcanist comment remover less aggressive about stripping instructional comments
Browse Repository
Passed
No Audits

Sep 6 2018

30b7835c37b5 Allow `willLintPaths` and `didLintPaths` to be overridden
Author
joshuaspence
Revisions
D19630: Allow `willLintPaths` and `didLintPaths` to be overridden
Browse Repository
Passed
No Audits

Aug 24 2018

e1e93271e6e0 Make the ArcanistBundle algorithm do what "diff -u" does when hunks are…
Author
epriestley
Revisions
D19603: Make the ArcanistBundle algorithm do what "diff -u" does when hunks are arguably mergeable
Browse Repository
Passed
No Audits

Aug 3 2018

d9a4293ae734 Consolidate redundant "should should" from some linter help strings in Arcanist
Author
epriestley
Revisions
D19561: Consolidate redundant "should should" from some linter help strings in Arcanist
Browse Repository
Passed
No Audits

Jul 9 2018

875d01836037 Fix `arc diff` when adding large new file with new git
Author
avivey
Revisions
D19513: Fix `arc diff` when adding large new file with new git
Browse Repository
Passed
No Audits

Jun 19 2018

222800a86ed0 Parse Mercurial changeset evolution "instability" log field
Author
epriestley
Revisions
D19498: Parse Mercurial changeset evolution "instability" log field
Browse Repository
Passed
No Audits

Jun 7 2018

df7313bdf2a3 In "arc patch", update submodules slightly later
Author
epriestley
Revisions
D19475: In "arc patch", update submodules slightly later
Browse Repository
Passed
No Audits

Jun 5 2018

b199ca808660 [ARCUNIT] Set the ConfigurationManager of ConfigurationDrivenUnitTestEngines
Author
tmcjilton
Revisions
D19465: [ARCUNIT] Set the ConfigurationManager of ConfigurationDrivenUnitTestEngines
Browse Repository
Passed
No Audits

May 14 2018

d581c453b83c Allow diff generation via ArcanistBundle to be limited to an approximate…
Author
epriestley
Revisions
D19444: Allow diff generation via ArcanistBundle to be limited to an approximate maximum byte size
Browse Repository
Passed
No Audits

May 9 2018

a1aec701e3ea Raise the intraline diff hard limit from 80 to 100 characters
Author
epriestley
Revisions
D19442: Raise the intraline diff hard limit from 80 to 100 characters
Browse Repository
Passed
No Audits

Apr 27 2018

a60454810102 Slightly improve base85 performance for 64-bit systems
Author
epriestley
Revisions
D19408: Slightly improve base85 performance for 64-bit systems
Browse Repository
Passed
No Audits

bcab677a7a8c Restructure base85 unit tests to support inlining and multiple encoding pathways
Author
epriestley
Revisions
D19407: Restructure base85 unit tests to support inlining and multiple encoding pathways
Browse Repository
Passed
No Audits

Apr 20 2018

ad3087e5e151 Correctly parse `git status --porcelain=2` output with filenames with spaces
Author
alexmv
Revisions
D19389: Correctly parse `git status --porcelain=2` output with filenames with spaces
Browse Repository
Passed
No Audits

Apr 5 2018

73f5afd44110 Remove "very large change" warning from Arcanist
Author
epriestley
Revisions
D19299: Remove "very large change" warning from Arcanist
Browse Repository
Passed
No Audits

Apr 3 2018

e44a2d3ac0bf Improve argument parsing for "arc patch --revision Dxxx"
Author
epriestley
Revisions
D19292: Improve argument parsing for "arc patch --revision Dxxx"
Browse Repository
Passed
No Audits

Mar 26 2018

b8c9c385a7f5 Survive extra "obsolete:" log output from the Mercurial evolve extension
Author
epriestley
Revisions
D19262: Survive extra "obsolete:" log output from the Mercurial evolve extension
Browse Repository
Passed
No Audits

bf3d32e34e79 Remove accidental sprintf injection in error reporting
Author
alexmv
Revisions
D19261: Remove accidental sprintf injection in error reporting
Browse Repository
Passed
No Audits

Mar 3 2018

dcd7ef66d0e4 Add support for Go 1.10 (cached) output
Author
nathanleclaire
Revisions
D19161: Add support for Go 1.10 (cached) output
Browse Repository
Passed
No Audits

Feb 13 2018

be1dd7e2ba23 Robustly fuse files together with `arc weld`
Author
epriestley
Revisions
D19081: Robustly fuse files together with `arc weld`
Browse Repository
Passed
No Audits

Feb 5 2018

349109426c7f Clarify what "--everything" means in "arc lint" and "arc unit"
Author
epriestley
Revisions
D18989: Clarify what "--everything" means in "arc lint" and "arc unit"
Browse Repository
Passed
No Audits

Jan 16 2018

2e02332216c6 Add trailing tabs when generating synthetic Git diffs for files with spaces
Author
epriestley
Revisions
D18869: Add trailing tabs when generating synthetic Git diffs for files with spaces
Browse Repository
Passed
No Audits

Dec 26 2017

3d06bd4c568c Fix a minor 'buildableStatus' error in "arc land"
Author
epriestley
Browse Repository
Passed
Audit Required

Dec 24 2017

9144658e695c Accelerate working tree operations in git
Author
alexmv
Revisions
D18842: Accelerate working tree operations in git
Browse Repository
Passed
No Audits

f34467914ca0 Add tests for git submodules, based on current behavior
Author
alexmv
Revisions
D18841: Add tests for git submodules, based on current behavior
Browse Repository
Passed
No Audits

Dec 23 2017

c784b569202f Make "arc land" accommodate a minor API change in Harbormaster build statuses
Author
epriestley
Revisions
D18837: Make "arc land" accommodate a minor API change in Harbormaster build statuses
Browse Repository
Passed
No Audits

Dec 12 2017

249f3a80fe77 Default the prompt for "Amend HEAD with these patches" to true
Author
alexmv
Revisions
D18824: Default the prompt for "Amend HEAD with these patches" to true
Browse Repository
Passed
No Audits

Nov 30 2017

f4c80a114d36 Make "arc land" prompt on "Changes Planned" revisions more explicit
Author
epriestley
Revisions
D18807: Make "arc land" prompt on "Changes Planned" revisions more explicit
Browse Repository
Passed
No Audits

Nov 2 2017

90546042144f Fix some lint rendering issues when lines prior to other identical lines are…
Author
epriestley
Revisions
D18759: Fix some lint rendering issues when lines prior to other identical lines are removed
Browse Repository
Passed
No Audits

Oct 20 2017

0989343a4e0c Correct some lint console renderer issues with files missing trailing newlines
Author
epriestley
Revisions
D18716: Correct some lint console renderer issues with files missing trailing newlines
Browse Repository
Passed
No Audits

Oct 17 2017

617c2e46d6a5 Make "line" and "char" strictly optional in ArcanistLintMessage
Author
epriestley
Revisions
D18711: Make "line" and "char" strictly optional in ArcanistLintMessage
Browse Repository
Passed
No Audits

Oct 4 2017

76b54ce0a9af Fix parsing of Git branches with common and useful name "0"
Author
epriestley
Revisions
D18678: Fix parsing of Git branches with common and useful name "0"
Browse Repository
Passed
No Audits

Sep 21 2017

c804c5026011 Don't show a blank line if there is no user data
Author
alexmv
Revisions
D18632: Don't show a blank line if there is no user data
Browse Repository
Passed
No Audits

Sep 20 2017

b836557b12b3 Correct lint rendering when patching trailing whitespace in files
Author
epriestley
Revisions
D18631: Correct lint rendering when patching trailing whitespace in files
Browse Repository
Passed
No Audits

Sep 14 2017

df81d79d77f8 Add explicit limits to unit test/lint error names
Author
amckinley
Revisions
D18603: Add explicit limits to unit test/lint error names
Browse Repository
Passed
No Audits

Sep 6 2017

cbc785ddce71 Fix a similar lint rendering issue when trimming identical lines out of patches
Author
epriestley
Revisions
D18541: Fix a similar lint rendering issue when trimming identical lines out of patches
Browse Repository
Passed
No Audits

Sep 5 2017

7371277d2065 Fix a prefix/suffix counting issue in Arcanist lint rendering
Author
epriestley
Revisions
D18538: Fix a prefix/suffix counting issue in Arcanist lint rendering
Browse Repository
Passed
No Audits

Sep 2 2017

d9cb5b18fbc1 Cheat our way through `arc version` on Windows for the moment
Author
epriestley
Revisions
D18518: Cheat our way through `arc version` on Windows for the moment
Browse Repository
Passed
No Audits

Aug 31 2017

ad8214456add Restore ANSI highlighting of lint sections to lint output
Author
epriestley
Revisions
D18512: Restore ANSI highlighting of lint sections to lint output
Browse Repository
Passed
No Audits

213ed3ff15d7 Restore the caret pointer ("^") for lint lines which only have a character…
Author
epriestley
Revisions
D18511: Restore the caret pointer ("^") for lint lines which only have a character offset
Browse Repository
Passed
No Audits