Diffusion Arcanist (legacy-2019) History

rARC/src/lint/linter/tests
legacy-2019

May 21 2019

dd514e268b2c Modify the `lint-test` file format to allow for more powerful assertions
Author
joshuaspence
Revisions
D11176: Modify the `lint-test` file format to allow for more powerful assertions
Browse Repository
Passed
No Audits

May 14 2019

4f583dded366 Call `$linter->setEngine` in linter tests
Author
joshuaspence
Browse Repository
Passed
No Audits

Feb 12 2019

7e61e43f6554 Add version check whitelists for constants to the version compatibility lint…
Author
epriestley
Revisions
D20146: Add version check whitelists for constants to the version compatibility lint rule
Browse Repository
Passed
No Audits

Aug 31 2017

be67df611856 Extract and cover the logic for "trimming" a lint message
Author
epriestley
Revisions
D18509: Extract and cover the logic for "trimming" a lint message
Browse Repository
Passed
No Audits

Jul 22 2017

836768bdccd4 Fix ArcanistPHPCloseTagXHPASTLinterRule always bailing out
Author
asherkin
Revisions
D18271: Fix ArcanistPHPCloseTagXHPASTLinterRule always bailing out
Browse Repository
Passed
No Audits

May 3 2017

3c4735795a29 Detect trailing spaces and tabs
Author
johnny-bit
Revisions
D17814: Detect trailing spaces and tabs
Browse Repository
Passed
No Audits

Feb 16 2017

d0353d238113 Fix errors found by PHPStan
Author
vrana
Revisions
D17367: Fix errors found by PHPStan
Browse Repository
Passed
No Audits

Nov 19 2015

2eada58960e5 Fix cppcheck linter test case
Author
joshuaspence
Revisions
D14524: Fix cppcheck linter test case
Browse Repository
Passed
No Audits

Nov 18 2015

4d512c51d43c Test XHPAST linter rules in isolation
Author
joshuaspence
Revisions
D14010: Test XHPAST linter rules in isolation
Browse Repository
Passed
No Audits

Nov 17 2015

b25cf080bc55 Fix ArcanistCSSLintLinter issue for messages without line number
Author
dereckson
Revisions
D14497: Fix ArcanistCSSLintLinter issue for messages without line number
Browse Repository
Passed
No Audits

Nov 12 2015

9dd6eafb5254 Fold `ArcanistPhutilXHPASTLinter` into `ArcanistXHPASTLinter`
Author
joshuaspence
Revisions
D13867: Fold `ArcanistPhutilXHPASTLinter` into `ArcanistXHPASTLinter`
Browse Repository
Passed
No Audits

Sep 2 2015

9419cccdd2b1 Delete another problematic XML test file
Author
joshuaspence
Revisions
D14027: Delete another problematic XML test file
Browse Repository
No Builds
No Audits

Sep 1 2015

6fa2de5ff813 Add a linter rule for detecting empty files
Author
joshuaspence
Revisions
D13881: Add a linter rule for detecting empty files
Browse Repository
No Builds
No Audits

Aug 30 2015

a5304e472d18 Add a linter rule for newlines after PHP open tags
Author
joshuaspence
Revisions
D13534: Add a linter rule for newlines after PHP open tags
Browse Repository
No Builds
No Audits

Aug 25 2015

43f8e7eb7119 Recover from PyLint raising messages at character "-1"
Author
epriestley
Revisions
D13991: Recover from PyLint raising messages at character "-1"
Browse Repository
No Builds
No Audits

1d3266395f70 Remove two problematic XML linter unit tests
Author
epriestley
Revisions
D13992: Remove two problematic XML linter unit tests
Browse Repository
No Builds
No Audits

Aug 20 2015

9b8c9d280ea4 Exclude variables used in strings inside closures when checking for undeclared…
Author
joshuaspence
Revisions
D13938: Exclude variables used in strings inside closures when checking for undeclared variables
Browse Repository
No Builds
No Audits

Aug 19 2015

27ec3a2e34aa Improve linter handling of short array syntax
Author
joshuaspence
Revisions
D13895: Improve linter handling of short array syntax
Browse Repository
No Builds
Audited

4404e66735c4 Improve the "inline HTML" linter rule
Author
joshuaspence
Revisions
D13896: Improve the "inline HTML" linter rule
Browse Repository
No Builds
Audited

Aug 13 2015

fe8ed2a6f8b0 Add a linter rule for the use of `parse_str`
Author
joshuaspence
Revisions
D13857: Add a linter rule for the use of `parse_str`
Browse Repository
No Builds
No Audits

2e76e2965cbe Add a linter rule for inline HTML
Author
joshuaspence
Revisions
D13871: Add a linter rule for inline HTML
Browse Repository
No Builds
No Audits

bf88f4616cdf Add a linter rule for global variables
Author
joshuaspence
Revisions
D13882: Add a linter rule for global variables
Browse Repository
No Builds
No Audits

Aug 12 2015

f4c322cb72cd Add a linter rule for list assignments
Author
joshuaspence
Revisions
D13870: Add a linter rule for list assignments
Browse Repository
No Builds
No Audits

Aug 11 2015

423e7d238933 Move a test file
Author
joshuaspence
Revisions
D13866: Move a test file
Browse Repository
No Builds
No Audits

e00e2939c164 Various linter fixes
Author
joshuaspence
Revisions
D13861: Various linter fixes
Browse Repository
No Builds
No Audits

31a49196801a Improve linter rules for array formatting
Author
joshuaspence
Revisions
D13859: Improve linter rules for array formatting
Browse Repository
No Builds
No Audits

b82e4cd40e1f Fix failing JSHint linter test
Author
joshuaspence
Revisions
D13860: Fix failing JSHint linter test
Browse Repository
No Builds
No Audits

Aug 10 2015

504ff4268188 Minor improvement for array value linter rule
Author
joshuaspence
Revisions
D13856: Minor improvement for array value linter rule
Browse Repository
No Builds
No Audits

830bcbc2a5e9 Add a linter rule for array elements
Author
joshuaspence
Revisions
D13842: Add a linter rule for array elements
Browse Repository
No Builds
No Audits

587f7440e3f9 Fix self member reference rule for PHP 5.3
Author
joshuaspence
Revisions
D13820: Fix self member reference rule for PHP 5.3
Browse Repository
No Builds
No Audits

6c759ae34396 Improve useless overriding method linter rule
Author
joshuaspence
Revisions
D13840: Improve useless overriding method linter rule
Browse Repository
No Builds
No Audits

f43b74c6052f Improve PHP compatibility linter
Author
joshuaspence
Revisions
D13841: Improve PHP compatibility linter
Browse Repository
No Builds
No Audits

Aug 8 2015

9e65fc65164a Improve declaration formatting linter rule for anonymous functions
Author
joshuaspence
Revisions
D13804: Improve declaration formatting linter rule for anonymous functions
Browse Repository
No Builds
No Audits

Aug 6 2015

968f4ae5d73e Add a linter rule for unary postfix expression spacing
Author
joshuaspence
Revisions
D13805: Add a linter rule for unary postfix expression spacing
Browse Repository
No Builds
No Audits

Aug 5 2015

986f5d82d073 Add a linter rule for object operator spacing
Author
joshuaspence
Revisions
D13798: Add a linter rule for object operator spacing
Browse Repository
No Builds
No Audits

c8f0deffab60 Add a linter rule for unary prefix expression spacing
Author
joshuaspence
Revisions
D13797: Add a linter rule for unary prefix expression spacing
Browse Repository
No Builds
No Audits

1e75302e7703 Add a linter rule for spacing before opening parenthesis in function calls
Author
joshuaspence
Revisions
D13796: Add a linter rule for spacing before opening parenthesis in function calls
Browse Repository
No Builds
No Audits

bf4e7d4ca89a Improve undeclared variables linter rule
Author
joshuaspence
Revisions
D13795: Improve undeclared variables linter rule
Browse Repository
No Builds
No Audits

402899a9c32d Allow closing tags in files containing HTML
Author
joshuaspence
Revisions
D13794: Allow closing tags in files containing HTML
Browse Repository
No Builds
No Audits

Aug 2 2015

0d6f3328a08f Fix some failing unit tests
Author
joshuaspence
Revisions
D13693: Fix some failing unit tests
Browse Repository
No Builds
No Audits

Jul 22 2015

e286ef66c8ce Improve the declaration parentheses linting
Author
joshuaspence
Revisions
D13675: Improve the declaration parentheses linting
Browse Repository
No Builds
No Audits

Jul 17 2015

58302432cc5f Fix brace formatting linter rule
Author
joshuaspence
Revisions
D13633: Fix brace formatting linter rule
Browse Repository
No Builds
No Audits

Jun 24 2015

04d788c79ed4 Ensure that a space is used after a catch token
Author
joshuaspence
Revisions
D13389: Ensure that a space is used after a catch token
Browse Repository
No Builds
No Audits

Jun 15 2015

ac8367a884ff Add a linter rule for extending Phobject
Author
joshuaspence
Revisions
D13275: Add a linter rule for extending Phobject
Browse Repository
No Builds
No Audits

Jun 2 2015

4754a3e15639 Linter fixes
Author
joshuaspence
Revisions
D13106: Linter fixes
Browse Repository
No Builds
No Audits

Jun 1 2015

0b1acf0dc02a Split the `ArcanistXHPASTLinter` into modular rules
Author
joshuaspence
Revisions
D10541: Split the `ArcanistXHPASTLinter` into modular rules
Browse Repository
No Builds
No Audits

May 22 2015

6f8686610489 `pht`ize a bunch more strings
Author
joshuaspence
Revisions
D12888: `pht`ize a bunch more strings
Browse Repository
No Builds
No Audits

May 19 2015

097c894d0831 Add linter rule for invalid modifiers
Author
joshuaspence
Revisions
D12922: Add linter rule for invalid modifiers
Browse Repository
No Builds
No Audits

753705b2c5b5 Rename ArcanistPhutilTestCase to PhutilTestCase and Remove ArcanistTestCase
Author
joshuaspence
Revisions
D12665: Rename ArcanistPhutilTestCase to PhutilTestCase and Remove ArcanistTestCase
Browse Repository
No Builds
Audited

9444072e2161 Improve the robustness of the "alias function" linter rule
Author
joshuaspence
Revisions
D12921: Improve the robustness of the "alias function" linter rule
Browse Repository
No Builds
No Audits

80691e0a6646 Add a linter rule for modifier ordering
Author
joshuaspence
Revisions
D12421: Add a linter rule for modifier ordering
Browse Repository
No Builds
No Audits

993166fa497e Further improvements to array comma linter rule
Author
joshuaspence
Revisions
D12308: Further improvements to array comma linter rule
Browse Repository
No Builds
No Audits

May 18 2015

60a5a2403360 Add a linter rule for invalid default parameters
Author
joshuaspence
Revisions
D12855: Add a linter rule for invalid default parameters
Browse Repository
No Builds
No Audits

4bb2eecdaf42 Add a linter rule for the instanceof operator
Author
joshuaspence
Revisions
D12856: Add a linter rule for the instanceof operator
Browse Repository
No Builds
No Audits

May 17 2015

8c6e1284cc65 Improve ArcanistXHPASTLinter::LINT_TOSTRING_EXCEPTION
Author
joshuaspence
Revisions
D12892: Improve ArcanistXHPASTLinter::LINT_TOSTRING_EXCEPTION
Browse Repository
No Builds
No Audits

2422202ba429 Add a linter rule to prevent the __lambda_func function from being redeclared
Author
joshuaspence
Revisions
D12870: Add a linter rule to prevent the __lambda_func function from being redeclared
Browse Repository
No Builds
No Audits

1e3073a4f88e Add a linter rule to prevent exceptions from being thrown in a toString method
Author
joshuaspence
Revisions
D12854: Add a linter rule to prevent exceptions from being thrown in a toString method
Browse Repository
No Builds
No Audits

2e66d03c68e4 Add a linter rule for spacing after a cast
Author
joshuaspence
Revisions
D12321: Add a linter rule for spacing after a cast
Browse Repository
No Builds
No Audits

e1a057b4d938 Add a linter rule for alias functions
Author
joshuaspence
Revisions
D12422: Add a linter rule for alias functions
Browse Repository
No Builds
No Audits

1df248cc2d53 Improve the "invalid parent scope" linter rule
Author
joshuaspence
Revisions
D12853: Improve the "invalid parent scope" linter rule
Browse Repository
No Builds
No Audits

May 14 2015

e1a051a033b8 Improve linter rule for useless overriding methods
Author
joshuaspence
Revisions
D12828: Improve linter rule for useless overriding methods
Browse Repository
No Builds
No Audits

f00d4219ddab Add a linter rule for incorrect use of parent scope
Author
joshuaspence
Revisions
D12420: Add a linter rule for incorrect use of parent scope
Browse Repository
No Builds
No Audits

May 13 2015

6295134bc7fb Add a linter rule for useless overriding methods
Author
joshuaspence
Revisions
D12419: Add a linter rule for useless overriding methods
Browse Repository
No Builds
No Audits

d2b38cdf9444 `pht` all the things
Author
joshuaspence
Revisions
D12607: `pht` all the things
Browse Repository
No Builds
No Audits

May 12 2015

9090efcb40ed Add a linter rule to prevent hardcoded class names
Author
joshuaspence
Revisions
D12605: Add a linter rule to prevent hardcoded class names
Browse Repository
No Builds
No Audits

May 5 2015

8919a9c5b55e Remove hook functionality
Author
joshuaspence
Revisions
D12698: Remove hook functionality
Browse Repository
No Builds
No Audits

0846c6aff5c4 Remove commit linter
Author
joshuaspence
Revisions
D12697: Remove commit linter
Browse Repository
No Builds
No Audits

0a711315f86b Fix a failing XML unit test
Author
joshuaspence
Revisions
D12706: Fix a failing XML unit test
Browse Repository
No Builds
No Audits

Apr 22 2015

f4aadb96048b Split large path lists into blocks when linting
Author
epriestley
Revisions
D12501: Split large path lists into blocks when linting
Browse Repository
No Builds
No Audits

ab4eac6f3180 Add a linter rule for lowercase function names
Author
joshuaspence
Revisions
D12377: Add a linter rule for lowercase function names
Browse Repository
No Builds
No Audits

Apr 20 2015

c56e4a56dc2e Add a linter rule for default parameters
Author
joshuaspence
Revisions
D12418: Add a linter rule for default parameters
Browse Repository
No Builds
No Audits

Apr 13 2015

51b5c70010de Minor improvement to self member reference linter rule
Author
joshuaspence
Revisions
D12391: Minor improvement to self member reference linter rule
Browse Repository
No Builds
No Audits

e233b158f2e1 Add a linter rule for declaring nested functions
Author
joshuaspence
Revisions
D12389: Add a linter rule for declaring nested functions
Browse Repository
No Builds
No Audits

c011f948d3f7 Improvements to "self member reference" linter rule
Author
joshuaspence
Revisions
D12385: Improvements to "self member reference" linter rule
Browse Repository
No Builds
No Audits

Apr 12 2015

b11757fa23a5 Add a linter rule for logical operators
Author
joshuaspence
Revisions
D12376: Add a linter rule for logical operators
Browse Repository
No Builds
No Audits

fc70dfe268f8 Add a linter rule for self member references
Author
joshuaspence
Revisions
D12370: Add a linter rule for self member references
Browse Repository
No Builds
No Audits

6525a309c29f Further improvements to keyword casing linter rule
Author
joshuaspence
Revisions
D12368: Further improvements to keyword casing linter rule
Browse Repository
No Builds
No Audits

f86f4f24e617 Add a linter rule for uppercase constant definitions
Author
joshuaspence
Revisions
D12366: Add a linter rule for uppercase constant definitions
Browse Repository
No Builds
No Audits

e101496508e2 Fix a failing unit test
Author
joshuaspence
Revisions
D12322: Fix a failing unit test
Browse Repository
No Builds
No Audits

Apr 7 2015

f2a3fdf5e393 Fix text lint issues
Author
joshuaspence
Revisions
D11640: Fix text lint issues
Browse Repository
No Builds
No Audits

Apr 6 2015

3a5ffdc2fdf2 Improve array comma rule
Author
joshuaspence
Revisions
D12296: Improve array comma rule
Browse Repository
No Builds
No Audits

c5df885d7bd5 Add a linter rule to detect unnecessary semicolons
Author
joshuaspence
Revisions
D12139: Add a linter rule to detect unnecessary semicolons
Browse Repository
No Builds
No Audits

41ddd34aeb26 Added RuboCop linter
Author
cburroughs
Revisions
D10738: Added RuboCop linter
Browse Repository
No Builds
No Audits

Mar 23 2015

e79032fec289 Add a linter rule for unnecessary use of the `final` modifier
Author
joshuaspence
Revisions
D12135: Add a linter rule for unnecessary use of the `final` modifier
Browse Repository
No Builds
No Audits

8530cfcec1d7 Fix a few edge cases for call-time pass-by-reference linting
Author
joshuaspence
Revisions
D12134: Fix a few edge cases for call-time pass-by-reference linting
Browse Repository
No Builds
No Audits

Feb 10 2015

d8ba7e6f719f Add a linter rule to detect mismatched parameters for formatted strings
Author
joshuaspence
Revisions
D11661: Add a linter rule to detect mismatched parameters for formatted strings
Browse Repository
No Builds
No Audits

Feb 9 2015

bf7b32fe2c20 Rename `ArcanistXHPASTLintTestSwitchHook` class
Author
joshuaspence
Revisions
D11712: Rename `ArcanistXHPASTLintTestSwitchHook` class
Browse Repository
No Builds
No Audits

Feb 4 2015

992d939e3a5c Remove the `ArcanistArcanistLinterTestCase`
Author
joshuaspence
Revisions
D11662: Remove the `ArcanistArcanistLinterTestCase`
Browse Repository
No Builds
No Audits

Jan 27 2015

e9ffde30ba71 Fix `ArcanistJscsLinter` unit tests
Author
joshuaspence
Revisions
D11520: Fix `ArcanistJscsLinter` unit tests
Browse Repository
No Builds
No Audits

edc60cefc475 Fix failing unit tests for `ArcanistLesscLinter`
Author
joshuaspence
Revisions
D11521: Fix failing unit tests for `ArcanistLesscLinter`
Browse Repository
No Builds
No Audits

Jan 22 2015

1a3afa44297f Add a linter rule to detect call-time pass-by-reference
Author
joshuaspence
Revisions
D10537: Add a linter rule to detect call-time pass-by-reference
Browse Repository
No Builds
No Audits

Jan 20 2015

1cc8f3f377f6 Don't use newInstanceWithoutConstructor in Arcanist unit test
Author
epriestley
Revisions
D11450: Don't use newInstanceWithoutConstructor in Arcanist unit test
Browse Repository
No Builds
No Audits

Jan 14 2015

272f73711020 Write tests for `ArcanistNoLintLinter`
Author
joshuaspence
Revisions
D11345: Write tests for `ArcanistNoLintLinter`
Browse Repository
No Builds
No Audits

afc53ed32211 Add unit tests for `ArcanistChmodLinter`
Author
joshuaspence
Revisions
D11343: Add unit tests for `ArcanistChmodLinter`
Browse Repository
No Builds
No Audits

7aa89ddf9620 Lint against undefined magic symbols
Author
joshuaspence
Revisions
D11386: Lint against undefined magic symbols
Browse Repository
No Builds
No Audits

Jan 12 2015

af4ab07381a5 Improve lint handling of `declare()` special statement blocks
Author
joshuaspence
Revisions
D11350: Improve lint handling of `declare()` special statement blocks
Browse Repository
No Builds
No Audits

f58642a8ab99 Add unit tests for `ArcanistFilenameLinter`
Author
joshuaspence
Revisions
D11341: Add unit tests for `ArcanistFilenameLinter`
Browse Repository
No Builds
No Audits

Jan 11 2015

e4149e43cd19 Improve parsing of `csslint` output
Author
joshuaspence
Revisions
D11311: Improve parsing of `csslint` output
Browse Repository
No Builds
No Audits

9c0568e12dae Delete a problematic test case
Author
joshuaspence
Revisions
D11313: Delete a problematic test case
Browse Repository
No Builds
No Audits

Jan 7 2015

a232f7d5b874 Improvements to `LINT_IMPLICIT_VISIBILITY`
Author
joshuaspence
Revisions
D11267: Improvements to `LINT_IMPLICIT_VISIBILITY`
Browse Repository
No Builds
No Audits