Page MenuHomePhabricator

Resolve deleted packages properly as having no mailable members
ClosedPublic

Authored by epriestley on Jul 21 2021, 9:22 PM.
Tags
None
Referenced Files
F13080546: D21707.id51712.diff
Wed, Apr 24, 8:46 AM
Unknown Object (File)
Wed, Apr 17, 3:17 PM
Unknown Object (File)
Sun, Apr 7, 11:27 AM
Unknown Object (File)
Sun, Apr 7, 6:00 AM
Unknown Object (File)
Fri, Apr 5, 4:48 PM
Unknown Object (File)
Mar 23 2024, 9:10 PM
Unknown Object (File)
Feb 25 2024, 2:37 AM
Unknown Object (File)
Feb 21 2024, 6:11 AM
Subscribers
None

Details

Summary

Fixes T13648. If a package recipient has been destroyed, this query currently fails to return an expanded recipient value.

Instead, make sure all input PHIDs get an output. For destroyed packages, the output will just be an empty list.

Test Plan
  • Added a package to a revision as a reviewer.
  • Destroyed the package.
  • Commented on the revision.
  • Processed the publishing worker with bin/worker execute.
  • Before: fatal after expanding the destroyed package.
  • After: clean publish.

Diff Detail

Repository
rP Phabricator
Branch
member1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25516
Build 35276: Run Core Tests
Build 35275: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:50 PM
This revision was automatically updated to reflect the committed changes.