Page MenuHomePhabricator

Test if "get_magic_quotes_gpc()" exists before calling it
ClosedPublic

Authored by epriestley on Feb 8 2021, 5:29 PM.
Tags
None
Referenced Files
F12819881: D21549.id51295.diff
Thu, Mar 28, 5:51 AM
Unknown Object (File)
Feb 26 2024, 9:58 AM
Unknown Object (File)
Feb 26 2024, 9:57 AM
Unknown Object (File)
Feb 17 2024, 7:04 AM
Unknown Object (File)
Feb 17 2024, 6:54 AM
Unknown Object (File)
Feb 4 2024, 12:40 AM
Unknown Object (File)
Jan 25 2024, 8:14 AM
Unknown Object (File)
Jan 25 2024, 2:22 AM
Subscribers
None

Details

Summary

Ref T13588. This function was deprecated in PHP 7.4 (see D20942) and removed in PHP8.

Test that it exists before calling it so we don't fatal in PHP8.

See https://discourse.phabricator-community.org/t/daemon-fails-on-php-8-0-2-in-utils-php-array-merge-call-w-fix/4568.

Test Plan

Used "|| true" to test the message in PHP7. No actual testing in PHP8, but a user reports a similar patch works.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2021, 5:34 PM
This revision was automatically updated to reflect the committed changes.