Page MenuHomePhabricator

Log unexpected exceptions raised by Conduit calls
ClosedPublic

Authored by epriestley on Sep 16 2020, 12:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 23 2024, 4:45 AM
Unknown Object (File)
Feb 19 2024, 7:23 AM
Unknown Object (File)
Feb 13 2024, 4:51 AM
Unknown Object (File)
Jan 9 2024, 8:02 AM
Unknown Object (File)
Dec 25 2023, 2:53 AM
Unknown Object (File)
Dec 22 2023, 1:30 AM
Unknown Object (File)
Dec 18 2023, 9:01 PM
Unknown Object (File)
Nov 30 2023, 5:46 AM
Subscribers
None

Details

Summary

Ref T13581. Currently, unexpected exceptions inside Conduit calls are passed to the client, but not logged on the server.

These exceptions should generally be unexpected, and producing a server-side trace is potentially useful.

Test Plan

Simulated a during-execution exception, saw it get logged on the server.

Diff Detail

Repository
rP Phabricator
Branch
cref15
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24891
Build 34345: Run Core Tests
Build 34344: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:37 AM
This revision was automatically updated to reflect the committed changes.