Make "Quote" work properly in Pholio
ClosedPublic
Actions

Authored by epriestley on Aug 10 2020, 8:31 PM.

Tags

None

Referenced Files

	F13089599: D21437.diff
	Thu, Apr 25, 1:55 AM

	F13089039: D21437.id51010.diff
	Thu, Apr 25, 1:38 AM

	Unknown Object (File)
	Wed, Apr 24, 6:08 AM

	Unknown Object (File)
	Tue, Apr 23, 9:20 AM

	Unknown Object (File)
	Fri, Apr 19, 4:33 AM

	Unknown Object (File)
	Thu, Apr 11, 9:34 AM

	Unknown Object (File)
	Thu, Mar 28, 12:43 AM

	Unknown Object (File)
	Wed, Mar 27, 12:42 PM

View All 57 Files

Subscribers

None

Details

Reviewers: None
Commits: rP79375c6c5398: Make "Quote" work properly in Pholio

Summary

See https://discourse.phabricator-community.org/t/quote-comment-missing-on-mock-pages/4155. Pholio is currently missing a couple of configuration calls to make the "Quote" action work.

Moving to EditEngine is the "real" fix, but this fix is trivial and should make "Quote" work properly with no negative effects.

Test Plan

Viewed a mock, used "quote" to quote a comment.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 10 2020, 8:31 PM

Harbormaster completed remote builds in B24828: Diff 51010.Aug 10 2020, 8:32 PM

epriestley requested review of this revision.Aug 10 2020, 8:32 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 10 2020, 8:40 PM

Closed by commit rP79375c6c5398: Make "Quote" work properly in Pholio (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP79375c6c5398: Make "Quote" work properly in Pholio.

Revision Contents
Changeset List

Path

Size

src/

applications/

pholio/

controller/

PholioMockViewController.php

3 lines

Diff 51011

View Options

src/applications/pholio/controller/PholioMockViewController.php

Make "Quote" work properly in PholioClosedPublicActions