Page MenuHomePhabricator

Move "Wait for Previous Commits to Build" out of prototype
ClosedPublic

Authored by epriestley on Jul 30 2020, 7:43 PM.
Tags
None
Referenced Files
F12839807: D21432.id50997.diff
Thu, Mar 28, 7:53 PM
Unknown Object (File)
Wed, Mar 27, 12:40 PM
Unknown Object (File)
Feb 24 2024, 4:58 PM
Unknown Object (File)
Feb 20 2024, 3:42 PM
Unknown Object (File)
Jan 30 2024, 4:09 AM
Unknown Object (File)
Jan 23 2024, 9:24 AM
Unknown Object (File)
Jan 19 2024, 9:57 PM
Unknown Object (File)
Jan 9 2024, 12:59 PM
Subscribers
Restricted Owners Package

Details

Summary

Although I'm not entirely thrilled about doing flow control like this (as an actual action in a build plan), I believe this build step works correctly and there's no fancy replacement mechanism on the immediate horizon, and this didn't send us down a slippery slope of Turing-complete builds encoded without real structure or context. Just kick it out of prototype.

(Other approaches which might be better in the long run are things like "this is a top-level behavior on the build plan itself" and/or "build plans are written in a DSL, not a Javascript UI".)

Test Plan

Added a new build step, saw this as an option in the "Flow Control" section.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable