Page MenuHomePhabricator

Fix an issue with destruction of Revision and Diff objects with viewstates
ClosedPublic

Authored by epriestley on Jul 22 2020, 6:55 PM.
Tags
None
Referenced Files
F12815649: D21421.diff
Thu, Mar 28, 3:03 AM
Unknown Object (File)
Wed, Mar 27, 12:38 PM
Unknown Object (File)
Sun, Mar 10, 1:56 AM
Unknown Object (File)
Jan 20 2024, 4:44 PM
Unknown Object (File)
Jan 16 2024, 5:50 PM
Unknown Object (File)
Jan 12 2024, 5:38 PM
Unknown Object (File)
Jan 8 2024, 4:45 PM
Unknown Object (File)
Jan 4 2024, 4:10 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/domainexception-when-trying-to-remove-an-differentialrevision/4105.

These queries aren't actually constructed properly, and destroying a revision or diff with viewstates currently fails.

Test Plan

Used bin/remove destroy Dxxx to destroy a revision with viewstates (this also destroys the associated diffs).

Diff Detail

Repository
rP Phabricator
Branch
rmdiff
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24789
Build 34197: Run Core Tests
Build 34196: arc lint + arc unit