Page MenuHomePhabricator

Clean up Diffusion behaviors for inline edit suggestions
ClosedPublic

Authored by epriestley on May 20 2020, 4:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 2:36 AM
Unknown Object (File)
Thu, Apr 4, 2:27 PM
Unknown Object (File)
Tue, Mar 26, 11:28 AM
Unknown Object (File)
Jan 20 2024, 8:58 PM
Unknown Object (File)
Jan 5 2024, 1:23 PM
Unknown Object (File)
Dec 26 2023, 10:12 AM
Unknown Object (File)
Dec 19 2023, 9:09 AM
Unknown Object (File)
Dec 13 2023, 12:46 PM
Subscribers
None

Details

Summary

Ref T13513. For now, I'm not supporting inline edit suggestions in Diffusion, although it's likely not difficult to do so in the future. Clean up some of the code so that plain ol' inlines work the same way they did before.

Test Plan
  • Created, edited, reloaded, submitted inlines in Diffusion: familiar old behavior.
  • Created, edited, reloaded, submitted inlines with suggestions in Differential: familiar new behavior.

Diff Detail

Repository
rP Phabricator
Branch
inline12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24482
Build 33738: Run Core Tests
Build 33737: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:28 PM
This revision was automatically updated to reflect the committed changes.