Page MenuHomePhabricator

Fix an issue where builds with no initiator failed to render in build plans
ClosedPublic

Authored by epriestley on May 19 2020, 4:44 PM.
Tags
None
Referenced Files
F12833717: D21269.id50647.diff
Thu, Mar 28, 2:12 PM
Unknown Object (File)
Sun, Mar 24, 8:28 PM
Unknown Object (File)
Sun, Mar 24, 5:41 AM
Unknown Object (File)
Sun, Mar 10, 12:10 AM
Unknown Object (File)
Dec 14 2023, 3:21 PM
Unknown Object (File)
Dec 10 2023, 6:50 AM
Unknown Object (File)
Nov 30 2023, 6:04 AM
Unknown Object (File)
Nov 19 2023, 4:49 AM
Subscribers
Restricted Owners Package

Details

Summary

See PHI1743. If a build has no initiator PHID, the rendering pathway incorrectly tries to access a handle for it anyway.

Test Plan
  • Set a build to have no initiator PHID.
  • Viewed the build plan for the build.
  • Before: fatal when trying to access the null handle.
  • After: clean build plan rendering.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable