Page MenuHomePhabricator

When creating an inline, save the current document engine
ClosedPublic

Authored by epriestley on May 12 2020, 7:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 7:32 AM
Unknown Object (File)
Sun, Apr 7, 9:40 AM
Unknown Object (File)
Sun, Mar 31, 2:39 AM
Unknown Object (File)
Sun, Mar 31, 2:39 AM
Unknown Object (File)
Sun, Mar 31, 2:39 AM
Unknown Object (File)
Fri, Mar 29, 5:18 PM
Unknown Object (File)
Fri, Mar 29, 2:54 PM
Unknown Object (File)
Mar 15 2024, 6:32 AM
Subscribers
None

Details

Summary

Ref T13513. As part of inline metadata, save the document engine the change is being rendered with.

This will allow other parts of the UI to detect that an inline was created on a Jupyter notebook but is being rendered on raw source, or whatever else.

The immediate goal is to fix nonsensical inline snippet rendering in email on Jupyter notebooks.

Test Plan
  • Created inlines and replies on normal soure code, saw no document engine annotated in the database.
  • Created inlines and replies on a Jupyter notebook rendered in Jupyter mode, saw "jupyter" annotations in the database.
  • Swapped document engines between Jupyter and Source, etc.

Diff Detail

Repository
rP Phabricator
Branch
engine1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24400
Build 33617: Run Core Tests
Build 33616: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 12 2020, 9:25 PM
This revision was automatically updated to reflect the committed changes.