Page MenuHomePhabricator

Switch file uploader in "arc diff" to use ConduitEngine
ClosedPublic

Authored by epriestley on Mar 20 2020, 7:18 PM.
Tags
None
Referenced Files
F12846541: D21043.diff
Fri, Mar 29, 1:18 AM
Unknown Object (File)
Thu, Mar 14, 6:08 PM
Unknown Object (File)
Mon, Mar 4, 5:27 PM
Unknown Object (File)
Feb 21 2024, 6:21 AM
Unknown Object (File)
Dec 21 2023, 7:42 PM
Unknown Object (File)
Dec 16 2023, 4:08 AM
Unknown Object (File)
Dec 14 2023, 9:13 AM
Unknown Object (File)
Dec 12 2023, 12:34 AM
Subscribers
None

Details

Summary

Fixes T13498. Currently, arc diff may invoke the file upload flow using an older variation of the API. Both the modern and fallback clients build an Engine, so switching to the modern API is trivial.

Test Plan
  • Created a local commit with a 1MB binary file.
  • Ran arc diff --only.
  • Before patch: fatal on old API call.
  • After patch: clean upload.

Diff Detail

Repository
rARC Arcanist
Branch
upload1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23949
Build 32958: Run Core Tests
Build 32957: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 20 2020, 7:19 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.