Page MenuHomePhabricator
Differential D20956

Update Herald rule creation workflow to use more modern UI elements
ClosedPublic
Actions

Authored by epriestley on Jan 29 2020, 8:40 PM.
Tags
None
Referenced Files
F13052025: D20956.id49952.diff
Fri, Apr 19, 6:28 AM
Unknown Object (File)
Wed, Apr 17, 5:01 PM
Unknown Object (File)
Tue, Apr 16, 5:57 AM
Unknown Object (File)
Fri, Apr 5, 10:59 AM
Unknown Object (File)
Fri, Apr 5, 1:30 AM
Unknown Object (File)
Sat, Mar 30, 9:26 AM
Unknown Object (File)
Fri, Mar 29, 11:58 AM
Unknown Object (File)
Thu, Mar 21, 2:45 AM
View All 81 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields
Commits
rP6d4c6924d6d9: Update Herald rule creation workflow to use more modern UI elements
Summary

Ref T13480. Creating a rule in Herald currently uses the older radio-button flow. Update it to the "clickable menu" flow to simplify it a little bit.

Test Plan

Created new personal, object, and global rules. Hit the object rule error conditions.

Diff Detail

Repository
rP Phabricator
Branch
author8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23750
Build 32663: Run Core Tests
Build 32662: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 29 2020, 8:40 PM
Harbormaster completed remote builds in B23750: Diff 49924.Jan 29 2020, 8:41 PM
epriestley requested review of this revision.Jan 29 2020, 8:41 PM
epriestley updated this revision to Diff 49952.Feb 4 2020, 3:35 PM
  • Rebase and use "PHUILauncherView" in the new UIs.
Harbormaster completed remote builds in B23777: Diff 49952.Feb 4 2020, 3:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 3:37 PM
Closed by commit rP6d4c6924d6d9: Update Herald rule creation workflow to use more modern UI elements (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP6d4c6924d6d9: Update Herald rule creation workflow to use more modern UI elements.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
herald/
adapter/
6 lines
controller/
543 lines
view/
phui/
20 lines
webroot/
rsrc/
css/
phui/
6 lines

Diff 49924

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldNewController.php

Loading...
View Options

src/view/phui/PHUIObjectBoxView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-box.css

Loading...
Phabricator · Built by Phacility