Differential D20901

Correct rendering of workboard column move stories when a single transaction performs moves on multiple boards
ClosedPublic
Actions

Authored by epriestley on Nov 9 2019, 12:55 AM.

Details

Reviewers: None
Commits: rPa3f4cbd7484b: Correct rendering of workboard column move stories when a single transaction…

Summary

See https://discourse.phabricator-community.org/t/unhandled-exception-rendering-maniphest-task/3234.

If a single transaction performs column moves on multiple different boards (which is permitted in the API), the rendering logic currently fails. Make it render properly.

Test Plan

Diff Detail

Repository

rP Phabricator

Branch

moves1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23646
Build 32506: Run Core Tests
Build 32505: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 9 2019, 12:55 AM

Harbormaster completed remote builds in B23646: Diff 49818.Nov 9 2019, 12:56 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 9 2019, 12:56 AM

epriestley requested review of this revision.

Closed by commit rPa3f4cbd7484b: Correct rendering of workboard column move stories when a single transaction… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa3f4cbd7484b: Correct rendering of workboard column move stories when a single transaction….

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

storage/

PhabricatorApplicationTransaction.php

2 lines

Diff 49818

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Correct rendering of workboard column move stories when a single transaction performs moves on multiple boardsClosedPublicActions