Page MenuHomePhabricator

Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries
ClosedPublic

Authored by epriestley on Sep 3 2019, 11:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 18, 8:50 PM
Unknown Object (File)
Tue, Mar 5, 3:11 AM
Unknown Object (File)
Feb 19 2024, 9:40 PM
Unknown Object (File)
Feb 14 2024, 3:21 PM
Unknown Object (File)
Jan 27 2024, 5:48 PM
Unknown Object (File)
Jan 15 2024, 9:13 PM
Unknown Object (File)
Dec 24 2023, 6:35 AM
Unknown Object (File)
Dec 21 2023, 11:40 AM
Subscribers
None

Details

Summary

Ref T13404. This query is invalid under "sql_mode=ONLY_FULL_GROUP_BY". Rewrite it to avoid interacting with actorIdentity at all; this is a little more robust in the presence of weird data and not really more complicated.

Test Plan
  • Enabled "ONLY_FULL_GROUP_BY".
  • Hit system actions (e.g., login).
    • Before: error.
    • After: clean login.
  • Tried to login with a bad password many times in a row, got properly limited by the system action rate limiter.

Diff Detail

Repository
rP Phabricator
Branch
group1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23379
Build 32116: Run Core Tests
Build 32115: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 3 2019, 11:50 PM
This revision was automatically updated to reflect the committed changes.