Page MenuHomePhabricator

Fix a warning in BoardLayoutEngine when no objects are being updated
ClosedPublic

Authored by epriestley on Aug 7 2019, 4:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 6:09 AM
Unknown Object (File)
Jan 25 2024, 11:04 AM
Unknown Object (File)
Dec 24 2023, 5:44 PM
Unknown Object (File)
Nov 30 2023, 6:22 AM
Unknown Object (File)
Nov 25 2023, 10:27 PM
Unknown Object (File)
Nov 19 2023, 9:56 AM
Unknown Object (File)
Oct 25 2023, 10:30 AM
Unknown Object (File)
Oct 23 2023, 11:55 AM
Subscribers
None

Details

Summary

Fixes T13368. Some workflows (like "Move tasks to...") execute board layout without objects to update. In these cases, we can hit a warning because objectPHIDs is not initialized to array().

Test Plan

Went through the "Move tasks to..." workflow on a workboard, no longer saw a warning when trying to iterate over an empty objectPHIDs list.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 8 2019, 5:18 PM
This revision was automatically updated to reflect the committed changes.