Stop writing PID files in daemons
ClosedPublic
Actions

Authored by epriestley on Jun 20 2019, 10:05 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date

Commits

rPHU7adfe4e4f4a3: Stop writing PID files in daemons

Summary

Ref T13321. There are no more PID file readers, so we can stop writing them.

Test Plan

Ran bin/phd start, saw daemons doing stuff.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 20 2019, 10:05 PM

Harbormaster completed remote builds in B23016: Diff 49144.Jun 20 2019, 10:06 PM

epriestley requested review of this revision.Jun 20 2019, 10:06 PM

src/daemon/PhutilDaemonOverseer.php
124–125	One thing we're losing here is that daemons will no longer crash instantly on startup if they don't have permissions or the disk is full.

This revision is now accepted and ready to land.Jun 20 2019, 10:51 PM

epriestley added inline comments.Jun 20 2019, 11:01 PM

src/daemon/PhutilDaemonOverseer.php
124–125	Haha, yes. All told, I think I deleted like four blocks of `// TODO: It would be nice if this wasn't a horrible, fragile mess.` code.

Closed by commit rPHU7adfe4e4f4a3: Stop writing PID files in daemons (authored by epriestley). · Explain WhyJun 24 2019, 6:28 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPHU7adfe4e4f4a3: Stop writing PID files in daemons.

Revision Contents
Changeset List

Path

Size

src/

daemon/

PhutilDaemonHandle.php

8 lines

PhutilDaemonOverseer.php

67 lines

Diff 49172

View Options

src/daemon/PhutilDaemonHandle.php