Page MenuHomePhabricator

Remove unnecessary "," from Pylint version regex
ClosedPublic

Authored by epriestley on May 8 2019, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 3:13 AM
Unknown Object (File)
Fri, Apr 19, 3:12 AM
Unknown Object (File)
Fri, Apr 19, 3:12 AM
Unknown Object (File)
Thu, Apr 18, 3:08 PM
Unknown Object (File)
Thu, Apr 11, 10:39 AM
Unknown Object (File)
Thu, Apr 11, 4:20 AM
Unknown Object (File)
Tue, Apr 9, 8:08 AM
Unknown Object (File)
Sat, Mar 23, 12:41 AM
Subscribers
None

Details

Summary

See PHI1238. This "," in the regex can only make the lint binding fail if there is no "," in the version output string. In modern versions of Pylint, there is (apparently) no comma in the version string. Remove it.

See also https://discourse.phabricator-community.org/t/arcanistpylintlinter-version-regex-issue/2688

Test Plan
$ pip install pylint
Traceback (most recent call last):
  File "/Users/epriestley/Library/Python/2.7/bin/pip", line 6, in <module>
    from pip._internal import main
ImportError: No module named pip._internal

¯\_(ツ)_/¯

Diff Detail

Repository
rARC Arcanist
Branch
pylint1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22771
Build 31229: Run Core Tests
Build 31228: arc lint + arc unit