Differential D20335
When query panels overheat, degrade them and show a warning Authored by epriestley on Mar 27 2019, 3:45 PM. Tags None Referenced Files
Subscribers None
Details Depends on D20334. Ref T13272. After recent changes to make overheating queries throw by default, dashboard panels now fail into an error state when they overheat. This is a big step up from the hard-coded homepage panels removed by D20333, but can be improved. Let these panels render partial results when they overheat and show a human-readable warning. 
Diff Detail
Event Timeline
Comment Actions I think knowing how to refine the query might be helpful, especially for more technical users. In particular, the hint "too many results are not visible to you" implies the correct remedy ("change the query to match only stuff I can see"), at least if you're paying close attention. The hint "took too long" might imply the wrong remedy ("simplify the query"). Simplifying the query by removing constraints tends make overheating worse by matching more stuff -- you should usually add constraints, making the query more complex but excluding results you can't see. Comment Actions That's fair. I just think users aren't used to thinking of queries as having distinct "fetching" and "policy enforcement" phases. Also, it feels kind of vaguely user-hostile to tell someone that "most of these objects aren't visible to you", like finding out you've been given the kiddie wine list at a nice restaurant. Maybe "Filtering your query results is taking too long. To see more results, speed up filtering by adding additional constraints." or similar? Not a big deal; I'm ok with this if you like it as-is. Comment Actions I do generally agree this flow isn't great. I'm not sure we can produce a good outcome for less-technical users: if we don't explain that this is a policy filtering issue, I think even technical users are unlikely to be able to guess how to refine the query, but if we do explain that this is a policy issue it turns into this paragraph of very technical details that necessarily says "you can't see some of the results". (I'm not sure if "not visible to you" or "you don't have permission" is more of a kid-menu phrasing and can't immediately come up with a better one.) Possibly we should just accept a friendly-but-useless error like "OwO this took too long! we're very sowwy!" under the assumption that no user is likely to be able to navigate this under any reasonable error message. Or "OwO sowssy wittle qwewy oopsie! OuO view very technical detaiws (experts only!) OuO". That probably looks more like this:
We do already have similar language in ApplicationSearchController->newOverheatedView() and it hasn't caused problems yet, for whatever that's worth. Comment Actions
| ||||||||||||||||||||||||||||||||||||||||