Page MenuHomePhabricator

Don't show workboard action previews if the action won't have any effect
ClosedPublic

Authored by epriestley on Mar 20 2019, 2:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 9, 6:11 AM
Unknown Object (File)
Fri, Mar 1, 8:47 AM
Unknown Object (File)
Feb 3 2024, 9:47 PM
Unknown Object (File)
Dec 25 2023, 4:09 PM
Unknown Object (File)
Dec 22 2023, 7:05 AM
Unknown Object (File)
Dec 20 2023, 9:54 AM
Unknown Object (File)
Dec 4 2023, 5:30 PM
Unknown Object (File)
Dec 1 2023, 3:04 AM
Subscribers
None

Details

Summary

Ref T10335. When you (for example) drag a "Resolved" task into a column with "Trigger: change status to resolved.", don't show a hint that the action will "Change status to resolved." since this isn't helpful and is somewhat confusing.

For now, the only visibility operator is "!=" since all current actions are simple field comparisons, but some actions in the future (like "add subscriber" or "remove project") might need other conditions.

Test Plan

Dragged cards in ways that previously provided useless hints: move from column A to column B on a "Group by Priority" board; drag a resolved task to a "Trigger: change status to as resolved" column. Saw a more accurate preview in both cases.

Drags which actually cause effects still show the effects correctly.

Diff Detail

Repository
rP Phabricator
Branch
trigger6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22318
Build 30528: Run Core Tests
Build 30527: arc lint + arc unit