Page MenuHomePhabricator

When highlighting source, catch "python" for the PHP parser
ClosedPublic

Authored by epriestley on Feb 28 2019, 8:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 2:29 PM
Unknown Object (File)
Sun, Mar 10, 4:17 PM
Unknown Object (File)
Feb 18 2024, 5:29 AM
Unknown Object (File)
Feb 10 2024, 2:27 PM
Unknown Object (File)
Dec 27 2023, 1:10 PM
Unknown Object (File)
Dec 27 2023, 1:10 PM
Unknown Object (File)
Dec 27 2023, 1:09 PM
Unknown Object (File)
Dec 27 2023, 1:09 PM
Subscribers
None

Details

Summary

See PHI1065. Normally, Python files are called ".py" and we end up with the lexer coded as "py" by the time we get here, but if you "Highlight As..." and select "Python" we can end up here with "python". (Probably also if you name a file "something.python", although this is very unusual.)

Catch both "py" and "python" for our highlighter.

T3626 should eventually standardize and moot this, but since this patch is only a quarter of a line long it seems reasonable until then.

Test Plan

Added a phlog(), verified we now hit the first-party highlighter with "Highlight As... > Python".

Diff Detail

Repository
rPHU libphutil
Branch
python1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22153
Build 30275: Run Core Tests
Build 30274: arc lint + arc unit