Page MenuHomePhabricator

Prepare owners package audit rules to become more flexible
ClosedPublic

Authored by epriestley on Feb 7 2019, 4:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 1:07 PM
Unknown Object (File)
Tue, Mar 26, 1:06 PM
Unknown Object (File)
Sat, Mar 23, 12:38 PM
Unknown Object (File)
Sat, Mar 23, 8:16 AM
Unknown Object (File)
Mon, Mar 4, 8:50 PM
Unknown Object (File)
Feb 8 2024, 11:15 AM
Unknown Object (File)
Feb 3 2024, 9:15 PM
Unknown Object (File)
Dec 31 2023, 8:50 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13244. See PHI1055. (Earlier, see D20091 and PHI1047.) Previously, we expanded the Owners package autoreview rules from "Yes/No" to several "Review (Blocking) If Non-Owner Author Not Subscribed via Package" kinds of rules. The sky didn't fall and this feature didn't turn into "Herald-in-Owners", so I'm comfortable doing something similar to the "Audit" rules.

PHI1055 is a request for a way to configure slightly different audit behavior, and expanding the options seems like a good approach to satisfy the use case.

Prepare to add more options by moving everything into a class that defines all the behavior of different states, and converting the "0/1" boolean column to a text column.

Test Plan
  • Created several packages, some with and some without auditing.
  • Inspected database for: package state; and associated transactions.
  • Ran the migrations.
  • Inspected database to confirm that state and transactions migrated correctly.
  • Reviewed transaction logs.
  • Created and edited packages and audit state.
  • Viewed the "Package List" element in Diffusion.
  • Pulled package information with owners.search, got sensible results.
  • Edited package audit status with owners.edit.

Diff Detail

Repository
rP Phabricator
Branch
audit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21879
Build 29867: Run Core Tests
Build 29866: arc lint + arc unit