Page MenuHomePhabricator

Provide a convenient way to log arbitrary text in Drydock without needing structured log classes
ClosedPublic

Authored by epriestley on Sep 14 2018, 4:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 8:29 PM
Unknown Object (File)
Wed, Mar 20, 10:26 PM
Unknown Object (File)
Wed, Mar 20, 10:26 PM
Unknown Object (File)
Dec 25 2023, 10:55 AM
Unknown Object (File)
Dec 17 2023, 12:45 PM
Unknown Object (File)
Dec 7 2023, 10:20 PM
Unknown Object (File)
Nov 30 2023, 4:29 AM
Unknown Object (File)
Nov 17 2023, 9:13 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19673. Ref T13197. See PHI873.

Test Plan

Added some code like this:

$operation->logText('Nice convenient text logging.');

...then got:

Screen Shot 2018-09-14 at 9.23.09 AM.png (976×1 px, 137 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Sep 14 2018, 4:25 PM
amckinley added inline comments.
src/applications/drydock/logtype/DrydockTextLogType.php
4–11

What's the maximum amount of text you can dump into a log? Worth documenting here?

This revision is now accepted and ready to land.Sep 14 2018, 6:55 PM

I think any "reasonable" amount should be fine. Maybe I'm not being imaginative enough, of course...

This revision was automatically updated to reflect the committed changes.