Community Report: https://discourse.phabricator-community.org/t/cannot-display-placeholder-in-src-view-form-control-aphrontformtokenizercontrol-php/
All tokenizers I checked seemed to work OK. I think the Locate File field in Diffusion uses this.
Differential D18240
Fallback to placeholder if datasource placeholder does not exist chad on Jul 19 2017, 2:43 AM. Authored by Tags None Referenced Files
Subscribers
Details
Community Report: https://discourse.phabricator-community.org/t/cannot-display-placeholder-in-src-view-form-control-aphrontformtokenizercontrol-php/ All tokenizers I checked seemed to work OK. I think the Locate File field in Diffusion uses this. Diffusion, various other placeholders.
Diff Detail
Event TimelineComment Actions I am also awaiting further instructions. https://discourse.phabricator-community.org/t/cannot-display-placeholder-in-src-view-form-control-aphrontformtokenizercontrol-php/89/11 Comment Actions I'll admit I missed reproduction steps on first pass (and didn't ask until after I wrote the diff) Comment Actions I don't see any callsites, so I believe this doesn't cause any reproducible bad behavior -- i.e., this is support for third-party development, not a bug fix. If there are no callsites, we should just remove setPlaceholder() and the placeholder property if you want to clean this up. Comment Actions (Without blaming it, my guess is that this method predates the modularization of TypeaheadDatasource into a separate subclass and has been obsolete since then.) |